This looks good to me.
Reviewed-By: Derek Foreman der...@osg.samsung.com
On 19/03/15 03:58 AM, Jonas Ådahl wrote:
Without this patch, the scanner would generate invalid C which wouldn't
compile anyway, so lets be nice and fail earlier and point out where the
error is.
Signed-off-by: Jonas
Now clamping width and height to a minimum of 1, 1 when drag resizing.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
desktop-shell/shell.c | 4
1 file changed, 4 insertions(+)
diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c
index 826692f..aca91eb 100644
--- a/desktop
normal circumstances maybe we should log (perhaps just the first
time) the 1000 case, as it seems to indicate something is rather wrong?
This all looks pretty good to me though,
Reviewed-By: Derek Foreman der...@osg.samsung.com
+ output_repaint_timer_handler(output);
+ else
On 18/03/15 03:14 AM, Pekka Paalanen wrote:
On Mon, 22 Dec 2014 16:09:15 -0600
Derek Foreman der...@osg.samsung.com wrote:
In preparation for a future patch which allows test clients to control
the presentation clock, we wrap any clock_gettime() of the presentation
clock
On 18/03/15 02:16 AM, Jonas Ådahl wrote:
If the client calls wl_pointer.set_cursor with the same surface that is
already set, don't do anything as no state was changed.
This avoids an issue where a client setting the same cursor surface
multiple times would receive wl_surface.leave/enter on
The pixman-renderer is already performing transformations when compositing
into the shadow buffer, we just need to get the damage co-ordinates right
when copying from shadow to front.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
src/compositor-fbdev.c | 110
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
src/compositor-rpi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/compositor-rpi.c b/src/compositor-rpi.c
index 2d72686..bceb280 100644
--- a/src/compositor-rpi.c
+++ b/src/compositor-rpi.c
@@ -344,6 +344,7 @@ rpi_output_create
on a different seat and that causes a crash
at startup.
Derek Foreman (5):
compositor-fbdev: give the output a name
input: don't assume outputs have names
compositor-rpi: give the output a name
compositor-fbdev: allow configuring transform in the ini file
compositor-fbdev: fix output
If you have devices configured in seats with udev then the output names
are tested with string compare. This fixes a potential crash on startup and
device insertion.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
src/compositor-fbdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git
On 17/03/15 07:34 AM, Pekka Paalanen wrote:
On Tue, 17 Mar 2015 13:02:34 +0100
Thilo Cestonaro th...@cestona.ro wrote:
Hey!
Just curious, why didn't you get the fbdev backend to work? Was it the
color format thing?
No, I got the color format to work, but I need to rotate the screen, and
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
src/compositor-fbdev.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/src/compositor-fbdev.c b/src/compositor-fbdev.c
index ae526e5..c08f170 100644
--- a/src/compositor-fbdev.c
+++ b/src/compositor-fbdev.c
If an output is unnamed and devices are in seats, the strcmp will crash.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
src/libinput-seat.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/libinput-seat.c b/src/libinput-seat.c
index ef2d804..c0a87ea 100644
=pixmancomplex-3
Thanks,
pq
Derek Foreman (1):
compositor: use weston_matrix_transform for
weston_output_transform_coordinate
S-O-B me.
Jason Ekstrand (4):
Use pixel coordinates for weston_output.matrix
zoom: Use pixels instead of GL coordinates
compositor: Add surface-to-buffer
On 09/03/15 05:52 AM, Pekka Paalanen wrote:
On Fri, 06 Mar 2015 13:46:26 -0600
Derek Foreman der...@osg.samsung.com wrote:
On 06/03/15 05:04 AM, Pekka Paalanen wrote:
From: Pekka Paalanen pekka.paala...@collabora.co.uk
Move code from draw_view() into a new function draw_view_translated
On 06/03/15 05:03 AM, Pekka Paalanen wrote:
From: Pekka Paalanen pekka.paala...@collabora.co.uk
This will be used by pixman-renderer.
Signed-off-by: Pekka Paalanen pekka.paala...@collabora.co.uk
---
src/compositor.c | 36
src/compositor.h | 5 +
On 06/03/15 05:03 AM, Pekka Paalanen wrote:
From: Pekka Paalanen pekka.paala...@collabora.co.uk
Move the long piece of code computing the end-to-end transformation from
repaint_region() into a new function
pixman_renderer_compute_transform().
The code itself it not modified.
Nice
On 06/03/15 05:04 AM, Pekka Paalanen wrote:
From: Pekka Paalanen pekka.paala...@collabora.co.uk
Change the region argument types in repaint_region(), moving the
final_region computation to the caller. The caller is in a better
position deciding if source_clip is needed or if it can be
On 06/03/15 05:04 AM, Pekka Paalanen wrote:
From: Pekka Paalanen pekka.paala...@collabora.co.uk
Implement a way to do composition clipping with a region32 given in
source image space.
Pixman does not directly support this kind of operation at all. If you
pixman_image_set_clip_region32()
. This is a follow-up to
http://lists.freedesktop.org/archives/wayland-devel/2015-March/020354.html
Really good stuff here.
Replied to some individual patches with suggestions.
Reviewed-By: Derek Foreman der...@osg.samsung.com
For all except 2, 5, 6.
Would like to see 6 split into refactor
On 05/03/15 02:15 AM, Pekka Paalanen wrote:
On Wed, 4 Mar 2015 16:26:25 -0600
Derek Foreman der...@osg.samsung.com wrote:
Certain circumstances may lead to the force clause in
input_set_pointer_image() being reached when the current cursor
is blank or unset. These are special cursors
It's useful to know how long the current cursor frame should be displayed
so we can wait that long to change it.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
differences from v1:
Add comment about 0 durations
document return of 0 duration as unchanging image
make sure duration
On 04/03/15 01:50 AM, Pekka Paalanen wrote:
On Tue, 3 Mar 2015 15:24:13 -0600
Derek Foreman der...@osg.samsung.com wrote:
It's useful to know how long the current cursor frame should be displayed
so we can wait that long to change it.
Signed-off-by: Derek Foreman der...@osg.samsung.com
It's useful to know how long the current cursor frame should be displayed
so we can wait that long to change it.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
differences from v1:
Add comment about 0 durations
document return of 0 duration as unchanging image
make sure duration
in its own function and calls
it from both places that need it. Previously only the frame callback
handler did this correctly.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
clients/window.c | 27 +++
1 file changed, 19 insertions(+), 8 deletions(-)
diff --git
On 04/03/15 03:52 AM, Pekka Paalanen wrote:
On Tue, 03 Mar 2015 16:50:47 -0600
Derek Foreman der...@osg.samsung.com wrote:
Minor pedantry below.
On 02/03/15 09:15 AM, Pekka Paalanen wrote:
Are you happy with the explanations?
I fixed all the typos, and will push if you are. :-)
Sure
Instead of a frame callback we can now use a timerfd and the time
left in the current cursor frame. This saves us from setting
the cursor at 60hz even when no updates are required.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
NOTE: this requires a wayland change I just posted
It's useful to know how long the current cursor frame should be displayed
so we can wait that long to change it.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
In a follow up weston patch I use this to let toytoolkit set the cursor
with a timerfd instead of using a frame callback
Some minor pedantry below as well, but otherwise the whole series is
Reviewed-By: Derek Foreman der...@osg.samsung.com
On 02/03/15 09:16 AM, Pekka Paalanen wrote:
From: Pekka Paalanen pekka.paala...@collabora.co.uk
Implement support for weston_view_set_mask().
Signed-off-by: Pekka
Minor pedantry below.
On 02/03/15 09:15 AM, Pekka Paalanen wrote:
From: Pekka Paalanen pekka.paala...@collabora.co.uk
Add API for setting a clip ('scissor' in the code) rectangle per view,
in surface coordinates. Ivi-shell requires this feature to be able to
implement the IVI Layer Manager
Series looks good to me now.
Reviewed-by: Derek Foreman der...@osg.samsung.com
On 25/02/15 06:42 AM, Jonny Lamb wrote:
---
src/compositor-drm.c | 13 +-
src/compositor-fbdev.c | 2 +-
src/compositor-wayland.c | 20 +++--
src/compositor-x11.c | 11 -
src/gl
On 23/02/15 10:02 AM, Jonny Lamb wrote:
The intention here is to be able to find an existing wl_global using
some search parameters and then get some information about it.
I'm not sure I see a need for this, but if there is need there should
also be documentation. :)
---
On 10/02/15 09:22 AM, sardemff7+wayl...@sardemff7.net wrote:
On 2015-02-10 03:15, Bryce Harrington wrote:
Turns out the issue I've run into is that the --with-xserver-path
setting doesn't get passed down into distcheck, which calls configure
like this:
$(am__cd) $(distdir)/_build
The replacement xwayland-test should succeed, so we should run it
from distcheck again.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
Makefile.am | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 589b47b..1864b70 100644
and presence, as
currently this requires the releaser to have Xwayland installed.
Derek Foreman (2):
configure.ac: Don't look for Xwayland in the weston install
destination
build: Enable xwayland-test during distcheck
Makefile.am | 3 +--
configure.ac | 2 +-
2 files changed, 2 insertions(+), 3
Xwayland isn't part of this distribution so looking for Xwayland in
weston's install dir will cause distcheck to fail. Let's set the
default to /usr/bin where it's likely to live.
It can still be overriden during configure exactly as before.
Signed-off-by: Derek Foreman der...@osg.samsung.com
. It'll work fine the way it is now, or the way it
was.
Either way you choose:
Reviewed-by: Derek Foreman der...@osg.samsung.com
Signed-off-by: Bryce Harrington br...@osg.samsung.com
---
tests/test-runner.c | 62
+++--
1 file changed, 51
Looks fine to me.
Reviewed-by: Derek Foreman der...@osg.samsung.com
On 05/02/15 09:31 AM, Daniel Stone wrote:
Add autotools remnants, as well as more comprehensive vim swapfiles,
Sublime Text configuration, and git format-patch output.
Signed-off-by: Daniel Stone dani...@collabora.com
Failing to remove this can result in a crash when the signal is sent
after the window manager is destroyed.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
xwayland/window-manager.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/xwayland/window-manager.c b/xwayland/window-manager.c
On 02/02/15 03:40 PM, Bill Spitzak wrote:
On 02/02/2015 01:24 PM, Derek Foreman wrote:
force_kill_binding() appears to have deleted the setting of the
focus_surface variable.
I don't see it... I think I just moved it to the top of the function?
I think you are right.
It is assuming
Thanks for looking at this rather cumbersome patch! :)
On 02/02/15 01:40 PM, Bill Spitzak wrote:
Is there a reason it does not just clear the pointer when
keyboard_device_count is changed to zero? That would seem like a smaller
patch.
Pulled Jonas Ådahl in on the CC for that question... I
On 02/02/15 04:26 PM, Hardening wrote:
Le 02/02/2015 22:24, Derek Foreman a écrit :
Thanks for looking at this rather cumbersome patch! :)
On 02/02/15 01:40 PM, Bill Spitzak wrote:
Is there a reason it does not just clear the pointer when
keyboard_device_count is changed to zero? That would
renames the touch/keyboard/pointer pointers and adds
helper functions to get them that hide this complexity and return
NULL when *_device_count is 0.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
Fixed a couple of bugs, responded to some of Bill's concerns
desktop-shell/exposay.c
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
src/screenshooter.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/screenshooter.c b/src/screenshooter.c
index c98e2f9..4e32db5 100644
--- a/src/screenshooter.c
+++ b/src/screenshooter.c
@@ -558,8 +558,7
renames the touch/keyboard/pointer pointers and adds
helper functions to get them that hide this complexity and return
NULL when *_device_count is 0.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
This time around we rename the pointers and make everyone use the
helper functions (except
Remove a few instances of casting weston_seat to weston_seat.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
desktop-shell/shell.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c
index f6d9c79..0793352
.
There are some cases (new device setup) where the pointers still
need to be tested directly.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
desktop-shell/shell.c | 45 -
fullscreen-shell/fullscreen-shell.c | 4
src/compositor.c
The old xwayland-test hasn't worked in a while...
This new test checks that the wayland specific WL_SURFACE_ID atom exists,
checks that the window manager name is Weston WM and then maps a window
and waits for an exposure event.
Signed-off-by: Derek Foreman der...@osg.samsung.com
commit 78d00e45cc renamed text_model to text_input
This cleans up remaining uses of the word model
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
Same as seen previously, just rebased.
protocol/input-method.xml | 18 ++--
src/text-backend.c| 70
input_method's context
pointer to NULL to prevent a dangling pointer.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
Was asked to resend this with a better commit log. :)
I think the third item could be broken into a separate (2 line) patch,
but I don't think the dangling pointer is a problem
of testing.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
Makefile.am | 16 -
protocol/wayland-test.xml | 62 -
protocol/weston-test.xml | 73 +++
tests/button-test.c
callback being delayed indefinitely while waiting
for epoll_wait() to complete.
Callbacks are removed from the list when they're run, so the second
dispatch won't result in any extra calls.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
Amusingly, the problem Bill points out is exactly
On 28/01/15 09:39 AM, Giulio Camuffo wrote:
2015-01-28 17:25 GMT+02:00 Derek Foreman der...@osg.samsung.com:
To fix a shutdown crash in weston's x11 compositor I want to move the
weston X window close to an idle handler.
Since idle handlers are processed at the start of an event loop
the dispatcher blocks on epoll
forever (since all input events that will ever occur have been consumed).
Moving the idle handler callbacks to after the epoll_wait allows this to
all be completed within a single dispatch, and stops the lock-up from
occurring.
Signed-off-by: Derek Foreman der...@osg.samsung.com
.
NOTE: this requires a patch for wayland that moves the idle handler
dispatch to after epoll_wait in the event loop processing.
Closes bug: https://bugs.freedesktop.org/show_bug.cgi?id=81314
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
src/compositor-x11.c | 32
On 26/01/15 08:24 PM, Jonas Ådahl wrote:
On Mon, Jan 26, 2015 at 02:27:51PM -0600, Derek Foreman wrote:
On 26/01/15 04:19 AM, Jonas Ådahl wrote:
Warn and fail when trying to create sub surfaces when swap interval 0 is
not supported by the EGL platform.
Signed-off-by: Jonas Ådahl jad
On 26/01/15 04:19 AM, Jonas Ådahl wrote:
Warn and fail when trying to create sub surfaces when swap interval 0 is
not supported by the EGL platform.
Signed-off-by: Jonas Ådahl jad...@gmail.com
---
clients/nested.c | 1 +
clients/subsurfaces.c | 2 ++
clients/window.c | 19
There are functions below the Deprecated functions below comment
that are not deprecated.
Move the deprecated functions back down, and add a comment at the
end of the file to try to keep this from happening again.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
Rebased on master
src
On 23/01/15 11:16 AM, Bryce Harrington wrote:
On Tue, Jan 20, 2015 at 01:16:26PM -0600, Derek Foreman wrote:
This also skips the test when running on the headless backend.
Signed-off-by: Derek Foreman der...@osg.samsung.com
Reviewed-by: Bryce Harrington br...@osg.samsung.com
(But waiting
This skips the test when running on the headless backend.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
tests/buffer-count-test.c | 3 +++
tests/weston-test-client-helper.c | 2 ++
tests/weston-test-client-helper.h | 2 ++
3 files changed, 7 insertions(+)
diff --git a/tests
On 23/01/15 07:46 AM, Hans de Goede wrote:
For touchscreens we always send raw touch events to the compositor, and the
compositor or application toolkits do gesture recognition. This makes sense
because on a touchscreen which window / widget the touches are over is
important context to know to
On 22/01/15 03:48 PM, Daniel Stone wrote:
Hi,
On Tuesday, January 20, 2015, Derek Foreman der...@osg.samsung.com
mailto:der...@osg.samsung.com wrote:
This also skips the test when running on the headless backend.
I like this part!
+ if (strstr(extensions
There are functions below the Deprecated functions below comment
that are not deprecated.
Move the deprecated functions back down, and add a comment at the
end of the file to try to keep this from happening again.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
src/wayland-server.c
better
to me now. :)
Reviewed-by: Derek Foreman der...@osg.samsung.com
On 01/21/2015 07:28 AM, Derek Foreman wrote:
On 02/01/15 08:29 PM, Bill Spitzak wrote:
This object is only in wayland-private.h so it's methods should not
be in the documentation.
---
src/wayland-util.c |4
1
On 20/01/15 05:30 PM, Bryce Harrington wrote:
From: Bryce Harrington br...@osg.samsung.com
Adds weston_config_update(), which parses a condensed string of
comma-delimited key/value pairs and adds or changes the corresponding
parameters in the weston_config structure.
Signed-off-by: Bryce
*section,
Otherwise, looks good to me.
Reviewed-by: Derek Foreman der...@osg.samsung.com
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel
Looks good to me.
Reviewed-by: Derek Foreman der...@osg.samsung.com
On 20/01/15 05:30 PM, Bryce Harrington wrote:
From: Bryce Harrington br...@osg.samsung.com
Adds a setter, weston_config_section_set(), for changing key values in
the loaded copy of the weston.ini configuration
This looks good to me, though I suppose arguments could be made either
way. I think it makes more sense this way.
Reviewed-by: Derek Foreman der...@osg.samsung.com
On 02/01/15 08:29 PM, Bill Spitzak wrote:
The fact that these functions take both a display and queue argument is
I think
This seems like a big win to me.
Reviewed-by: Derek Foreman der...@osg.samsung.com
On 02/01/15 08:29 PM, Bill Spitzak wrote:
This makes it a lot easier to figure out what is going on!
---
doc/publican/protocol-to-docbook.xsl | 35
++
1 file changed, 35
to look at.
Reviewed-by: Derek Foreman der...@osg.samsung.com
---
doc/publican/protocol-to-docbook.xsl | 38
++
1 file changed, 25 insertions(+), 13 deletions(-)
diff --git a/doc/publican/protocol-to-docbook.xsl
b/doc/publican/protocol-to-docbook.xsl
index
On 02/01/15 08:29 PM, Bill Spitzak wrote:
This object is only in wayland-private.h so it's methods should not
be in the documentation.
---
src/wayland-util.c |4
1 file changed, 4 insertions(+)
diff --git a/src/wayland-util.c b/src/wayland-util.c
index b099882..db51ebb 100644
):
name
uint unique name for the object
I think it might be better with a - or with summary in (). However, I
think that's a fairly minor complaint.
enums are much nicer than before, imho.
Reviewed-by: Derek Foreman der...@osg.samsung.com
___
wayland
Looks good to me.
Reviewed-by: Derek Foreman der...@osg.samsung.com
On 02/01/15 08:29 PM, Bill Spitzak wrote:
---
src/wayland-client.c |7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/wayland-client.c b/src/wayland-client.c
index 9e8bdfe..d1d21ca 100644
Hmm, if I understand what this is doing... it disables doxygen parsing
for a block that has no doxygen comments in it anyway.
In the future if we deprecate stuff that actually has doxygen comments,
I suppose this will result in nicer documentation, and I see no harm in
it...
Reviewed-by: Derek
nice zoom semantics for multi-seat later)
On 01/09/2015 10:45 AM, Derek Foreman wrote:
Any time the zoom is updated the best zoom target will be calculated
with the following priority:
1) The current pointer location.
2) The last known location of the pointer that initiated the zoom.
3
Nice catch. Zooming with mod+scrollwheel will divide by zero a few times
at the start of zoom without this patch.
Reviewed-by: Derek Foreman der...@osg.samsung.com
On 17/01/15 01:31 PM, Carlos Olmedo Escobar wrote:
Check the value of level before dividing 1 by it.
Signed-off-by: Carlos
I think we can call this obviously correct.
Reviewed-by: Derek Foreman der...@osg.samsung.com
On 09/01/15 08:09 PM, Bryce Harrington wrote:
Signed-off-by: Bryce Harrington br...@osg.samsung.com
---
releasing.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
This also skips the test when running on the headless backend.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
tests/buffer-count-test.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/tests/buffer-count-test.c b/tests/buffer-count-test.c
index 5985a9e..3dd6e1a 100644
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
protocol/input-method.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/protocol/input-method.xml b/protocol/input-method.xml
index 6961c5a..2f596f0 100644
--- a/protocol/input-method.xml
+++ b/protocol/input-method.xml
commit 78d00e45cc renamed text_model to text_input
This cleans up remaining uses of the word model
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
Please note that this applies on top of my earlier test-input fix-ups
patch set, not directly on top of master.
protocol/input-method.xml
On 11/01/15 04:37 PM, Mike Gorse wrote:
Hi,
I was curious whether wl_test (from weston) is intended to eventually be
moved into wayland. I'm asking because it contains functionality (such
as being able to track and move the mouse pointer) that the Orca screen
reader relies on[1], so I'm
It doesn't do anything with a pointer, and zoom can be initiated by the
keyboard, so the name was a little confusing.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
src/zoom.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/zoom.c b/src/zoom.c
index
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
src/compositor.h | 2 +-
src/zoom.c | 7 ---
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/compositor.h b/src/compositor.h
index 3f7ed4a..311bea0 100644
--- a/src/compositor.h
+++ b/src/compositor.h
@@ -152,7
No longer call weston_output_update_zoom() when trying to zoom out
on an unzoomed output.
Add an assert() to make sure update_zoom is never called without an
active zoom.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
desktop-shell/shell.c | 5 -
src/zoom.c| 2 ++
2
if
a device is plugged in to control the pointer.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
src/compositor.h | 4
src/input.c | 4
src/zoom.c | 31 ---
3 files changed, 36 insertions(+), 3 deletions(-)
diff --git a/src/compositor.h
Track the seat that initiated a seat instead of picking the first one.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
desktop-shell/shell.c | 2 +-
src/compositor.h | 4 +++-
src/zoom.c| 20 +++-
3 files changed, 11 insertions(+), 15 deletions(-)
diff
that initiated a zoom no longer has a keyboard (so is unable
to change the zoom) then other seats will control that zoom.
The zoom may jump when the target changes.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
desktop-shell/shell.c | 18 +
src/compositor.c | 70
don't annoy anyone, but
I think they only change things in cases that crashed or were
obviously weird before.
The normal (single seat with a mouse) use case should act as before.
Derek Foreman (6):
zoom: Change zoom-active to a bool
zoom: Call weston_output_activate_zoom() appropriately
zoom
On 09/01/15 02:52 PM, Giulio Camuffo wrote:
I have a comment below, the rest looks good to me.
2014-10-16 18:55 GMT+03:00 Derek Foreman der...@osg.samsung.com:
From: Jason Ekstrand ja...@jlekstrand.net
---
src/compositor.c | 84
Thanks for looking at this!
On 09/01/15 03:15 PM, Giulio Camuffo wrote:
One comment below, otherwise looks fine
2014-10-16 18:55 GMT+03:00 Derek Foreman der...@osg.samsung.com:
From: Jason Ekstrand ja...@jlekstrand.net
Now that we have a buffer-to-surface matrix and the global-to-output
On 06/01/15 09:25 PM, Jonas Ådahl wrote:
On Tue, Jan 06, 2015 at 07:51:43PM -0600, Derek Foreman wrote:
Removing the last device that provides a pointer now destroys the
pointer struct and sets it to NULL (so things like zoom don't use
the old co-ordinates)
The fact that the pointer
When the last pointer is removed from a seat, the pointer struct is
intentionally kept. This has some interesting side effects, so I've
documented it here so people like me don't errantly assume it's a bug.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
I tried to fix this bug
Removing the last device that provides a pointer now destroys the
pointer struct and sets it to NULL (so things like zoom don't use
the old co-ordinates)
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
src/input.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
On 06/01/15 04:04 PM, Peter Hutterer wrote:
On Tue, Jan 06, 2015 at 02:28:13PM -0600, Derek Foreman wrote:
The zoom effect zooms at the seat's current pointer location. When no
pointer is present the zoom key bindings cause a crash.
Instead, check for the absence of a pointer and log
For now, the intention of test-mode is to have a way to allow a client
to control the presentation clock to allow capturing deterministic
screenshots during testing.
Once in test-mode you're trapped in test-mode forever.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
protocol/wayland
In preparation for a future patch which allows test clients to control
the presentation clock, we wrap any clock_gettime() of the presentation
clock in weston_compositor_presentation_clock_gettime().
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
src/compositor-drm.c | 2 +-
src
Add a way to set the presentation clock to an arbitrary value, but only
when in test mode.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
protocol/wayland-test.xml | 9 +
src/compositor.c | 23 +++
src/compositor.h | 4
tests/weston
On 19/12/14 06:40 AM, Pekka Paalanen wrote:
On Fri, 12 Dec 2014 14:29:42 -0600
Derek Foreman der...@osg.samsung.com wrote:
I just noticed that the follow patch *exactly* undoes commit 22ba60e
Is there any other reason that commit was necessary, or was it intended
to be cosmetic?
No, I
Add a test mode callback for compositor-headless that allows client
driven repaint.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
src/compositor-headless.c | 34 --
1 file changed, 32 insertions(+), 2 deletions(-)
diff --git a/src/compositor-headless.c
This series allows test clients to put the compositor into a new test mode
where the presentation clock is controlled by the client, and the client
can request a repaint.
Only the headless compositor supports this for now.
Derek Foreman (6):
test: Add a compositor test-mode
compositors: Wrap
For now, the intention of test-mode is to have a way to allow a client
to control the presentation clock to allow capturing deterministic
screenshots during testing.
Once in test-mode you're trapped in test-mode forever.
Signed-off-by: Derek Foreman der...@osg.samsung.com
---
protocol/wayland
901 - 1000 of 1150 matches
Mail list logo
