[PATCH weston v2 1/2] compositor: add plugin-registry

2016-06-29 Thread Giulio Camuffo
patch fixes that. The tests all pass. Signed-off-by: Pekka Paalanen Signed-off-by: Giulio Camuffo --- Makefile.am | 8 +++ libweston/compositor.c | 6 ++ libweston/compositor.h | 2 + libweston/plugin-registry.c | 156

Re: [PATCH weston 2/2] xwayland: make the plugin usable by libweston compositors

2016-06-29 Thread Giulio Camuffo
t; + wxw->process.cleanup = xserver_cleanup; >> + if (api->listen(xwayland, wxw, spawn_xserver) < 0) >> + return -1; >> + >> + loop = wl_display_get_event_loop(comp->wl_display); >> + wxw->sigusr1_source = wl_event_loop_a

Re: [PATCH weston v2] compositor: allow to control the vt switching

2016-06-29 Thread Giulio Camuffo
2016-06-23 9:37 GMT+02:00 Daniel Stone : > Hi Guilio, > > On 5 June 2016 at 03:48, Giulio Camuffo wrote: >> @@ -97,8 +97,17 @@ switch_vt_binding(struct weston_keyboard *keyboard, >> uint32_t time, uint32_t key, void *data) >> { >> str

Re: [PATCH weston 12/12] compositor: Switch to new surface/view mapped checks

2016-06-29 Thread Giulio Camuffo
2016-06-28 14:30 GMT+02:00 Pekka Paalanen : > On Thu, 23 Jun 2016 11:59:40 +0200 > Armin Krezović wrote: > >> This patch makes use of new flags which were introduced >> by previous patches to check if a surface/view is mapped >> >> Signed-off-by: Armin Krezović >> --- >> src/compositor.c | 10 ++

Re: [PATCH weston 08/11] compositor: Untangle mapedness from outputs

2016-06-23 Thread Giulio Camuffo
2016-06-18 19:15 GMT+02:00 Armin Krezović : > Currently, weston assumes a surface/view is mapped if > it has an output assigned. In a zero outputs scenario, > this isn't really desirable. > > This patch introduces a new flag to weston_surface and > weston_view, which has to be set manually to indic

Re: [PATCH wayland 2/5] Add API to retrieve the interface of a wl_resource

2016-06-17 Thread Giulio Camuffo
2016-06-17 14:09 GMT+03:00 Pekka Paalanen : > On Mon, 7 Mar 2016 18:31:32 +0100 > Giulio Camuffo wrote: > >> --- >> src/wayland-server-core.h | 2 ++ >> src/wayland-server.c | 12 >> 2 files changed, 14 insertions(+) >> >> diff --

Re: [PATCH wayland-protocols v3 7/7] xdg-shell: Introduce xdg_positioner

2016-06-08 Thread Giulio Camuffo
2016-06-08 10:35 GMT+02:00 Jonas Ådahl : > On Wed, Jun 08, 2016 at 11:16:49AM +0300, Giulio Camuffo wrote: >> Hi, one comment below, but anyway i think this looks good. However i >> will try to use it in qt asap to confirm it really is. >> >> 2016-05-26

Re: [PATCH wayland-protocols v3 7/7] xdg-shell: Introduce xdg_positioner

2016-06-08 Thread Giulio Camuffo
Hi, one comment below, but anyway i think this looks good. However i will try to use it in qt asap to confirm it really is. 2016-05-26 7:32 GMT+03:00 Jonas Ådahl : > + > + > + > + Set the size of the surface that is to be positioned with the > positioner > + object. The si

Re: [PATCH wayland-protocols v3 6/7] xdg-shell: Make xdg_popup non-grabbing by default

2016-06-08 Thread Giulio Camuffo
2016-06-08 3:08 GMT+02:00 Jonas Ådahl : > On Tue, Jun 07, 2016 at 05:39:09PM +0300, Giulio Camuffo wrote: >> Hi, a couple of comments below: >> >> 2016-05-26 7:32 GMT+03:00 Jonas Ådahl : >> > Turn xdg_popup into plain temporary child surfaces without any grabbing >

Re: [PATCH wayland-protocols v3 6/7] xdg-shell: Make xdg_popup non-grabbing by default

2016-06-07 Thread Giulio Camuffo
Hi, a couple of comments below: 2016-05-26 7:32 GMT+03:00 Jonas Ådahl : > Turn xdg_popup into plain temporary child surfaces without any grabbing > or mapping order requirements by default. > > In order to create grabbing popup chains, a new request 'grab' is > introduced which enables more or les

Re: [PATCH wayland-protocols v3 1/7] xdg-shell: Turn xdg_surface into a generic base interface

2016-06-07 Thread Giulio Camuffo
Hi, just a few nitpicks below. 2016-05-26 7:32 GMT+03:00 Jonas Ådahl : > Split out toplevel window like requests and events into a new interface > called xdg_toplevel, and turn xdg_surface into a generic base interface > which others extends. > > xdg_popup is changed to extend the xdg_surface. > >

Re: [PATCH weston 1/2] Move weston source to compositor/

2016-06-06 Thread Giulio Camuffo
2016-06-06 15:52 GMT+03:00 Pekka Paalanen : > On Sun, 5 Jun 2016 21:50:33 +0300 > Giulio Camuffo wrote: > >> 2016-06-03 17:33 GMT+03:00 Pekka Paalanen : >> > From: Pekka Paalanen >> > >> > This is the start of separating weston-the-compositor sou

Re: [PATCH weston 1/2] Move weston source to compositor/

2016-06-05 Thread Giulio Camuffo
2016-06-03 17:33 GMT+03:00 Pekka Paalanen : > From: Pekka Paalanen > > This is the start of separating weston-the-compositor source files from > libweston source files. > > This is moving all the files related to the 'weston' binary. Also the > CMS and systemd plugins are moved. > > xwayland plugi

Re: [PATCH weston 5/5] main: remove unused argument from backend loaders

2016-06-05 Thread Giulio Camuffo
Maybe it would make sense to squash this with the previous one? Cheers, Giulio 2016-06-03 15:41 GMT+03:00 Pekka Paalanen : > From: Pekka Paalanen > > There is no need to pass the backend name string to these functions > anymore. > > Signed-off-by: Pekka Paalanen > --- > src/main.c | 24 ++

Re: [PATCH weston 2/5] compositor, main: use weston_compositor_load_backend()

2016-06-05 Thread Giulio Camuffo
git am complains on this one: Applying patch #91319 using 'git am' Description: [weston,2/5] compositor, main: use weston_compositor_load_backend() Applying: compositor, main: use weston_compositor_load_backend() .git/rebase-apply/patch:44: new blank line at EOF. + warning: 1 line adds whitespace

Re: [PATCH weston 3/5] libweston: remove unused backend_init() arguments

2016-06-05 Thread Giulio Camuffo
2016-06-03 15:41 GMT+03:00 Pekka Paalanen : > From: Pekka Paalanen > > Backends do not have access to command line elements nor weston_config > anymore. The use the backend-specific config APIs now. Missing a y here, The -> They. Cheers, Giulio > > Signed-off-by: Pekka Paalanen > --- > src/co

Re: [PATCH weston 0/5] Clean up after backend config conversion

2016-06-05 Thread Giulio Camuffo
Hi, i have a few nitpicks on some patches, but for the whole series: Reviewed-by: Giulio Camuffo 2016-06-03 16:12 GMT+03:00 Quentin Glidic : > On 03/06/2016 14:41, Pekka Paalanen wrote: >> >> From: Pekka Paalanen >> >> Now that the rpi-backend is gone, we can cle

[PATCH weston v2] compositor: allow to control the vt switching

2016-06-04 Thread Giulio Camuffo
weston_compositor_set_vt_switcher() function, so that it can delay the switching to later, by calling weston_compositor_activate_vt(). Signed-off-by: Giulio Camuffo --- Makefile.am | 2 +- src/compositor.c | 18 ++ src/compositor.h | 39

[PATCH weston] compositor: allow to control the vt switching

2016-06-04 Thread Giulio Camuffo
weston_compositor_set_vt_switcher() function, so that it can delay the switching to later, by calling weston_compositor_activate_vt(). Signed-off-by: Giulio Camuffo --- Makefile.am | 2 +- src/compositor.c | 18 ++ src/compositor.h | 39 +++ src

[PATCH weston 1/2] compositor: add plugin-registry

2016-06-04 Thread Giulio Camuffo
From: Pekka Paalanen Implement a simple register and lookup for function tables. This is intended for plugins to expose APIs to other plugins. It has been very hard to arrange a plugin to be able to call into another plugin without modifying Weston core to explicitly support each case. This patc

[PATCH weston 2/2] xwayland: make the plugin usable by libweston compositors

2016-06-04 Thread Giulio Camuffo
the compositor side, and to deal with signal handling. A new function is added in compositor.c to load and init the xwayland.so plugin. Signed-off-by: Giulio Camuffo --- Makefile.am| 14 ++- src/compositor.c | 15 +++ src/compositor.h | 3 + src/main.c

[PATCH weston v3 7/8] Split the modules and include files between weston and libweston

2016-06-02 Thread Giulio Camuffo
number will need to be increased. Signed-off-by: Giulio Camuffo Reviewed-by: Quentin Glidic Acked-by: Pekka Paalanen --- v3: - renamed the new function to wet_load_module - change include in weston.h to use <> Makefile.am| 25 +++-- config

[PATCH weston v3 2/8] Move part of screenshooter.c to weston-screenshooter.c

2016-06-02 Thread Giulio Camuffo
start and stop the recorder. Signed-off-by: Giulio Camuffo Reviewed-by: Pekka Paalanen --- v3: put weston.h in westoninclude_HEADERS Makefile.am| 2 + desktop-shell/shell.c | 1 + src/compositor.h | 8 +- src/screenshooter.c| 187

[PATCH weston v3 6/8] allow compositors to define the logging behavior

2016-06-02 Thread Giulio Camuffo
Signed-off-by: Giulio Camuffo Reviewed-by: Quentin Glidic Reviewed-by: Pekka Paalanen --- v3: - added documentation for weston_log_set_handler - fixed whitespace issue src/compositor.h | 5 ++-- src/log.c| 87 ++-- src/main.c

[PATCH weston v3 8/8] Create a libweston-0.so

2016-06-02 Thread Giulio Camuffo
This commit also adds a libweston-0.pc file. The -0 is the abi version introduced in the previous patch. Signed-off-by: Giulio Camuffo Reviewed-by: Quentin Glidic Acked-by: Pekka Paalanen --- v3: - read dropped library dependencies for libweston - keep log.c where it is - put weston.h

[PATCH weston v3 5/8] libinput: don't use weston_config when configuring input devices

2016-06-02 Thread Giulio Camuffo
Instead add callbacks to the drm and fbdev backends and pass that to the input backens so that when a new device needs to be configured that is called and the compositor can configure it. Signed-off-by: Giulio Camuffo Reviewed-by: Quentin Glidic Reviewed-by: Pekka Paalanen --- v3: nothing

[PATCH weston v3 1/8] Rename weston_compositor_xkb_init to weston_compositor_set_xkb_rule_names

2016-06-02 Thread Giulio Camuffo
weston_compositor_xkb_destroy() is called automatically so having only weston_compositor_xkb_init() to be called by the user was a bit weird. So rename it so that it makes more sense. Also export it, since libweston compositors need to call it. Signed-off-by: Giulio Camuffo Reviewed-by: Quentin

[PATCH weston v3 3/8] Move the functions launching clients to main.c

2016-06-02 Thread Giulio Camuffo
They belong in the compositor rather than libweston since they set signals handlers, and a library should not do that behind its user's back. Besides, they were using functions in main.c already so they were not usable by other compositors. Signed-off-by: Giulio Camuffo Reviewed-by: Qu

[PATCH weston v3 4/8] compositor: remove the weston_config field in weston_compositor

2016-06-02 Thread Giulio Camuffo
The config can now be retrieved with a new function defined in weston.h, wet_get_config(weston_compositor*). Signed-off-by: Giulio Camuffo Reviewed-by: Pekka Paalanen Reviewed-by: Quentin Glidic --- v3: renamed the new function to wet_get_config desktop-shell/shell.c | 2 +- ivi-shell

Re: [PATCH weston v2 5/8] libinput: don't use weston_config when configuring input devices

2016-06-02 Thread Giulio Camuffo
2016-06-02 11:44 GMT+03:00 Quentin Glidic : > On 01/06/2016 20:43, Giulio Camuffo wrote: >> >> Instead add callbacks to the drm and fbdev backends and pass that to >> the input backens so that when a new device needs to be configured >> that is called and the

[PATCH weston v2 4/8] compositor: remove the weston_config field in weston_compositor

2016-06-01 Thread Giulio Camuffo
The config can now be retrieved with a new function defined in weston.h, weston_get_config(weston_compositor*). Signed-off-by: Giulio Camuffo --- desktop-shell/shell.c | 2 +- ivi-shell/hmi-controller.c | 6 +++--- ivi-shell/ivi-shell.c | 3 ++- src/cms-static.c | 3 ++- src

[PATCH weston v2 6/8] allow compositors to define the logging behavior

2016-06-01 Thread Giulio Camuffo
Signed-off-by: Giulio Camuffo --- src/compositor.h | 5 ++-- src/log.c| 74 ++- src/main.c | 80 3 files changed, 90 insertions(+), 69 deletions(-) diff --git a/src

[PATCH weston v2 3/8] Move the functions launching clients to main.c

2016-06-01 Thread Giulio Camuffo
They belong in the compositor rather than libweston since they set signals handlers, and a library should not do that behind its user's back. Besides, they were using functions in main.c already so they were not usable by other compositors. Signed-off-by: Giulio Camuffo --- ivi-shel

[PATCH weston v2 0/8] Create libweston.so, v2

2016-06-01 Thread Giulio Camuffo
This new version fixes the issues raised and adds two new patches to plug a hole i didn't notice before. Now libweston should not use any functionality that is part of weston-the-compositor. Giulio Camuffo (8): Rename weston_compositor_xkb_init to weston_compositor_set_xkb_rule_

[PATCH weston v2 1/8] Rename weston_compositor_xkb_init to weston_compositor_set_xkb_rule_names

2016-06-01 Thread Giulio Camuffo
weston_compositor_xkb_destroy() is called automatically so having only weston_compositor_xkb_init() to be called by the user was a bit weird. So rename it so that it makes more sense. Also export it, since libweston compositors need to call it. --- v2: renamed xkb_init to set_xkb_rule_names src/

[PATCH weston v2 8/8] Create a libweston-0.so

2016-06-01 Thread Giulio Camuffo
This commit also adds a libweston-0.pc file. The -0 is the abi version introduced in the previous patch. Signed-off-by: Giulio Camuffo --- Makefile.am | 45 +++-- configure.ac| 4 src/libweston.pc.in | 12 src

[PATCH weston v2 7/8] Split the modules and include files between weston and libweston

2016-06-01 Thread Giulio Camuffo
the number will be increased. Signed-off-by: Giulio Camuffo --- v2: - don't remove MODULEDIR - keep systemd-notify with the main.c side - rename the new load function to load_weston_plugin Makefile.am| 24 +++- configure.ac | 2 ++ ivi-shel

[PATCH weston v2 5/8] libinput: don't use weston_config when configuring input devices

2016-06-01 Thread Giulio Camuffo
Instead add callbacks to the drm and fbdev backends and pass that to the input backens so that when a new device needs to be configured that is called and the compositor can configure it. Signed-off-by: Giulio Camuffo --- Makefile.am| 3 ++- src/compositor-drm.c | 3 ++- src

[PATCH weston v2 2/8] Move part of screenshooter.c to weston-screenshooter.c

2016-06-01 Thread Giulio Camuffo
start and stop the recorder. Signed-off-by: Giulio Camuffo --- v2 Makefile.am| 2 + desktop-shell/shell.c | 1 + src/compositor.h | 8 +- src/screenshooter.c| 187 +--- src/weston-screenshooter.c | 191

Re: [PATCH] compositor-drm: pass only const strings as backend parameters

2016-05-25 Thread Giulio Camuffo
2016-05-25 10:46 GMT+03:00 Quentin Glidic : > On 24/05/2016 18:50, Giulio Camuffo wrote: >> >> This makes more clear that the backend doesn't take ownership >> of the data and it makes the API more usable. >> >> Signed-off-by: Giulio Camuffo

[PATCH weston 4/6] Move part of screenshooter.c to weston-screenshooter.c

2016-05-24 Thread Giulio Camuffo
start and stop the recorder. Signed-off-by: Giulio Camuffo --- Makefile.am| 1 + desktop-shell/shell.c | 1 + src/compositor.h | 8 +- src/screenshooter.c| 187 +--- src/weston-screenshooter.c | 191

[PATCH weston 1/6] Export weston_compositor_xkb_init, as required for libweston users

2016-05-24 Thread Giulio Camuffo
--- src/input.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/input.c b/src/input.c index 8fe898c..c6cdedd 100644 --- a/src/input.c +++ b/src/input.c @@ -2277,7 +2277,7 @@ bind_seat(struct wl_client *client, void *data, uint32_t version, uint32_t id) } #ifdef ENA

[PATCH weston 5/6] allow compositors to define the logging behavior

2016-05-24 Thread Giulio Camuffo
Signed-off-by: Giulio Camuffo --- src/compositor.h | 5 ++-- src/log.c| 74 ++- src/main.c | 80 3 files changed, 90 insertions(+), 69 deletions(-) diff --git a/src

[PATCH weston 6/6] Create a libweston-0.so

2016-05-24 Thread Giulio Camuffo
This commit also adds a libweston-0.pc file. The -0 is the abi version introduced in the previous patch. Signed-off-by: Giulio Camuffo --- Makefile.am | 44 +++- configure.ac| 1 + src/libweston.pc.in | 11 +++ 3 files changed, 39

[PATCH weston 3/6] Move the functions launching clients to main.c

2016-05-24 Thread Giulio Camuffo
They belong in the compositor rather than libweston since they set signals handlers, and a library should not do that behind its user's back. Besides, they were using functions in main.c already so they were not usable by other compositors. Signed-off-by: Giulio Camuffo --- ivi-shel

[PATCH weston 2/6] Split the modules and include files between weston and libweston

2016-05-24 Thread Giulio Camuffo
the number will be increased. Signed-off-by: Giulio Camuffo --- Makefile.am| 28 +--- configure.ac | 2 ++ ivi-shell/ivi-layout.c | 3 ++- src/compositor.c | 2 +- src/main.c | 47 ++- src

[PATCH weston 0/6] Create the libweston library

2016-05-24 Thread Giulio Camuffo
orted. Some patches i believe could go in by themselves, such as 1, 3 and 4 if the ones actually dealing with the .so need to be changed. Cheers, Giulio Giulio Camuffo (6): Export weston_compositor_xkb_init, as required for libweston users Split the modules and include files between westo

[PATCH] compositor-drm: pass only const strings as backend parameters

2016-05-24 Thread Giulio Camuffo
This makes more clear that the backend doesn't take ownership of the data and it makes the API more usable. Signed-off-by: Giulio Camuffo --- src/compositor-drm.h | 10 +- src/main.c | 18 -- 2 files changed, 17 insertions(+), 11 deletions(-) diff --git

Re: [PATCH wayland] shm, server, server-core: Move deprecated prototype

2016-05-23 Thread Giulio Camuffo
Hi, 2016-05-24 4:27 GMT+03:00 Yong Bakos : > From: Yong Bakos > > wayland-server-core.h contains the prototype of wl_shm_buffer_create, > which is marked WL_DEPRECATED. > > Move the prototype out of wayland-server-core.h and into the group of > deprecated prototypes in wayland-server.h. > Add the

[PATCH] Build a libweston library

2016-05-11 Thread Giulio Camuffo
an be done when we identify which files are they. When the API/ABI of libweston changes in an incompatible way, the abi version will be bumped so that multiple versions can live together. Also a libweston-N.pc file is created and installed together with weston.pc. Signed-off-by: Giul

Re: [PATCH weston v6 06/12] x11: port the x11 backend to the new init api

2016-04-30 Thread Giulio Camuffo
2016-04-30 0:44 GMT+03:00 Bryce Harrington : > On Sun, Apr 17, 2016 at 05:10:24PM +0300, Giulio Camuffo wrote: >> 2016-04-16 6:28 GMT+03:00 Bryce Harrington : >> > From: Benoit Gschwind >> > >> > Use a "well" defined structure to configure x11-

Re: [PATCH weston v6 06/12] x11: port the x11 backend to the new init api

2016-04-30 Thread Giulio Camuffo
2016-04-30 0:38 GMT+03:00 Bryce Harrington : > On Sun, Apr 17, 2016 at 05:31:32PM +0300, Giulio Camuffo wrote: >> Sorry, i keep seeing things after i hit send... >> >> 2016-04-17 17:10 GMT+03:00 Giulio Camuffo : >> > 2016-04-16 6:28 GMT+03:00 Bryce

Re: [PATCH weston v6 12/12] x11: Initialize all outputs at start

2016-04-17 Thread Giulio Camuffo
2016-04-16 6:28 GMT+03:00 Bryce Harrington : > We know ahead of time the maximum number of outputs we'll be > configuring, so just alloc that memory from the get-go, instead of > realloc'ing for each new output. > > Suggested-by: Pekka Paalanen > Signed-off-by: Bryce Harrington > --- > src/main.

Re: [PATCH weston v6 06/12] x11: port the x11 backend to the new init api

2016-04-17 Thread Giulio Camuffo
Sorry, i keep seeing things after i hit send... 2016-04-17 17:10 GMT+03:00 Giulio Camuffo : > 2016-04-16 6:28 GMT+03:00 Bryce Harrington : >> From: Benoit Gschwind >> >> Use a "well" defined structure to configure x11-backend and move >> configurat

Re: [PATCH weston v6 11/12] Enforce destruction of all backend config objects after initialization

2016-04-17 Thread Giulio Camuffo
Maybe it would make sense to squash this too, but either way: Reviewed-by: Giulio Camuffo 2016-04-16 6:28 GMT+03:00 Bryce Harrington : > Since the backend config struct versioning implies that there we expect > potential future descrepancy between main's definition of the config >

Re: [PATCH weston v6 08/12] drm: Don't hang onto the backend config object post-backend_init

2016-04-17 Thread Giulio Camuffo
Ah, so this fixes the problem with patch 5. I think it would make sense to squash them together. One comment below. 2016-04-16 6:28 GMT+03:00 Bryce Harrington : > The drm backend was copying most everything out of the config object > already, but now also copy the use_current_mode parameter and th

Re: [PATCH weston v6 07/12] headless: port the headless backend to the new init api

2016-04-17 Thread Giulio Camuffo
Reviewed-by: Giulio Camuffo 2016-04-16 6:28 GMT+03:00 Bryce Harrington : > From: Benoit Gschwind > > refactor configuration API of headless-backend > > Signed-off-by: Bryce Harrington > Reviewed-by: Pekka Paalanen > > v6: > - Define version number in the hea

Re: [PATCH weston v6 06/12] x11: port the x11 backend to the new init api

2016-04-17 Thread Giulio Camuffo
o err_x11_input; > } > > - x = pixman_region32_extents(&output->base.region)->x2; > - > - output_count++; > - if (option_count && output_count >= option_count) > - break; > -

Re: [PATCH weston v6 05/12] drm: port the drm backend to the new init api

2016-04-17 Thread Giulio Camuffo
2016-04-17 16:47 GMT+03:00 Giulio Camuffo : > Hi, this looks good to me. > Reviewed-by: Giulio Camuffo Actually no, sorry. See comments below. > > 2016-04-16 6:28 GMT+03:00 Bryce Harrington : >> From: Giulio Camuffo >> >> Signed-off-by: Bryce Harrington

Re: [PATCH weston v6 05/12] drm: port the drm backend to the new init api

2016-04-17 Thread Giulio Camuffo
Hi, this looks good to me. Reviewed-by: Giulio Camuffo 2016-04-16 6:28 GMT+03:00 Bryce Harrington : > From: Giulio Camuffo > > Signed-off-by: Bryce Harrington > Reviewed-by: Quentin Glidic > Acked-by: Pekka Paalanen > Tested-by: Benoit Gschwind > > v6: > - Fi

Re: [PATCH weston v6 03/12] compositor: Drop unneeded create_output callback

2016-04-17 Thread Giulio Camuffo
I must say the approach you've taken in the x11 backend, passing all the configs at init time, is neat, but this leaves me wondering if we'll ever want to create an output after initialization... however i think until such need arises this is ok. Reviewed-by: Giulio Camuffo 2016-04-1

Re: [PATCH weston v6 01/12] drm: Spelling fix in comment

2016-04-17 Thread Giulio Camuffo
Hi, Trivial enough, Reviewed-by: Giulio Camuffo 2016-04-16 6:28 GMT+03:00 Bryce Harrington : > Signed-off-by: Bryce Harrington > --- > src/compositor-drm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/compositor-drm.c b/src/compositor-drm

Re: [PATCH weston v6 09/12] drm: Move drm's output configuration into the drm backend

2016-04-17 Thread Giulio Camuffo
Hi, I don't understand this one at all, you're moving configuration back into the backend, partially reverting patch 5. 2016-04-16 6:28 GMT+03:00 Bryce Harrington : > Signed-off-by: Bryce Harrington > --- > src/compositor-drm.c | 93 > > src

Re: [PATCH weston v5 03/11] drm: port the drm backend to the new init api

2016-04-15 Thread Giulio Camuffo
2016-04-16 1:02 GMT+03:00 Bryce Harrington : > On Fri, Apr 15, 2016 at 02:32:04PM +0200, Benoit Gschwind wrote: >> > + /** The seat to be used by the output. Set to NULL to use the >> > +* default seat. */ >> > + char *seat; >> > + /** The modeline to be used by the output. Refer to the d

Re: [PATCH weston v5 08/11] drm: Code and comments reformatting for consistency with other backend configs

2016-04-14 Thread Giulio Camuffo
2016-04-13 16:17 GMT+03:00 Pekka Paalanen : > On Wed, 13 Apr 2016 03:25:12 -0700 > Bryce Harrington wrote: > >> Signed-off-by: Bryce Harrington >> --- >> src/compositor-drm.c | 10 ++ >> src/compositor-drm.h | 43 --- >> src/main.c | 6 +

Re: [PATCH 2/5] drm: port the drm backend to the new init api

2016-04-14 Thread Giulio Camuffo
2016-04-13 14:30 GMT+03:00 Pekka Paalanen : > On Tue, 12 Apr 2016 21:34:28 -0700 > Bryce Harrington wrote: > >> On Wed, Apr 06, 2016 at 11:37:57AM +0300, Pekka Paalanen wrote: >> > On Wed, 9 Mar 2016 16:49:29 -0800 >> > Bryce Harrington wrote:

[PATCH wayland v2] Add API to install protocol loggers on the server wl_display

2016-04-07 Thread Giulio Camuffo
. Signed-off-by: Giulio Camuffo --- v2: changed the logger function to pass a struct wl_log_message* with all the relevant data instead of a string. src/wayland-server-core.h | 21 ++ src/wayland-server.c | 100 +++--- 2 files changed, 115

Re: [PATCH 2/5] drm: port the drm backend to the new init api

2016-04-06 Thread Giulio Camuffo
2016-04-06 11:37 GMT+03:00 Pekka Paalanen : > On Wed, 9 Mar 2016 16:49:29 -0800 > Bryce Harrington wrote: > >> From: Giulio Camuffo >> >> Signed-off-by: Bryce Harrington >> Reviewed-by: Quentin Glidic >> Acked-by: Pekka Paalanen >> --- >&g

Re: [PATCH weston v2 01/10] compositor: Track idle as a per-seat property

2016-04-06 Thread Giulio Camuffo
2016-04-07 1:46 GMT+03:00 Bryce Harrington : > On Mon, Mar 28, 2016 at 10:17:20AM +0300, Giulio Camuffo wrote: >> 2016-03-24 20:27 GMT+02:00 Bryce Harrington : >> > Instead of having a single global idle tracker, track idling separately >> > for each seat. Still treat

Re: [PATCH wayland] Add API to install protocol loggers on the server wl_display

2016-03-30 Thread Giulio Camuffo
2016-03-30 21:26 GMT+03:00 Bryce Harrington : > On Wed, Mar 30, 2016 at 09:05:07AM +0300, Giulio Camuffo wrote: >> 2016-03-30 2:10 GMT+03:00 Bryce Harrington : >> > On Wed, Mar 23, 2016 at 04:31:16PM +0200, Giulio Camuffo wrote: >> >> The new wl_display_add_protocol_l

Re: [PATCH wayland] Add API to install protocol loggers on the server wl_display

2016-03-29 Thread Giulio Camuffo
2016-03-30 2:10 GMT+03:00 Bryce Harrington : > On Wed, Mar 23, 2016 at 04:31:16PM +0200, Giulio Camuffo wrote: >> The new wl_display_add_protocol_logger allows to set a function as >> a logger, which will get called when a new request is received or an >> event is sent. >&

Re: Collaboration on standard Wayland protocol extensions

2016-03-28 Thread Giulio Camuffo
2016-03-29 6:23 GMT+03:00 Drew DeVault : > On 2016-03-29 2:15 AM, Martin Peres wrote: >> I was proposing for applications to just bind the interface and see if it >> works or not. But Giulio's proposal makes sense because it could be used to >> both grant and revoke rights on the fly. > > I think

Re: [PATCH weston v4] refactor x11-backend configuration API

2016-03-28 Thread Giulio Camuffo
Sorry, i hit send by mistake before i was finished... 2016-03-28 11:45 GMT+03:00 Giulio Camuffo : > 2016-03-21 23:58 GMT+02:00 Benoit Gschwind : >> Use a "well" defined structure to configure x11-backend and move >> configuration >> file parsing inside the weston

Re: [PATCH weston v4] refactor x11-backend configuration API

2016-03-28 Thread Giulio Camuffo
2016-03-21 23:58 GMT+02:00 Benoit Gschwind : > Use a "well" defined structure to configure x11-backend and move configuration > file parsing inside the weston compositor code. > > v4: add struct_version, and check for null pointer of the configuration > structure. > v3: properly check memory error

Re: [PATCH wayland-protocols v3] Add screensaver idle inhibitor protocol

2016-03-28 Thread Giulio Camuffo
2016-03-24 20:14 GMT+02:00 Bryce Harrington : > This interface allows disabling of screensaver/screenblanking on a > per-surface basis. As long as the surface remains visible and > non-occluded it blocks the screensaver, etc. from activating on the > output(s) that the surface is visible on. > > T

Re: [PATCH weston v2 03/10] compositor: Track surface activity

2016-03-28 Thread Giulio Camuffo
2016-03-24 20:27 GMT+02:00 Bryce Harrington : > Surfaces flagged as 'active' are considered of primary urgency to the > user. It might be the surface with the keyboard focus or displaying > something important; the exact specification of what 'active' means is > left as shell-specific. > > An 'act

Re: [PATCH weston v2 01/10] compositor: Track idle as a per-seat property

2016-03-28 Thread Giulio Camuffo
2016-03-24 20:27 GMT+02:00 Bryce Harrington : > Instead of having a single global idle tracker, track idling separately > for each seat. Still treat inhibition on any one seat as inhibiting > the screensaver globally, for now. > > Signed-off-by: Bryce Harrington > --- > src/compositor.c | 6 +++

Re: Collaboration on standard Wayland protocol extensions

2016-03-27 Thread Giulio Camuffo
2016-03-27 23:34 GMT+03:00 Drew DeVault : > Greetings! I am the maintainer of the Sway Wayland compositor. > > http://swaywm.org > > It's almost the Year of Wayland on the Desktop(tm), and I have > reached out to each of the projects this message is addressed to (GNOME, > Kwin, and wayland-devel) t

[PATCH wayland] Add API to install protocol loggers on the server wl_display

2016-03-23 Thread Giulio Camuffo
. Signed-off-by: Giulio Camuffo --- src/connection.c | 117 ++ src/wayland-private.h | 4 ++ src/wayland-server-core.h | 13 ++ src/wayland-server.c | 94 ++--- 4 files changed, 192 insertions(+), 36

Re: [PATCH 4/7] gl-renderer: Add support for EGLDevice+EGLOutput

2016-03-22 Thread Giulio Camuffo
2016-03-21 18:37 GMT+02:00 Miguel A. Vico : > static void > +gl_renderer_attach_egl_fd_texture(struct weston_surface *es, > + struct weston_buffer *buffer, > + EGLNativeFileDescriptorKHR streamFd) > +{ > + struct weston_compo

[PATCH weston v6] input: use doubles in the interfaces to notify of input events

2016-03-22 Thread Giulio Camuffo
This patch is a further step in the wl_fixed_t internal sanitization. It changes the notify_* functions to take doubles instead of wl_fixed_t but does not change how these are stored in the various input structs yet, except for weston_pointer_axis_event. However this already allows to remove all wl

[PATCH weston v5] input: use doubles in the interfaces to notify of input events

2016-03-22 Thread Giulio Camuffo
This patch is a further step in the wl_fixed_t internal sanitization. It changes the notify_* functions to take doubles instead of wl_fixed_t but does not change how these are stored in the various input structs yet, except for weston_pointer_axis_event. However this already allows to remove all wl

Re: [PATCH weston v3] input: use doubles in the interfaces to notify of input events

2016-03-22 Thread Giulio Camuffo
2016-03-22 14:32 GMT+02:00 Pekka Paalanen : > On Mon, 21 Mar 2016 13:29:00 +0200 > Giulio Camuffo wrote: > >> This patch is a further step in the wl_fixed_t internal sanitization. >> It changes the notify_* functions to take doubles instead of wl_fixed_t >> but do

[PATCH weston v4] input: use doubles in the interfaces to notify of input events

2016-03-22 Thread Giulio Camuffo
This patch is a further step in the wl_fixed_t internal sanitization. It changes the notify_* functions to take doubles instead of wl_fixed_t but does not change how these are stored in the various input structs yet, except for weston_pointer_axis_event. However this already allows to remove all wl

Re: [PATCH weston v3] input: use doubles in the interfaces to notify of input events

2016-03-22 Thread Giulio Camuffo
2016-03-22 11:47 GMT+02:00 Daniel Stone : > Hey Giulio, > > On 21 March 2016 at 11:29, Giulio Camuffo wrote: >> @@ -1275,11 +1275,15 @@ input_set_cursor(struct wayland_input *input) >> static void >> input_handle_pointer_enter(void *data,

[PATCH weston v3] input: use doubles in the interfaces to notify of input events

2016-03-21 Thread Giulio Camuffo
This patch is a further step in the wl_fixed_t internal sanitization. It changes the notify_* functions to take doubles instead of wl_fixed_t but does not change how these are stored in the various input structs yet, except for weston_pointer_axis_event. However this already allows to remove all wl

[PATCH] Add a new wl_proxy_set_listener function

2016-03-19 Thread Giulio Camuffo
The wl_proxy_add_listener function is ill-named, because it suggests that a proxy can have many listeners. Instead it can only have one so deprecate the old function and add a new wl_proxy_set_listener. The implementation of the new function is exactly the same implementation wl_proxy_add_listener

Re: [PATCH 2/5] drm: port the drm backend to the new init api

2016-03-19 Thread Giulio Camuffo
2016-03-10 2:49 GMT+02:00 Bryce Harrington : > From: Giulio Camuffo > > Signed-off-by: Bryce Harrington > Reviewed-by: Quentin Glidic > Acked-by: Pekka Paalanen > --- > v4: Update to current trunk > - Add missing param doc for mode in drm_output_choose_initia

[PATCH] Add a new wl_proxy_set_listener function

2016-03-19 Thread Giulio Camuffo
The wl_proxy_add_listener function is ill-named, because it suggests that a proxy can have many listeners. Instead it can only have one so deprecate the old function and add a new wl_proxy_set_listener. The implementation of the new function is exactly the same implementation wl_proxy_add_listener

[PATCH wayland 0/5] add api to inspect the compositor state

2016-03-07 Thread Giulio Camuffo
uld be, so for now i believe these patches stand on their own and they can be pushed once R-b-ed. Giulio Camuffo (4): Add API to retrieve the interface of a wl_resource Add API to get the list of connected clients Add a resource creation signal Add API to retrieve and iterate over the reso

[PATCH wayland 1/5] server: add listener API for new clients

2016-03-07 Thread Giulio Camuffo
From: Sungjae Park Using display object, Emit a signal if a new client is created. In the server-side, we can get the destroy event of a client, But there is no way to get the created event of it. Of course, we can get the client object from the global registry binding callbacks. But it can be c

[PATCH wayland 5/5] Add API to retrieve and iterate over the resources list of a client

2016-03-07 Thread Giulio Camuffo
To complement on the new resource created signal, this allows to iterate over the existing resources of a client. --- src/wayland-server-core.h | 8 src/wayland-server.c | 23 +++ 2 files changed, 31 insertions(+) diff --git a/src/wayland-server-core.h b/src/way

[PATCH wayland 3/5] Add API to get the list of connected clients

2016-03-07 Thread Giulio Camuffo
--- src/wayland-server-core.h | 14 + src/wayland-server.c | 52 +++ 2 files changed, 66 insertions(+) diff --git a/src/wayland-server-core.h b/src/wayland-server-core.h index a4ca350..4201b2c 100644 --- a/src/wayland-server-core.h +++

[PATCH wayland 4/5] Add a resource creation signal

2016-03-07 Thread Giulio Camuffo
--- src/wayland-server-core.h | 4 src/wayland-server.c | 20 2 files changed, 24 insertions(+) diff --git a/src/wayland-server-core.h b/src/wayland-server-core.h index 4201b2c..9af2481 100644 --- a/src/wayland-server-core.h +++ b/src/wayland-server-core.h @@ -217,

[PATCH wayland 2/5] Add API to retrieve the interface of a wl_resource

2016-03-07 Thread Giulio Camuffo
--- src/wayland-server-core.h | 2 ++ src/wayland-server.c | 12 2 files changed, 14 insertions(+) diff --git a/src/wayland-server-core.h b/src/wayland-server-core.h index 1bc4d6b..a4ca350 100644 --- a/src/wayland-server-core.h +++ b/src/wayland-server-core.h @@ -419,6 +419,8 @

Re: [PATCH weston 1/2] simple-touch: Use damage_buffer if available

2016-02-20 Thread Giulio Camuffo
2016-02-20 5:20 GMT+02:00 Bryce Harrington : > On Fri, Feb 12, 2016 at 09:03:16AM +0200, Giulio Camuffo wrote: >> 2016-02-12 6:26 GMT+02:00 Bryce Harrington : >> > On Fri, Jan 08, 2016 at 03:00:55PM -0600, Derek Foreman wrote: >> >> Signed-off-by: Derek Foreman &

Re: [PATCH wayland] server: validate resource versions at creation time

2016-02-18 Thread Giulio Camuffo
2016-01-14 22:46 GMT+02:00 Derek Foreman : > We shouldn't ever create a resource with version less than 1 or > greater than the interface version. There was a discussion in IRC some days ago, stemming from the bumping of wl_buffer to v2 in your network patch series. Currently it's not possible to

Re: [PATCH weston 1/2] simple-touch: Use damage_buffer if available

2016-02-11 Thread Giulio Camuffo
2016-02-12 6:26 GMT+02:00 Bryce Harrington : > On Fri, Jan 08, 2016 at 03:00:55PM -0600, Derek Foreman wrote: >> Signed-off-by: Derek Foreman >> --- >> clients/simple-touch.c | 18 +++--- >> 1 file changed, 15 insertions(+), 3 deletions(-) > > Given that the demo clients exist to show

Re: [server-core] Add signal for creation of clients.

2016-02-09 Thread Giulio Camuffo
Hi, thanks, i think this was long overdue. I have a few comments below. 2016-02-04 11:59 GMT+02:00 : > Using display object, if a new client is created, emit a signal. > > In the server-side, we can get the destroy event of a client, The indentation is weird from here on. > But the

Re: [PATCH wayland-protocols v2] xdg-shell: Introduce xdg_tooltip

2016-02-03 Thread Giulio Camuffo
2016-02-03 11:07 GMT+02:00 Jonas Ådahl : > On Wed, Feb 03, 2016 at 11:02:14AM +0200, Giulio Camuffo wrote: >> 2016-02-03 11:00 GMT+02:00 Jasper St. Pierre : >> > No? The parent is the surface the tooltip is laid on top of. >> >> So where do the contents of the tooltip

<    1   2   3   4   5   6   7   8   >