Re: [PATCH libinput 6/6] touchpad: pretend the jumpy semi-mt touchpad is a single-touch touchpad

Hi, On 30-07-15 08:11, Peter Hutterer wrote: The first finger is accurate, it's just the second finger that is imprecise, so we can't handle it as a true touch. Instead, revert the device back to being a single-touch touchpad and use the fake touch bits for second finger handling. Two-finger

Re: [PATCH libinput 5/6] touchpad: elantech touchpads can use a 2mm gesture motion threshold

-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt-touchpad-gestures.c | 4 +++- src/evdev.c| 1 + src/evdev.h| 1 + udev/90-libinput-model-quirks.hwdb | 1

Re: [PATCH libinput 4/6] touchpad: disable gestures on Synaptics semi-mt touchpads

Hi, On 30-07-15 08:11, Peter Hutterer wrote: Follow-up to eb146677e, if we disable 2fg scrolling on those touchpads we should also disable gestures. The data doesn't magically become more useful. I think we should wait with doing this until the scroll situation is more clear, see my last

Re: [PATCH libinput 3/6] touchpad: make gestures optional

Hi, On 30-07-15 08:11, Peter Hutterer wrote: Not all multi-finger touchpads are able to reliably produce gestures, so make it optional. This patch just adds a boolean (currently always true) that gets set on touchpad init time, i.e. it is not run-time configurable. Three and four-finger

Re: [PATCH libinput 6/6] touchpad: pretend the jumpy semi-mt touchpad is a single-touch touchpad

Hi, On 30-07-15 14:33, Hans de Goede wrote: Hi, On 30-07-15 08:11, Peter Hutterer wrote: The first finger is accurate, it's just the second finger that is imprecise, so we can't handle it as a true touch. Instead, revert the device back to being a single-touch touchpad and use the fake touch

Re: [PATCH libinput 4/6] touchpad: disable gestures on Synaptics semi-mt touchpads

Hi, On 30-07-15 14:31, Hans de Goede wrote: Hi, On 30-07-15 08:11, Peter Hutterer wrote: Follow-up to eb146677e, if we disable 2fg scrolling on those touchpads we should also disable gestures. The data doesn't magically become more useful. I think we should wait with doing this until

Re: [PATCH libinput] gestures: check ntouches, not just num_slots for the number of fingers

Ah, yes.: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt-touchpad-gestures.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/evdev-mt-touchpad-gestures.c b/src/evdev-mt-touchpad-gestures.c index 8bcdeb4..6b1a273 100644 --- a/src

Re: [PATCH libinput] touchpad: drop distance threshold to detect pinches

together for a while, scroll */ This comment now no longer makes sense it should be something like: /* If fingers stay in the same place for a while assume a (slow) scroll */ Other then that this looks good to me: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans

Re: [PATCH v2 libinput] touchpad: serial synaptics need to fake new touches on TRIPLETAP

, t, time); tp_begin_touch(tp, t, time); t-state = TOUCH_UPDATE; break; } Rather then use the temporary state variable and have the if (state == ) ... Ack (grmbl) either way: Reviewed-by: Hans de Goede hdego

Re: [PATCH v2 libinput] touchpad: disable 2fg scrolling on Synaptics semi-mt touchpads

= tp_scroll_get_methods(tp); + + if (tp-ntouches = 2 + (methods LIBINPUT_CONFIG_SCROLL_2FG)) + method = LIBINPUT_CONFIG_SCROLL_2FG; No need to test ntouches here, that is already done in tp_scroll_get_methods(), other than that this patch looks good: Reviewed-by: Hans de

Re: [PATCH libinput] touchpad: serial synaptics need to fake new touches on TRIPLETAP

Hi, On 24-07-15 04:54, Peter Hutterer wrote: On the 4.1 kernels synaptics pretends to have 3 slots (the serial fw only does 2). This was added to avoid cursor jumps but has since been reverted. In some cases a TRIPLETAP may be triggered without slot 2 ever activating. While there are still

Re: [PATCH libinput] touchpad: don't check clickfinger distance for three fingers

. With this fixed: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans @@ -873,10 +871,6 @@ tp_clickfinger_set_button(struct tp_dispatch *tp) first = t; else if (!second) second = t; - else if (!third

Re: [PATCH libinput 11/11] touchpad: put a movement threshold on thumb detection

Hi, On 23-07-15 04:31, Peter Hutterer wrote: On Wed, Jul 22, 2015 at 03:54:02PM +0200, Hans de Goede wrote: Hi, On 22-07-15 07:09, Peter Hutterer wrote: If a thumb moves around, it's not resting and we should consider it a normal touch. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net

Re: [PATCH libinput 1/3] test: only initialize the generic rules/hwdb once

-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/path.c| 2 +- test/litest.c | 34 +- 2 files changed, 22 insertions(+), 14 deletions(-) diff --git a/src/path.c b/src/path.c index ab4d065..04c703c 100644 --- a/src/path.c +++ b/src/path.c @@ -312,7

Re: [PATCH libinput 06/11] touchpad: scale thumb pressure threshold with the resolution

. https://bugs.freedesktop.org/show_bug.cgi?id=91362 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Tricky, feels a bit like black magic, I cannot think of a better approach though, so lets see how this works out: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src

Re: [PATCH libinput 07/11] touchpad: only try thumb detection in the lowest 15/8mm

Hi, On 22-07-15 07:09, Peter Hutterer wrote: That's the most likely area it will be resting in, if it's sitting anywhere above that it's likely part of an interaction. A thumb in the lowest 15mm needs to trigger the pressure threshold before it's labelled a thumb. A thumb in the lowest 8mm is

Re: [PATCH libinput 1/2] touchpad: make the edge-scroll edge 7mm wide

...@who-t.net Series looks good to me: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt-touchpad-edge-scroll.c | 25 +++-- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/src/evdev-mt-touchpad-edge-scroll.c b/src/evdev-mt

Re: [PATCH libinput] touchpad: drop thumb handling from gestures

. Reported-by: Carlos Garnacho carl...@gnome.org Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt-touchpad-gestures.c | 19 --- src/evdev-mt-touchpad.c | 2 +- src/evdev-mt

Re: [PATCH libinput 0/4] Fix synaptics cursor jumps for triple-touches

touches we'd get a coordinate jump. 4/4 filters those out now, causing a more stable experience when three-finger tapping or clicking. Series looks good to me: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans ___ wayland-devel mailing list

Re: [PATCH libinput 1/2] touchpad: reduce 2fg scroll threshold to 2mm

-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt-touchpad-gestures.c | 3 ++- test/gestures.c | 10 +- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/evdev-mt-touchpad-gestures.c b/src/evdev-mt-touchpad-gestures.c index

Re: [PATCH libinput 05/11] touchpad: use the top-most touch for fake finger positions

touchpad - we know it's big enough to enable thumb detection and that way we don't have to double-check in the how big the touchpad is, etc. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Patches 1 - 5 look good to me: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans

Re: [PATCH libinput 10/11] touchpad: a pressure change alone needs touch processing, mark as dirty

Hi, On 22-07-15 07:09, Peter Hutterer wrote: A thumb may not move, but may change pressure so we need to process accordingly. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Patches 8 - 10 LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt

Re: [PATCH libinput 11/11] touchpad: put a movement threshold on thumb detection

Hi, On 22-07-15 07:09, Peter Hutterer wrote: If a thumb moves around, it's not resting and we should consider it a normal touch. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad.c | 16 src/evdev-mt-touchpad.h | 1 + test/touchpad.c

Re: [PATCH libinput 1/2] Add a configuration interface for enabling/disabling disable-while-typing

where needed. https://bugs.freedesktop.org/show_bug.cgi?id=90624 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Series looks good to me: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/libinput-private.h| 12 ++ src/libinput.c| 42

Re: [PATCH libinput] touchpad: disable 2fg scrolling on semi-mt touchpads

Hi, On 07/16/2015 01:55 AM, Peter Hutterer wrote: On Wed, Jul 15, 2015 at 11:44:47AM -0400, Benjamin Tissoires wrote: On Mon, Jul 13, 2015 at 11:39 PM, Peter Hutterer peter.hutte...@who-t.net wrote: These touchpads have a terrible resolution when two fingers are down, causing scrolling to

Re: [PATCH v2 libinput 5.5/9] udev: add a model-quirks callout

the firmware version is the interesting bit. The udev rule is added already to match on that, note that the callout doesn't do anything at this point. The various touchpad-related things will be added separately. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede

Re: [PATCH libinput 9/9] touchpad: drop fake resolution handling

Hi, On 01-07-15 08:08, Peter Hutterer wrote: Now that we have all devices init a fixed resolution we don't need code to handle custom cases anymore. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev

Re: [PATCH libinput 8/9] touchpad: default to a 69x50mm sized touchpad

. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt-touchpad.c | 40 1 file changed, 40 insertions(+) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt

Re: [PATCH libinput 7/9] udev: add size hint for apple touchpads

Hi, On 01-07-15 08:08, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- udev/90-libinput-model-quirks.hwdb | 1 + 1 file changed, 1 insertion(+) diff --git a/udev/90-libinput-model

Re: [PATCH libinput 6/9] udev: add ALPS firmware detection and size properties

Hi, On 01-07-15 08:08, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- udev/90-libinput-model-quirks.hwdb | 4 udev/libinput-model-quirks.c | 20 2

Re: [PATCH libinput 1/9] udev: make sure the udev callout path is valid for a test run

-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- configure.ac| 10 +- test/Makefile.am| 2 +- udev/.gitignore | 1 + udev/80-libinput

Re: [PATCH libinput 5/9] udev: add Elantech touchpad firmware detection

Hi, On 01-07-15 08:08, Peter Hutterer wrote: Only firmware v4 (and probably whatever comes in the future) have resolution set, for the first couple of touchpads we need size hints. Add a callout that looks at the properties on the touchpad and decides the firmware version. The udev/hwdb is

Re: [PATCH libinput 4/9] evdev: use LIBINPUT_ATTR_SIZE_HINT for resolutions

/60-evdev.hwdb. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- doc/device-configuration-via-udev.dox | 14 +- src/evdev.c | 36 +-- 2 files

Re: [PATCH libinput 3/9] util: add a helper function to parse a WIDTHxHEIGHT property

Hi, On 01-07-15 08:08, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/libinput-util.c | 30 ++ src/libinput-util.h | 2 ++ test/misc.c | 47

Re: [PATCH libinput 2/9] evdev: simplify setting a fake resolution

structs. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev.c | 55 --- 1 file changed, 12 insertions(+), 43 deletions(-) diff --git a/src/evdev.c b

Re: [PATCH libinput] touchpad: be smarter about clickfinger thumb detection

separately and are not regarded as thumb. https://bugs.freedesktop.org/show_bug.cgi?id=91046 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt-touchpad-buttons.c | 50 +++-- test

Re: [PATCH libinput 1/4] test: allow for a default value on LITEST_AUTO_ASSIGNS

itself. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net This feels somwhat adventurous, but I cannot find anything wrong with it, so: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- test/litest-bcm5974.c | 19 ++- test/litest-int.h

Re: [PATCH libinput 1/4] test: allow for a default value on LITEST_AUTO_ASSIGNS

Hi, On 08-07-15 15:11, Hans de Goede wrote: Hi, On 08-07-15 08:56, Peter Hutterer wrote: The touchpads currently all send a default value of 30 for ABS_PRESSURE. For some tests we want to have a custom pressure but changing all tests isn't sensible. So hook each device up to send a default

Re: [PATCH libinput 1/3] test: move enable_edge_scroll up

Hi, On 06-07-15 06:26, Peter Hutterer wrote: No functional changes, just so we can group those helpers together. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net The entire series LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- test/touchpad.c | 26

Re: [PATCH libinput 1/3] test: wait for the uinput_monitor on test devices

testing. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net The entire series LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- test/litest.c | 96 --- 1 file changed, 58 insertions(+), 38 deletions(-) diff

Re: [PATCH libinput 1/5] util: allow list_remove() on a NULL node

. With those 2 extra checks added patches 2 - 5 are: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH libinput] touchpad: disable tap drag lock by default

peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- diff of the test is a bit confusing, but i renamed _enabled to _disabled and _disabled to _unavailable. Should be a 4-line diff... src/evdev-mt-touchpad-tap.c | 2 +- test/touchpad-tap.c

Re: [PATCH libinput 3/5] filter: pass the DPI to the acceleration filter

-base; } Otherwise the entire series looks good, if you squash in this bit from 5/5 into this patch (3/5) then this series is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans diff --git a/src/filter.h b/src/filter.h index de94997..64a8b50 100644 --- a/src/filter.h +++ b/src

Re: [PATCH libinput] filter: reduce deceleration to minimal speeds only

. pointer moves like the physical device does). https://bugzilla.redhat.com/show_bug.cgi?id=1227039#c44 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good to me: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/filter.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH libinput] evdev: store the device dimensions

Hi, On 25-06-15 09:07, Peter Hutterer wrote: We use width/height often enough that storing it once is better than calculating it on each event. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good to me: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src

Re: [PATCH libinput 1/2] touchpad: only send most recent edge delta when triggering threshold

, still better than the jump. https://bugs.freedesktop.org/show_bug.cgi?id=90990 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Series looks good and is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt-touchpad-edge-scroll.c | 5 - 1 file changed, 4

Re: [PATCH libinput 1/5] test: replace tap config with helper function

peter.hutte...@who-t.net The entire series LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- test/litest.h | 24 test/touchpad-tap.c | 109 ++-- test/touchpad.c | 68

Re: [PATCH libinput] udev: prepend the libinput group with the product string

://bugs.freedesktop.org/show_bug.cgi?id=89802 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- udev/libinput-device-group.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/udev

Re: [PATCH libinput] touchpad: mark ALPS touchpads for middle button emulation

: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt-touchpad-buttons.c| 33 ++--- src/evdev.c| 1 + src/evdev.h| 1 + test/pointer.c | 24

Re: [PATCH libinput] touchpad: disable right-edge palm detection for edge scrolling

Hi, On 16-06-15 08:17, Peter Hutterer wrote: Most scroll motions would be labelled a palm. https://bugs.freedesktop.org/show_bug.cgi?id=90980 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good to me: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src

Re: [PATCH libinput 1/2] touchpad: fix pinned finger drifting

Hi, On 15-06-15 06:40, Peter Hutterer wrote: This caused the finger to be unpinned on the first motion event after the click, effectively disabling this feature. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Oops, my bad (IIRC), looks good to me: Reviewed-by: Hans de Goede hdego

Re: [PATCH libinput 2/2] touchpad: set the finger pin distance to 5mm where possible

to be. Maybe we should try 3 first? Regardless of the above this looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt-touchpad-buttons.c | 19 ++-- src/evdev-mt-touchpad.c | 10 - src/evdev-mt-touchpad.h | 5

Re: [PATCH libinput] touchpad: make the hysteresis dependent on physical distance

de Goede hdego...@redhat.com Can you also ask the reporter of: https://bugs.freedesktop.org/show_bug.cgi?id=90590 To test libinput/master once you've pushed this? It will likely help with his problem too. Regards, Hans --- src/evdev-mt-touchpad.c | 16 1 file changed, 12

Re: [PATCH 2.5/4 libinput] test: install hwdb.d files in /etc, not /run

and mark them with a REMOVEME and a comment that if that file is left after the tests, it should be removed by the user. https://github.com/systemd/systemd/issues/127 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- I'll

Re: [PATCH libinput] touchpad: restart the motion filter on touch begin

to me: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt-touchpad.c | 7 +++ src/filter-private.h| 3 +++ src/filter.c| 31 +++ src/filter.h| 5 + 4 files changed, 46 insertions(+) diff --git

Re: [PATCH libinput] filter: require minimum acceleration factor of 0.3

://bugzilla.redhat.com/show_bug.cgi?id=1227039 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good to me: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/filter.c b/src/filter.c index

Re: [PATCH libinput 1/4] test: fix litest_log() when libunwind is missing

Hi, On 05-06-15 08:41, Peter Hutterer wrote: Previous expansion had side-effects when litest_log was called in an if condition without {} Signed-off-by: Peter Hutterer peter.hutte...@who-t.net The entire set looks good to me: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans

Re: [PATCH libinput 3/4] touchpad: impose maximum distance limits on clickfingers

common and this also makes it easier to rule out thumbs which tend to be well below the fingers. http://bugs.freedesktop.org/show_bug.cgi?id=90526 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- doc/clickpad

Re: [PATCH libinput 2/4] touchpad: move clickfinger finger decision into a helper function

Hi, On 03-06-15 07:51, Peter Hutterer wrote: No functional changes. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt-touchpad-buttons.c | 27 +++ 1 file changed, 19

Re: [PATCH libinput 1/4] touchpad: replace hardcoded resolution 1

Hi, On 03-06-15 07:51, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt-touchpad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/evdev-mt-touchpad.c

Re: [PATCH libinput 4/4] touchpad: on non-resolution touchpads, use 30% as maximum clickfinger spread

Hi, On 03-06-15 07:51, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt-touchpad-buttons.c | 35 +++ test/touchpad.c | 2

Re: [PATCH libinput] evdev: always default to the middle button for button-scrolling

benefit to leaving the button at 0 when the scroll method isn't enabled anyway. So always default to the middle button (if available). https://bugzilla.redhat.com/show_bug.cgi?id=1227182 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com

Re: [PATCH libinput] evdev: use the button down time for no-scroll middle button press event

...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev.c | 4 +++- src/evdev.h | 2 ++ test/trackpoint.c | 23 +-- 3 files changed, 26 insertions(+), 3 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index

Re: [PATCH libinput 1/3] filter: pass last_velocity as argument

Hi, On 01-06-15 08:13, Peter Hutterer wrote: Let the caller set the various fields, here we just calculate stuff. No functional changes. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Tricky stuff, but the entire set LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards

Re: [PATCH libinput] evdev: use the udev ID_INPUT_POINTINGSTICK property

Hi, On 29-05-15 17:06, Benjamin Tissoires wrote: On 05/29/2015 03:31 AM, Hans de Goede wrote: Hi, On 29-05-15 03:28, Peter Hutterer wrote: Added in systemd 220, but note that for udev backwards compatibility, the ID_INPUT_POINTINGSTICK tag is set in addition to the ID_INPUT_MOUSE tag

Re: [PATCH libinput] evdev: use the udev ID_INPUT_POINTINGSTICK property

bugs where the input prop isn't set yet. https://bugzilla.redhat.com/show_bug.cgi?id=1225563 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev.c | 13 ++--- 1 file changed, 10 insertions(+), 3

Re: [PATCH libinput 1/2] touchpad: check touchpad for basic features we expect

Hi, Both patch LGTM, series is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans On 29-05-15 00:21, Peter Hutterer wrote: If a relative device is tagged by udev as ID_INPUT_TOUCHPAD we need to catch this before we try to dereference device-abs.absinfo_x. Signed-off-by: Peter

Re: [PATCH libinput] touchpad: only pair tracksticks with touchpads where needed

Hi, On 29-05-15 05:16, Peter Hutterer wrote: On topbuttonpads we need the trackstick pairing to generate the right software buttons, on the X1 Carbon-like devices we need the pairing to route the buttons correctly (though this code is obsolete with newer kernels). This fixes the touchpad being

Re: [PATCH libinput 00/11] disable-while-typing refinement

), the palm remains disabled, so resting a palm on the touchpad while typing is safe to do. We also release any touch already down before the typing sequence, though I'm not 100% on a real-world case for this, it was just a side-effect of the implementation. Entire set LGTM: Reviewed-by: Hans de

Re: [PATCH libinput] test: add an extra loop for slow udev initialization

will have ID_INPUT set, so check for that before we continue. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- If anyone has any better ideas here, I'm all ears. I'm afraid I don't have any better idea for this either: LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans

Re: [PATCH libinput gestures 1/4] gestures: check for valid types on the gesture event API

Hi, On 22-05-15 04:03, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net The entire series looks good to me: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/libinput.c | 60 ++ 1

Re: [PATCH libinput 1/7] evdev: log a bug if releasing a key fails, but don't loop forever

peter.hutte...@who-t.net The entire set LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev.c | 47 --- 1 file changed, 28 insertions(+), 19 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 4ce9250..435bc52 100644

Re: [PATCH libinput 1/6] test: move main() into litest

Hi, On 20-05-15 05:24, Peter Hutterer wrote: This allows us to filter things based on argv before setting up tests, etc. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net The entire set LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- test/device.c | 5

Re: [PATCH libinput 0/3] touchpad: add disable-while-typing feature

. The entire set LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH libinput] timer: fix coverity warning about unused return value

-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/timer.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/timer.c b/src/timer.c index 114a649..d1d3c10 100644 --- a/src/timer.c +++ b/src/timer.c @@ -102,8 +102,14 @@ libinput_timer_handler(void *data

Re: [PATCH libinput] filter: add Simon's copyright

Hi, On 06-05-15 05:20, Peter Hutterer wrote: This code was largely lifted from the X server in bb25b2ad297891430606c367bfabc but didn't take the copyright messages that applied to that code. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego

Re: [PATCH libinput 1/3] test: add litest_add_ranged* functionality

wraps the underlying check framework, the ranged variable is available as _i in the test. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net The entire set LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- test/litest.c | 64

Re: [PATCH libinput 1/7] test: litest_is_button_event should take an unsigned int

Hi, On 05-05-15 07:43, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net The entire series looks good to me and is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- test/litest.c | 2 +- test/litest.h | 2 +- 2 files changed, 2 insertions

Re: [PATCH 2/2] touchpad: don't apply tap config until all fingers are up

Hi, On 04-05-15 08:41, Peter Hutterer wrote: On Fri, May 01, 2015 at 10:19:59AM +0200, Hans de Goede wrote: Hi, On 01-05-15 04:48, Peter Hutterer wrote: On Thu, Apr 30, 2015 at 10:01:55AM +0200, Hans de Goede wrote: Hi, On 30-04-15 08:00, Peter Hutterer wrote: If tapping is enabled while

Re: [PATCH libinput] touchpad: enable clickfinger by default on chromebooks

: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt-touchpad-buttons.c| 5 - src/evdev.c| 1 + src/evdev.h| 1 + udev/90-libinput-model-quirks.hwdb | 22 ++ 4 files changed, 28

Re: [PATCH libinput] touchpad: enable clickfinger by default on some System76 laptops

Hutterer peter.hutte...@who-t.net Hmm, do these come configured like this by system76 ootb ? I'm not sure if we should start doing per model rather then per vendor defaults TBH. If you really think this is a good idea then this is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans

Re: [PATCH v2 libinput 1/2] touchpad: drop the tap finger count

needs to handle (and discard) any touch release events. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Series looks good and is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt-touchpad-tap.c | 6 ++ src/evdev-mt-touchpad.h | 1 - 2 files

Re: [PATCH libinput v3 0/5] touchpad gestures support

Hi, On 01-05-15 20:54, Carlos Garnacho wrote: Hey Hans :), On Wed, Apr 29, 2015 at 2:18 PM, Hans de Goede hdego...@redhat.com wrote: Hi All, Here is v3 of my touchpad gestures support patch series. Changes since v2: - For pinch gestures instead of reporting finger distance deltas report

Re: [PATCH 1/2] touchpad: when clearing the touchpad state, release fake touches too

Hi, On 01-05-15 04:48, Peter Hutterer wrote: On Thu, Apr 30, 2015 at 09:49:30AM +0200, Hans de Goede wrote: Hi, On 30-04-15 07:59, Peter Hutterer wrote: Causes an error message in the device_disable_release_tap_n_drag test. When the touchpad is suspended, all touches are ended

Re: [PATCH libinput] timer: drain data on the timerfd when it triggers

Hi, On 30-04-15 03:33, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net It seems this is the right thing todo: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- I admit, I'm not sure of the effect it has leaving the data sitting

Re: [PATCH libinput] tools: ship the event-debug tool as an installed libinput-debug-events tool

Hutterer peter.hutte...@who-t.net Looks good to me: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- I find myself asking more bugreporters to git clone and run the debug tool, it'd be easier in some cases for them to run it directly. So we might as well install it, but I like

Re: [PATCH 2/2] touchpad: don't apply tap config until all fingers are up

Hi, On 30-04-15 08:00, Peter Hutterer wrote: If tapping is enabled while at least one finger is down, we underrun tp-tap.tap_finger_count on touch release. Avoid this by only switching tap config whenever there are no fingers down. The immediate applying of tapping enabled changes is

Re: [PATCH 1/2] touchpad: when clearing the touchpad state, release fake touches too

Hi, On 30-04-15 07:59, Peter Hutterer wrote: Causes an error message in the device_disable_release_tap_n_drag test. When the touchpad is suspended, all touches are ended in tp_clear_state. Since the hovering support was added, this returns the touches to TOUCH_HOVERING, a subsequent

[PATCH libinput v3 4/5] touchpad: Implement pinch gesture support

Implement touchpad pinch (and rotate) gesture support. Note that two two-finger scrolling tests are slightly tweaked to assure that there is enough touch movement to allow the scroll-or-pinch detect code to do its work. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Jason Gerecke

[PATCH libinput v3 5/5] touchpad: Allow querying whether a gesture ended normally or was cancelled

Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad-gestures.c | 20 src/evdev-mt-touchpad.c | 4 ++-- src/evdev-mt-touchpad.h | 2 +- src/libinput-private.h | 11 +++ src/libinput.c | 37

[PATCH libinput v3 0/5] touchpad gestures support

Hi All, Here is v3 of my touchpad gestures support patch series. Changes since v2: - For pinch gestures instead of reporting finger distance deltas report a scale value which is relative to the initial finger distance - Added a new patch to provide cancellation information when a gesture ends

Re: [PATCH libinput] touchpad: allow BTN_LEFT in clickfinger mode without touches

still think this is a good idea, then this is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev-mt-touchpad-buttons.c | 6 -- test/touchpad.c | 30 ++ 2 files changed, 34 insertions(+), 2 deletions(-) diff --git

Re: [PATCH libinput v2 0/4] touchpad gestures support

Hi, On 24-04-15 13:39, Carlos Garnacho wrote: Hey Hans :), On jue, 2015-03-26 at 10:04 +0100, Hans de Goede wrote: Hi All, Here is v2 of my touchpad gestures support patch series, changes since v1: - Merge the gesture capability flag and event-debug patched into the touchpad: Add an API

[PATCH] touchpad: Only use slot 0 deltas for 2fg scrolling on semi-mt touchpads

. BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=89683 Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad-gestures.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/evdev-mt-touchpad-gestures.c b/src/evdev-mt-touchpad-gestures.c

Re: [PATCH libinput] evdev: add support for LIBINPUT_MODEL_* udev tags

is a private API and subject to change at any time without notice. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- A few more changes than expected, so sending this out again for another set of eyes

[PATCH] test-touchpad: Adjust touchpad_edge_scroll_no_2fg test for gesture support

2fg scroll tests fixing this. Signed-off-by: Hans de Goede hdego...@redhat.com --- test/touchpad.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/touchpad.c b/test/touchpad.c index ad9203a..d05c8cf 100644 --- a/test/touchpad.c +++ b/test/touchpad.c @@ -2829,9

Re: [PATCH libinput] Add libinput_device_keyboard_has_key()

for KEY_PLAY or somesuch), depending on the context required. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- Had a deja-vu implementing this, I thought this already existed. src/evdev.c | 9

Re: [PATCH libinput 1/5] tools: add --set-scroll-method commandline flag

Hi, Series looks good and is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans On 21-04-15 07:28, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- tools/shared.c | 29 + tools/shared.h | 1 + 2 files changed, 30

Re: [PATCH libinput 1.5/5] tools: add --set-scroll-button as option

Hi, On 21-04-15 10:30, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Sorry, should've been part of 1/5, I only just noticed that enabling button scrolling isn't overly useful without setting the button too. Looks good: Reviewed-by: Hans de Goede hdego

Re: [PATCH libinput] evdev: accept but disable ABS_MISC and above for min/max == 0

-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/evdev.c| 26 -- test/Makefile.am | 1 + test/device.c | 4 +- test/litest-mouse-roccat.c | 205 + test/litest.c | 2 + test

<    1   2   3   4   5   6   7   8   >