Re: Wayland/weston, Qt and RDP connection...

2024-07-29 Thread Hardening
o services. And it doesn’t start: Hi, sorry very late reply, but if the goal is to export a Qt app through RDP, you may be interested by qfreerdp_platform (https://github.com/hardening/qfreerdp_platform). This a QPA (Qt Platform Abstraction module) that expose the screen and inputs through

Re: [PATCH] rdp-compositor: fix compilation against last FreeRDP 2.0

2018-05-27 Thread Hardening
Le 25/05/2018 à 16:17, Pekka Paalanen a écrit : > On Thu, 24 May 2018 14:55:20 +0200 > David Fort wrote: > >> The SURFACE_BITS_COMMAND struct has changed and some members have been moved >> in the >> bmp field. >> --- >> configure.ac | 5 ++- [...] >> > > Hi, > > with freerd

Re: [PATCH weston] compositor-rdp: fix compilation with freerdp 2.0.0-rc2

2018-05-23 Thread Hardening
Le 22/05/2018 à 16:12, Pekka Paalanen a écrit : > On Fri, 11 May 2018 11:47:47 +0200 > Luca Weiss wrote: > >> See >> https://github.com/FreeRDP/FreeRDP/commit/1f7d33a2f22a372c124ce985a394619e186e06b9 >> for the upstream change. >> >> Signed-off-by: Luca Weiss >> --- >> libweston/compositor-rd

Re: [PATCH 3/3] rdp-backend.so: OpenGL hardware acceleration

2018-04-03 Thread Hardening
Le 06/07/2017 à 12:06, Olivier Blin a écrit : > From: DRC > > --- > compositor/main.c | 23 +++- > configure.ac | 4 +- > libweston/compositor-rdp.c | 314 > +++-- > libweston/compositor-rdp.h | 24 > 4 files changed, 352 i

Re: [PATCH 2/3] gl-renderer: read PIXMAN_x8r8g8b8 as GL_BGRA_EXT

2018-04-03 Thread Hardening
Le 06/07/2017 à 12:06, Olivier Blin a écrit : > This is needed by the RDP backend, which uses PIXMAN_x8r8g8b8 for its > shadow buffers. > --- > libweston/gl-renderer.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libweston/gl-renderer.c b/libweston/gl-renderer.c > index da29b072..b8b1

Re: [PATCH weston] compositor-rdp: Correct mouse scrolling direction

2018-02-21 Thread Hardening
Le 21/02/2018 à 11:09, Hardening a écrit : > Le 09/02/2018 à 17:14, Jason Gerecke a écrit : >> The direction of scrolling in the RDP compositor appears to be inverted. >> When using Weston directly in X, sending X11 button 4 cuases window >> contents to scroll up and butto

Re: [PATCH weston] compositor-rdp: Correct mouse scrolling direction

2018-02-21 Thread Hardening
Le 09/02/2018 à 17:14, Jason Gerecke a écrit : > The direction of scrolling in the RDP compositor appears to be inverted. > When using Weston directly in X, sending X11 button 4 cuases window > contents to scroll up and button 4 to be reported to xwayland clients. > Conversely, when using Weston th

Re: [PATCH weston 05/21] libweston: weston_output_init(..., +name)

2017-09-26 Thread Hardening
Le 22/09/2017 à 16:31, Pekka Paalanen a écrit : > From: Pekka Paalanen > > Add 'name' argument to weston_output_init(). This is much more obvious > than the assert inside weston_output_init() to ensure the caller has set > a field in weston_output first. > > Now weston_output_init() will strdup(

Re: [PATCH] Fix API troubles with FreeRDP 2.0

2017-09-25 Thread Hardening
Le 25/09/2017 à 10:49, Pekka Paalanen a écrit : > On Fri, 22 Sep 2017 11:17:41 +0200 > David Fort wrote: > >> With FreeRDP 2.0 the crypto needs to be initialized or we fail as soon as we >> try to >> compute a md5. The API also changed for the suppress output callback. >> --- >> libweston/compo

Re: [PATCH 1/3] compositor-rdp: fix leak of frame bitmap in raw mode

2017-07-09 Thread Hardening
Le 06/07/2017 à 12:06, Olivier Blin a écrit : > In rdp_peer_refresh_raw(), cmd->bitmapData was reallocated, but never freed. > > The cmd content (actually peer->update->surface_bits_command) was > re-initialized to zero at the beginning of the function, losing the > pointer to the previously alloc

Re: Remote display with 3D acceleration using Wayland/Weston

2017-02-28 Thread Hardening
Le 24/02/2017 à 00:51, DRC a écrit : > On 12/15/16 3:01 AM, Pekka Paalanen wrote: >> The current RDP-backed is written to set up and use only the Pixman >> renderer. Pixman renderer is a software renderer, and will not >> initialize EGL in the compositor. Therefore no support for hardware >> accele

Re: [PATCH] scanner: Fix building on musl

2016-06-22 Thread Hardening
Le 23/06/2016 01:48, Kylie McClain a écrit : > From: Kylie McClain > > `uint` is defined in sys/types.h on musl libc. > > Signed-off-by: Kylie McClain > --- > src/scanner.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/scanner.c b/src/scanner.c > index 4708cae..48d6014 100644 >

Re: [PATCH weston] Make config.h inclusion consistent

2016-06-16 Thread Hardening
Le 16/06/2016 03:13, Bryce Harrington a écrit : > Signed-off-by: Bryce Harrington Reviewed-by: David Fort > --- > clients/multi-resource.c | 2 +- > clients/presentation-shm.c| 2 +- > clients/simple-damage.c | 2 +- > clients/simple-dmabuf-intel.c | 2 +- > clients/simple-dmabu

Re: [PATCH weston] terminal: Document console codes less cryptically

2016-06-16 Thread Hardening
Le 16/06/2016 03:36, Bryce Harrington a écrit : > C.f. http://man7.org/linux/man-pages/man4/console_codes.4.html > > Signed-off-by: Bryce Harrington Definitely an improvement. Reviewed-by: David Fort > --- > clients/terminal.c | 72 > +++--- >

Re: [PATCH weston] main: report presentation clock resolution

2016-06-15 Thread Hardening
Le 13/06/2016 13:34, Pekka Paalanen a écrit : > From: Pekka Paalanen > > For debugging weird timing issues. If your clock resolution is > unexpectedly e.g. 10 ms, you can be sure you will have strange timing > issues. This is almost certainly caused by kernel misconfiguration. > > We rely on clo

Collaborative window resize

2016-06-07 Thread Hardening
Hi wayland list, Yeah I know the title sounds a lot like marketing bullshit. Anyway I was playing with the RDP compositor with my daughter (haven't you notice how many bugs you find when you let your children play with your programs ?), we were on 2 different computers, so 2 seats, and we have tri

Re: [PATCH 0/6] RDP compositor needs love v2

2016-05-26 Thread Hardening
Le 26/04/2016 23:34, David Fort a écrit : > Compared to the first version: > * compilation with FreeRDP 2.0 is now prefered; > * trivial patch using constant instead of hard coded value has its own commit; > * I have splitted the output resized patch so that the shell and the core > weston > part

Re: [PATCH] rdp: don't release the seat until it is safe v2

2016-05-20 Thread Hardening
Le 20/05/2016 11:58, Sam Spilsbury a écrit : > On Fri, May 20, 2016 at 5:33 PM, David Fort wrote: >> Releasing a seat is not safe, so let's just announce it without keyboard >> and mouse until this is fixed. Without this patch we just can't reconnect on >> the RDP compositor as it crashes. >> >> v

Re: [PATCH 2/6] rdp: don't release the seat until it is safe

2016-05-19 Thread Hardening
Le 20/05/2016 00:51, Bryce Harrington a écrit : > On Tue, Apr 26, 2016 at 11:34:04PM +0200, David Fort wrote: >> Releasing a seat is not safe, so let's just announce it without keyboard >> and mouse until this is fixed. Without this patch we just can't reconnect on >> the RDP compositor as it crash

Re: [ANNOUNCE] wayland 1.10.91

2016-05-11 Thread Hardening
Le 11/05/2016 21:11, Bryce Harrington a écrit : > On Fri, May 06, 2016 at 02:17:23PM +0300, Pekka Paalanen wrote: >> On Wed, 4 May 2016 11:46:23 -0700 >> Bryce Harrington wrote: >> >>> On Wed, May 04, 2016 at 12:55:16AM -0700, Bryce Harrington wrote: Here's the alpha for the upcoming 1.11 rel

Re: [GSoC] Some questions about wayland clients with no outputs present

2016-05-03 Thread Hardening
Le 03/05/2016 09:52, Pekka Paalanen a écrit : > On Mon, 2 May 2016 17:33:14 -0700 > Bryce Harrington wrote: > >> On Mon, May 02, 2016 at 12:49:04PM +0200, Armin Krezović wrote: >>> On 30.04.2016 22:14, Bryce Harrington wrote: On Sat, Apr 30, 2016 at 05:20:09PM +0200, Armin Krezović wrote:

Re: [PATCH 1/6] rdp: allow to compile against FreeRDP 2.0

2016-05-01 Thread Hardening
Le 01/05/2016 23:32, David Fort a écrit : > FreeRDP 2.0 is about to be released, this allows to compile against this > version. > The detection is adjusted to prefer FreeRDP 2 against version 1.x. > > Signed-off-by: David Fort > --- > configure.ac | 5 - > src/compositor-rdp.c | 23

Re: [PATCH 1/5] rdp: allow to compile against FreeRDP 2.0

2016-04-23 Thread Hardening
Le 23/04/2016 11:50, Quentin Glidic a écrit : > On 22/04/2016 15:19, David Fort wrote: >> FreeRDP 2.0 is about to be released, this allows to compile against >> this version. >> >> Signed-off-by: David Fort >> --- >> configure.ac | 8 +++- >> src/compositor-rdp.c | 23 +++

Re: [PATCH v1] refactor configuration API of rdp-backend

2016-04-22 Thread Hardening
Le 22/04/2016 17:05, Benoit Gschwind a écrit : > Implement a "well" defined API to configure the rdp backend. > Following according to discution about libweston API. > --- > v1: > - Fix the patch log > v0: > - Nothing particular. > > Signed-off-by: Benoit Gschwind > > Makefile.am |

Re: [PATCH 5/5] desktop shell: resize background and panel when an output switches mode

2016-04-22 Thread Hardening
Le 22/04/2016 16:18, Pekka Paalanen a écrit : > On Fri, 22 Apr 2016 15:19:06 +0200 > David Fort wrote: > >> When an output permanently switches mode, the desktop shell must be notified >> so >> that the misc components can resize to the new size of the output. This >> patch also >> fixes the co

Re: [PATCH 3/5] rdp: fix presentation for the RDP compositor

2016-04-22 Thread Hardening
Le 22/04/2016 15:55, Pekka Paalanen a écrit : > On Fri, 22 Apr 2016 15:19:04 +0200 > David Fort wrote: > >> Set an update delay that is a multiple of the output frequency, or we may do >> incorrect weston_output_finish_frame calls. >> --- >> src/compositor-rdp.c | 2 +- >> 1 file changed, 1 inse

Re: [PATCH 1/5] rdp: allow to compile against FreeRDP 2.0

2016-04-22 Thread Hardening
Le 22/04/2016 15:19, David Fort a écrit : > FreeRDP 2.0 is about to be released, this allows to compile against this > version. > > Signed-off-by: David Fort > --- > configure.ac | 8 +++- > src/compositor-rdp.c | 23 --- > 2 files changed, 23 insertions(+), 8 d

Re: [PATCH wayland 2/3] server: move include directives before extern "C" wrapper

2016-04-17 Thread Hardening
Le 17/04/2016 13:29, Emil Velikov a écrit : > Analogous to previous commit but for the server(-core) header. > > Signed-off-by: Emil Velikov > --- > src/wayland-server-core.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/wayland-server-core.h b/src/wayland

Re: [PATCH weston] input: Implement wl_seat.release

2016-03-16 Thread Hardening
Le 13/03/2016 17:49, Quentin Glidic a écrit : > From: Quentin Glidic > > Avoid a crash because listener is NULL. > > Signed-off-by: Quentin Glidic > --- > src/input.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/src/input.c b/src/input.c > index 8c106dd..5d13b08 100644 > --

Re: [PATCH wayland] scanner: Print filename on DTD validation error

2016-01-25 Thread Hardening
Le 25/01/2016 10:28, Jonas Ådahl a écrit : > Don't just print prefix the errors with "protocol", but the actual file > name, if wayland-scanner was passed with the filename of the protocol > file. If wayland-scanner is reading from stdin, errors will be prefixed > with "" instead of "protocol". >

wayalnd client wants to know the keyboard layout

2016-01-14 Thread Hardening
Hello, I have worked on having the FreeRDP client have a decent wayland support. On the graphical part everything is quite straight forward anyway, I'm hitting some troubles with keyboard support (someone could say as usual when you code something around keyboard). In X11, xfreerdp queries X abou

Re: [PATCH] clients: Fix compositor version check for WL_SURFACE_DAMAGE_BUFFER_SINCE_VERSION

2015-12-23 Thread Hardening
Le 20/12/2015 13:41, Chris Michael a écrit : > Signed-off-by: Chris Michael > --- > clients/simple-damage.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/clients/simple-damage.c b/clients/simple-damage.c > index 37a81f5..24c67cc 100644 > --- a/clients/simple-damage.c

Re: [PATCH v4] xwm: let the shells decide the position of X windows

2015-12-15 Thread Hardening
Le 11/12/2015 19:57, Giulio Camuffo a écrit : > The xwm used to automatically send to Xwayland the position of X windows > when that changed, using the x,y of the primary view of the surface. > This works fine for the desktop shell but less so for others. > This patch adds a 'send_position' vfunc t

Re: [PATCH weston] compositor-fbdev: Drop intermediate shadow buffer

2015-12-08 Thread Hardening
Le 05/12/2015 02:20, Derek Foreman a écrit : > From: Sjoerd Simons > > Currently the fbdev compositor has its own shadow buffer when rendering > with pixman, causing the following copies to occur: > > [pixman shadow buffer] -> [fbdev shadow buffer] -> [fbdev hardware] > > As the pixman render a

Re: Process for implementing a double buffer on Wayland

2015-11-25 Thread Hardening
Le 25/11/2015 17:18, Daniel Stone a écrit : > Hi Mike, > > On 25 November 2015 at 16:06, Mike Johnson wrote: >> I've created 2 buffers of the same size (800x600 pixels). So I want the >> input buffer to get filled off-screen, while the output buffer will show the >> content on-screen. >> >> Firs

Re: [PATCH weston 03/10] Use presentation timing protocol from wayland-protocols

2015-11-06 Thread Hardening
Le 04/11/2015 09:49, Jonas Ådahl a écrit : > Signed-off-by: Jonas Ådahl > --- > Makefile.am | 21 ++- > clients/presentation-shm.c | 65 +- > clients/weston-info.c| 19 +-- > protocol/presentation_timing.xml | 274 > --

Re: [PATCH weston 03/10] Use presentation timing protocol from wayland-protocols

2015-11-06 Thread Hardening
Le 04/11/2015 09:49, Jonas Ådahl a écrit : > Signed-off-by: Jonas Ådahl > --- > Makefile.am | 21 ++- > clients/presentation-shm.c | 65 +- > clients/weston-info.c| 19 +-- > protocol/presentation_timing.xml | 274 > --

Re: [PATCH] weston: implement inert objects for keyboard/pointer/touch

2015-10-20 Thread Hardening
Le 20/10/2015 17:12, Bryce Harrington a écrit : > On Tue, Oct 20, 2015 at 10:39:51AM +0200, Hardening wrote: >> Le 20/10/2015 10:24, Bryce Harrington a écrit : >>> On Mon, Oct 19, 2015 at 03:47:19PM +0200, David FORT wrote: >>>> This patch implements inert objects f

Re: [PATCH] weston: implement inert objects for keyboard/pointer/touch

2015-10-20 Thread Hardening
Le 20/10/2015 10:24, Bryce Harrington a écrit : > On Mon, Oct 19, 2015 at 03:47:19PM +0200, David FORT wrote: >> This patch implements inert objects for wl_keyboard, wl_pointer and wl_touch. >> The target case is when the server has just send a capability event about a >> disappearing object, and t

Re: [RFC] weston: implement inert objects for keyboard/pointer/touch

2015-10-16 Thread Hardening
Le 16/10/2015 11:53, David FORT a écrit : > This patch implements inert objects for wl_keyboard, wl_pointer and wl_touch. > The target case is when the server has just send a capability event about a > disappearing object, and the client binds the corresponding object. We bind an > inert object: an

Re: [RFC] weston: implement inert objects for keyboard/pointer/touch

2015-10-16 Thread Hardening
Le 16/10/2015 11:53, David FORT a écrit : > This patch implements inert objects for wl_keyboard, wl_pointer and wl_touch. > The target case is when the server has just send a capability event about a > disappearing object, and the client binds the corresponding object. We bind an > inert object: an

Re: [weston] xkbcommon library is not optional.

2015-10-16 Thread Hardening
> > Joaquim Duran > Don't get me wrong, I'm not saying it's not useful. I'm saying that probably nobody's using it as otherwise it doesn't compile. > 2015-10-16 10:27 GMT+02:00 Hardening : >> Le 16/10/2015 03:28, Bryce Harrington a écrit : >&

Re: [weston] xkbcommon library is not optional.

2015-10-16 Thread Hardening
Le 16/10/2015 03:28, Bryce Harrington a écrit : > On Tue, Oct 13, 2015 at 01:59:13PM +0200, Joaquim Duran wrote: >> Hello, >> >> When configuring the Weston project, it is possible to disable (don't >> include) the library libxkbcommon. To compile Weston successfully, >> even if the option --disabl

Re: [PATCH weston] clients: track seat_version per seat, not per display

2015-10-14 Thread Hardening
Le 14/10/2015 16:39, Derek Foreman a écrit : > Apparently it's possible for a compositor to advertise seats with > different versions on the same connection, so this makes us more robust > against that dubious behaviour. > > This also tracks the seat version we requested instead of the advertised

Re: [PATCH] weston: release keyboard/touch/pointer objects

2015-10-08 Thread Hardening
Le 08/10/2015 05:14, Jonas Ådahl a écrit : > On Tue, Oct 06, 2015 at 10:59:32AM +0200, David FORT wrote: >> This patch adds the missing calls to release when the seat has capabilities >> changes. It also fixes a missing release of the touch object. >> --- >> clients/window.c | 23 +

Re: [PATCH wayland] scanner: Generate 'since' macros for requests as well

2015-10-08 Thread Hardening
Le 08/10/2015 05:10, Jonas Ådahl a écrit : > We already generate WL_[INTERFACE]_[REQUEST]_SINCE_VERSION macros for > events in the server protocol headers. Lets do the same for requests in > the client protocol headers as well. > > Signed-off-by: Jonas Ådahl > --- > src/scanner.c | 1 + > 1 file

Re: [PATCH] weston-input: Reformat weston_log line to add missing space between words

2015-10-07 Thread Hardening
Le 07/10/2015 18:33, Derek Foreman a écrit : > On 07/10/15 10:59 AM, Chris Michael wrote: >> Signed-off-by: Chris Michael > > Reviewed-by: Derek Foreman > >> --- >> src/input.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/input.c b/src/input.c >> index e230c8

Re: [PATCH 4/4] compositor-rdp: Add missing '\n' in weston_log usage

2015-10-07 Thread Hardening
Le 01/10/2015 16:51, Chris Michael a écrit : > Signed-off-by: Chris Michael > --- > src/compositor-rdp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/compositor-rdp.c b/src/compositor-rdp.c > index c221eb9..7272f41 100644 > --- a/src/compositor-rdp.c > +++ b/src/c

Re: [PATCH wayland v2] scanner: Close input resource when done to prevent leak

2015-10-02 Thread Hardening
Le 02/10/2015 03:13, Bryce Harrington a écrit : > Addresses this error reported by Denis Denisov: > > [src/scanner.c:1415]: (error) Resource leak: input > > Signed-off-by: Bryce Harrington > > v2: Also close input for other exit points in main. > Signed-off-by: Bryce Harrington Reviewed-by:

Re: [PATCH] wayland: add release request on wl_seat

2015-09-29 Thread Hardening
Le 29/09/2015 09:58, Jonas Ådahl a écrit : > On Tue, Sep 29, 2015 at 09:43:01AM +0200, David FORT wrote: >> This is required if we want to correctly remove a wl_seat compositor-side. A >> wl_seat is announced as a global object, then it is bound by the client. When >> the compositor wants to remove

Re: [PATCH 3/3] Add a release request on wl_seat

2015-09-27 Thread Hardening
Le 24/09/2015 01:59, Jonas Ådahl a écrit : > On Wed, Sep 23, 2015 at 11:17:33AM -0500, Derek Foreman wrote: >> On 25/02/15 08:03 AM, David FORT wrote: >>> This is required if we want to correctly remove a wl_seat server-side. >>> --- >>> protocol/wayland.xml | 6 ++ >>> 1 file changed, 6 inser

Re: [PATCH weston] RDP compositor: make the seat dynamic and don't destroy it on removal

2015-09-25 Thread Hardening
Le 25/09/2015 19:15, Derek Foreman a écrit : > On 25/09/15 08:19 AM, Hardening wrote: >> Le 25/09/2015 11:31, Pekka Paalanen a écrit : >>> On Thu, 24 Sep 2015 23:40:26 +0200 >>> David FORT wrote: >>> >>>> This patch makes the seat dynamic and

Re: [PATCH weston] RDP compositor: make the seat dynamic and don't destroy it on removal

2015-09-25 Thread Hardening
Le 25/09/2015 11:31, Pekka Paalanen a écrit : > On Thu, 24 Sep 2015 23:40:26 +0200 > David FORT wrote: > >> This patch makes the seat dynamic and leak it on purpose during seat removal >> to >> prevent the ghost object case. >> --- >> src/compositor-rdp.c | 39 +++---

Re: [PATCH weston v3] compositor-rdp: rdp_destroy() double free error #91457

2015-08-06 Thread Hardening
Le 05/08/2015 22:20, Derek Foreman a écrit : > On 05/08/15 03:21 PM, Dawid Gajownik wrote: >> When something goes wrong during weston initialization, >> weston_compositor_destroy() is executed. It destroys the backend and >> then frees compositor memory. Unfortunately RDP backend is not correctly >

Re: [PATCH weston] compositor-rdp: free() can handle NULL pointers

2015-08-01 Thread Hardening
Le 01/08/2015 16:02, Dawid Gajownik a écrit : > There's no need to check if a pointer exists before passing it to free(). > free() can handle NULL pointers. > > Signed-off-by: Dawid Gajownik Reviewed-By: David FORT > --- > src/compositor-rdp.c | 9 +++-- > 1 file changed, 3 insertions(+),

Re: [PATCH wayland 3/3] shm: wl_shm_buffer_get_data() requires a valid pool.

2015-07-16 Thread Hardening
Le 01/07/2015 12:52, Marek Chalupa a écrit : > > > On Wed, Jul 1, 2015 at 11:25 AM, Marek Chalupa > wrote: > > > > On Fri, Jun 26, 2015 at 6:35 PM, Derek Foreman > mailto:der...@osg.samsung.com>> wrote: > > There's no situation where a shm buffer w

Re: [PATCH wayland] shm: add getters for the fd and offset

2015-07-16 Thread Hardening
Le 01/07/2015 10:25, Giulio Camuffo a écrit : > This allows to share the buffer data by mmapping the fd again. > --- > src/wayland-server-core.h | 6 ++ > src/wayland-shm.c | 16 +++- > 2 files changed, 21 insertions(+), 1 deletion(-) > Reviewed-by: David FORT > diff -

Re: [PATCH weston 11/11] configure: add an option to allow building only the libraries

2015-06-23 Thread Hardening
Le 22/06/2015 22:02, Giulio Camuffo a écrit : > the --enable/disable-weston-binaries enables or disables the creation > of 'weston', 'weston-launch' and all the binaries that are > installed in $prefix/lib/libexec. This allows, together with > --enable-clients, to only build the libraries, making p

Re: [PATCH weston 09/17] src: Update boilerplate from MIT X11 license to MIT Expat license

2015-06-18 Thread Hardening
Le 13/06/2015 00:04, Bryce Harrington a écrit : > Signed-off-by: Bryce Harrington > --- > src/animation.c | 35 +++ > src/bindings.c| 35 +++ > src/clipboard.c | 35 +++

Re: [PATCH weston] Add config option to disable input method

2015-06-06 Thread Hardening
Le 06/06/2015 12:18, Murray Calavera a écrit : > When building a shell-plugin the developer might not want to implement > an input method. Nevertheless weston will look for one, print errors > complaining that the input method died and then give up. > > Signed-off-by: Murray Calavera > --- > man

Re: Wayland not MIT-licensed / FAQ wrong

2015-05-29 Thread Hardening
Le 28/05/2015 23:15, Kristian Høgsberg a écrit : > Yes, it appears you're correct. The HPND license is widely used in X > (even new additions such as > http://cgit.freedesktop.org/xorg/xserver/tree/dri3/dri3.c) and I think > I assumed it was the most recent/modern version of the MIT license. It > w

Re: [PATCH 2/2] RDP compositor: enforce certificate and key

2015-05-21 Thread Hardening
Le 21/05/2015 09:02, Pekka Paalanen a écrit : > On Tue, 19 May 2015 10:07:40 +0200 > David FORT wrote: > >> The RDP compositor is usable without certificates and key in a very limited >> number of cases (local usage using xfreerdp), so let's force the presence of >> keys and certificates. [...]

Re: [PATCH 2/2] RDP compositor: enforce certificate and key

2015-05-21 Thread Hardening
Le 21/05/2015 09:02, Pekka Paalanen a écrit : > On Tue, 19 May 2015 10:07:40 +0200 > David FORT wrote: > >> The RDP compositor is usable without certificates and key in a very limited >> number of cases (local usage using xfreerdp), so let's force the presence of >> keys and certificates. >> ---

Re: [PATCH weston] compositor-wayland: Handle window close events more gracefully

2015-05-19 Thread Hardening
Le 20/05/2015 01:41, Bryce Harrington a écrit : > On Mon, May 18, 2015 at 11:14:16PM -0700, Dima Ryazanov wrote: >> When a compositor window is closed, remove the output instead of just >> exiting. >> >> (The "if (!input->output)" checks are kind of ugly - but I couldn't find >> a better way to ha

Re: [PATCH 1/2] RDP compositor: make the seat dynamic and don't destroy it on removal

2015-05-19 Thread Hardening
Le 19/05/2015 11:20, Pekka Paalanen a écrit : > On Tue, 19 May 2015 10:07:39 +0200 > David FORT wrote: > >> This patch makes the seat dynamic and leak it on purpose during seat removal >> to >> prevent the ghost object case. >> --- >> src/compositor-rdp.c | 39 +++---

Re: [PATCH weston] compositor-drm: disable hardware cursors

2015-05-19 Thread Hardening
Le 19/05/2015 09:26, Pekka Paalanen a écrit : > From: Pekka Paalanen > > With the recent universal plane and atomic modeset / nuclear pageflip > development in the kernel, cursor content updates on Intel are currently > causing > an extra wait for vblank. This drops Weston's framerate to a fract

Re: [PATCH] RDP compositor: fixes for multiple connections, mstsc and FreeRDP master compilation

2015-05-11 Thread Hardening
Le 11/05/2015 15:06, Pekka Paalanen a écrit : > On Wed, 6 May 2015 10:59:42 +0200 > David FORT wrote: > >> From: Hardening >> >> This patch fixes the problem reported on the mailing list >> (http://lists.freedesktop.org/archives/wayland-devel/2015-January/019

Re: [PATCH weston] compositor-drm: Open drm device with CLOEXEC

2015-05-04 Thread Hardening
Le 01/05/2015 16:59, Derek Foreman a écrit : > Signed-off-by: Derek Foreman > --- > src/compositor-drm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/compositor-drm.c b/src/compositor-drm.c > index 43197a8..6a2dbd9 100644 > --- a/src/compositor-drm.c > +++ b/src

Re: Weston RDP on ARM

2015-03-26 Thread Hardening
Le 26/03/2015 15:45, Heikki Sarkanen a écrit : > Hi, > > I am trying to use the RDP backend on custom Freescale iMX6 based ARM > board where the only supported fbdev-backend is heavily patched: > https://github.com/Freescale/meta-fsl-arm/tree/master/recipes-graphics/wayland/weston. > I am using Yo

Re: [RFC wayland 1/2] server: implement intact resources

2015-03-24 Thread Hardening
Le 19/03/2015 09:11, Marek Chalupa a écrit : > When server looses some capability (like pointer or keyboard), > it takes some time to get this information to clients. > When client sends request with new_id argument to the object > that has been just destroyed on server-side (client > does not know

Re: [PATCH wayland] scanner: Fail on empty enumerations

2015-03-20 Thread Hardening
Le 19/03/2015 09:58, Jonas Ådahl a écrit : > Without this patch, the scanner would generate invalid C which wouldn't > compile anyway, so lets be nice and fail earlier and point out where the > error is. > > Signed-off-by: Jonas Ådahl +1 Reviewed-By: David FORT > --- > src/scanner.c | 4

Re: [PATCH 1/3] Extend WAYLAND_DISPLAY and name parameter semantics to support absolute paths. For example WAYLAND_DISPLAY="/my/path/wayland-2" or connect_to_socket("/my/path/wayland-2").

2015-03-05 Thread Hardening
Le 03/03/2015 13:49, Davide Bettio a écrit : > Signed-off-by: Davide Bettio > --- > doc/man/wl_display_connect.xml | 8 > src/wayland-client.c | 22 +- > src/wayland-server.c | 23 ++- > 3 files changed, 39 insertions(+), 14 de

Re: [PATCH wayland v3] Add support for direct file reading and writing in wayland-scanner.

2015-03-03 Thread Hardening
Le 03/03/2015 09:11, Pekka Paalanen a écrit : > On Mon, 2 Mar 2015 16:08:00 +0200 > Jussi Pakkanen wrote: > >> Add support for direct file reading and writing in wayland-scanner. >> >> Signed-off-by: Jussi Pakkanen >> >> --- >> src/scanner.c | 26 +- >> 1 file changed,

Re: Experiment: compiling Wayland and Weston with Meson

2015-02-24 Thread Hardening
Le 21/02/2015 22:16, Jussi Pakkanen a écrit : > Hi all > > I'm working on a new build system called Meson. As part of development I > take open source projects and rewrite their build systems to ensure it > fulfils real world requirement. This time I took Wayland and Weston. > [...] > > For mo

Re: Weston 1.7 memleaks

2015-02-20 Thread Hardening
Le 19/02/2015 03:41, Titus Johnson a écrit : > Just checking mem leaks. > Is this normal or are we shooting for zero leaks? > > [21:32:52.432] weston 1.7.0 >http://wayland.freedesktop.org >Bug reports to: > https://bugs.freedesktop.org/enter_bug.cgi?product=Wayland&

Re: RDP connection to wayland compositor

2015-02-09 Thread Hardening
Le 09/02/2015 13:18, Vasyl Vavrychuk a écrit : > Hi, > > Weston supports RDP protocol via rdp-backend. Its use is for example > described here https://wiki.tizen.org/wiki/Weston_RDP_access. > > Current implementation works in the way that weston compositor launched > with wayland backend and west

[PATCH] RDP compositor: v2 fixes for multiple connections and mstsc

2015-02-04 Thread Hardening
This patch fixes the problem reported on the mailing list (http://lists.freedesktop.org/archives/wayland-devel/2015-January/019575.html). All certificate and key paths were not copied when given to FreeRDP, so they were freed when the peer was disconnecting. And so the next connection was failing.

Re: [PATCH] RDP compositor: fixes for multiple connections and mstsc

2015-02-04 Thread Hardening
Le 02/02/2015 21:03, John Obaterspok a écrit : > Hello, > > I had a bit problem to apply the patch. I tried both 1.6.0 and weston git. > Finally I went to patch the 1.6.0 version I have in Fedora 21. > > I needed to comment out the cmd->skipCompression = FALSE; I have a patch for this. > > fr

Re: [PATCH v2 weston] input: Don't test keyboard/pointer/touch pointers

2015-02-02 Thread Hardening
Le 02/02/2015 22:24, Derek Foreman a écrit : > Thanks for looking at this rather cumbersome patch! :) > > On 02/02/15 01:40 PM, Bill Spitzak wrote: >> Is there a reason it does not just clear the pointer when >> keyboard_device_count is changed to zero? That would seem like a smaller >> patch. >

[PATCH] RDP compositor: fixes for multiple connections and mstsc

2015-01-30 Thread Hardening
This patch fixes the problem reported on the mailing list (http://lists.freedesktop.org/archives/wayland-devel/2015-January/019575.html). All certificate and key paths were not copied when given to FreeRDP, so they were freed when the peer was disconnecting. And so the next connection was failing.

Re: [PATCH weston] input: Don't test keyboard/pointer/touch pointers

2015-01-29 Thread Hardening
Le 29/01/2015 18:39, Derek Foreman a écrit : > Keyboards and pointers aren't freed when devices are removed, > so we should really be testing keyboard_device_count and > pointer_device_count in most cases, not the actual pointers. > Otherwise we end up with different behaviour after removing a > de

Re: Is the RDP backend suppose to work?

2015-01-27 Thread Hardening
Le 24/01/2015 20:00, John Obaterspok a écrit : > Hello, > > I've tried for quite some time to get the RDP backend going. Perhaps > it's just me that's not setting things up correctly. I'm trying this on > a updated 64-bit Fedora 21 box that has Wayland 1.6 and > freerdp-1.2.0-0.2.beta.1.fc21.x86_6

Re: [RFC weston 00/15] libweston

2014-12-01 Thread Hardening
Le 13/11/2014 21:07, Giulio Camuffo a écrit : > 2014-11-13 21:56 GMT+02:00 Bryce Harrington : >> On Thu, Nov 06, 2014 at 10:41:19PM +0200, Giulio Camuffo wrote: >>> This patchset makes a libweston.so out of the compositor core, thought >>> to be used by many different users. >> >> Who are thought b

Re: [PATCH 2/4] event-loop.c: Use correct OS abstraction function for dupfd()

2014-11-03 Thread Hardening
Le 01/11/2014 18:06, Philip Withnall a écrit : > Signed-off-by: Philip Withnall > Signed-off-by: Karsten Otto > --- > src/event-loop.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/event-loop.c b/src/event-loop.c > index a149db9..1f571ba 100644 > --- a/src/event-l

Re: [PATCH] shell: fix weston_output_mode_switch() usage

2014-09-23 Thread Hardening
happened. > >>> Therefore: pushed. Feel free to refactor the code in a follow-up, >>> IMHO. ;-) >> >> Ok, I'll try to get to that in the next couple of days. > > Thank you. > > Hardening, could you keep an eye here and make sure we don't br

Re: Keysym event in the text protocol

2014-07-28 Thread Hardening
Le 25/07/2014 22:08, Bill Spitzak a écrit : > On 07/25/2014 11:59 AM, Daniel Stone wrote: >> Since you're just repeating yourself without taking on anything that's >> been said, so will I: that won't work. > > This I am finding hard to believe. > > My proposal is that the compositor maintain a xk

Re: [PATCH V2] Do not assume 64x64 cursor, added support for other sizes (like in AMD Kaveri, 128x128).

2014-07-02 Thread Hardening
Le 25/06/2014 16:09, Alvaro Fernando García a écrit : > Init cursor size to 64x64 if drmGetCap() fails. > > Use Mesa GBM_BO_USE_CURSOR define (which removes 64x64 restriction) > > Signed-off-by: Alvaro Fernando García > --- > src/compositor-drm.c | 43 ---

Re: [PATCH] weston: Fix memleak issue in compositor.c

2014-06-03 Thread Hardening
Le 27/05/2014 11:00, Srivardhan Hebbar a écrit : > This fix is upon "Hardening " patch. [PATCH 2/2] Handle > OOM with signal events. > LGTM Reviewed-by: Hardening > Signed-off-by: Srivardhan Hebbar > --- > src/compositor.c | 23 +-- >

Re: [PATCH 0/2] RDP Keyboard

2014-06-02 Thread Hardening
Le 26/05/2014 17:22, Hardening a écrit : > I'm resending this serie of patches that are related to keyboard with the RDP > compositor. The first one make weston support more RDP keyboard (RDP to Xkb > convertion). The second make use of buildin FreeRDP functions instead of >

[PATCH 2/2] Use FreeRDP buildin functions to get scancodes

2014-05-26 Thread Hardening
This patch make use of the functions available in FreeRDP to retrieve the scancode to inject. --- src/compositor-rdp.c | 24 ++-- 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/src/compositor-rdp.c b/src/compositor-rdp.c index 437954f..b749129 100644 --- a/src/c

[PATCH 0/2] RDP Keyboard

2014-05-26 Thread Hardening
ese at the last sending, so if nobody's against I will commit them. Hardening (2): Add more keyboards for the RDP compositor Use FreeRDP buildin functions to get scancodes src/compositor-rdp.c | 156 +-- 1 file changed, 126 insertions(+

[PATCH 1/2] Add more keyboards for the RDP compositor

2014-05-26 Thread Hardening
This patch complements the table that contains matches between RDP and xkb keyboard layouts. We now handle variants too. --- src/compositor-rdp.c | 132 ++- 1 file changed, 120 insertions(+), 12 deletions(-) diff --git a/src/compositor-rdp.c b/src/c

Re: [PATCH] protocol: remove redundant 'the' in description

2014-05-23 Thread Hardening
Le 23/05/2014 09:14, Pekka Paalanen a écrit : On Fri, 23 May 2014 03:04:29 -0400 "Jasper St. Pierre" wrote: On Fri, May 23, 2014 at 2:49 AM, Pekka Paalanen wrote: [...] This is obviously correct. Can I push this, or shall we reserve the right to push to libwayland for Kristian only, ev

Re: Wayland and Weston 1.5.0 is released

2014-05-21 Thread Hardening
of the key contributors. Either people that have their corner of weston that they maintain (for example Pekka and the Raspberry Pi backend or Hardening and the RDP backend) or contributors who have been part of the project for a while and understands the code base well - or both. Hi, congratul

Re: [PATCH V2] event: assert wl_event_source pointer is NULL.

2014-05-12 Thread Hardening
Le 12/05/2014 07:56, Srivardhan Hebbar a écrit : Signed-off-by: Srivardhan Hebbar --- src/event-loop.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/event-loop.c b/src/event-loop.c index 9790cde..57e3fed 100644 --- a/src/event-loop.c +++ b/src/event-loop.c @@

[PATCH 2/2] Handle OOM with signal events

2014-05-09 Thread Hardening
This patch handles the case where a signal event source can not be created. --- src/compositor.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index 6ad3387..047df8a 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -4197,

[PATCH 1/2] Set to NULL event source after a call to wl_event_source_remove

2014-05-09 Thread Hardening
This patch sets to NULL event sources after a call to wl_event_source_remove() has been made. --- src/clipboard.c | 3 ++- src/compositor-drm.c | 3 +++ src/compositor-rpi.c | 1 + src/compositor-x11.c | 2 ++ src/compositor.c | 6 +- src/evdev-touchpad.c | 1 + src/evdev.c |

Re: [PATCH] event: Cheking for NULL before dereferencing the pointer.

2014-05-09 Thread Hardening
Le 09/05/2014 12:20, Pekka Paalanen a écrit : On Fri, 09 May 2014 15:21:51 +0530 Srivardhan wrote: -Original Message- From: Pekka Paalanen [mailto:ppaala...@gmail.com] Sent: Friday, May 09, 2014 3:09 PM To: Srivardhan Cc: 'Hardening'; wayland-devel@lists.freedesktop.org S

Re: [PATCH] event: Cheking for NULL before dereferencing the pointer.

2014-05-09 Thread Hardening
Le 09/05/2014 08:43, Srivardhan Hebbar a écrit : Checking for NULL before dereferencing the wl_event_source pointer so as to avoid crash. Signed-off-by: Srivardhan Hebbar --- src/event-loop.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/event-loop.c b/src/

Re: [PATCH wayland] connection: Don't write past the end of the connection buffer

2014-04-17 Thread Hardening
Le 17/04/2014 17:20, Ander Conselvan de Oliveira a écrit : From: Ander Conselvan de Oliveira If a message was too big to fit in the connection buffer, the code in wl_buffer_put would just write past the end of it. I haven't seen any real world use case that would trigger this bug, but it was p

  1   2   >