Hi!
On 4 December 2017 at 09:16, Pekka Paalanen wrote:
> On Sat, 2 Dec 2017 10:57:45 +0800
> Jonas Ådahl wrote:
>
>> Now that xdg_shell is stable and much better defined than wl_shell we
>> can finally deprecate wl_shell and guide users towards xdg_shell
>> instead.
>>
>> Signed-off-by: Jonas Å
Hi!
On Fri, Jul 29, 2016 at 10:52 AM, Pekka Paalanen wrote:
> On Fri, 22 Jul 2016 21:39:20 +0200
> "Nils Chr. Brause" wrote:
>
>> HI,
>>
>> On Thu, Jun 2, 2016 at 10:30 AM, Pekka Paalanen wrote:
>> > On Thu, 2 Jun 2016 15:39:47 +0800
>> >
HI,
On Thu, Jun 2, 2016 at 10:30 AM, Pekka Paalanen wrote:
> On Thu, 2 Jun 2016 15:39:47 +0800
> Jonas Ådahl wrote:
>
>> On Thu, Jun 02, 2016 at 10:24:19AM +0300, Pekka Paalanen wrote:
>> > On Wed, 1 Jun 2016 13:16:31 -0500
>> > Yong Bakos wrote:
>> >
>> > > On May 30, 2016, at 3:54 AM, Pekka P
Very nice to see that finally landing! :)
Since this patch has been created by Auke Booij back in 2015 (thank
you very much!), there have been some protocol additions in the DnD
area, which also need proper enum attributes. From the wayland.xml of
the C++ Bindings[1]:
wayland.xml:543:
waylan
On 30 Dec 2015 01:24, "Jonas Ådahl" wrote:
>
> On Tue, Dec 29, 2015 at 05:31:33PM +0100, Nils Chr. Brause wrote:
> > On 29 Dec 2015 3:20 pm, "Jonas Ådahl" wrote:
> > >
> > > On Tue, Dec 29, 2015 at 01:56:14PM +0100, Nils Chr. Brause wrote:
>
On 29 Dec 2015 3:20 pm, "Jonas Ådahl" wrote:
>
> On Tue, Dec 29, 2015 at 01:56:14PM +0100, Nils Chr. Brause wrote:
> > No.
> > If we want Wayland to be successful and widely used it has to be well
> > documented (which it still is far from). Turning off warn
No.
If we want Wayland to be successful and widely used it has to be well
documented (which it still is far from). Turning off warnings about
undocumented fields doesn't exactly help the documentation effort but
rather impedes it.
On Tue, Dec 29, 2015 at 3:10 AM, Jonas Ådahl wrote:
> There are l
Awesome! I hope that gets pushed soon. :)
Reviewed-by: Nils Christopher Brause
On Sat, Dec 5, 2015 at 1:39 PM, Auke Booij wrote:
> The enum attribute, for which scanner support was introduced in
> 1771299, can be used to link message arguments to s. However,
> some arguments refer to s in a di
Hi,
On Thu, Dec 3, 2015 at 4:31 PM, Chris Michael wrote:
> Signed-off-by: Chris Michael
> ---
> src/compositor-rdp.c | 2 +-
> src/vaapi-recorder.c | 2 +-
> tests/weston-test.c | 2 +-
> xwayland/window-manager.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> di
On Wed, Dec 2, 2015 at 11:48 AM, Auke Booij wrote:
> I'd be happy to rebase against that, but since that hasn't been merged
> yet, I thought I'd take the current tree as a a basis.
>
> If you think having the interface:: prefix everywhere makes sense, I
> can change that if you want.
I think that
Hi,
On Wed, Nov 25, 2015 at 10:01 PM, Bryce Harrington
wrote:
> On Wed, Nov 25, 2015 at 03:25:55PM +, Daniel Stone wrote:
>> Hi,
>>
>> On 25 November 2015 at 14:17, Auke Booij wrote:
>> > On 25 November 2015 at 13:43, Daniel Stone wrote:
>> >> Warnings aren't harmless though; there's a reas
Hi,
On Tue, Nov 24, 2015 at 2:48 PM, Auke Booij wrote:
> On 24 November 2015 at 12:41, Nils Chr. Brause
> wrote:
>> On Mon, Nov 16, 2015 at 11:46 AM, Pekka Paalanen wrote:
>>> On Sun, 15 Nov 2015 22:17:38 +0100
>>> "Nils Chr. Brause" wrote:
>&g
On Mon, Nov 16, 2015 at 11:46 AM, Pekka Paalanen wrote:
> On Sun, 15 Nov 2015 22:17:38 +0100
> "Nils Chr. Brause" wrote:
>
>> On Sun, Nov 15, 2015 at 9:48 PM, Auke Booij wrote:
>> > On 9 November 2015 at 18:17, Bill Spitzak wrote:
>> >> I really do
On Sun, Nov 15, 2015 at 9:48 PM, Auke Booij wrote:
> On 9 November 2015 at 18:17, Bill Spitzak wrote:
>> Making the transform into a bitfield allows bitfield tests for useful facts:
>> it can see if it is a mirror image by testing the flip bit, and check for
>> transposition of the axes by checki
Hi,
On Mon, Nov 9, 2015 at 4:35 PM, Pekka Paalanen wrote:
> On Mon, 9 Nov 2015 15:38:22 +0100
> "Nils Chr. Brause" wrote:
>
>> Hi,
>>
>> On Mon, Nov 9, 2015 at 2:49 PM, Pekka Paalanen wrote:
>> > On Mon, 9 Nov 2015 12:54:00 +0100
>> > &
Hi,
On Mon, Nov 9, 2015 at 3:39 PM, Auke Booij wrote:
> On 9 November 2015 at 11:54, Nils Chr. Brause wrote:
>> Hi,
>>
>> On Mon, Nov 9, 2015 at 12:04 PM, Pekka Paalanen wrote:
>>> On Fri, 6 Nov 2015 16:05:10 +0100
>>> "Nils Chr. Brause" wrote
Hi,
On Mon, Nov 9, 2015 at 2:49 PM, Pekka Paalanen wrote:
> On Mon, 9 Nov 2015 12:54:00 +0100
> "Nils Chr. Brause" wrote:
>
>> Hi,
>>
>> On Mon, Nov 9, 2015 at 12:04 PM, Pekka Paalanen wrote:
>> > On Fri, 6 Nov 2015 16:05:10 +0100
>> > &
Hi,
On Mon, Nov 9, 2015 at 12:04 PM, Pekka Paalanen wrote:
> On Fri, 6 Nov 2015 16:05:10 +0100
> "Nils Chr. Brause" wrote:
>
>> Hi,
>>
>> On Fri, Nov 6, 2015 at 3:48 PM, Auke Booij wrote:
>> > On 6 November 2015 at 13:03, Nils Christo
Hi,
On Fri, Nov 6, 2015 at 3:48 PM, Auke Booij wrote:
> On 6 November 2015 at 13:03, Nils Christopher Brause
> wrote:
>> The enumeration wl_output.transform is clearly a bitfield.
>> The definition of a bitfield is that each bit has a distinct
>> meaning. This is clearly the case in the enumerat
Hi,
On Sat, Oct 24, 2015 at 1:07 PM, Auke Booij wrote:
> Signed-off-by: Auke Booij
> ---
> doc/publican/protocol-to-docbook.xsl | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/doc/publican/protocol-to-docbook.xsl
> b/doc/publican/protocol-to-docbook.xsl
> index 7b45969..fad20
Hi,
On Sat, Oct 24, 2015 at 1:07 PM, Auke Booij wrote:
> The scanner now checks whether arguments that have an associated
> have the right type.
> An argument with an enum attribute must be of type int or uint,
> and if the with that name has the bitfield attribute
> set to true, then the argum
Hi,
On Sat, Oct 24, 2015 at 1:07 PM, Auke Booij wrote:
> Signed-off-by: Auke Booij
> ---
> protocol/wayland.xml | 36 ++--
> 1 file changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/protocol/wayland.xml b/protocol/wayland.xml
> index 59819e9..9c22d45 10
Hi,
On Sat, Oct 24, 2015 at 1:07 PM, Auke Booij wrote:
> Introduce the enum and bitfield attributes, which allow you to refer to the
> enum
> you are expecting in an argument, and specify which enums are to be thought of
> as bitfields.
>
> Signed-off-by: Auke Booij
> ---
> doc/publican/source
Hi,
On Thu, Oct 22, 2015 at 10:18 PM, Bill Spitzak wrote:
> On Wed, Oct 21, 2015 at 5:22 AM, Nils Chr. Brause
> wrote:
>>
>>
>> >> - Support for cross-interface enum referencing (e.g.
>> >> wl_shm_pool::create_buffer::format to wl_shm::format,
Hi,
On Thu, Oct 22, 2015 at 2:41 PM, Auke Booij wrote:
> On 22 October 2015 at 02:46, Bill Spitzak wrote:
>> Sorry if this is a duplicate, I am having trouble with gmail.
>>
>> On 10/20/2015 12:38 AM, Bryce Harrington wrote:
>>>
>>> On Tue, Oct 20, 2015 at 12:01:14AM -0700, Bryce Harrington wrot
Hi,
You are missing bitfield="true" for wl_shell_surface::resize and
wl_output::transform.
Cheers,
Nils
On Tue, Oct 20, 2015 at 12:21 AM, Auke Booij wrote:
> Signed-off-by: Auke Booij
> ---
> protocol/wayland.xml | 34 +-
> 1 file changed, 17 insertions(+), 17
Okay.
Reviewed-by
On Wed, Oct 21, 2015 at 3:34 PM, Auke Booij wrote:
> On 21 October 2015 at 13:13, Nils Chr. Brause wrote:
>> Hi,
>>
>> On Tue, Oct 20, 2015 at 9:38 AM, Bryce Harrington
>> wrote:
>>> On Tue, Oct 20, 2015 at 12:01:14AM -0700, Bryce H
Hi,
On Tue, Oct 20, 2015 at 10:30 AM, Auke Booij wrote:
> On 19 October 2015 at 23:21, Auke Booij wrote:
>> There has been plenty of discussion regarding the introduction of new XML
>> attributes. This series of patches improves on my earlier attempt to find
>> common ground in this.
>>
>> Majo
Hi,
On Tue, Oct 20, 2015 at 9:38 AM, Bryce Harrington wrote:
> On Tue, Oct 20, 2015 at 12:01:14AM -0700, Bryce Harrington wrote:
>> On Mon, Oct 19, 2015 at 11:21:23PM +0100, Auke Booij wrote:
>> > Introduce the enum and bitfield attributes, which allow you to refer to
>> > the enum
>> > you are
Hi,
On Wed, Oct 14, 2015 at 10:25 AM, Pekka Paalanen wrote:
> On Tue, 13 Oct 2015 20:27:58 +0100
> Auke Booij wrote:
>
>> On 13 October 2015 at 16:19, Solerman Kaplon wrote:
>> > Em 13-10-2015 11:35, Nils Chr. Brause escreveu:
>> >>
>> >> In
On Tue, Oct 13, 2015 at 5:18 PM, Erik De Rijcke wrote:
>
>
> On Tue, Oct 13, 2015 at 4:35 PM, Nils Chr. Brause
> wrote:
>>
>> Hi,
>>
>> On Mon, Oct 12, 2015 at 11:08 AM, Pekka Paalanen
>> wrote:
>> > On Mon, 12 Oct 2015 10:41:22 +0200
>>
Hi,
On Mon, Oct 12, 2015 at 11:08 AM, Pekka Paalanen wrote:
> On Mon, 12 Oct 2015 10:41:22 +0200
> Erik De Rijcke wrote:
>
>> Adding enum members is backward compatible for Java. If you compile against
>> an enum with 2 members, and later on a new member is added, you can simply
>> use the new v
Hi,
Reviewed-by: Nils Christopher Brause
I ran distcheck and it worked. :)
Cheers,
Nils
On Fri, Oct 9, 2015 at 10:01 AM, Auke Booij wrote:
> Yeah, that was a pretty embarrassing mistake by me, for such a simple
> patch. Thanks to Bryce for catching it.
>
> On 8 October 2015 at 15:05, Pekka P
Hi,
On Thu, Oct 8, 2015 at 10:13 PM, Daniel Stone wrote:
> Hi,
>
> On 5 October 2015 at 21:31, Victor Berger wrote:
>> Le 2015-10-05 21:53, Nils Chr. Brause a écrit :
>>> Since a language binding should support unknown values anyway, I don't
>>> quite
I see. You're right. :)
On 5 Oct 2015 22:31, "Victor Berger" wrote:
>
> Le 2015-10-05 21:53, Nils Chr. Brause a écrit :
>>
>> Bill Spitzak wrote:
>>>
>>> Similarly it seems like an "open" indicator that can be added to enums
>>&
Hi,
Auke Booij wrote:
> I think that we have an agreement in principle, just not in terms (and
> this also goes back to my comment to Victor Berger). What I meant to
> express is that any bindings that violate this rule are on the risk of
> the bindings writers, rather than the wayland and wayland
Hi,
On Sat, Oct 3, 2015 at 9:05 PM, Erik De Rijcke wrote:
> - Defining an uint (bitfield) or int (single enum) in the xml for an enum
> argument is the wrong approach. It prescribes, not describes. In some
> languages eg Java, there is no such thing as an uint. What is important, is
> to know how
Hi,
Pekka Paalanen wrote:
> Adding these attributes to XML must not change the signatures generated
> by wayland-scanner.
>
> Why: these are also used in C++, which does not implicitly covert
> between enums and other stuff, which would break the build.
> http://lists.freedesktop.org/archives/wayl
On Thu, Oct 1, 2015 at 9:00 PM, Bill Spitzak wrote:
>
>
> On Thu, Oct 1, 2015 at 8:09 AM, Nils Chr. Brause
> wrote:
>>
>> Hi,
>>
>> I would recommend to also include the name of the interface, where the
>> enum is defined, in the enum attribute, e.g:
&g
Hi,
On Thu, Oct 1, 2015 at 7:49 PM, Bryce Harrington wrote:
> The topic of adding better enum/bitfield support to the protocol has
> come up a few[0] times[1] in the past, and again more recently[2]. We
> also have several proposed patches in patchwork, but I'm not sure they
> reflect consensus
Hi,
I would recommend to also include the name of the interface, where the enum
is defined, in the enum attribute, e.g:
Also, I think you forgot some enum attributes, e.g. wl_shm_pool::
create_buffer::format is the wl_shm::format enum, but I can't find it in
your patch (I can't seem to find the
Hi,
On Fri, Sep 25, 2015 at 10:52 AM, Victor Berger
wrote:
>
> What I meant here is that the format and contents of the XML files is
> currently defined by the implementation of the C scanner, which is a less
> than optimal situation to discuss evolutions of this format.
>
> There will most likel
)
> - as well, adding the specification of the type contained in an array to an
> arg that didn't have it would be a breaking change, and as such needs
> thought.
>
>
> Victor
>
> Le 2015-09-18 20:55, Bill Spitzak a écrit :
>>
>> On Fri, Sep 18, 2015 at
Hi,
There are even earlier discussions about including 'bitfield' and
'enum' fields into the XML protocol file, e.g:
http://lists.freedesktop.org/archives/wayland-devel/2014-September/017071.html
But none of them led to any actual changes.
I still would very much like to see the 'bitfield' and 'e
On Tue, Sep 23, 2014 at 8:35 AM, Pekka Paalanen wrote:
> On Tue, 23 Sep 2014 13:59:39 +0800
> Boyan Ding wrote:
>
>> On Mon, 2014-09-22 at 11:27 -0700, Jason Ekstrand wrote:
>>
>> > I'm a little unsure. I think trying to completely solve this problem
>> > in a way that will truly make strongly t
On Mon, Sep 22, 2014 at 11:21 AM, Pekka Paalanen wrote:
>
> On Wed, 3 Sep 2014 19:44:04 +0200
> "Nils Chr. Brause" wrote:
>
> > This replaces "[PATCH wayland] Add "enum" attribute to "arg" elements".
> > Previous co
This replaces "[PATCH wayland] Add "enum" attribute to "arg" elements".
Previous concers have be incorporated and it is meant for 1.7.
>From 733fb18b163de93276f092a4be100c7e0c0c723f Mon Sep 17 00:00:00 2001
From: "Nils Chr. Brause"
Date: Wed
On Wed, Sep 3, 2014 at 9:15 AM, Pekka Paalanen wrote:
>
> On Mon, 1 Sep 2014 22:07:44 +0200
> "Nils Chr. Brause" wrote:
> >
> > While I'm at that, I would also like to make use of the enum names in the
> > generated C code. As far as I can see, this wo
Another possibility would of course be to add an 'is_bitfield="true"'
attribute to enum elements that are actually bit fields instead of using
'bitfield' elements. Every sanely written scanner should be able to cope
with that, shouldn't it?
On Wed, Sep 3
> On Mon, 1 Sep 2014 22:07:44 +0200
> > > "Nils Chr. Brause" wrote:
> > >
> > >> On Mon, Sep 1, 2014 at 10:45 AM, Pekka Paalanen
> wrote:
> > >
> > >> > Another problem with this patch is that while it adds new syntax to
>
On Mon, Sep 1, 2014 at 10:45 AM, Pekka Paalanen wrote:
>
> On Sat, 30 Aug 2014 17:20:45 +0200
> "Nils Chr. Brause" wrote:
>
> > There are programming languages, that are more strongly typed than
> > C. People creating Wayland bindings for these languages pro
rface" is the name of the interface,
where the enumeration is declared and "$enum" is the name of the
enumeration, which is used in this argument.
This might also be of documentary value.
Signed-off-by: Nils Chr. Brause
---
protocol/wayland.dtd | 1 +
protocol/wayland.xml | 32 +++
Hi!
Because the other thread got so long, I repost the improved version of
the patch for easier review:
>From 50cdeaf09a9bd90b1957a831217319e863c4c484 Mon Sep 17 00:00:00 2001
From: "Nils Chr. Brause"
Date: Mon, 25 Aug 2014 09:46:55 +0200
Subject: [PATCH] wayland-client: Ini
Since wl_display_get_fd() doesn't have any side effects, this is truly
useless.
Reviewed-by: Nils Chr. Brause
On Tue, Aug 26, 2014 at 2:59 PM, Ryo Munakata wrote:
> ---
> clients/simple-shm.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/clients/simple-sh
On Tue, Aug 12, 2014 at 09:27:02AM +0200, Marek Chalupa wrote:
> On 11 August 2014 18:02, Nils Chr. Brause wrote:
>
> > On Mon, Aug 11, 2014 at 08:36:51AM +0200, Marek Chalupa wrote:
> > > > proxy->flags = 0;
> > > >
> > >
>
This looks much more readable to me. Unnamed magic numbers are always
confusing.
Reviewed-by: Nils Chr. Brause
On Thu, Aug 21, 2014 at 3:47 PM, Ondřej Majerech
wrote:
> Signed-off-by: Ondřej Majerech
> ---
> desktop-shell/shell.c | 11 +--
> 1 file changed, 9 inse
I also noticed this in current master. This seems to fix the problem. :)
Reviewed-by: Nils Chr. Brause
On Thu, Aug 21, 2014 at 2:51 AM, Ondřej Majerech
wrote:
> We want to set the size of the entire window, not just the input area.
> This fixes the bug where resizing an X client
On Mon, Aug 11, 2014 at 7:36 PM, Pekka Paalanen wrote:
> Which brings us back to my earlier question, now rephrased
> differently: are you going to forbid using the same Wayland
> connection with a 3rd party library?
>
> If yes, you're all good. ;-)
>
Yes. :)
One of the goals of my bindings are
On Mon, Aug 11, 2014 at 12:57 PM, Giulio Camuffo
wrote:
> The problem is that windows don't always have a meaningful position.
> If a window is shown on two outputs at the same time, maybe one of
> which a remote one, what is the window position? And what is the
> position of a window rotated 45
ct wl_callback_listener frame_listener = {
> - redraw
> -};
> -
> static void
> pointer_handle_enter(void *data, struct wl_pointer *pointer,
> uint32_t serial, struct wl_surface *surface,
>
This is indeed unused
,6 @@ gears_create(struct display *display)
> gears->view.rotx = 20.0;
> gears->view.roty = 30.0;
>
> - gettimeofday(&tv, NULL);
> - gears->last_fps = tv.tv_sec * 1000 + tv.tv_usec / 1000;
> printf("Warning: FPS count is limited
On Mon, Aug 11, 2014 at 8:39 AM, Pekka Paalanen wrote
> No, I do not think that is wrong, but are you not writing language
> bindings or a wrapper library, which means you do not know how your code
> will be used?
>
Yes, I'm writing C++ Bindings. These bindings don't expose the user_data at
all
oxy->dispatcher = NULL;
> > proxy->display = display;
> > proxy->queue = factory->queue;
> > proxy->flags = 0;
> >
>
> The same.
>
Yes, of course. I guess we can also remove similar lines from
wl_display_connect_to_fd then? New pa
: FPS count is limited by the wayland compositor or
> monitor refresh rate\n");
>
> glEnable(GL_NORMALIZE);
I like this patch. It appears to be correct, it compiles, it certainly
fixes the problem, its code style matches the rest of weston, it is
well readable and
On Sat, Aug 9, 2014 at 3:14 PM, Pekka Paalanen wrote:
> I see nothing wrong here, memset to zero is a usual pattern, and
> wl_proxy is a complex enough type, that checking every member is
> set is tedious. Therefore:
>
> Reviewed-by: Pekka Paalanen
>
Thanks!
> But I do wonder, if it ever make
a new patch:
>From 685959fb80e6a1b10b2230efb331996bc38838ed Mon Sep 17 00:00:00 2001
From: "Nils Chr. Brause"
Date: Fri, 8 Aug 2014 18:06:16 +0200
Subject: [PATCH] wayland-client: Initialize newly created wl_proxys to zero.
Up until now, newly created wl_proxys (with proxy_create o
On 08/08/2014 07:23 PM, Marek Chalupa wrote:
> Just out of curiosity, did you have some troubles because of non-setting the
> proxy to zeroes?
I wanted to check if I already assigned my meta data to the proxy be
testing user_data against NULL. I have a workaround for this now, but I
don't want any
: Nils Chr. Brause
---
src/wayland-client.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/wayland-client.c b/src/wayland-client.c
index 3e401d3..8006581 100644
--- a/src/wayland-client.c
+++ b/src/wayland-client.c
@@ -274,6 +274,8 @@ proxy_create(struct wl_proxy *factory, const struct
68 matches
Mail list logo
