Re: [PATCH] connection: Leave fd open in wl_connection_destroy

2014-11-04 Thread Pekka Paalanen
On Mon, 27 Oct 2014 09:55:46 +0100 Marek Chalupa mchqwe...@gmail.com wrote: Hi, at first glance I didn't like returning fd from wl_connection_destroy, but at the other, I did! If you think about the connection as a buffer for the fd (and that is really the case), then it make sense to do

Re: [PATCH] connection: Leave fd open in wl_connection_destroy

2014-10-27 Thread Marek Chalupa
Hi, at first glance I didn't like returning fd from wl_connection_destroy, but at the other, I did! If you think about the connection as a buffer for the fd (and that is really the case), then it make sense to do something like: create conn -- destroy conn fd