Re: [PATCH] protocol: Extend wl_touch with touch point shape

2016-04-05 Thread Dennis Kempin
Thanks a lot for the comments guys! I agree on all of the above and uploaded a v2 of the patch. I included Peters description about the relationship to the frame event and updated the documentation to better describe how that ellipse is described. What major/minor means, how exactly the

Re: [PATCH] protocol: Extend wl_touch with touch point shape

2016-04-04 Thread Daniel Stone
Hi, On 3 April 2016 at 23:35, Peter Hutterer wrote: > Agreed. And please specify the exact details of what is considered the > major/minor axis (direction, orientation) and where the logical 0 is for the > orientation. Referencing the kernel isn't good enough here, we

Re: [PATCH] protocol: Extend wl_touch with touch point shape

2016-04-03 Thread Peter Hutterer
On Thu, Mar 31, 2016 at 10:49:42AM +0800, Jonas Ådahl wrote: > On Fri, Mar 25, 2016 at 09:29:56AM -0700, Dennis Kempin wrote: > > This CL updates the wl_touch interface with a shape event. > > The shape of a touch point is not relevant for most UI > > applications, but allows a better experience

Re: [PATCH] protocol: Extend wl_touch with touch point shape

2016-03-30 Thread Jonas Ådahl
On Fri, Mar 25, 2016 at 09:29:56AM -0700, Dennis Kempin wrote: > This CL updates the wl_touch interface with a shape event. > The shape of a touch point is not relevant for most UI > applications, but allows a better experience in some cases > such as drawing app. > > The shape event is used by

Re: [PATCH] protocol: Extend wl_touch with touch point shape

2016-03-25 Thread Dennis Kempin
Hi everyone! I am working with David Reveman on his implementation of a wayland compositor in Chrome (see https://code.google.com/p/chromium/codesearch#chromium/src/components/exo/ ). As part of that I have been looking into reporting information about the shape of a touch, which is supported by

[PATCH] protocol: Extend wl_touch with touch point shape

2016-03-25 Thread Dennis Kempin
This CL updates the wl_touch interface with a shape event. The shape of a touch point is not relevant for most UI applications, but allows a better experience in some cases such as drawing app. The shape event is used by the compositor to inform the client about changes in the shape of a