Re: [PATCH 1/2] Introduce keyboard grabbing protocol for Xwayland

hi Kristian, > > Yes, that's precisely the whole point of this protocol (and grabs in > > general) :) > > > > Take the attached sample code for example, it maps a single override > > redirect window (one that no X11 window manager would focus, because it's > > an O-R) and issues an active

Re: [PATCH 1/2] Introduce keyboard grabbing protocol for Xwayland

On Fri, Apr 21, 2017 at 5:50 AM Olivier Fourdan wrote: > > Hi Jonas, > > > > [...] > > > For that last point, I'd rather use: > > > > > > * does not guarantee that events sent to this client are > continuous, > > > a compositor may change and reroute keyboard

Re: [PATCH 1/2] Introduce keyboard grabbing protocol for Xwayland

Hi Jonas, > > [...] > > For that last point, I'd rather use: > > > > * does not guarantee that events sent to this client are continuous, > > a compositor may change and reroute keyboard events while the grab > > is nominally active. > > > > > hmm, and thinking about the last

Re: [PATCH 1/2] Introduce keyboard grabbing protocol for Xwayland

On Wed, Mar 22, 2017 at 05:27:22PM +0100, Olivier Fourdan wrote: > This patch introduces a new protocol for grabbing the keyboard from > Xwayland. > > This is needed for X11 applications that map an override redirect window > (ths not focused by the window manager) and issue an active grab on the

Re: [PATCH 1/2] Introduce keyboard grabbing protocol for Xwayland

Hi > I cannot see why this api cannot be correctly emulated using some > wayland api that normal wayland clients can also use. Allowing X > clients to have more rights and abilities than Wayland clients seems > horrendously wrong. > > The X emulation does not have to do 1:1 translation of X11

Re: [PATCH 1/2] Introduce keyboard grabbing protocol for Xwayland

Hi Pekka, > you cannot ignore a wl_registry.bind request. Did you ever try to see > what happens? :-) Admittedly, I didn't go that far! > If you do not create a wl_resource when the protocol spec says "this > creates a new object", then if the client ever refers to the > non-created object, it

Re: [PATCH 1/2] Introduce keyboard grabbing protocol for Xwayland

On Mon, 3 Apr 2017 09:47:50 -0400 (EDT) Olivier Fourdan wrote: > Hi Quentin, > > > I think it may be worth it to add a little safety net: > > “Compositors are required to restrict this interface to Xwayland alone, > > and raise a protocol error for native Wayland clients.”

Re: [PATCH 1/2] Introduce keyboard grabbing protocol for Xwayland

- Original Message - > I was thinking about your “hide global”[1] API, which does kill the > client. It seems like a perfect use of it to me. > > [1] > Hehe, yes, that's precisely the use

Re: [PATCH 1/2] Introduce keyboard grabbing protocol for Xwayland

On 4/3/17 3:47 PM, Olivier Fourdan wrote: Hi Quentin, I think it may be worth it to add a little safety net: “Compositors are required to restrict this interface to Xwayland alone, and raise a protocol error for native Wayland clients.” Yes, agreed, good point! But do we really need to kill

Re: [PATCH 1/2] Introduce keyboard grabbing protocol for Xwayland

Hi Quentin, > I think it may be worth it to add a little safety net: > “Compositors are required to restrict this interface to Xwayland alone, > and raise a protocol error for native Wayland clients.” Yes, agreed, good point! But do we really need to kill a client that would dare to try to bind

Re: [PATCH 1/2] Introduce keyboard grabbing protocol for Xwayland

Hey Peter, Thanks for the review! > woohoo, grabs. My favourite topic! ;) > > Mostly ok, a few complaints regarding the documentation but the protocol is > fine from my POV. > > On Wed, Mar 22, 2017 at 05:27:22PM +0100, Olivier Fourdan wrote: > > This patch introduces a new protocol for

Re: [PATCH 1/2] Introduce keyboard grabbing protocol for Xwayland

On 4/2/17 2:57 AM, Peter Hutterer wrote: woohoo, grabs. My favourite topic! ;) On Wed, Mar 22, 2017 at 05:27:22PM +0100, Olivier Fourdan wrote: >> [snip] + + This protocol specifies a way for Xwayland to request all keyboard + events to be forwarded to a surface even when the

Re: [PATCH 1/2] Introduce keyboard grabbing protocol for Xwayland

woohoo, grabs. My favourite topic! ;) Mostly ok, a few complaints regarding the documentation but the protocol is fine from my POV. On Wed, Mar 22, 2017 at 05:27:22PM +0100, Olivier Fourdan wrote: > This patch introduces a new protocol for grabbing the keyboard from > Xwayland. > > This is

[PATCH 1/2] Introduce keyboard grabbing protocol for Xwayland

This patch introduces a new protocol for grabbing the keyboard from Xwayland. This is needed for X11 applications that map an override redirect window (ths not focused by the window manager) and issue an active grab on the keyboard to capture all keyboard events. Signed-off-by: Olivier Fourdan