Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Peter Hutterer
On Tue, Jun 03, 2014 at 11:23:07AM -0400, Jasper St. Pierre wrote: > Just have people shoot an email saying "hey, we'd like to add a constant > for this". Talking to each other is really all we need to do, no need to > make it any more formal. indeed. and there's a high chance that if another OS n

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Peter Hutterer
On Tue, Jun 03, 2014 at 08:54:38AM -0400, Jasper St. Pierre wrote: > I think it should be #include "linux/input.h" at the very least. > has always meant "system library" to me. amended locally, thanks. Cheers, Peter > On Tue, Jun 3, 2014 at 5:34 AM, Peter Hutterer > wrote: > > > On 3/06/20

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Jonas Ådahl
On Tue, Jun 03, 2014 at 08:08:15AM +1000, Peter Hutterer wrote: > Avoids having to #define any values we're trying to use. > > Header file is from Linux 3.15-rc8. Changing to "linux/input.h" or not, the patch looks correct to me, so Reviewed-by: Jonas Ådahl > > Signed-off-by: Peter Hutterer

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Jasper St. Pierre
Just have people shoot an email saying "hey, we'd like to add a constant for this". Talking to each other is really all we need to do, no need to make it any more formal. On Tue, Jun 3, 2014 at 11:17 AM, Thiago Macieira wrote: > Em ter 03 jun 2014, às 19:32:06, Peter Hutterer escreveu: > > > Th

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Thiago Macieira
Em ter 03 jun 2014, às 19:32:06, Peter Hutterer escreveu: > > The current situation is vague, and this patch probably is not intended > > to fix that at all, but is there a plan? Or is it expected that other > > OSs implement their own libinput or something? > > No, other OS can use libinput, they

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Thiago Macieira
Em ter 03 jun 2014, às 08:54:38, Jasper St. Pierre escreveu: > I think it should be #include "linux/input.h" at the very least. > has always meant "system library" to me. That distinction is blurred when you have third-party libraries. "" is actually meant for "headers in my project" because it

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Jasper St. Pierre
I think it should be #include "linux/input.h" at the very least. has always meant "system library" to me. On Tue, Jun 3, 2014 at 5:34 AM, Peter Hutterer wrote: > On 3/06/2014 17:06 , Thiago Macieira wrote: > >> Em ter 03 jun 2014, às 16:56:35, Peter Hutterer escreveu: >> >>> On Mon, Jun 02, 20

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Peter Hutterer
On 3/06/2014 17:06 , Thiago Macieira wrote: Em ter 03 jun 2014, às 16:56:35, Peter Hutterer escreveu: On Mon, Jun 02, 2014 at 10:01:20PM -0700, Thiago Macieira wrote: Em ter 03 jun 2014, às 08:08:15, Peter Hutterer escreveu: Avoids having to #define any values we're trying to use. Header file

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Peter Hutterer
On 3/06/2014 17:21 , Pekka Paalanen wrote: On Tue, 03 Jun 2014 00:06:40 -0700 Thiago Macieira wrote: Em ter 03 jun 2014, às 16:56:35, Peter Hutterer escreveu: On Mon, Jun 02, 2014 at 10:01:20PM -0700, Thiago Macieira wrote: Em ter 03 jun 2014, às 08:08:15, Peter Hutterer escreveu: Avoids ha

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Jonas Ådahl
On Tue, Jun 03, 2014 at 10:21:07AM +0300, Pekka Paalanen wrote: > On Tue, 03 Jun 2014 00:06:40 -0700 > Thiago Macieira wrote: > > > Em ter 03 jun 2014, às 16:56:35, Peter Hutterer escreveu: > > > On Mon, Jun 02, 2014 at 10:01:20PM -0700, Thiago Macieira wrote: > > > > Em ter 03 jun 2014, às 08:08

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Pekka Paalanen
On Tue, 03 Jun 2014 00:06:40 -0700 Thiago Macieira wrote: > Em ter 03 jun 2014, às 16:56:35, Peter Hutterer escreveu: > > On Mon, Jun 02, 2014 at 10:01:20PM -0700, Thiago Macieira wrote: > > > Em ter 03 jun 2014, às 08:08:15, Peter Hutterer escreveu: > > > > Avoids having to #define any values we

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-03 Thread Thiago Macieira
Em ter 03 jun 2014, às 16:56:35, Peter Hutterer escreveu: > On Mon, Jun 02, 2014 at 10:01:20PM -0700, Thiago Macieira wrote: > > Em ter 03 jun 2014, às 08:08:15, Peter Hutterer escreveu: > > > Avoids having to #define any values we're trying to use. > > > > > > Header file is from Linux 3.15-rc8.

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-02 Thread Peter Hutterer
On Mon, Jun 02, 2014 at 10:01:20PM -0700, Thiago Macieira wrote: > Em ter 03 jun 2014, às 08:08:15, Peter Hutterer escreveu: > > Avoids having to #define any values we're trying to use. > > > > Header file is from Linux 3.15-rc8. > > > > Signed-off-by: Peter Hutterer > > Wouldn't this be time a

Re: [PATCH libinput] Add our own version of linux/input.h

2014-06-02 Thread Thiago Macieira
Em ter 03 jun 2014, às 08:08:15, Peter Hutterer escreveu: > Avoids having to #define any values we're trying to use. > > Header file is from Linux 3.15-rc8. > > Signed-off-by: Peter Hutterer Wouldn't this be time as well to start using a different include than ? -- Thiago Macieira - thiago (

[PATCH libinput] Add our own version of linux/input.h

2014-06-02 Thread Peter Hutterer
Avoids having to #define any values we're trying to use. Header file is from Linux 3.15-rc8. Signed-off-by: Peter Hutterer --- include/linux/input.h | 1174 +++ src/Makefile.am |6 +- src/evdev-mt-touchpad-buttons.c |4 - src