Re: [PATCH libinput 1/2] touchpad: add a hwdb quirk for (external) touchpad/keyboard combos

On Fri, Feb 10, 2017 at 11:04:00AM +0100, Hans de Goede wrote: > Hi, > > Series looks good, but patch 1/2 introduces > tp_is_tpkb_combo_below() and patch 2/2 then moves it around > to avoid doing a forward declaration, it would be better IMHO > if patch 1/2 simply defined it in the place where

Re: [PATCH libinput 1/2] touchpad: add a hwdb quirk for (external) touchpad/keyboard combos

Hi, Series looks good, but patch 1/2 introduces tp_is_tpkb_combo_below() and patch 2/2 then moves it around to avoid doing a forward declaration, it would be better IMHO if patch 1/2 simply defined it in the place where 2/2 puts it. With that fixed: Reviewed-by: Hans de Goede

[PATCH libinput 1/2] touchpad: add a hwdb quirk for (external) touchpad/keyboard combos

Specify the layout of the combo so we know when to initialize palm detection. This allows us to drop palm detection on external touchpads otherwise, replacing the wacom-specific check with something more generic.. Signed-off-by: Peter Hutterer ---