Re: [PATCH v1 weston 06/11] tests: Add screenshot recording to weston-test

2014-12-11 Thread Pekka Paalanen
On Wed, 10 Dec 2014 19:19:50 -0800 Bryce Harrington br...@osg.samsung.com wrote: On Mon, Nov 24, 2014 at 01:01:29PM +0200, Pekka Paalanen wrote: could we use a wl_shm-based wl_buffer instead of a file, please? That way we can simply relay the pixels as is to the test client, which can

Re: [PATCH v1 weston 06/11] tests: Add screenshot recording to weston-test

2014-12-10 Thread Bryce Harrington
On Mon, Nov 24, 2014 at 01:01:29PM +0200, Pekka Paalanen wrote: could we use a wl_shm-based wl_buffer instead of a file, please? That way we can simply relay the pixels as is to the test client, which can then compare without compressing and decompressing from PNG first. For an example how

Re: [PATCH v1 weston 06/11] tests: Add screenshot recording to weston-test

2014-11-26 Thread Pekka Paalanen
On Tue, 25 Nov 2014 09:11:39 -0600 Derek Foreman der...@osg.samsung.com wrote: On 25/11/14 03:53 AM, Pekka Paalanen wrote: On Mon, 24 Nov 2014 15:20:35 -0800 Bryce Harrington br...@osg.samsung.com wrote: On Mon, Nov 24, 2014 at 04:31:01PM -0600, Derek Foreman wrote: On 24/11/14 05:01

Re: [PATCH v1 weston 06/11] tests: Add screenshot recording to weston-test

2014-11-25 Thread Pekka Paalanen
On Mon, 24 Nov 2014 15:20:35 -0800 Bryce Harrington br...@osg.samsung.com wrote: On Mon, Nov 24, 2014 at 04:31:01PM -0600, Derek Foreman wrote: On 24/11/14 05:01 AM, Pekka Paalanen wrote: On Wed, 19 Nov 2014 15:06:21 -0800 Bryce Harrington br...@osg.samsung.com wrote: From: Derek

Re: [PATCH v1 weston 06/11] tests: Add screenshot recording to weston-test

2014-11-25 Thread Derek Foreman
On 25/11/14 03:53 AM, Pekka Paalanen wrote: On Mon, 24 Nov 2014 15:20:35 -0800 Bryce Harrington br...@osg.samsung.com wrote: On Mon, Nov 24, 2014 at 04:31:01PM -0600, Derek Foreman wrote: On 24/11/14 05:01 AM, Pekka Paalanen wrote: On Wed, 19 Nov 2014 15:06:21 -0800 Bryce Harrington

Re: [PATCH v1 weston 06/11] tests: Add screenshot recording to weston-test

2014-11-25 Thread Bill Spitzak
On 11/25/2014 07:11 AM, Derek Foreman wrote: What's fuzz exactly? Each pixel can be within +-fuzz/2 on each color component and still be a match? a fuzz of 256 would match everything? The cairo project has done some work on a fuzzy comparison for their tests, may be able to reuse that.

Re: [PATCH v1 weston 06/11] tests: Add screenshot recording to weston-test

2014-11-25 Thread Bryce Harrington
On Tue, Nov 25, 2014 at 11:46:05AM -0800, Bill Spitzak wrote: On 11/25/2014 07:11 AM, Derek Foreman wrote: What's fuzz exactly? Each pixel can be within +-fuzz/2 on each color component and still be a match? a fuzz of 256 would match everything? The cairo project has done some work on a

Re: [PATCH v1 weston 06/11] tests: Add screenshot recording to weston-test

2014-11-24 Thread Pekka Paalanen
On Wed, 19 Nov 2014 15:06:21 -0800 Bryce Harrington br...@osg.samsung.com wrote: From: Derek Foreman der...@osg.samsung.com Adds wl_test_record_screenshot() to weston test. This commit also adds a dependency on cairo to weston-test to use it for writing PNG files. Fixes:

Re: [PATCH v1 weston 06/11] tests: Add screenshot recording to weston-test

2014-11-24 Thread Derek Foreman
On 24/11/14 05:01 AM, Pekka Paalanen wrote: On Wed, 19 Nov 2014 15:06:21 -0800 Bryce Harrington br...@osg.samsung.com wrote: From: Derek Foreman der...@osg.samsung.com Adds wl_test_record_screenshot() to weston test. This commit also adds a dependency on cairo to weston-test to use it for

Re: [PATCH v1 weston 06/11] tests: Add screenshot recording to weston-test

2014-11-24 Thread Bryce Harrington
On Mon, Nov 24, 2014 at 04:31:01PM -0600, Derek Foreman wrote: On 24/11/14 05:01 AM, Pekka Paalanen wrote: On Wed, 19 Nov 2014 15:06:21 -0800 Bryce Harrington br...@osg.samsung.com wrote: From: Derek Foreman der...@osg.samsung.com Adds wl_test_record_screenshot() to weston test.

[PATCH v1 weston 06/11] tests: Add screenshot recording to weston-test

2014-11-19 Thread Bryce Harrington
From: Derek Foreman der...@osg.samsung.com Adds wl_test_record_screenshot() to weston test. This commit also adds a dependency on cairo to weston-test to use it for writing PNG files. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=83981 Signed-off-by: Bryce Harrington br...@osg.samsung.com