Re: [PATCH v2 0/3] Deal with destroy signal use after free issues

2018-04-20 Thread Derek Foreman
I've pushed this series now. Thanks, Derek On 2018-04-16 03:00 PM, Derek Foreman wrote: > Now that the release is out, I'd like to dig back into this mess. > This is a round up of some patches that were on list shortly before > the release to deal with a problem where many existing libwayland >

Re: [PATCH v2 0/3] Deal with destroy signal use after free issues

2018-04-16 Thread Derek Foreman
On 2018-04-16 04:29 PM, Markus Ongyerth wrote: > Hi, > > Thanks for getting to this. I was waiting for the release, but I'm currently > not at full capacity, so you got it before me. > > The commit message of patch 1 contains a lie. The second paragraph should > contain "IF there was only one

Re: [PATCH v2 0/3] Deal with destroy signal use after free issues

2018-04-16 Thread Markus Ongyerth
Hi, Thanks for getting to this. I was waiting for the release, but I'm currently not at full capacity, so you got it before me. The commit message of patch 1 contains a lie. The second paragraph should contain "IF there was only one listener object", which the testcase in Patch 3 shows. But I

[PATCH v2 0/3] Deal with destroy signal use after free issues

2018-04-16 Thread Derek Foreman
Now that the release is out, I'd like to dig back into this mess. This is a round up of some patches that were on list shortly before the release to deal with a problem where many existing libwayland users don't delete their destroy signal listeners before freeing them. These leads to a bit of a