Re: [PATCH wayland] protocol: Bump seat to version 7 and require keymaps be private

2018-11-30 Thread Derek Foreman
On 11/2/18 6:15 AM, Pekka Paalanen wrote: > On Thu, 1 Nov 2018 11:15:46 -0500 > Derek Foreman wrote: > >> Weston commit 76829fc4eaea329d2a525c3978271e13bd76c078 (and similar >> commits for other compositors) protects the compositor's keyboard >> mapping from client damage by duplicating the

Re: [PATCH wayland] protocol: Bump seat to version 7 and require keymaps be private

2018-11-02 Thread Pekka Paalanen
On Thu, 1 Nov 2018 11:15:46 -0500 Derek Foreman wrote: > Weston commit 76829fc4eaea329d2a525c3978271e13bd76c078 (and similar > commits for other compositors) protects the compositor's keyboard > mapping from client damage by duplicating the keymap for every > client. > > On some systems there

Re: [PATCH wayland] protocol: Bump seat to version 7 and require keymaps be private

2018-11-02 Thread Pekka Paalanen
On Thu, 1 Nov 2018 13:01:13 -0500 Derek Foreman wrote: > On 11/1/18 12:18 PM, Philipp Kerling wrote: > > Actually... (below) > > Yes, you are of course strictly correct. > > However, the recent previous commits that bumped wl_seat version 9a18a8 > and c5356e have also kept all three

Re: [PATCH wayland] protocol: Bump seat to version 7 and require keymaps be private

2018-11-01 Thread Derek Foreman
On 11/1/18 12:18 PM, Philipp Kerling wrote: > Actually... (below) Yes, you are of course strictly correct. However, the recent previous commits that bumped wl_seat version 9a18a8 and c5356e have also kept all three children in sync, and it's become de-facto convention to do so. Thanks, Derek

Re: [PATCH wayland] protocol: Bump seat to version 7 and require keymaps be private

2018-11-01 Thread Philipp Kerling
Actually... (below) 2018-11-01 (木) の 11:15 -0500 に Derek Foreman さんは書きました: > Weston commit 76829fc4eaea329d2a525c3978271e13bd76c078 (and similar > commits for other compositors) protects the compositor's keyboard > mapping from client damage by duplicating the keymap for every > client. > > On

Re: [PATCH wayland] protocol: Bump seat to version 7 and require keymaps be private

2018-11-01 Thread Philipp Kerling
I second: \o/ Don't know if it means much at this point, but as original reporter of the issue I claim this is Reviewed-by: Philipp Kerling ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org

Re: [PATCH wayland] protocol: Bump seat to version 7 and require keymaps be private

2018-11-01 Thread Daniel Stone
On Thu, 1 Nov 2018 at 16:16, Derek Foreman wrote: > Weston commit 76829fc4eaea329d2a525c3978271e13bd76c078 (and similar > commits for other compositors) protects the compositor's keyboard > mapping from client damage by duplicating the keymap for every > client. > > On some systems there are

Re: [PATCH wayland] protocol: Bump seat to version 7 and require keymaps be private

2018-11-01 Thread Simon Ser
Nice. Reviewed-by: Simon Ser ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH wayland] protocol: Bump seat to version 7 and require keymaps be private

2018-11-01 Thread Derek Foreman
Weston commit 76829fc4eaea329d2a525c3978271e13bd76c078 (and similar commits for other compositors) protects the compositor's keyboard mapping from client damage by duplicating the keymap for every client. On some systems there are other potential fixes for this - such as using sealed memfds on