Re: [PATCH wayland] wayland-egl: Make symbol test fail on failure

On Mon, 19 Mar 2018 11:59:25 -0500 Derek Foreman wrote: > On 2018-03-19 11:20 AM, Eric Engestrom wrote: > > On Monday, 2018-03-19 16:10:57 +, Daniel Stone wrote: > >> Hi, > >> > >> On 19 March 2018 at 16:08, Eric Engestrom > >> wrote:

Re: [PATCH wayland] wayland-egl: Make symbol test fail on failure

On 2018-03-19 11:20 AM, Eric Engestrom wrote: On Monday, 2018-03-19 16:10:57 +, Daniel Stone wrote: Hi, On 19 March 2018 at 16:08, Eric Engestrom wrote: On Monday, 2018-03-19 15:13:14 +, Daniel Stone wrote: +if ! test -f "$LIB"; then + echo "Test

Re: [PATCH wayland] wayland-egl: Make symbol test fail on failure

On Monday, 2018-03-19 16:10:57 +, Daniel Stone wrote: > Hi, > > On 19 March 2018 at 16:08, Eric Engestrom wrote: > > On Monday, 2018-03-19 15:13:14 +, Daniel Stone wrote: > >> +if ! test -f "$LIB"; then > >> + echo "Test binary \"$LIB\" does not exist" > >>

Re: [PATCH wayland] wayland-egl: Make symbol test fail on failure

Hi, On 19 March 2018 at 16:08, Eric Engestrom wrote: > On Monday, 2018-03-19 15:13:14 +, Daniel Stone wrote: >> +if ! test -f "$LIB"; then >> + echo "Test binary \"$LIB\" does not exist" >> + exit 99 >> +fi >> + >> +if ! test -n "$NM"; then >> + echo

Re: [PATCH wayland] wayland-egl: Make symbol test fail on failure

On Monday, 2018-03-19 15:13:14 +, Daniel Stone wrote: > The previous rewrite of the wayland-egl ABI checker introduced checks > for removed symbols as well as added symbols, but broke some failure > conditions. Add an explict return-code variable set in failure paths, > rather than chaining or

[PATCH wayland] wayland-egl: Make symbol test fail on failure

The previous rewrite of the wayland-egl ABI checker introduced checks for removed symbols as well as added symbols, but broke some failure conditions. Add an explict return-code variable set in failure paths, rather than chaining or conditions. If we cannot find the binary or nm, we regard this