Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-22 Thread Simon Ser
On March 22, 2018 2:39 PM, Simon McVittie wrote: > Those dialogs still have all the window-management operation widgets that > the application designer wants them to have - that just happens to mean > "none" in this case. > > Contrast with the same dialogs in a SSD

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-22 Thread Simon McVittie
On Thu, 22 Mar 2018 at 08:22:23 -0400, Simon Ser wrote: > I think we really do mean "decorations" and not "window management". > Decorations > are used for window management, but their scope is larger - they are also user > interface components. > > For instance, I can think of GNOME [1] and

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-22 Thread Simon Ser
On March 22, 2018 6:37 AM, Peter Hutterer wrote: > so, random thought: instead of talking about decorations or not (which isn't > what we really care about) talk about window management and who does it. I think we really do mean "decorations" and not "window

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-21 Thread Peter Hutterer
On Mon, Mar 19, 2018 at 04:59:15AM +0900, Eike Hein wrote: > > >> If server and client do not negotiate the use of a server-side > >> decoration using this protocol, clients continue to self-decorate as > >> they see fit." > > > > The wording here is weird, and I want to avoid the word decorate.

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-19 Thread Pekka Paalanen
On Sun, 18 Mar 2018 14:59:58 -0400 Simon Ser wrote: > On March 16, 2018 1:22 PM, Pekka Paalanen wrote: > > > > I'm missing a comment that describes what happens if the xdg_toplevel is > > > > destroyed. There is some object dependency here that needs to

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-18 Thread Peter Hutterer
On Wed, Mar 14, 2018 at 06:41:53AM -0400, Simon Ser wrote: > On March 14, 2018 10:22 AM, Peter Hutterer wrote: > > sorry about the delay, but better late than too late ;) > > No problem, thanks for your review! > > > On Sun, Mar 11, 2018 at 05:53:42PM -0400, Simon Ser

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-18 Thread Drew DeVault
How about: If the client chooses not to use server-side decorations, it may be responsible for its own window management operations. ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-18 Thread Eike Hein
>> If server and client do not negotiate the use of a server-side >> decoration using this protocol, clients continue to self-decorate as >> they see fit." > > The wording here is weird, and I want to avoid the word decorate. What > the client does is not necessarily decorate. The reason why

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-18 Thread Drew DeVault
On 2018-03-19 4:42 AM, Eike Hein wrote: > How about: > > > +1 > And as description: > > "This interface allows a server to announce support for server-side > decorations and optionally express a preference for using them. > > A client can use this protocol to request being decorated by a >

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-18 Thread Eike Hein
How about: And as description: "This interface allows a server to announce support for server-side decorations and optionally express a preference for using them. A client can use this protocol to request being decorated by a supporting server. If server and client do not negotiate the use

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-18 Thread Drew DeVault
To summarize the state of affairs here, the purpose of this protocol is to communicate: - The compositor's preference to use SSD or leave the client to its own devices - The choice of the client to have SSD displayed We can completely remove CSD from the question because the term is barely

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-18 Thread Simon Ser
On March 16, 2018 1:22 PM, Pekka Paalanen wrote: > > > I'm missing a comment that describes what happens if the xdg_toplevel is > > > destroyed. There is some object dependency here that needs to be stated. > > > Do > > > we need an event here? Or are we assuming that

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-18 Thread Daniel Stone
Hi Eike, On 18 March 2018 at 16:35, Eike Hein wrote: > On 03/18/2018 03:55 PM, Markus Ongyerth wrote: >>> a) Change the definition of "decoration" to "window controls as deemed >>> appropriate by the compositor, for example ...". This leaves what's in a >>> server-side deco and

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-18 Thread Daniel Stone
Hi, On 18 March 2018 at 16:22, Eike Hein wrote: > On 03/18/2018 10:45 PM, Daniel Stone wrote: >> That strikes me as a problem. So what can we do to bridge the gap >> between these projects? > > FWIW, I agree this is a problem. KDE's Wayland contributor base is > slowly growing,

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-18 Thread Eike Hein
On 03/18/2018 03:55 PM, Markus Ongyerth wrote: >> a) Change the definition of "decoration" to "window controls as deemed >> appropriate by the compositor, for example ...". This leaves what's in a >> server-side deco and what's in a client-side deco up to servers and >> clients, respectively, and

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-18 Thread Eike Hein
On 03/18/2018 10:45 PM, Daniel Stone wrote: > That strikes me as a problem. So what can we do to bridge the gap > between these projects? FWIW, I agree this is a problem. KDE's Wayland contributor base is slowly growing, though - we have more people working on Wayland stuff than we had

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-18 Thread Markus Ongyerth
Sorry, I messed up my quoting, cutting down the mail =.= I wanted to keep the part that ended in: > Yes, but I think this reinforces my point. If an IVI, phone or > set-top-box compositor suddenly started sticking decorations on the > surfaces it found, it wouldn't be useful. Saying 'but the

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-18 Thread Markus Ongyerth
On 2018/3月/18 01:45, Daniel Stone wrote: > Hi Drew, > > On 15 March 2018 at 16:53, Drew DeVault wrote: > >> > In fact, I have done so. Before we started working on this protocol, > >> > Sway did exactly this. We have provided users the means of overriding > >> > the approach to

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-18 Thread Drew DeVault
On 2018-03-18 1:45 PM, Daniel Stone wrote: > I don't think prolonging the argument is helpful. Just a fairly clear > statement that in the absence of this extension and unless told > otherwise, clients which can decorate themselves, should decorate > themselves, would work for me. I don't want to

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-18 Thread Daniel Stone
Hi Drew, On 15 March 2018 at 16:53, Drew DeVault wrote: >> Denying facts and being disingenuous doesn't help anyone, and it's >> tiring. Tiring enough that I came into this thread with the intention >> of giving this protocol a couple of suggestions and a push towards >> getting

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-18 Thread Markus Ongyerth
On 2018/3月/18 10:50, Eike Hein wrote: > > > On 03/16/2018 12:43 AM, Daniel Stone wrote:> No, it really has. GTK+ has > always - well, until you got the patches > > for this protocol merged a month or two ago - decorated its own > > windows under Wayland. Same with Qt. Same with EFL. These are

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-17 Thread Eike Hein
On 03/16/2018 12:43 AM, Daniel Stone wrote:> No, it really has. GTK+ has always - well, until you got the patches > for this protocol merged a month or two ago - decorated its own > windows under Wayland. Same with Qt. Same with EFL. These are toolkits > which have been around and deployed for

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-16 Thread Pekka Paalanen
On Wed, 14 Mar 2018 06:41:53 -0400 Simon Ser wrote: > On March 14, 2018 10:22 AM, Peter Hutterer wrote: > > sorry about the delay, but better late than too late ;) > > No problem, thanks for your review! > > > On Sun, Mar 11, 2018 at 05:53:42PM

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-15 Thread Drew DeVault
> I understand you dislike Wayland's established window-management model > and you wish it was the same as X11. I disagree, but that's fine. > What's not fine, is trying to rewrite history and insulting everyone's > intelligence. You're acting as if the consensus which has underpinned > everything

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-15 Thread Daniel Stone
On 15 March 2018 at 15:21, Drew DeVault wrote: > On 2018-03-15 3:16 PM, Daniel Stone wrote: >> You could write a compositor which put decorations on everything >> unless explicitly instructed not to, and claim victory in the name of >> technical correctness. Even though it's

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-15 Thread Drew DeVault
On 2018-03-15 3:16 PM, Daniel Stone wrote: > You could write a compositor which put decorations on everything > unless explicitly instructed not to, and claim victory in the name of > technical correctness. Even though it's double-decorating GTK+, EFL, > Weston, and pretty much everything

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-15 Thread Daniel Stone
Hi, On 15 March 2018 at 15:12, Drew DeVault wrote: > On 2018-03-15 3:04 PM, Mike Blumenkrantz wrote: >> It seems to me that there is no harm in restating that clients are required >> to implement CSD inside a protocol which permits adding a separate, >> optional method of window

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-15 Thread Drew DeVault
On 2018-03-15 3:04 PM, Mike Blumenkrantz wrote: > It seems to me that there is no harm in restating that clients are required > to implement CSD inside a protocol which permits adding a separate, > optional method of window decoration. > > Note that it is not an assumption that

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-15 Thread Mike Blumenkrantz
It seems to me that there is no harm in restating that clients are required to implement CSD inside a protocol which permits adding a separate, optional method of window decoration. Note that it is not an assumption that clients/compositors "support both" modes, it's a hard requirement that

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-14 Thread Drew DeVault
On 2018-03-14 3:16 PM, Simon Ser wrote: > However, the situation we'd like to avoid is clients wanting decorations not > implementing CSD at all and relying on this protocol to show them via SSD. > What > about rewording this sentence to: I understand where you're coming from, but this is not

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-14 Thread Simon Ser
On March 14, 2018 7:33 PM, Drew DeVault wrote: > On 2018-03-14 6:41 AM, Simon Ser wrote: > > > Since we assume CSD by default, this implies that any client must be able > > > to > > > do CSD, which should be explicitly stated here. > > > > It's already stated in the protocol

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-14 Thread Drew DeVault
On 2018-03-14 6:41 AM, Simon Ser wrote: > > Since we assume CSD by default, this implies that any client must be able to > > do CSD, which should be explicitly stated here. > > It's already stated in the protocol description ("Note that even if > the server supports server-side window

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-14 Thread Simon Ser
On March 14, 2018 10:22 AM, Peter Hutterer wrote: > sorry about the delay, but better late than too late ;) No problem, thanks for your review! > On Sun, Mar 11, 2018 at 05:53:42PM -0400, Simon Ser wrote: > > This adds a new protocol to negotiate server- and

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-14 Thread Peter Hutterer
sorry about the delay, but better late than too late ;) On Sun, Mar 11, 2018 at 05:53:42PM -0400, Simon Ser wrote: > This adds a new protocol to negotiate server- and client-side rendering of > window decorations for xdg-toplevels. This allows compositors that want > to draw decorations

[PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-11 Thread Simon Ser
This adds a new protocol to negotiate server- and client-side rendering of window decorations for xdg-toplevels. This allows compositors that want to draw decorations themselves to send their preference to clients, and clients that prefer server-side decorations to request them. This is inspired