Re: [PATCH wayland-protocols] xdg-output: deprecate the xdg_output.done event

2019-07-02 Thread Jonas Ã…dahl
On Sat, Apr 27, 2019 at 07:44:39AM +, Simon Ser wrote: > This commit makes it so a wl_output.done event is guaranteed to be sent with a > xdg_output.done event. > > This protocol change has been discussed in a recent xorg-devel discussions > [1]. > > First let's recap why a change is

Re: [PATCH wayland-protocols] xdg-output: deprecate the xdg_output.done event

2019-06-24 Thread Pekka Paalanen
On Sun, 28 Apr 2019 21:52:34 +1200 Scott Anderson wrote: > >>> This commit makes it so a wl_output.done event is guaranteed to be sent > >>> with a > >>> xdg_output.done event. > >> > >> Humm, I am not sure I like changing xdg-output to rely on another protocol > >> event, it's looks like a

Re: [PATCH wayland-protocols] xdg-output: deprecate the xdg_output.done event

2019-05-10 Thread Olivier Fourdan
Hi Simon, On Mon, Apr 29, 2019 at 9:22 AM Olivier Fourdan wrote: > On Mon, Apr 29, 2019 at 9:05 AM Simon Ser wrote: >> >> On Monday, April 29, 2019 9:51 AM, Olivier Fourdan >> wrote: >> > > On Sunday, April 28, 2019 12:04 PM, Olivier Fourdan >> > > wrote: >> > IMHO, it would better,

Re: [PATCH wayland-protocols] xdg-output: deprecate the xdg_output.done event

2019-04-29 Thread Olivier Fourdan
Hi On Mon, Apr 29, 2019 at 9:05 AM Simon Ser wrote: > On Monday, April 29, 2019 9:51 AM, Olivier Fourdan > wrote: > > > On Sunday, April 28, 2019 12:04 PM, Olivier Fourdan < > ofour...@redhat.com> wrote: > > IMHO, it would better, semantically, to keep `xdg-output.done` and > > clarify (in

Re: [PATCH wayland-protocols] xdg-output: deprecate the xdg_output.done event

2019-04-29 Thread Simon Ser
On Monday, April 29, 2019 9:51 AM, Olivier Fourdan wrote: > Hi, > > On Sun, 28 Apr 2019 at 11:19, Simon Ser wrote: > > On Sunday, April 28, 2019 12:04 PM, Olivier Fourdan > > wrote: > > > Humm, I am not sure I like changing xdg-output to rely on another protocol > > > event, it's looks like a

Re: [PATCH wayland-protocols] xdg-output: deprecate the xdg_output.done event

2019-04-29 Thread Olivier Fourdan
Hi, On Sun, 28 Apr 2019 at 11:19, Simon Ser wrote: > On Sunday, April 28, 2019 12:04 PM, Olivier Fourdan wrote: > > Humm, I am not sure I like changing xdg-output to rely on another protocol > > event, it's looks like a weird mixup to me... > > As noted below, this is idiomatic in the Wayland

Re: [PATCH wayland-protocols] xdg-output: deprecate the xdg_output.done event

2019-04-28 Thread Scott Anderson
This commit makes it so a wl_output.done event is guaranteed to be sent with a xdg_output.done event. Humm, I am not sure I like changing xdg-output to rely on another protocol event, it's looks like a weird mixup to me... As noted below, this is idiomatic in the Wayland protocol. The

Re: [PATCH wayland-protocols] xdg-output: deprecate the xdg_output.done event

2019-04-28 Thread Simon Ser
On Sunday, April 28, 2019 12:04 PM, Olivier Fourdan wrote: > Hi, > > On Sat, Apr 27, 2019 at 9:44 AM Simon Ser wrote: > > > This commit makes it so a wl_output.done event is guaranteed to be sent > > with a > > xdg_output.done event. > > Humm, I am not sure I like changing xdg-output to rely on

Re: [PATCH wayland-protocols] xdg-output: deprecate the xdg_output.done event

2019-04-28 Thread Olivier Fourdan
Hi, On Sat, Apr 27, 2019 at 9:44 AM Simon Ser wrote: > This commit makes it so a wl_output.done event is guaranteed to be sent > with a > xdg_output.done event. > Humm, I am not sure I like changing xdg-output to rely on another protocol event, it's looks like a weird mixup to me... > This

[PATCH wayland-protocols] xdg-output: deprecate the xdg_output.done event

2019-04-27 Thread Simon Ser
This commit makes it so a wl_output.done event is guaranteed to be sent with a xdg_output.done event. This protocol change has been discussed in a recent xorg-devel discussions [1]. First let's recap why a change is needed: Xwayland listens to both wl_output and xdg_output changes. When an