Re: [PATCH wayland-protocols v2 11/13] xdg-shell: clarify map/unmap wording

There is already this paragraph added to xdg_toplevel: + Unmapping an xdg_toplevel means that the surface cannot be shown + by the compositor until it is explicitly mapped again. + All active operations (e.g., move, resize) are canceled and all + attributes (e.g. title, state,

Re: [PATCH wayland-protocols v2 11/13] xdg-shell: clarify map/unmap wording

Then I'd like some stronger wording in this patch that dictates that unmapping and remapping a surface by either destroying the xdg_surface or attaching a NULL buffer should be indistinguishable. No "hidden state", either accessible or inaccessible to the app (such as stacking order, window

Re: [PATCH wayland-protocols v2 11/13] xdg-shell: clarify map/unmap wording

On Sun, Jul 16, 2017 at 11:16:25PM -0700, Jasper St. Pierre wrote: > (Coming into this one late) > > When I first wrote xdg-shell, I maintained that attaching a NULL buffer > should be illegal since it has no benefit compared to destroying the > surface, but compositors might not reset all data

Re: [PATCH wayland-protocols v2 11/13] xdg-shell: clarify map/unmap wording

(Coming into this one late) When I first wrote xdg-shell, I maintained that attaching a NULL buffer should be illegal since it has no benefit compared to destroying the surface, but compositors might not reset all data attached to the surface, making a weird exception where clients depend on bugs

Re: [PATCH wayland-protocols v2 11/13] xdg-shell: clarify map/unmap wording

> > The idea is that having unmapped by null-attach means the > xdg_surface/xdg_toplevel etc is reset to the exact same state that it > had when first created, thus to map again, one would do what one would > do the same as when mapping it for the first time: set up the state > (set_title,

Re: [PATCH wayland-protocols v2 11/13] xdg-shell: clarify map/unmap wording

On Tue, Jul 11, 2017 at 11:30:11PM +0100, David Edmundson wrote: > Can you clarify something here. > > >A newly-unmapped surface is considered to have met condition (1) out > + of the 3 required conditions for mapping a surface if its role > surface > + has not been destroyed. > >

Re: [PATCH wayland-protocols v2 11/13] xdg-shell: clarify map/unmap wording

Can you clarify something here. >A newly-unmapped surface is considered to have met condition (1) out + of the 3 required conditions for mapping a surface if its role surface + has not been destroyed. Attaching a null buffer unmaps the surface Unmapping the surface resets the state

[PATCH wayland-protocols v2 11/13] xdg-shell: clarify map/unmap wording

From: Mike Blumenkrantz ensure that this is as precise and explicit as possible for all useful cases and also define previously-unspecified behavior Signed-off-by: Mike Blumenkrantz Reviewed-by: Jonas Ådahl ---