Re: [PATCH wayland 1/2] contributing: add review guidelines

2018-06-19 Thread Emil Velikov
Hi Pekka, On 18 June 2018 at 14:42, Pekka Paalanen wrote: > +- Stable ABI or API is not broken. > + I think I've just caught one of those ;-) Thanks for the vast, yet concise writeup. Fwiw Reviewed-by: Emil Velikov -Emil ___ wayland-devel mailing

Re: [PATCH wayland 1/2] contributing: add review guidelines

2018-06-19 Thread Pekka Paalanen
On Tue, 19 Jun 2018 11:45:24 +0100 Daniel Stone wrote: > Hi Pekka, > > On Mon, 18 Jun 2018 at 14:43, Pekka Paalanen wrote: > > This sets up the standards for patch review, and defines when a patch > > can be merged. I believe these are the practises we have been using > > already for a long

Re: [PATCH wayland 1/2] contributing: add review guidelines

2018-06-19 Thread Daniel Stone
Hi Pekka, On Mon, 18 Jun 2018 at 14:43, Pekka Paalanen wrote: > This sets up the standards for patch review, and defines when a patch > can be merged. I believe these are the practises we have been using > already for a long time, now they are just written down explicitly. > > It's not an

Re: [PATCH wayland 1/2] contributing: add review guidelines

2018-06-18 Thread Matheus Santana
Reviewed-by: Matheus Santana It seems a great starting point. On Mon, Jun 18, 2018 at 10:42 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > This sets up the standards for patch review, and defines when a patch > can be merged. I believe these are the practises we have been using >

[PATCH wayland 1/2] contributing: add review guidelines

2018-06-18 Thread Pekka Paalanen
From: Pekka Paalanen This sets up the standards for patch review, and defines when a patch can be merged. I believe these are the practises we have been using already for a long time, now they are just written down explicitly. It's not an exhaustive list of criteria and likely cannot ever be,