Re: [PATCH weston] clients: fix errno handling

2017-01-19 Thread Daniel Stone
On 18 January 2017 at 22:21, Peter Hutterer wrote: > clients/editor.c: In function ‘read_file’: > clients/editor.c:1578:16: warning: logical ‘or’ applied to non-boolean > constant [-Wlogical-op] > errno = errsv || EINVAL; > > This works in the shell, but not in C.

Re: [PATCH weston] clients: fix errno handling

2017-01-19 Thread Emilio Pozuelo Monfort
On 18/01/17 23:58, Emilio Pozuelo Monfort wrote: > On 18/01/17 23:21, Peter Hutterer wrote: >> clients/editor.c: In function ‘read_file’: >> clients/editor.c:1578:16: warning: logical ‘or’ applied to non-boolean >> constant [-Wlogical-op] >> errno = errsv || EINVAL; >> >> This works in the

Re: [PATCH weston] clients: fix errno handling

2017-01-18 Thread Bryce Harrington
On Thu, Jan 19, 2017 at 08:21:45AM +1000, Peter Hutterer wrote: > clients/editor.c: In function ‘read_file’: > clients/editor.c:1578:16: warning: logical ‘or’ applied to non-boolean > constant [-Wlogical-op] > errno = errsv || EINVAL; > > This works in the shell, but not in C. Introduced in

Re: [PATCH weston] clients: fix errno handling

2017-01-18 Thread Emilio Pozuelo Monfort
On 18/01/17 23:21, Peter Hutterer wrote: > clients/editor.c: In function ‘read_file’: > clients/editor.c:1578:16: warning: logical ‘or’ applied to non-boolean > constant [-Wlogical-op] > errno = errsv || EINVAL; > > This works in the shell, but not in C. Introduced in 411ffabbb56b > >

[PATCH weston] clients: fix errno handling

2017-01-18 Thread Peter Hutterer
clients/editor.c: In function ‘read_file’: clients/editor.c:1578:16: warning: logical ‘or’ applied to non-boolean constant [-Wlogical-op] errno = errsv || EINVAL; This works in the shell, but not in C. Introduced in 411ffabbb56b Signed-off-by: Peter Hutterer ---

Re: [PATCH weston] clients: fix errno handling

2017-01-18 Thread Emilio Pozuelo Monfort
On 18/01/17 01:53, Peter Hutterer wrote: > clients/editor.c: In function ‘read_file’: > clients/editor.c:1578:16: warning: logical ‘or’ applied to non-boolean > constant [-Wlogical-op] > errno = errsv || EINVAL; > > This works in the shell, but not in C. Introduced in 411ffabbb56b > >

[PATCH weston] clients: fix errno handling

2017-01-17 Thread Peter Hutterer
clients/editor.c: In function ‘read_file’: clients/editor.c:1578:16: warning: logical ‘or’ applied to non-boolean constant [-Wlogical-op] errno = errsv || EINVAL; This works in the shell, but not in C. Introduced in 411ffabbb56b Signed-off-by: Peter Hutterer ---