RE: [PATCH weston] shell: End grab if the grabbed shell surface has been destroyed

2013-05-23 Thread Eoff, Ullysses A
From: Eoff, Ullysses A > Sent: Monday, May 20, 2013 8:59 AM > To: Eoff, Ullysses A; Bradford, Robert; wayland-devel@lists.freedesktop.org > Subject: RE: [PATCH weston] shell: End grab if the grabbed shell surface has > been > destroyed > > Nonetheless, this is still a reasona

Re: [PATCH weston] shell: End grab if the grabbed shell surface has been destroyed

2013-05-20 Thread Kristian Høgsberg
On Mon, May 20, 2013 at 12:09:20PM +0100, Rob Bradford wrote: > From: Rob Bradford > > The shell_grab_start function sets up a destroy notification on the > shell surface such that when the shell surface is destroyed the pointer > on the grab to the shell surface is set to NULL. > > We must ther

RE: [PATCH weston] shell: End grab if the grabbed shell surface has been destroyed

2013-05-20 Thread Eoff, Ullysses A
> bounces+ullysses.a.eoff=intel@lists.freedesktop.org] On Behalf Of Eoff, > Ullysses A > Sent: Monday, May 20, 2013 5:59 AM > To: Bradford, Robert; wayland-devel@lists.freedesktop.org > Subject: RE: [PATCH weston] shell: End grab if the grabbed shell surface has > been > destroyed >

RE: [PATCH weston] shell: End grab if the grabbed shell surface has been destroyed

2013-05-20 Thread Eoff, Ullysses A
Eoff, Ullysses A > Subject: Re: [PATCH weston] shell: End grab if the grabbed shell surface has > been > destroyed > > I should add that although I think that this patch fixes the bug, i've > written it by inspection of the code & backtraces only as I was unable > to re

Re: [PATCH weston] shell: End grab if the grabbed shell surface has been destroyed

2013-05-20 Thread Rob Bradford
I should add that although I think that this patch fixes the bug, i've written it by inspection of the code & backtraces only as I was unable to reproduce the issue. Artie, perhaps you could try this and give me a Tested-by if it resolves the problem. Cheers, Rob On 20 May 2013 12:09, Rob Bradfo

[PATCH weston] shell: End grab if the grabbed shell surface has been destroyed

2013-05-20 Thread Rob Bradford
From: Rob Bradford The shell_grab_start function sets up a destroy notification on the shell surface such that when the shell surface is destroyed the pointer on the grab to the shell surface is set to NULL. We must therefore check whether the shell surface is NULL and end the grab if it is. ht