Re: [PATCH weston 03/17] xdg-shell: Document error conditions when popup and surface getters

2015-04-30 Thread Jasper St. Pierre
Oh, nice catch, that's a typo. The expected behavior here is that you cannot change from xdg_surface to xdg_popup or cursor surface or anything. You should be able to destroy and recreate the xdg_surface without destroying the wl_surface. On Thu, Apr 30, 2015 at 7:08 AM, Giulio Camuffo wrote: >

Re: [PATCH weston 03/17] xdg-shell: Document error conditions when popup and surface getters

2015-04-30 Thread Giulio Camuffo
2015-04-07 12:01 GMT+03:00 Jonas Ådahl : > Document that a wl_surface can only be assigned either a xdg_popup or > xdg_surface once and that if the client still stries to do that an error > is raised. > > Signed-off-by: Jonas Ådahl > --- > protocol/xdg-shell.xml | 14 -- > 1 file chan

Re: [PATCH weston 03/17] xdg-shell: Document error conditions when popup and surface getters

2015-04-30 Thread Pekka Paalanen
On Tue, 7 Apr 2015 17:26:46 -0700 Bryce Harrington wrote: > On Tue, Apr 07, 2015 at 05:01:18PM +0800, Jonas Ådahl wrote: > > Document that a wl_surface can only be assigned either a xdg_popup or > > xdg_surface once and that if the client still stries to do that an error > > is raised. > > > > S

Re: [PATCH weston 03/17] xdg-shell: Document error conditions when popup and surface getters

2015-04-07 Thread Bryce Harrington
On Tue, Apr 07, 2015 at 05:01:18PM +0800, Jonas Ådahl wrote: > Document that a wl_surface can only be assigned either a xdg_popup or > xdg_surface once and that if the client still stries to do that an error > is raised. > > Signed-off-by: Jonas Ådahl LGTM, Reviewed-by: Bryce Harrington > --- >

[PATCH weston 03/17] xdg-shell: Document error conditions when popup and surface getters

2015-04-07 Thread Jonas Ådahl
Document that a wl_surface can only be assigned either a xdg_popup or xdg_surface once and that if the client still stries to do that an error is raised. Signed-off-by: Jonas Ådahl --- protocol/xdg-shell.xml | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/prot