Re: [PATCH weston 05/21] libweston: weston_output_init(..., +name)

2017-10-04 Thread Pekka Paalanen
On Wed, 4 Oct 2017 13:47:56 +0100 Daniel Stone wrote: > Hi Pekka, > > On 22 September 2017 at 15:31, Pekka Paalanen wrote: > > * > > * \param output The weston_output object to initialize > > * \param compositor The compositor instance. > >

Re: [PATCH weston 05/21] libweston: weston_output_init(..., +name)

2017-10-04 Thread Daniel Stone
Hi Pekka, On 22 September 2017 at 15:31, Pekka Paalanen wrote: > * > * \param output The weston_output object to initialize > * \param compositor The compositor instance. > + * \param name Name for the output. Please document that @name is duplicated

Re: [PATCH weston 05/21] libweston: weston_output_init(..., +name)

2017-09-26 Thread Hardening
Le 22/09/2017 à 16:31, Pekka Paalanen a écrit : > From: Pekka Paalanen > > Add 'name' argument to weston_output_init(). This is much more obvious > than the assert inside weston_output_init() to ensure the caller has set > a field in weston_output first. > > Now

Re: [PATCH weston 05/21] libweston: weston_output_init(..., +name)

2017-09-25 Thread Ray, Ian (GE Healthcare)
On 22/09/2017, 17.32, "wayland-devel on behalf of Pekka Paalanen" wrote: > > From: Pekka Paalanen > > Add 'name' argument to weston_output_init(). This is much more obvious > than

[PATCH weston 05/21] libweston: weston_output_init(..., +name)

2017-09-22 Thread Pekka Paalanen
From: Pekka Paalanen Add 'name' argument to weston_output_init(). This is much more obvious than the assert inside weston_output_init() to ensure the caller has set a field in weston_output first. Now weston_output_init() will strdup() the name itself, which