On Tue, 27 May 2014 10:47:44 +0300
Pekka Paalanen wrote:
> Hi,
>
> I see you posted a v2 of this patch, but I think my comments below are
> still valid.
>
>
> On Mon, 19 May 2014 18:23:45 +0100
> Neil Roberts wrote:
>
> > diff --git a/src/compositor.c b/src/compositor.c
> > index 574db2d..ea
Hi,
I see you posted a v2 of this patch, but I think my comments below are
still valid.
On Mon, 19 May 2014 18:23:45 +0100
Neil Roberts wrote:
> Previously when an output was unplugged the clients' resources for it
> were left around and if they were used in a request it could cause
> Weston t
Jason Ekstrand writes:
> The destructor passed in here should be 0, why is it ~0? Also, it
> might be a good idea to throw it in a #define or enum for clarity.
The ~0 is meant to signify ‘there is no destructor’, ie, it's a fake
opcode that will never match a request. The reason is that I put th
Jason Ekstrand writes:
> Yeah, these are the wrong semantics. If they specify an output and it
> turns out to be a zombie, we should do nothing. A null output in
> wl_fullscreen_shell.present_surface means "put it somewhere". In the case
> of weston's implementation, it goes on all outputs. W
One more comment
On Mon, May 19, 2014 at 3:04 PM, Jason Ekstrand wrote:
> Neil,
> Looks good except for the two comments below
> --Jason
>
>
> On Mon, May 19, 2014 at 12:23 PM, Neil Roberts wrote:
>
>> Previously when an output was unplugged the clients' resources for it
>> were left around and
Neil,
Looks good except for the two comments below
--Jason
On Mon, May 19, 2014 at 12:23 PM, Neil Roberts wrote:
> Previously when an output was unplugged the clients' resources for it
> were left around and if they were used in a request it could cause
> Weston to access invalid memory. Now wh
Previously when an output was unplugged the clients' resources for it
were left around and if they were used in a request it could cause
Weston to access invalid memory. Now when an output is unplugged the
resources for it are marked as zombies. This is done by setting a
dummy dispatcher and settin
