Re: writing Was: [PATCH weston 1/5] gl-renderer: Rename gl_renderer_create to gl_renderer_display_create

On Wed, May 18, 2016 at 06:33:15PM -0400, Yong Bakos wrote: > Hi, > I'm partly to blame for the bikeshedding on writing, yet believe me, > I'm always asking "is this worth it?", prioritizing corrections/clarity > over mere style judgements, and am definitely sensitive to > everyone's cognitive

Re: writing Was: [PATCH weston 1/5] gl-renderer: Rename gl_renderer_create to gl_renderer_display_create

On Wed, May 18, 2016 at 6:33 PM Yong Bakos wrote: > Hi, > I'm partly to blame for the bikeshedding on writing, yet believe me, > I'm always asking "is this worth it?", prioritizing corrections/clarity > over mere style judgements, and am definitely sensitive to >

Re: writing Was: [PATCH weston 1/5] gl-renderer: Rename gl_renderer_create to gl_renderer_display_create

Hi, I'm partly to blame for the bikeshedding on writing, yet believe me, I'm always asking "is this worth it?", prioritizing corrections/clarity over mere style judgements, and am definitely sensitive to everyone's cognitive bandwidth. My goal is high quality documentation for Wayland, and I am

Re: [PATCH weston 1/5] gl-renderer: Rename gl_renderer_create to gl_renderer_display_create

Thank you all for your clarifications. I'm about to send updated revisions of all patches. I made a rebase and fixed all indentation/alignment issues across all patches. Thanks. On Wed, 18 May 2016 15:31:32 +0100 Daniel Stone wrote: > Hi, > > On 18 May 2016 at 15:25,

Re: [PATCH weston 1/5] gl-renderer: Rename gl_renderer_create to gl_renderer_display_create

Hi, On 18 May 2016 at 15:25, Derek Foreman wrote: > On 18/05/16 08:41 AM, Mike Blumenkrantz wrote: >> In fairness, we'd likely be less short on review bandwidth if the >> majority of that bandwidth was not in use to make/revise trivial >> criticisms such as whitespace

Re: [PATCH weston 1/5] gl-renderer: Rename gl_renderer_create to gl_renderer_display_create

On 18/05/16 08:41 AM, Mike Blumenkrantz wrote: > > > On Wed, May 18, 2016 at 3:51 AM Pekka Paalanen > wrote: > > On Thu, 12 May 2016 17:20:49 +0200 > Miguel Angel Vico > wrote: >

Re: [PATCH weston 1/5] gl-renderer: Rename gl_renderer_create to gl_renderer_display_create

On Wed, May 18, 2016 at 3:51 AM Pekka Paalanen wrote: > On Thu, 12 May 2016 17:20:49 +0200 > Miguel Angel Vico wrote: > > > Thanks Derek. > > > > Inline. > > > > On Thu, 12 May 2016 08:54:26 -0500 > > Derek Foreman wrote: > > >

Re: [PATCH weston 1/5] gl-renderer: Rename gl_renderer_create to gl_renderer_display_create

On Thu, 12 May 2016 17:20:49 +0200 Miguel Angel Vico wrote: > Thanks Derek. > > Inline. > > On Thu, 12 May 2016 08:54:26 -0500 > Derek Foreman wrote: > > > On 11/05/16 10:53 AM, Miguel Angel Vico wrote: > > > Thanks, Yong. > > > > > > Inline.

Re: [PATCH weston 1/5] gl-renderer: Rename gl_renderer_create to gl_renderer_display_create

Thanks Derek. Inline. On Thu, 12 May 2016 08:54:26 -0500 Derek Foreman wrote: > On 11/05/16 10:53 AM, Miguel Angel Vico wrote: > > Thanks, Yong. > > > > Inline. > > > > On Wed, 11 May 2016 09:45:15 -0500 > > Yong Bakos wrote: > > > >> On

Re: [PATCH weston 1/5] gl-renderer: Rename gl_renderer_create to gl_renderer_display_create

On 11/05/16 10:53 AM, Miguel Angel Vico wrote: > Thanks, Yong. > > Inline. > > On Wed, 11 May 2016 09:45:15 -0500 > Yong Bakos wrote: > >> On May 11, 2016, at 7:48 AM, Miguel A. Vico >> wrote: >>> >>> No functional change. This patch only renames

[PATCH weston 1/5] gl-renderer: Rename gl_renderer_create to gl_renderer_display_create

No functional change. This patch only renames gl_renderer_create() to gl_renderer_display_create(), which is something more descriptive of what the function does. Signed-off-by: Miguel A Vico Moya Reviewed-by: James Jones --- src/compositor-drm.c |