Re: [PATCH weston v2 2/2] xwm: support maximizing xwayland windows

2015-01-27 Thread Daniel Stone
Hi, On 9 January 2015 at 18:10, Giulio Camuffo giuliocamu...@gmail.com wrote: + if (maximized != window-maximized_vert window-maximized_horz) { Surely this needs to be: if (maximized != (window-maximized_vert window-maximized_horz))? You could break this out into a separate

Re: [PATCH weston v2 2/2] xwm: support maximizing xwayland windows

2015-01-27 Thread Giulio Camuffo
2015-01-27 17:28 GMT+02:00 Daniel Stone dan...@fooishbar.org: Hi, On 9 January 2015 at 18:10, Giulio Camuffo giuliocamu...@gmail.com wrote: + if (maximized != window-maximized_vert window-maximized_horz) { Surely this needs to be: if (maximized != (window-maximized_vert

[PATCH weston v2 2/2] xwm: support maximizing xwayland windows

2015-01-09 Thread Giulio Camuffo
This patch adds the maximize button to the window frame for the windows which set the MWM_DECOR_MAXIMIZE hint, and it wires it with the shell via a new method in weston_shell_interface. Additionally, it also listens for the wm hints coming from the client, but it doesn't support maximizing a