Re: [PATCH xwayland 3/3] Check if the frame exists before reading its size

2013-12-03 Thread Kristian Høgsberg
On Fri, Nov 15, 2013 at 11:24:03AM +0100, Axel Davy wrote: > You were faster than me! > > I was just about sending this very same patch. > > The patch is correct as I was explaining in my commit message: > "XWayland: Don't access the frame field for unmapped windows. > > There are situations

Re: [PATCH xwayland 3/3] Check if the frame exists before reading its size

2013-11-21 Thread Kristian Høgsberg
On Fri, Nov 15, 2013 at 02:02:23AM -0800, Dima Ryazanov wrote: > This fixes crashes caused by popup windows that don't have override_redirect > (e.g., menus in VLC and KDE apps), though I don't know if this is correct. > > Signed-off-by: Dima Ryazanov > --- > src/xwayland/window-manager.c | 4 ++

Re: [PATCH xwayland 3/3] Check if the frame exists before reading its size

2013-11-15 Thread Axel Davy
You were faster than me! I was just about sending this very same patch. The patch is correct as I was explaining in my commit message: "XWayland: Don't access the frame field for unmapped windows. There are situations where weston_wm_window_get_frame_size and weston_wm_window_get_child_

[PATCH xwayland 3/3] Check if the frame exists before reading its size

2013-11-15 Thread Dima Ryazanov
This fixes crashes caused by popup windows that don't have override_redirect (e.g., menus in VLC and KDE apps), though I don't know if this is correct. Signed-off-by: Dima Ryazanov --- src/xwayland/window-manager.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/xwayl