Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

Hi Carlos, thanks for reviewing! On Tue, 17 Jul 2018 19:18:36 +0200 Carlos Garnacho wrote: > Hi!, > > (Way way late, trying to revive the conversation...) > > On Thu, May 3, 2018 at 9:22 PM, Dorota Czaplejewicz > wrote: > > On Thu, 3 May 2018 20:47:27 +0200 > > Silvan Jegen wrote: > > >

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

Hi!, (Way way late, trying to revive the conversation...) On Thu, May 3, 2018 at 9:22 PM, Dorota Czaplejewicz wrote: > On Thu, 3 May 2018 20:47:27 +0200 > Silvan Jegen wrote: > >> Hi Dorota >> >> Some comments and typo fixes below. >> >> On Thu, May 03, 2018 at 05:41:21PM +0200, Dorota

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

On Thu, 17 May 2018 18:05:34 +0100 Daniel Stone wrote: > Hi Dorota, > > On 3 May 2018 at 16:41, Dorota Czaplejewicz > wrote: > > - There is no event to send keysyms. Compositors can use wl_keyboard > > interface instead. > > The reason

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

On Thu, May 10, 2018 at 11:46:32AM +0200, Dorota Czaplejewicz wrote: > On Thu, 10 May 2018 11:43:12 +0200 > Dorota Czaplejewicz wrote: > > > On Tue, 08 May 2018 07:07:24 + > > Silvan Jegen wrote: > > > > > On Mon, May 7, 2018 at 5:11 AM

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

On Thu, 10 May 2018 11:43:12 +0200 Dorota Czaplejewicz wrote: > On Tue, 08 May 2018 07:07:24 + > Silvan Jegen wrote: > > > On Mon, May 7, 2018 at 5:11 AM Joshua Watt wrote: > > > IMHO, if you are doing UTF-8 (which

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

On Tue, 08 May 2018 07:07:24 + Silvan Jegen wrote: > On Mon, May 7, 2018 at 5:11 AM Joshua Watt wrote: > > IMHO, if you are doing UTF-8 (which you should), you should *always* > > specify any offset in the string as a byte offset. I have a few > >

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

On Mon, May 7, 2018 at 5:11 AM Joshua Watt wrote: > IMHO, if you are doing UTF-8 (which you should), you should *always* > specify any offset in the string as a byte offset. I have a few > reasons for this justification: I agree with this as well. I thought some more about

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

On Sun, May 06, 2018 at 10:37:57PM +0200, Dorota Czaplejewicz wrote: > On Sat, 5 May 2018 13:37:44 +0200 > Silvan Jegen wrote: > > > On Sat, May 05, 2018 at 11:09:10AM +0200, Dorota Czaplejewicz wrote: > > > On Fri, 4 May 2018 22:32:15 +0200 > > > Silvan Jegen

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

On Sun, 6 May 2018 22:11:32 -0500 Joshua Watt wrote: > On Sun, May 6, 2018 at 3:37 PM, Dorota Czaplejewicz > wrote: > > On Sat, 5 May 2018 13:37:44 +0200 > > Silvan Jegen wrote: > > > >> On Sat, May 05, 2018 at 11:09:10AM

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

On Sun, May 6, 2018 at 3:37 PM, Dorota Czaplejewicz wrote: > On Sat, 5 May 2018 13:37:44 +0200 > Silvan Jegen wrote: > >> On Sat, May 05, 2018 at 11:09:10AM +0200, Dorota Czaplejewicz wrote: >> > On Fri, 4 May 2018 22:32:15 +0200 >> > Silvan Jegen

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

On Sat, 5 May 2018 13:37:44 +0200 Silvan Jegen wrote: > On Sat, May 05, 2018 at 11:09:10AM +0200, Dorota Czaplejewicz wrote: > > On Fri, 4 May 2018 22:32:15 +0200 > > Silvan Jegen wrote: > > > > > On Thu, May 03, 2018 at 10:46:47PM +0200, Dorota

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

On Sat, May 05, 2018 at 11:09:10AM +0200, Dorota Czaplejewicz wrote: > On Fri, 4 May 2018 22:32:15 +0200 > Silvan Jegen wrote: > > > On Thu, May 03, 2018 at 10:46:47PM +0200, Dorota Czaplejewicz wrote: > > > On Thu, 3 May 2018 21:55:40 +0200 > > > Silvan Jegen

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

On Fri, 4 May 2018 22:32:15 +0200 Silvan Jegen wrote: > On Thu, May 03, 2018 at 10:46:47PM +0200, Dorota Czaplejewicz wrote: > > On Thu, 3 May 2018 21:55:40 +0200 > > Silvan Jegen wrote: > > > > > On Thu, May 03, 2018 at 09:22:46PM +0200, Dorota

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

On Thu, May 03, 2018 at 10:46:47PM +0200, Dorota Czaplejewicz wrote: > On Thu, 3 May 2018 21:55:40 +0200 > Silvan Jegen wrote: > > > On Thu, May 03, 2018 at 09:22:46PM +0200, Dorota Czaplejewicz wrote: > > > On Thu, 3 May 2018 20:47:27 +0200 > > > Silvan Jegen

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

On Thu, 3 May 2018 21:55:40 +0200 Silvan Jegen wrote: > On Thu, May 03, 2018 at 09:22:46PM +0200, Dorota Czaplejewicz wrote: > > On Thu, 3 May 2018 20:47:27 +0200 > > Silvan Jegen wrote: > > > > > Hi Dorota > > > > > > Some comments and typo fixes

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

On Thu, May 03, 2018 at 09:22:46PM +0200, Dorota Czaplejewicz wrote: > On Thu, 3 May 2018 20:47:27 +0200 > Silvan Jegen wrote: > > > Hi Dorota > > > > Some comments and typo fixes below. > > > > On Thu, May 03, 2018 at 05:41:21PM +0200, Dorota Czaplejewicz wrote: > > > This

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

On Thu, 3 May 2018 20:47:27 +0200 Silvan Jegen wrote: > Hi Dorota > > Some comments and typo fixes below. > > On Thu, May 03, 2018 at 05:41:21PM +0200, Dorota Czaplejewicz wrote: > > This new protocol description is a simplification over v2. > > > > - All pre-edit text

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

Hi Dorota Some comments and typo fixes below. On Thu, May 03, 2018 at 05:41:21PM +0200, Dorota Czaplejewicz wrote: > This new protocol description is a simplification over v2. > > - All pre-edit text styling is gone. > - Pre-edit cursor can span characters. > - No events regarding input panel

[PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

From: Carlos Garnacho This new protocol description is a simplification over v2. - All pre-edit text styling is gone. - Pre-edit cursor can span characters. - No events regarding input panel (OSK) state nor covered rectangle. Compositors are still free to handle situations