Re: [PATCH libinput] tablet: invert tilt axes when left-handed is enabled

2016-01-03 Thread Peter Hutterer
On Mon, Dec 21, 2015 at 02:44:03PM -0800, Bill Spitzak wrote: > On Mon, Dec 21, 2015 at 1:24 PM, Peter Hutterer > wrote: > > > On Mon, Dec 21, 2015 at 10:12:24AM -0800, Bill Spitzak wrote: > > > I find it hard to believe this is what client programs will want. A > > >

Re: [PATCH libinput] tablet: invert tilt axes when left-handed is enabled

2015-12-23 Thread Bill Spitzak
On Mon, Dec 21, 2015 at 1:24 PM, Peter Hutterer wrote: > On Mon, Dec 21, 2015 at 10:12:24AM -0800, Bill Spitzak wrote: > > I find it hard to believe this is what client programs will want. A > > painting program wants the axis of an elongated brush to be perpendicular

Re: [PATCH libinput] tablet: invert tilt axes when left-handed is enabled

2015-12-23 Thread Bill Spitzak
I find it hard to believe this is what client programs will want. A painting program wants the axis of an elongated brush to be perpendicular to the tilt will work correctly only if *both* axes are flipped (as your code appears to be doing). But it will get "which edge is nearer" backward if it

Re: [PATCH libinput] tablet: invert tilt axes when left-handed is enabled

2015-12-22 Thread Hans de Goede
Hi, On 12/21/2015 02:46 AM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer Looks good to me: Reviewed-by: Hans de Goede Regards, Hans --- src/evdev-tablet.c | 4 test/tablet.c | 38 ++

Re: [PATCH libinput] tablet: invert tilt axes when left-handed is enabled

2015-12-21 Thread Peter Hutterer
On Mon, Dec 21, 2015 at 10:12:24AM -0800, Bill Spitzak wrote: > I find it hard to believe this is what client programs will want. A > painting program wants the axis of an elongated brush to be perpendicular > to the tilt will work correctly only if *both* axes are flipped (as your > code appears