Re: [PATCH] wl_shell: Add surface state changed event

2013-05-20 Thread Pekka Paalanen
On Wed, 15 May 2013 11:37:19 -0700 Mikko Levonmaa mikko.levon...@gmail.com wrote: On Wed, May 15, 2013 at 12:12:43PM -0500, Jason Ekstrand wrote: On Wed, May 15, 2013 at 9:39 AM, Mikko Levonmaa mikko.levon...@gmail.com wrote: This allows the shell to inform the surface that it has

Re: [PATCH 1/2] protocol: Allow output changes to be treated atomically

2013-05-20 Thread Pekka Paalanen
On Thu, 16 May 2013 15:49:35 +0200 al...@redhat.com wrote: From: Alexander Larsson al...@redhat.com This add a wl_output.done event which is send after every group of events caused by some property change. This allows clients to treat changes touching multiple events in an atomic fashion.

Re: [PATCH 2/2] protocol: Support scaled outputs and surfaces

2013-05-20 Thread Pekka Paalanen
Hi Alexander, nice to see this going forward, and sorry for replying so rarely and late. On Thu, 16 May 2013 15:49:36 +0200 al...@redhat.com wrote: From: Alexander Larsson al...@redhat.com This adds the wl_surface.set_buffer_scale request, and a wl_output.scale event. These together lets

Re: [PATCH 2/2] protocol: Support scaled outputs and surfaces

2013-05-20 Thread Pekka Paalanen
On Thu, 16 May 2013 16:43:52 -0500 Jason Ekstrand ja...@jlekstrand.net wrote: The point of this soi is to allow surfaces to render the same size on different density outputs. Are you serious? Really? Same size measured in meters? I do not think that will ever work:

Re: [PATCH 2/2] protocol: Support scaled outputs and surfaces

2013-05-20 Thread Pekka Paalanen
On Fri, 17 May 2013 12:06:35 -0700 Bill Spitzak spit...@gmail.com wrote: Alexander Larsson wrote: You can make a surface of any integer size (and it has to be integer due to existing APIs on surface coordinates/sizes), however the *buffer* has to be an integer multiple of the surface

[PATCH weston] shell: End grab if the grabbed shell surface has been destroyed

2013-05-20 Thread Rob Bradford
From: Rob Bradford r...@linux.intel.com The shell_grab_start function sets up a destroy notification on the shell surface such that when the shell surface is destroyed the pointer on the grab to the shell surface is set to NULL. We must therefore check whether the shell surface is NULL and end

Re: [PATCH weston] shell: End grab if the grabbed shell surface has been destroyed

2013-05-20 Thread Rob Bradford
I should add that although I think that this patch fixes the bug, i've written it by inspection of the code backtraces only as I was unable to reproduce the issue. Artie, perhaps you could try this and give me a Tested-by if it resolves the problem. Cheers, Rob On 20 May 2013 12:09, Rob

RE: [PATCH weston] shell: End grab if the grabbed shell surface has been destroyed

2013-05-20 Thread Eoff, Ullysses A
Rob, I tried this same local modification on Friday... it seems to fix Weston from segfaulting. However, I have another test case that triggered this problem, too; only it crashes on the client-side as well. The client-side crash did not disappear with this Weston modification, which indicates

[PATCH weston] weston-launch: Print explanation of why we failed to open the device

2013-05-20 Thread Rob Bradford
From: Rob Bradford r...@linux.intel.com --- src/weston-launch.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/weston-launch.c b/src/weston-launch.c index 89c3c5a..42b2506 100644 --- a/src/weston-launch.c +++ b/src/weston-launch.c @@ -320,12 +320,17 @@

RE: [PATCH weston] shell: End grab if the grabbed shell surface has been destroyed

2013-05-20 Thread Eoff, Ullysses A
Nonetheless, this is still a reasonable patch that can be applied to solve part of the problem... that is, it prevents Weston from crashing. -Original Message- From: wayland-devel-bounces+ullysses.a.eoff=intel@lists.freedesktop.org [mailto:wayland-devel-

[PATCH weston] udev-seat: Fail seat setup only if the seat is incomplete

2013-05-20 Thread Rob Bradford
From: Rob Bradford r...@linux.intel.com Rather than failing seat setup if we fail to open the input device instead fail the seat setup if we don't have complete seat with both keyboard and pointer or a touchscreen. https://bugs.freedesktop.org/show_bug.cgi?id=64506 --- src/udev-seat.c | 10

Re: [PATCH 2/2] protocol: Support scaled outputs and surfaces

2013-05-20 Thread Jason Ekstrand
On Mon, May 20, 2013 at 4:00 AM, Pekka Paalanen ppaala...@gmail.com wrote: On Thu, 16 May 2013 16:43:52 -0500 Jason Ekstrand ja...@jlekstrand.net wrote: The point of this soi is to allow surfaces to render the same size on different density outputs. Are you serious? Really? Same size

Re: [PATCH weston] shell: End grab if the grabbed shell surface has been destroyed

2013-05-20 Thread Kristian Høgsberg
On Mon, May 20, 2013 at 12:09:20PM +0100, Rob Bradford wrote: From: Rob Bradford r...@linux.intel.com The shell_grab_start function sets up a destroy notification on the shell surface such that when the shell surface is destroyed the pointer on the grab to the shell surface is set to NULL.

Re: [PATCH weston] weston-launch: Print explanation of why we failed to open the device

2013-05-20 Thread Kristian Høgsberg
On Mon, May 20, 2013 at 04:55:10PM +0100, Rob Bradford wrote: From: Rob Bradford r...@linux.intel.com That's better, though I wonder if we should instead let weston log the error message using weston_log()... committed this for now. Kristian --- src/weston-launch.c | 7 ++- 1 file

Re: [PATCH weston] udev-seat: Fail seat setup only if the seat is incomplete

2013-05-20 Thread Kristian Høgsberg
On Mon, May 20, 2013 at 05:55:03PM +0100, Rob Bradford wrote: From: Rob Bradford r...@linux.intel.com Rather than failing seat setup if we fail to open the input device instead fail the seat setup if we don't have complete seat with both keyboard and pointer or a touchscreen.

Re: [PATCH] configure.ac: colord version to 0.1.27

2013-05-20 Thread Kristian Høgsberg
On Sat, May 18, 2013 at 10:08:17PM +0900, Mun, Gwan-gyeong wrote: This patch fixes colord version check on confiure.ac file. Weston uses CD_PROFILE_METADATA_SCREEN_BRIGHTNESS, CD_DEVICE_PROPERTY_EMBEDDED colord macros. But weston checks colord old version. ( 0.1.8)

Re: [PATCH weston 1/6] protocol: improve sub-surface spec wording

2013-05-20 Thread Kristian Høgsberg
On Mon, May 20, 2013 at 08:33:53AM +0300, Pekka Paalanen wrote: On Fri, 17 May 2013 16:20:48 -0400 Kristian Høgsberg hoegsb...@gmail.com wrote: On Fri, May 17, 2013 at 04:46:03PM +0300, ppaala...@gmail.com wrote: From: Pekka Paalanen ppaala...@gmail.com Mention, that sub-surfaces

Re: [PATCH 2/2] protocol: Support scaled outputs and surfaces

2013-05-20 Thread Bill Spitzak
Pekka Paalanen wrote: This seems pretty limiting to me. What happens when *all* the outputs are hi-res? You really think wayland clients should not be able to take full advantage of this? Then the individual pixels are so small that it won't matter. It does not matter how tiny the pixels

Re: [RFC] libinputmapper: Input device configuration for graphic-servers

2013-05-20 Thread Peter Hutterer
On Thu, May 16, 2013 at 08:38:44AM -0400, Todd Showalter wrote: On Thu, May 16, 2013 at 1:37 AM, Peter Hutterer peter.hutte...@who-t.net wrote: why are gamepads and joysticks different? buttons, a few axes that may or may not map to x/y and the rest is device-specific. this may be in the

Re: [RFC] libinputmapper: Input device configuration for graphic-servers

2013-05-20 Thread Peter Hutterer
On Thu, May 16, 2013 at 03:16:11PM +0200, David Herrmann wrote: Hi Peter On Thu, May 16, 2013 at 7:37 AM, Peter Hutterer peter.hutte...@who-t.net wrote: On Sun, May 12, 2013 at 04:20:59PM +0200, David Herrmann wrote: [..] So what is the proposed solution? My recommendation is, that