[PATCH weston] desktop-shell: Stop asking for a RGB565 background

2017-01-15 Thread Emmanuel Gil Peyrot
This makes the background image look much nicer, at the expense of slightly more memory bandwidth used. Signed-off-by: Emmanuel Gil Peyrot --- clients/desktop-shell.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/clients/desktop-shell.c b/clients/desktop-shell.c

Re: [PATCH weston] desktop-shell: Stop asking for a RGB565 background

2017-01-15 Thread Quentin Glidic
On 15/01/2017 18:54, Emmanuel Gil Peyrot wrote: This makes the background image look much nicer, at the expense of slightly more memory bandwidth used. Signed-off-by: Emmanuel Gil Peyrot I see no reason not to: Reviewed-by: Quentin Glidic

[PATCH weston v2] editor: Drop g_type_init() call

2017-01-15 Thread Quentin Glidic
From: Quentin Glidic HAVE_PANGO is not in any AC_DEFINE(), so the check is just wrong. g_type_init() was never called, which is fine since GLib 2.36 anyway. It is better not to have a wrong usage of HAVE_PANGO here. Just check for GLib 2.36 in configure.ac instead.

Re: [PATCH weston v2 07/24] desktop-shell: debug set_position_from_xwayland

2017-01-15 Thread Quentin Glidic
On 21/12/2016 15:40, Pekka Paalanen wrote: From: Pekka Paalanen Helps tracking what happens with XWM. Use the same debugging guard as XWM. Signed-off-by: Pekka Paalanen Seems good: Reviewed-by: Quentin Glidic

Re: [PATCH weston v2 13/24] xwm: debug changes to override-redirect flag

2017-01-15 Thread Quentin Glidic
On 21/12/2016 15:40, Pekka Paalanen wrote: From: Pekka Paalanen For every event we handle and that delivers the override-redirect flag, print it to debug log. Add a comment to one code path explaining when it gets hit, because it is unobvious. It also serves as

Re: [PATCH] configure: search for lib with clock_getres()

2017-01-15 Thread Yann E. MORIN
Quentin, All, On 2017-01-15 13:51 +0100, Quentin Glidic spake thusly: > On 19/12/2016 18:20, Yann E. MORIN wrote: > >Like clock_gettime(), clock_getres() is in -lrt for glibc < 2.17. > >Add a check for it, like is done for clock_gettime(). > > > >Fixes: > > > >

Re: [PATCH weston v2 15/24] xwm: postpone geometry dirtying from pending.opaque

2017-01-15 Thread Quentin Glidic
On 21/12/2016 15:40, Pekka Paalanen wrote: From: Pekka Paalanen Changing the opaque region has no immediate effect, therefore there is no need to mark the view geometry dirty. The view geometry will be invalidated automatically by the next commit from Xwayland,

Re: [PATCH RFC weston 3/4] compositor-x11: Remove support for ancient XCB

2017-01-15 Thread Quentin Glidic
On 29/11/2016 18:00, Daniel Stone wrote: We had two non-pkg-config check paths in the configure script, to support XCB functionality used before XCB had had an accompanying release: xcb_poll_for_queued_event (released in 1.8, 2012), and a usable XKB event mechanism (released in 1.9, 2013).

Re: [PATCH weston v2 08/24] libweston-desktop/xwayland: debug commits

2017-01-15 Thread Quentin Glidic
On 21/12/2016 15:40, Pekka Paalanen wrote: From: Pekka Paalanen Helps tracking what happens with XWM. Use the same debugging guard as XWM. Signed-off-by: Pekka Paalanen Seems good: Reviewed-by: Quentin Glidic

Re: [PATCH weston v2 01/24] xwayland: WM debug prints

2017-01-15 Thread Quentin Glidic
On 21/12/2016 15:39, Pekka Paalanen wrote: From: Pekka Paalanen Add WM debug prints on map, decoration drawing and geometry setting. These help see the sequence and timing of operations, when debugging Xwayland window management glitches. Signed-off-by: Pekka

Re: [PATCH weston v2 16/24] xwm: delete dead flags from weston_wm_window_draw_decorations()

2017-01-15 Thread Quentin Glidic
On 21/12/2016 15:40, Pekka Paalanen wrote: From: Pekka Paalanen Obviously unused. Looks like weston_wm_window_activate() is doing that job. Signed-off-by: Pekka Paalanen Trivial: Reviewed-by: Quentin Glidic

Re: [PATCH weston v2 09/24] xwm: detect legacy fullscreen on MapRequest

2017-01-15 Thread Quentin Glidic
On 21/12/2016 15:40, Pekka Paalanen wrote: From: Pekka Paalanen The legacy fullscreen state needs to be detected at MapRequest time, because that is when the X11 client has alredy set up the initial window state. Doing it at xserver_map_shell_surface() meant

Re: [PATCH weston v2 12/24] xwm: move set_title and set_pid

2017-01-15 Thread Quentin Glidic
On 21/12/2016 15:40, Pekka Paalanen wrote: From: Pekka Paalanen Move the calls to set_title() and set_pid() out of weston_wm_window_read_properties() and into the three callers, each slightly different. xserver_map_shell_surface(): already calls these functions

Re: [PATCH weston v2 11/24] xwm: move frame_set_title() into draw_decoration()

2017-01-15 Thread Quentin Glidic
On 21/12/2016 15:40, Pekka Paalanen wrote: From: Pekka Paalanen The only thing using the frame title is frame_repaint(). Move the call to frame_set_title() from weston_wm_window_read_properties() into weston_wm_window_draw_decoration() where the only call to

Re: [PATCH] configure: search for lib with clock_getres()

2017-01-15 Thread Quentin Glidic
On 19/12/2016 18:20, Yann E. MORIN wrote: Like clock_gettime(), clock_getres() is in -lrt for glibc < 2.17. Add a check for it, like is done for clock_gettime(). Fixes: http://autobuild.buildroot.net/results/bce/bcecdbbce4a99eb1e9bfbf519857bf94d8952037/ Signed-off-by: "Yann E. MORIN"

Re: [PATCH weston v2 10/24] xwm: clarify props[] in weston_wm_window_read_properties()

2017-01-15 Thread Quentin Glidic
On 21/12/2016 15:40, Pekka Paalanen wrote: From: Pekka Paalanen The props array contained offsets to struct members. It is convenient for writing static const arrays as you only store a constant offset and compute the pointer later. However, the array was not

Re: [PATCH weston v2 14/24] xwm: debug print deleted property name

2017-01-15 Thread Quentin Glidic
On 21/12/2016 15:40, Pekka Paalanen wrote: From: Pekka Paalanen Use wm_log_continue() to avoid printing the timestamp in the middle of a message. Print the name of the property that got deleted. Signed-off-by: Pekka Paalanen

[ANNOUNCE] libinput 1.5.902

2017-01-15 Thread Peter Hutterer
The second RC for libinput 1.6 is now available. I merged quite a few changes in the test/ directory, so here's a second RC just in case I accidentally broke the build somewhere. The changes look big in pure diff but they're mostly renames for files. I have a whole bunch of test cases waiting for