Re: [PATCH weston v2] build: honour libinput header location

2018-03-16 Thread Pekka Paalanen
On Thu, 15 Mar 2018 14:01:28 + Daniel Stone wrote: > Hi, > > On 15 March 2018 at 13:45, Emil Velikov wrote: > > Add the respective CFLAGS to the build, otherwise it will error out as > > seen below. > > > > src/libinput-seat.c:30:22: fatal

Re: wl_buffer is not released for long time.

2018-03-16 Thread Pekka Paalanen
On Thu, 15 Mar 2018 15:44:18 + Sichem Zhou wrote: > Hi, > > Sorry for the trouble, I forgot to ask that is it safe to call > `wl_display_flush` and `wl_display_dispatch` in different threads? Hi, if you use threads, then you need to be using the prepare_read API of

Re: [PATCH wayland] configure.ac: don't install the static libraries

2018-03-16 Thread Pekka Paalanen
On Wed, 14 Mar 2018 19:00:22 +1000 Peter Hutterer wrote: > On Tue, Mar 13, 2018 at 01:43:37PM +, Emil Velikov wrote: > > From: Emil Velikov > > > > One should always be using the shared libraries. > > > > Spotted while going through

Re: compositor: do not free output region twice in weston_output_set_transform()

2018-03-16 Thread Pekka Paalanen
On Wed, 14 Mar 2018 10:59:52 +0200 Ilia Bozhinov wrote: > This is already done when weston_output_init_geometry() is called. > Actually this is a fix for 8564a0d, because without this patch, the > compositor sometimes crashes when setting output transform > > Signed-off-by:

Re: [PATCH] configure.ac: fix have_dbus if dbus support is disabled

2018-03-16 Thread Pekka Paalanen
On Wed, 14 Mar 2018 10:07:47 +0100 Michael Tretter wrote: > If dbus support is explicitly disabled, $have_dbus should be no, but was > empty. systemd-login support depends on dbus, but the check does not > trigger correctly, if $have_dbus is empty. > > Signed-off-by:

Re: [PATCH wayland-protcols v2] unstable: add xdg-toplevel-decoration protocol

2018-03-16 Thread Emil Velikov
On 15 March 2018 at 15:43, Simon Ser wrote: > On March 15, 2018 4:15 PM, Emil Velikov wrote: >> On 2 March 2018 at 15:33, Simon Ser wrote: >> > This adds a new protocol to negotiate server- and client-side rendering of >> >

Re: [PATCH wayland v3 1/3] wayland-egl: fail the symbol check if lib is missing

2018-03-16 Thread Emil Velikov
On 16 March 2018 at 13:52, Pekka Paalanen wrote: > On Thu, 15 Mar 2018 14:30:27 + > Emil Velikov wrote: > >> From: Emil Velikov >> >> Based on a similar patch (in Mesa) by Eric Engestrom. >> >> v2: Rebase on top of

[PATCH wayland] wayland-egl: set the correct path to libwayland-egl.so

2018-03-16 Thread Emil Velikov
From: Emil Velikov Earlier commit changed to passing the binary name as env. variable introducing a typo. That went unnoticed, since we do not check if the file is present or not. Cc: Pukka Paalanen Cc: Daniel Stone

Re: [PATCH weston v2] configure.ac: fixup systemd/systemd-login detection

2018-03-16 Thread Emil Velikov
On 15 March 2018 at 17:23, Michael Tretter wrote: > On Thu, 15 Mar 2018 14:20:21 +, Emil Velikov wrote: >> From: Emil Velikov >> >> Current systemd/systemd-login integration requires dbus. Although that >> is far from clear the way

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

2018-03-16 Thread Pekka Paalanen
On Wed, 14 Mar 2018 06:41:53 -0400 Simon Ser wrote: > On March 14, 2018 10:22 AM, Peter Hutterer wrote: > > sorry about the delay, but better late than too late ;) > > No problem, thanks for your review! > > > On Sun, Mar 11, 2018 at 05:53:42PM

Re: [PATCH wayland v3 1/3] wayland-egl: fail the symbol check if lib is missing

2018-03-16 Thread Daniel Stone
Hi Emil, On 15 March 2018 at 14:30, Emil Velikov wrote: > Based on a similar patch (in Mesa) by Eric Engestrom. > > v2: Rebase on top of $NM patch > v3: Rebase > > Reviewed-by: Eric Engestrom (v1) > Signed-off-by: Emil Velikov

Re: [PATCH weston v2 1/1] Allow simple-dmabuf-drm to pass y_inverted flag

2018-03-16 Thread Pekka Paalanen
On Fri, 16 Mar 2018 13:18:42 +0100 Guido Günther wrote: > On Fri, Mar 16, 2018 at 01:55:41PM +0200, Pekka Paalanen wrote: > > On Thu, 15 Mar 2018 17:34:55 +0100 > > Guido Günther wrote: > > > > > This allows to check if

Re: [PATCH weston] .gitignore weston-simple-dmabuf-drm

2018-03-16 Thread Pekka Paalanen
On Fri, 16 Mar 2018 13:12:41 +0100 Guido Günther wrote: > Got renamed in f9dec67990a54afe14d4d2db694bf696ae418bcd > > Signed-off-by: Guido Günther > --- > .gitignore | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.gitignore

Re: [PATCH weston v2 1/1] Allow simple-dmabuf-drm to pass y_inverted flag

2018-03-16 Thread Guido Günther
On Fri, Mar 16, 2018 at 01:55:41PM +0200, Pekka Paalanen wrote: > On Thu, 15 Mar 2018 17:34:55 +0100 > Guido Günther wrote: > > > This allows to check if ZWP_LINUX_BUFFER_PARAMS_V1_FLAGS_Y_INVERT is > > interpreted correctly by the compositor. > > --- > >

[PATCH weston] .gitignore weston-simple-dmabuf-drm

2018-03-16 Thread Guido Günther
Got renamed in f9dec67990a54afe14d4d2db694bf696ae418bcd Signed-off-by: Guido Günther --- .gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index ac76fd9f..661f4882 100644 --- a/.gitignore +++ b/.gitignore @@ -67,7 +67,7 @@

Re: [PATCH v2] xwm: Update input region on resize

2018-03-16 Thread Pekka Paalanen
On Tue, 13 Mar 2018 21:22:04 -0600 Scott Moreau wrote: > Commit 332d1892 introduced a bug because the window was > shaped only when the frame was created, leaving the input > region unchanged regardless if the window was resized. > This patch updates the input region shape on

[PATCH weston 0/3] Allow simple-dmabuf-drm to pass y_inverted flag and cleanups

2018-03-16 Thread Guido Günther
Changes from v2 - Explain OPT_* usage - Switch is_immediate to OPT_* - use getopt_long Changes from v1 - introduce opts as a bitmask of features that can be used to manipulate the displayed image Guido Günther (3): Allow simple-dmabuf-drm to pass y_inverted flag simple-dmabuf-drm:

[PATCH weston v3 1/3] Allow simple-dmabuf-drm to pass y_inverted flag

2018-03-16 Thread Guido Günther
This allows to check if ZWP_LINUX_BUFFER_PARAMS_V1_FLAGS_Y_INVERT is interpreted correctly by the compositor. We introduce an OPT_* bitmask to hold this flag and possible future command line flags. Signed-off-by: Guido Günther --- clients/simple-dmabuf-drm.c | 31

[PATCH weston v3 2/3] simple-dmabuf-drm: use opt bitmask instead of is_immediate

2018-03-16 Thread Guido Günther
Signed-off-by: Guido Günther --- clients/simple-dmabuf-drm.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index 1789db73..427597ab 100644 --- a/clients/simple-dmabuf-drm.c +++

[PATCH weston v3 3/3] simple-dmabuf-drm: use getopt_long

2018-03-16 Thread Guido Günther
Signed-off-by: Guido Günther --- clients/simple-dmabuf-drm.c | 51 - 1 file changed, 27 insertions(+), 24 deletions(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index 427597ab..4f26e4a9 100644 ---

[PATCH weston 0/3] Allow simple-dmabuf-drm to pass y_inverted flag and cleanups

2018-03-16 Thread Guido Günther
Changes from v2 - Explain OPT_* usage - Switch is_immediate to OPT_* - use getopt_long Changes from v1 - introduce opts as a bitmask of features that can be used to manipulate the displayed image Guido Günther (3): Allow simple-dmabuf-drm to pass y_inverted flag simple-dmabuf-drm:

Re: [PATCH v2] xwm: Update input region on resize

2018-03-16 Thread Scott Moreau
Hi Pekka, On Fri, Mar 16, 2018 at 9:20 AM, Pekka Paalanen wrote: > On Tue, 13 Mar 2018 21:22:04 -0600 > Scott Moreau wrote: > > > Commit 332d1892 introduced a bug because the window was > > shaped only when the frame was created, leaving the input > >

[PATCH weston] Add a missing error check to weston_wm_handle_icon

2018-03-16 Thread Dima Ryazanov
This fixes a crash when launching Duke Nukem Forever. (Sorry, I wish I had a less ridiculous test case...) Signed-off-by: Dima Ryazanov --- xwayland/window-manager.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xwayland/window-manager.c b/xwayland/window-manager.c

Re: [PATCH wayland v3 1/3] wayland-egl: fail the symbol check if lib is missing

2018-03-16 Thread Pekka Paalanen
On Thu, 15 Mar 2018 14:30:27 + Emil Velikov wrote: > From: Emil Velikov > > Based on a similar patch (in Mesa) by Eric Engestrom. > > v2: Rebase on top of $NM patch > v3: Rebase > > Reviewed-by: Eric Engestrom (v1)

Re: [PATCH weston v2 1/4] simple-dmabuf-drm: allow multiple backends

2018-03-16 Thread Pekka Paalanen
On Thu, 15 Mar 2018 17:33:18 +0100 Guido Günther wrote: > This allows to enable freedreno and intel backends at the same time > building the prerequisites for adding further ones. > --- > Makefile.am | 5 - > clients/simple-dmabuf-drm.c | 53 >

Re: [PATCH weston v2 4/4] simple-dmabuf-drm: support etnaviv drm as well

2018-03-16 Thread Pekka Paalanen
On Thu, 15 Mar 2018 17:33:21 +0100 Guido Günther wrote: > --- > Makefile.am | 1 + > clients/simple-dmabuf-drm.c | 73 > + > configure.ac| 5 +++- > 3 files changed, 78 insertions(+), 1 deletion(-)

Re: [PATCH weston v2 1/1] Allow simple-dmabuf-drm to pass y_inverted flag

2018-03-16 Thread Pekka Paalanen
On Thu, 15 Mar 2018 17:34:55 +0100 Guido Günther wrote: > This allows to check if ZWP_LINUX_BUFFER_PARAMS_V1_FLAGS_Y_INVERT is > interpreted correctly by the compositor. > --- > clients/simple-dmabuf-drm.c | 31 +++ > 1 file changed, 23

Re: [PATCH weston] Add a help string for --xwayland

2018-03-16 Thread Pekka Paalanen
On Fri, 16 Mar 2018 00:16:29 -0400 Dima Ryazanov wrote: > Signed-off-by: Dima Ryazanov > --- > compositor/main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/compositor/main.c b/compositor/main.c > index 18810f28..1e827884 100644 > ---