Re: [PATCH weston 0/7] Fix source code analyzer findings

2018-03-28 Thread Pekka Paalanen
On Tue, 20 Mar 2018 15:28:20 +0100 Emre Ucan wrote: > These patches fix some of the findings which are found by > clang source code analyzer. > > Emre Ucan (7): > compositor-drm: remove superfluos get_disable_state call > compositor-drm: remove dead assigment in

wl_list_remove(>link) point to invalid address

2018-03-28 Thread zou lan
Hi Pekka & all When I run some full screen applications under desktop shell, then kill some applications randomly, I find crashes maybe happened sometimes. Crash call stack: weston_view_destroy-->weston_view_unmap-->wl_list_reomve(>link). The view is black view. Then I debug code, find that

Re: [PATCH weston] xwm: Fix two more icon related memory leaks

2018-03-28 Thread Pekka Paalanen
On Tue, 27 Mar 2018 11:09:32 -0500 Derek Foreman wrote: > Hopefully sort the last leaks introduced in commit 6b58ea8c > > The window could be destroyed before it had a frame but after it had an icon > (I could trigger this with firefox), and the window could be assigned

Re: [PATCH weston] xwm: Fix two more icon related memory leaks

2018-03-28 Thread Derek Foreman
On 2018-03-28 08:56 AM, Pekka Paalanen wrote: > On Tue, 27 Mar 2018 11:09:32 -0500 > Derek Foreman wrote: > >> Hopefully sort the last leaks introduced in commit 6b58ea8c >> >> The window could be destroyed before it had a frame but after it had an icon >> (I could

Re: [PATCH v2] xwm: Update input region on resize

2018-03-28 Thread Derek Foreman
On 2018-03-28 12:55 AM, Ray, Ian (GE Healthcare) wrote: > On 27/03/2018, 21.50, "wayland-devel on behalf of Derek Foreman" > der...@osg.samsung.com> wrote: >> >> Hey everyone, >> >> I've added Ian Ray to CC as the author of commit

Re: [PATCH weston 4/7] input: fix use-after-free issue at pointer_cancel

2018-03-28 Thread Pekka Paalanen
On Tue, 20 Mar 2018 15:28:24 +0100 Emre Ucan wrote: > If the constraint is an one-shot constraint, constraint > is freed in disable_pointer_constraint function. > Therefore, we should not try to read freed memory at > "switch (constraint->lifetime)" statement. > > The

Re: [PATCH wayland-protocols v2] unstable/drm-lease: DRM lease protocol support

2018-03-28 Thread Marius-cristian Vlad
Ping? Daniel? Have submitted a v4 for the server/client example. Would be nice to know if the protocol is at least OK or needs more work. On Mon, 2018-02-12 at 16:51 +0200, Marius Vlad wrote: > Simple protocol extension to manage DRM lease. Based on the work by > Keith > Packard in [1],