Re: Proxying Wayland for security

2021-07-28 Thread Carsten Haitzler
On Wed, 28 Jul 2021 10:56:40 + Alyssa Ross said: > Carsten Haitzler writes: > > >> > What I think would be of value is a standardized method to decide which > >> > wayland clients should be locked down and which should not be. This is > >> > currently "undecided". Something a compositor

Re: Proxying Wayland for security

2021-07-28 Thread Simon Ser
On Wednesday, July 28th, 2021 at 19:22, Carsten Haitzler wrote: > On Wed, 28 Jul 2021 10:56:40 + Alyssa Ross h...@alyssa.is said: > > > Carsten Haitzler ras...@rasterman.com writes: > > > > > > > What I think would be of value is a standardized method to decide > > > > > which > > > > > >

Re: Proxying Wayland for security

2021-07-28 Thread Alyssa Ross
Pekka Paalanen writes: > On Wed, 28 Jul 2021 11:06:43 + > Alyssa Ross wrote: > >> Daniel Stone writes: >> >> >> One big issue for us is protecting the system against potentially >> >> malicious Wayland clients. It's important that a compartmentalized >> >> application can't read from the

Re: Proxying Wayland for security

2021-07-28 Thread Carsten Haitzler
On Wed, 28 Jul 2021 11:05:11 + Simon Ser said: > On Wednesday, July 28th, 2021 at 12:30, Carsten Haitzler > wrote: > > > On Wed, 28 Jul 2021 09:51:53 + Simon Ser cont...@emersion.fr said: > > > > > Please read the (lengthy) discussion at 1. > > > In particular, the "get_credentials →

Re: Proxying Wayland for security

2021-07-28 Thread Simon McVittie
On Wed, 28 Jul 2021 at 18:22:55 +0100, Carsten Haitzler wrote: > but in the end almost everyone wants some way to differentiate what clients > can > and cannot do based on some kind of sandboxing and rules. Before that can happen, you need a concept of identity: you can't say anything about what

Re: Proxying Wayland for security

2021-07-28 Thread Alyssa Ross
Carsten Haitzler writes: >> > What I think would be of value is a standardized method to decide which >> > wayland clients should be locked down and which should not be. This is >> > currently "undecided". Something a compositor can easily look up given the >> > client socket and then decide

Re: Proxying Wayland for security

2021-07-28 Thread Alyssa Ross
Hi Carsten, thanks for the detailed reply. Carsten Haitzler writes: > On Tue, 27 Jul 2021 19:29:45 + Alyssa Ross said: > >> Hi! I'm Alyssa and I'm working on Spectrum[1], which is a project >> aiming to create a compartmentalized desktop Linux system, with high >> levels of isolation

Re: Proxying Wayland for security

2021-07-28 Thread Alyssa Ross
Carsten Haitzler writes: > On Tue, 27 Jul 2021 19:29:45 + Alyssa Ross said: > >> Hi! I'm Alyssa and I'm working on Spectrum[1], which is a project >> aiming to create a compartmentalized desktop Linux system, with high >> levels of isolation between applications. >> >> One big issue for

Re: Proxying Wayland for security

2021-07-28 Thread Simon Ser
Please read the (lengthy) discussion at [1]. [1]: https://gitlab.freedesktop.org/wayland/weston/-/issues/206 In particular, the "get_credentials → PID → executable path" lookup is racy. PID re-use allows a malicious process to be recognized as another executable.

Re: Proxying Wayland for security

2021-07-28 Thread Carsten Haitzler
On Wed, 28 Jul 2021 09:51:53 + Simon Ser said: > Please read the (lengthy) discussion at [1]. > > [1]: https://gitlab.freedesktop.org/wayland/weston/-/issues/206 > > In particular, the "get_credentials → PID → executable path" lookup is > racy. PID re-use allows a malicious process to be

Re: Proxying Wayland for security

2021-07-28 Thread Alyssa Ross
Simon Ser writes: > On Wednesday, July 28th, 2021 at 11:17, Alyssa Ross wrote: > >> A further thought I've just had -- the pid lookup is generally done >> through libwayland-server's wl_client_get_credentials(), right? So if >> libwayland-server could be taught about the proxy, and the proxy

Re: Proxying Wayland for security

2021-07-28 Thread Simon Ser
On Wednesday, July 28th, 2021 at 12:30, Carsten Haitzler wrote: > On Wed, 28 Jul 2021 09:51:53 + Simon Ser cont...@emersion.fr said: > > > Please read the (lengthy) discussion at 1. > > In particular, the "get_credentials → PID → executable path" lookup is > > racy. PID re-use allows a

Re: Proxying Wayland for security

2021-07-28 Thread Carsten Haitzler
On Wed, 28 Jul 2021 09:08:03 + Alyssa Ross said: > Hi Carsten, thanks for the detailed reply. > > Carsten Haitzler writes: > > > On Tue, 27 Jul 2021 19:29:45 + Alyssa Ross said: > > > >> Hi! I'm Alyssa and I'm working on Spectrum[1], which is a project > >> aiming to create a

Re: Proxying Wayland for security

2021-07-28 Thread Alyssa Ross
Carsten Haitzler writes: > On Wed, 28 Jul 2021 09:51:53 + Simon Ser said: > >> Please read the (lengthy) discussion at [1]. >> >> [1]: https://gitlab.freedesktop.org/wayland/weston/-/issues/206 >> >> In particular, the "get_credentials → PID → executable path" lookup is >> racy. PID

Re: Proxying Wayland for security

2021-07-28 Thread Daniel Stone
Hi Alyssa, On Tue, 27 Jul 2021 at 20:30, Alyssa Ross wrote: > Hi! I'm Alyssa and I'm working on Spectrum[1], which is a project > aiming to create a compartmentalized desktop Linux system, with high > levels of isolation between applications. I've seen, it's neat! > One big issue for us is

Re: Proxying Wayland for security

2021-07-28 Thread Simon Ser
On Wednesday, July 28th, 2021 at 11:17, Alyssa Ross wrote: > A further thought I've just had -- the pid lookup is generally done > through libwayland-server's wl_client_get_credentials(), right? So if > libwayland-server could be taught about the proxy, and the proxy could > communicate the

Re: Proxying Wayland for security

2021-07-28 Thread Alyssa Ross
Daniel Stone writes: >> One big issue for us is protecting the system against potentially >> malicious Wayland clients. It's important that a compartmentalized >> application can't read from the clipboard or take a screenshot of the >> whole desktop without user consent. (The latter is

Re: Proxying Wayland for security

2021-07-28 Thread Jan Engelhardt
On Wednesday 2021-07-28 12:30, Carsten Haitzler wrote: > >> Please read the (lengthy) discussion at [1]. >> >> [1]: https://gitlab.freedesktop.org/wayland/weston/-/issues/206 >> >> In particular, the "get_credentials → PID → executable path" lookup is >> racy. PID re-use allows a malicious

Re: Proxying Wayland for security

2021-07-28 Thread Simon Ser
On Wednesday, July 28th, 2021 at 13:06, Alyssa Ross wrote: > That's true for screenshots, but it's not true for clipboard contents, > right? As I understand it, any application can paste, with the only > restriction being that it has to be in the foreground at the time, and > wl-clipboard[1]

Re: Proxying Wayland for security

2021-07-28 Thread Jonas Ådahl
On Wed, Jul 28, 2021 at 01:36:54PM +, Alyssa Ross wrote: > Jonas Ådahl writes: > > > On Wed, Jul 28, 2021 at 11:06:43AM +, Alyssa Ross wrote: > >> Daniel Stone writes: > >> > >> >> One big issue for us is protecting the system against potentially > >> >> malicious Wayland clients.

Re: Proxying Wayland for security

2021-07-28 Thread Alyssa Ross
Jonas Ådahl writes: > On Wed, Jul 28, 2021 at 11:06:43AM +, Alyssa Ross wrote: >> Daniel Stone writes: >> >> >> One big issue for us is protecting the system against potentially >> >> malicious Wayland clients. It's important that a compartmentalized >> >> application can't read from the

Re: Proxying Wayland for security

2021-07-28 Thread Jonas Ådahl
On Wed, Jul 28, 2021 at 11:06:43AM +, Alyssa Ross wrote: > Daniel Stone writes: > > >> One big issue for us is protecting the system against potentially > >> malicious Wayland clients. It's important that a compartmentalized > >> application can't read from the clipboard or take a

Re: Proxying Wayland for security

2021-07-28 Thread Simon Ser
On Wednesday, July 28th, 2021 at 15:36, Alyssa Ross wrote: > That's good to know, but even so, there's no way for the compositor to > know that the interaction corresponds to a user intent to paste. So an > application could still abuse a mouseover, or just some unrelated typing > in its window,

Re: Proxying Wayland for security

2021-07-28 Thread Pekka Paalanen
On Wed, 28 Jul 2021 11:06:43 + Alyssa Ross wrote: > Daniel Stone writes: > > >> One big issue for us is protecting the system against potentially > >> malicious Wayland clients. It's important that a compartmentalized > >> application can't read from the clipboard or take a screenshot of