Re: [RFC v2] drm/kms: control display brightness through drm_connector properties

2022-09-30 Thread Pekka Paalanen
On Thu, 29 Sep 2022 20:06:50 +0200 Sebastian Wick wrote: > If it is supposed to be a non-linear luminance curve, which one is it? > It would be much clearer if user space can control linear luminance > and use whatever definition of perceived brightness it wants. The > obvious downside of it is

Re: [PATCH v3 0/6] Add support for atomic async page-flips

2022-09-30 Thread Harry Wentland
On 9/29/22 14:43, Simon Ser wrote: > This series adds support for DRM_MODE_PAGE_FLIP_ASYNC for atomic > commits, aka. "immediate flip" (which might result in tearing). > The feature was only available via the legacy uAPI, however for > gaming use-cases it may be desirable to enable it via the

Re: KMS atomic state sets, full vs. minimal (Re: [PATCH v3 0/6] Add support for atomic async page-flips)

2022-09-30 Thread Ville Syrjälä
On Fri, Sep 30, 2022 at 06:37:00PM +0300, Pekka Paalanen wrote: > On Fri, 30 Sep 2022 18:09:55 +0300 > Ville Syrjälä wrote: > > > That would actively discourage people from even attempting the > > "just dump all the state into the ioctl" approach with async flips > > since even the props whose

Re: KMS atomic state sets, full vs. minimal (Re: [PATCH v3 0/6] Add support for atomic async page-flips)

2022-09-30 Thread Ville Syrjälä
On Fri, Sep 30, 2022 at 06:45:09PM +0300, Ville Syrjälä wrote: > On Fri, Sep 30, 2022 at 06:37:00PM +0300, Pekka Paalanen wrote: > > On Fri, 30 Sep 2022 18:09:55 +0300 > > Ville Syrjälä wrote: > > > > > That would actively discourage people from even attempting the > > > "just dump all the state

Re: [RFC v2] drm/kms: control display brightness through drm_connector properties

2022-09-30 Thread Sebastian Wick
On Fri, Sep 30, 2022 at 5:27 PM Pekka Paalanen wrote: > > On Fri, 30 Sep 2022 17:44:17 +0300 > Ville Syrjälä wrote: > > > On Fri, Sep 30, 2022 at 04:20:29PM +0200, Sebastian Wick wrote: > > > On Fri, Sep 30, 2022 at 9:40 AM Pekka Paalanen > > > wrote: > > > > > > > > On Thu, 29 Sep 2022

Re: [PATCH v3 3/6] drm: introduce drm_mode_config.atomic_async_page_flip_not_supported

2022-09-30 Thread Simon Ser
On Friday, September 30th, 2022 at 15:53, Ville Syrjälä wrote: > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > index 44235345fd57..7500e82cf06a 100644 > > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > >

Re: [PATCH v3 0/6] Add support for atomic async page-flips

2022-09-30 Thread Ville Syrjälä
On Fri, Sep 30, 2022 at 04:52:56PM +0300, Ville Syrjälä wrote: > On Thu, Sep 29, 2022 at 06:43:15PM +, Simon Ser wrote: > > This series adds support for DRM_MODE_PAGE_FLIP_ASYNC for atomic > > commits, aka. "immediate flip" (which might result in tearing). > > The feature was only available

Re: [RFC v2] drm/kms: control display brightness through drm_connector properties

2022-09-30 Thread Simon Ser
On Friday, September 30th, 2022 at 16:44, Ville Syrjälä wrote: > On Fri, Sep 30, 2022 at 04:20:29PM +0200, Sebastian Wick wrote: > > > On Fri, Sep 30, 2022 at 9:40 AM Pekka Paalanen ppaala...@gmail.com wrote: > > > > > On Thu, 29 Sep 2022 20:06:50 +0200 > > > Sebastian Wick

Re: [PATCH v3 0/6] Add support for atomic async page-flips

2022-09-30 Thread Ville Syrjälä
On Fri, Sep 30, 2022 at 05:19:07PM +0300, Ville Syrjälä wrote: > On Fri, Sep 30, 2022 at 04:52:56PM +0300, Ville Syrjälä wrote: > > On Thu, Sep 29, 2022 at 06:43:15PM +, Simon Ser wrote: > > > This series adds support for DRM_MODE_PAGE_FLIP_ASYNC for atomic > > > commits, aka. "immediate flip"

Re: [RFC v2] drm/kms: control display brightness through drm_connector properties

2022-09-30 Thread Pekka Paalanen
On Fri, 30 Sep 2022 17:44:17 +0300 Ville Syrjälä wrote: > On Fri, Sep 30, 2022 at 04:20:29PM +0200, Sebastian Wick wrote: > > On Fri, Sep 30, 2022 at 9:40 AM Pekka Paalanen wrote: > > > > > > > > On Thu, 29 Sep 2022 20:06:50 +0200 > > > Sebastian Wick wrote: > > > > > > > If it is

Re: [PATCH v3 3/6] drm: introduce drm_mode_config.atomic_async_page_flip_not_supported

2022-09-30 Thread Ville Syrjälä
On Thu, Sep 29, 2022 at 06:43:42PM +, Simon Ser wrote: > This new field indicates whether the driver has the necessary logic > to support async page-flips via the atomic uAPI. This is leveraged by > the next commit to allow user-space to use this functionality. > > All atomic drivers setting

Re: [PATCH v3 0/6] Add support for atomic async page-flips

2022-09-30 Thread Ville Syrjälä
On Thu, Sep 29, 2022 at 06:43:15PM +, Simon Ser wrote: > This series adds support for DRM_MODE_PAGE_FLIP_ASYNC for atomic > commits, aka. "immediate flip" (which might result in tearing). > The feature was only available via the legacy uAPI, however for > gaming use-cases it may be desirable

Re: [PATCH v3 3/6] drm: introduce drm_mode_config.atomic_async_page_flip_not_supported

2022-09-30 Thread Ville Syrjälä
On Fri, Sep 30, 2022 at 01:56:25PM +, Simon Ser wrote: > On Friday, September 30th, 2022 at 15:53, Ville Syrjälä > wrote: > > > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > > b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > > index 44235345fd57..7500e82cf06a

Re: [RFC v2] drm/kms: control display brightness through drm_connector properties

2022-09-30 Thread Sebastian Wick
On Fri, Sep 30, 2022 at 9:40 AM Pekka Paalanen wrote: > > On Thu, 29 Sep 2022 20:06:50 +0200 > Sebastian Wick wrote: > > > If it is supposed to be a non-linear luminance curve, which one is it? > > It would be much clearer if user space can control linear luminance > > and use whatever

Re: [RFC v2] drm/kms: control display brightness through drm_connector properties

2022-09-30 Thread Jani Nikula
On Fri, 30 Sep 2022, Sebastian Wick wrote: > On Fri, Sep 30, 2022 at 9:40 AM Pekka Paalanen wrote: >> >> On Thu, 29 Sep 2022 20:06:50 +0200 >> Sebastian Wick wrote: >> >> > If it is supposed to be a non-linear luminance curve, which one is it? >> > It would be much clearer if user space can

Re: [RFC v2] drm/kms: control display brightness through drm_connector properties

2022-09-30 Thread Ville Syrjälä
On Fri, Sep 30, 2022 at 04:20:29PM +0200, Sebastian Wick wrote: > On Fri, Sep 30, 2022 at 9:40 AM Pekka Paalanen wrote: > > > > On Thu, 29 Sep 2022 20:06:50 +0200 > > Sebastian Wick wrote: > > > > > If it is supposed to be a non-linear luminance curve, which one is it? > > > It would be much

KMS atomic state sets, full vs. minimal (Re: [PATCH v3 0/6] Add support for atomic async page-flips)

2022-09-30 Thread Pekka Paalanen
On Fri, 30 Sep 2022 18:09:55 +0300 Ville Syrjälä wrote: > That would actively discourage people from even attempting the > "just dump all the state into the ioctl" approach with async flips > since even the props whose value isn't even changing would be rejected. About that. To me it looks