Re: New to wayland, need help pls.

2014-04-15 Thread Pekka Paalanen
On Mon, 14 Apr 2014 12:11:11 +0530 Srivardhan M S srivardha...@gmail.com wrote: Hi, I am new to Wayland, and I would like to contribute to it. I have already, downloaded the source code and have built it. Now reading the documentation for understanding. Can you pls tell me how I can start

[PATCH] keyboard: add the missing symbols layout, fix arabic layout

2014-04-15 Thread Manuel Bachmann
The symbols modifier key of weston-keyboard is no longer inactive, but will provide an additionnal layout with numerals and special characters. Fix the Arabic keyboard, which was rendering out of the bounds, and now use the Arabic IBM PC keyboard as a reference for its standard and new symbols

Self introduction Hans de Goede

2014-04-15 Thread Hans de Goede
Hi All, I guess most of you already know me, but since I'm about to become a whole lot more active on this list, I thought it would be a good idea to start with a self-intro: My name is Hans de Goede, and I'm active as a FOSS contributor / developer since 1997. Recently I've mainly been

[PATCH libinput 02/20] touchpad: after a click, lock the finger to its current position

2014-04-15 Thread Hans de Goede
From: Peter Hutterer peter.hutte...@who-t.net On clickpads, clicking the pad usually causes some motion events. To avoid erroneous movements, lock the finger into position on the click and don't allow for motion events until we move past a given threshold (currently 2% of the touchpad diagonal).

[PATCH libinput 10/20] touchpad: Add tp_button_touch_active function

2014-04-15 Thread Hans de Goede
We don't want touches in the button area to cause the pointer to move, add a tp_button_touch_active function which the main code in evdev-mt-touchpad can call to see if a touch should be consider a candidate for being the pointer, should be taken into account for 2 finger scrolling, etc. The idea

[PATCH libinput 20/20] Change internal timestamps to uint64_t to properly deal with wrapping

2014-04-15 Thread Hans de Goede
We store timestamps in ms since system boot (CLOCK_MONOTONIC). This will wrap after circa 50 days. I've considered making our code wrapping safe, but that won't work. We also use our internal timestamps to program timer-fds for timeouts. And we store ms in a single integer but the kernel uses 2

[PATCH libinput 08/20] touchpad: Only enable clickfingers on Apple touchpads

2014-04-15 Thread Hans de Goede
From: Peter Hutterer peter.hutte...@who-t.net Apple touchpads don't have visible markings for the software button areas that almost all other vendors use. OS X provides clickfinger behaviour instead, where a click with two fingers on the touchpad generate a right button click. Use that same

[PATCH libinput 14/20] touchpad: Ignore non left clicks on clickpads

2014-04-15 Thread Hans de Goede
We should never get any non left button events on clickpads, but if we do these might confuse our state, so complain about it and ignore these. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-buttons.c | 7 +++ 1

[PATCH libinput 16/20] touchpad: softbuttons: Deal with a click arriving before any touches

2014-04-15 Thread Hans de Goede
It is possible for a click to get reported before any related touch events get reported, here is the relevant part of an evemu-record session on a T440s: E: 3.985585 # SYN_REPORT (0) -- E: 3.997419 0003 0039 -001 # EV_ABS / ABS_MT_TRACKING_ID -1 E:

[PATCH libinput 15/20] touchpad: post_button_events: Remove TOUCHPAD_EVENT_BUTTON_PRESS/RELEASE test

2014-04-15 Thread Hans de Goede
We already check for old != current everywhere, so this is not needed; And in tp_post_softbutton_buttons we want to do delay button down reporting if we don't have touch info yet in which case this check actually gets in the way. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter

[PATCH libinput 18/20] touchpad: Remove clickpad clicked test from 2 finger scrolling handling

2014-04-15 Thread Hans de Goede
This is no longer needed now that we take the button area and pinned fingers into account. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad.c | 5 - 1 file changed, 5 deletions(-) diff --git

[PATCH libinput 03/20] touchpad: reset the tap timer_fd to -1 on destroy

2014-04-15 Thread Hans de Goede
From: Peter Hutterer peter.hutte...@who-t.net No real effect, just for safety Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad-tap.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH libinput 04/20] touchpad: don't allow tapping while any button is down

2014-04-15 Thread Hans de Goede
From: Peter Hutterer peter.hutte...@who-t.net Immediately set the state to DEAD, waiting for the tap release to go back to idle. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad-tap.c | 2 +- 1 file changed, 1

[PATCH libinput 11/20] touchpad: Rework is_pointer handling

2014-04-15 Thread Hans de Goede
Move scanning for a suitable touch to be the pointer to tp_process_state and take tp_button_touch_active into account. Note this adds a tp_touch_active helper since we want to do the same checks in other places too (ie to see if a finger should count for 2 finger scrolling). Signed-off-by: Hans

[PATCH libinput 07/20] touchpad: save the active clickfinger button

2014-04-15 Thread Hans de Goede
From: Peter Hutterer peter.hutte...@who-t.net To avoid having a button left press and a button right release if the number of fingers changes. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad-buttons.c | 22

[PATCH libinput 13/20] touchpad: Use INPUT_PROP_BUTTONPAD instead of checking for buttons

2014-04-15 Thread Hans de Goede
And warn if INPUT_PROP_BUTTONPAD mismatches right/middle buttons presence. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-buttons.c | 34 ++ src/evdev-mt-touchpad.c | 4 ++--

[PATCH libinput 05/20] touchpad: move button-related code into a separate file

2014-04-15 Thread Hans de Goede
From: Peter Hutterer peter.hutte...@who-t.net This is about to become more complicated with the support for software button areas. Move it to a separate file to have it logically grouped together. No functional changes. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Hans

[PATCH libinput 06/20] doc: add state machine SVG to EXTRA_DIST

2014-04-15 Thread Hans de Goede
From: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Hans de Goede hdego...@redhat.com --- doc/Makefile.am | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/Makefile.am b/doc/Makefile.am index

[PATCH libinput 17/20] touchpad: Ignore fingers in button area for 2 finger scroll

2014-04-15 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 910bd2a..7333ec9 100644 ---

[PATCH libinput 19/20] touchpad: handle_timeouts: Remove unused return value

2014-04-15 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad-buttons.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/evdev-mt-touchpad-buttons.c b/src/evdev-mt-touchpad-buttons.c index 3b8b07b..c40b05c

[PATCH libinput 00/20] clickpad-improvements v2

2014-04-15 Thread Hans de Goede
Hi All, Here is my improved version of Peter's clickpad-improvements patch-set. Changes in v2: * after a click, lock the finger to its current position Pin all fingers until they move more then the threshold in * touchpad: add clickpad-style software buttons Simplify the state machine used

[PATCH libinput 12/20] Add a log_bug macro

2014-04-15 Thread Hans de Goede
For logging when things happen which should not happen. We may want to do something more fancy in the future but for now this suffices. Modelled after log_bug in libevdev. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net ---

[PATCH libinput 01/20] touchpad: set ntouches for single-touch pads depending on key bits

2014-04-15 Thread Hans de Goede
From: Peter Hutterer peter.hutte...@who-t.net A single-touch touchpad that provides BTN_TOOL_TRIPLETAP has 3 touches, etc. There aren't a lot of these out there, but some touchpads don't have slots but do provide two- or three-finger detection. Signed-off-by: Peter Hutterer

[PATCH libinput 09/20] touchpad: add clickpad-style software buttons

2014-04-15 Thread Hans de Goede
From: Peter Hutterer peter.hutte...@who-t.net This is a slightly fancier implementation than the simplest model and ported over from libtouchpad. It implements a state machine for the software buttons with left and right buttons currently implemented. Buttons are oriented left-to-right, in a

Re: [RCF wayland] client: extend error handling

2014-04-15 Thread Pekka Paalanen
On Fri, 11 Apr 2014 11:39:13 +0200 Marek Chalupa mchqwe...@gmail.com wrote: When an error occures, than wl_display_get_error() do not provide any way of getting know if it was a local error or if it was an error event, respectively what object caused the error and what the error was. This

Re: [PATCH libinput 08/20] touchpad: Only enable clickfingers on Apple touchpads

2014-04-15 Thread Daniel Stone
Hi, On 15 April 2014 13:28, Hans de Goede hdego...@redhat.com wrote: Apple touchpads don't have visible markings for the software button areas that almost all other vendors use. OS X provides clickfinger behaviour instead, where a click with two fingers on the touchpad generate a right

Re: [PATCH libinput 08/20] touchpad: Only enable clickfingers on Apple touchpads

2014-04-15 Thread Hans de Goede
Hi, On 04/15/2014 03:44 PM, Daniel Stone wrote: Hi, On 15 April 2014 13:28, Hans de Goede hdego...@redhat.com wrote: Apple touchpads don't have visible markings for the software button areas that almost all other vendors use. OS X provides clickfinger behaviour instead, where a click

Re: [PATCH] Check malloc result

2014-04-15 Thread Bryce W. Harrington
Much better error checking. In the out_pixman_error finalizer should it also destroy the zalloc'd sb object, since we're going to return NULL in this case? Also see one more comment below. But these are just nit picks; LGTM even without those changes. Reviewed-by: Bryce Harrington

Re: Question about multi-display on wayland protocol

2014-04-15 Thread Bryce W. Harrington
On Mon, Apr 14, 2014 at 11:08:00AM -0700, Bill Spitzak wrote: I think he is asking how to run Wayland so that it controls more than one monitor. This has nothing to do with how windows act once Wayland is running. That's how I read it too. @Yang, there have been various patch proposals for

Re: New to wayland, need help pls.

2014-04-15 Thread Bryce W. Harrington
On Tue, Apr 15, 2014 at 10:13:15AM +0300, Pekka Paalanen wrote: On Mon, 14 Apr 2014 12:11:11 +0530 Srivardhan M S srivardha...@gmail.com wrote: Hi, I am new to Wayland, and I would like to contribute to it. I have already, downloaded the source code and have built it. Now reading the

[PATCH libinput] evdev-mt-touchpad: check calloc result

2014-04-15 Thread Carlos Olmedo Escobar
Check the value returned by calloc. --- src/evdev-mt-touchpad.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index bbbd8f3..9ec1682 100644 --- a/src/evdev-mt-touchpad.c +++ b/src/evdev-mt-touchpad.c @@ -25,6 +25,7 @@ #include assert.h

RE: [PATCH weston 3/3] shell: Destroy a previous input panel animation when showing it again

2014-04-15 Thread Eoff, Ullysses A
This patch series fixes https://bugs.freedesktop.org/show_bug.cgi?id=77347 for me U. Artie Eoff -Original Message- From: wayland-devel [mailto:wayland-devel-boun...@lists.freedesktop.org] On Behalf Of Ander Conselvan de Oliveira Sent: Monday, April 14, 2014 5:48 AM To:

[Weston] More discussion about weston output relative motion algorithm

2014-04-15 Thread Wang, Quanxian
Hi, All Relative motion of output is needed in Weston compositor or others. For example, plugin a monitor, you want move it above or leftof or rightof or below others. More details about this motion algorithm will be shown in the email. Before that, I mention one point, I don't refer any code

RE: [Weston] More discussion about weston output relative motion algorithm

2014-04-15 Thread Wang, Quanxian
Clear some definition for easy understanding. Supposed B is beside A. B maybe leftof, rightof, above, or below A. If leftof, output(B) is the horizontal parent of A. If above, output(B) is the vertical parent of A. If rightof, output(B) is the horizontal child of A. If below, output(B) is the

xserver git version?

2014-04-15 Thread Bill Spitzak
It looks like the xwayland branch of xserver has disappeared: $ git pull Your configuration specifies to merge with the ref 'xwayland' from the remote, but no such ref was fetched. I tried git pull origin master but it produced lots of conflicts, it looks like there are many changes for

Re: New to wayland, need help pls.

2014-04-15 Thread Pekka Paalanen
On Tue, 15 Apr 2014 19:08:12 + Bryce W. Harrington b.harring...@samsung.com wrote: On Tue, Apr 15, 2014 at 10:13:15AM +0300, Pekka Paalanen wrote: On Mon, 14 Apr 2014 12:11:11 +0530 Srivardhan M S srivardha...@gmail.com wrote: Hi, I am new to Wayland, and I would like to