Re: [PATCH libinput 03/10] touchpad: hook up to the tapping configuration

2014-06-04 Thread Jonas Ådahl
On Wed, Jun 04, 2014 at 08:00:17AM +1000, Peter Hutterer wrote: On Tue, Jun 03, 2014 at 10:42:50PM +0200, Jonas Ådahl wrote: On Tue, Jun 03, 2014 at 03:34:56PM +1000, Peter Hutterer wrote: Now that we have run-time changes of the tap.enabled state move the check to the IDLE state only.

Re: [PATCH libinput 02/10] Add an interface to enable/disable tapping

2014-06-04 Thread Jonas Ådahl
On Wed, Jun 04, 2014 at 11:17:58AM +1000, Peter Hutterer wrote: On Tue, Jun 03, 2014 at 10:41:16PM +0200, Jonas Ådahl wrote: On Tue, Jun 03, 2014 at 03:34:55PM +1000, Peter Hutterer wrote: Provide an interface to enable/disable tapping, with a default mapping of 1/2/3 fingers mapping to

Re: [PATCH libinput 02/10] Add an interface to enable/disable tapping

2014-06-04 Thread Hans de Goede
Hi, On 06/04/2014 10:21 AM, Jonas Ådahl wrote: On Wed, Jun 04, 2014 at 11:17:58AM +1000, Peter Hutterer wrote: On Tue, Jun 03, 2014 at 10:41:16PM +0200, Jonas Ådahl wrote: On Tue, Jun 03, 2014 at 03:34:55PM +1000, Peter Hutterer wrote: Provide an interface to enable/disable tapping, with a

Re: [PATCH libinput 02/10] Add an interface to enable/disable tapping

2014-06-04 Thread Hans de Goede
Hi, On 06/03/2014 07:34 AM, Peter Hutterer wrote: Provide an interface to enable/disable tapping, with a default mapping of 1/2/3 fingers mapping to L/R/M button events, respectively. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput-private.h | 13 +

Re: [PATCH libinput 02/10] Add an interface to enable/disable tapping

2014-06-04 Thread Peter Hutterer
On 4/06/2014 18:40 , Hans de Goede wrote: Hi, On 06/03/2014 07:34 AM, Peter Hutterer wrote: Provide an interface to enable/disable tapping, with a default mapping of 1/2/3 fingers mapping to L/R/M button events, respectively. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net ---

Re: [PATCH libinput 03/10] touchpad: hook up to the tapping configuration

2014-06-04 Thread Hans de Goede
Hi, On 06/03/2014 07:34 AM, Peter Hutterer wrote: Now that we have run-time changes of the tap.enabled state move the check to the IDLE state only. Otherwise the tap machine may hang if tapping is disabled while a gesture is in progress. Two basic tests are added to check for the tap

Re: [PATCH libinput 02/10] Add an interface to enable/disable tapping

2014-06-04 Thread Hans de Goede
Hi, On 06/03/2014 07:34 AM, Peter Hutterer wrote: Provide an interface to enable/disable tapping, with a default mapping of 1/2/3 fingers mapping to L/R/M button events, respectively. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net I see that in all the other config interfaces you

Re: [PATCH libinput 04/10] Add a config interface for scroll methods

2014-06-04 Thread Hans de Goede
Hi, On 06/03/2014 07:34 AM, Peter Hutterer wrote: --- src/libinput-private.h | 9 ++ src/libinput.c | 35 src/libinput.h | 74 ++ 3 files changed, 118 insertions(+) Looks good to me. Regards,

Re: [PATCH libinput 05/10] touchpad: hook up scroll config

2014-06-04 Thread Hans de Goede
Hi, On 06/03/2014 07:34 AM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev-mt-touchpad.c | 43 +++ src/evdev-mt-touchpad.h | 1 + 2 files changed, 44 insertions(+) diff --git a/src/evdev-mt-touchpad.c

Re: [PATCH libinput 06/10] Add a config interface to change device rotation

2014-06-04 Thread Hans de Goede
Hi, On 06/03/2014 07:34 AM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput-private.h | 9 +++ src/libinput.c | 33 src/libinput.h | 69 ++ 3 files

Re: [PATCH libinput 07/10] Add a basic pointer acceleration API

2014-06-04 Thread Hans de Goede
Hi, On 06/03/2014 07:35 AM, Peter Hutterer wrote: Only exposes two knobs - speed and precision which have historically been the only two knobs exposed anyway on most UIs. We could go for something fancier but really, I think this will be enough. The only open question is whether speed will

Re: [PATCH libinput 02/10] Add an interface to enable/disable tapping

2014-06-04 Thread Jonas Ådahl
On Wed, Jun 04, 2014 at 10:38:19AM +0200, Hans de Goede wrote: Hi, On 06/04/2014 10:21 AM, Jonas Ådahl wrote: On Wed, Jun 04, 2014 at 11:17:58AM +1000, Peter Hutterer wrote: On Tue, Jun 03, 2014 at 10:41:16PM +0200, Jonas Ådahl wrote: On Tue, Jun 03, 2014 at 03:34:55PM +1000, Peter

Re: [PATCH libinput 09/10] Add config API for pointer modes

2014-06-04 Thread Hans de Goede
Hi, On 06/03/2014 07:35 AM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/libinput-private.h | 9 ++ src/libinput.c | 37 src/libinput.h | 77 ++ 3 files

Re: [PATCH libinput 10/10] Add config api for middle button emulation

2014-06-04 Thread Hans de Goede
Hi, On 06/03/2014 07:35 AM, Peter Hutterer wrote: --- src/libinput-private.h | 8 src/libinput.c | 33 ++ src/libinput.h | 54 ++ 3 files changed, 95 insertions(+) diff --git

Re: [PATCH libinput] touchpad: Drop the scroll direction lock, increase threshold instead

2014-06-04 Thread Hans de Goede
Hi, On 06/04/2014 06:09 AM, Peter Hutterer wrote: The direction lock was intended to avoid erroneous horizontal scroll events when scrolling vertically (and vice versa). Some testing on my touchpad here shows that it is too easy to accidentally lock the direction when no lock is intended

Re: [PATCH libinput 08/10] Add a config API for disable-while-typing

2014-06-04 Thread Hans de Goede
Hi, On 06/03/2014 07:35 AM, Peter Hutterer wrote: --- src/libinput-private.h | 9 src/libinput.c | 33 + src/libinput.h | 56 ++ 3 files changed, 98 insertions(+) diff --git

[PATCH] shell: Destroy the shell_surface when the xdg_shell interface gets destroyed

2014-06-04 Thread Sjoerd Simons
When running gtk3-demo under weston opening comboboxes a second time causes the program to bail due to weston returning an error. The relevant client trace in this case is: - xdg_shell@15.get_xdg_popup(new id xdg_popup@12, wl_surface@28, - xdg_popup@12.destroy() -

[PATCH libinput 3/3] evdev-mt-touchpad-tap: Switch over to new timer subsystem

2014-06-04 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad-tap.c | 76 ++--- src/evdev-mt-touchpad.c | 1 - src/evdev-mt-touchpad.h | 7 + 3 files changed, 10 insertions(+), 74 deletions(-) diff --git

Wayland and Android Emulator

2014-06-04 Thread Claudiu Lupu
Hello, I am running 2 operating systems in paralel on a Panda Board, Android and Linux with Weston on it. Since Android doesn't have access to the GPU (it's one OS or the other) I created proxy libs for EGL, GLESv1 and GLESv2 + gralloc(emulator part). So far all I was able to see on linux side

Re: [PATCH] s/libinput_pointer_button_state/libinput_button_state/

2014-06-04 Thread Jonas Ådahl
On Wed, Jun 04, 2014 at 12:54:58PM +1000, Peter Hutterer wrote: On Tue, Jun 03, 2014 at 08:08:02PM -0400, Stephen Chandler Paul wrote: Button states are applicable to more then just the pointer, so having a non-generic name name for a generic enumerator value like

Re: [PATCH libinput 03/10] touchpad: hook up to the tapping configuration

2014-06-04 Thread Jonas Ådahl
On Wed, Jun 04, 2014 at 11:10:35AM +0200, Hans de Goede wrote: Hi, On 06/03/2014 07:34 AM, Peter Hutterer wrote: Now that we have run-time changes of the tap.enabled state move the check to the IDLE state only. Otherwise the tap machine may hang if tapping is disabled while a gesture is

Re: [PATCH] s/libinput_pointer_button_state/libinput_button_state/

2014-06-04 Thread Peter Hutterer
On Wed, Jun 04, 2014 at 10:40:10PM +0200, Jonas Ådahl wrote: On Wed, Jun 04, 2014 at 12:54:58PM +1000, Peter Hutterer wrote: On Tue, Jun 03, 2014 at 08:08:02PM -0400, Stephen Chandler Paul wrote: Button states are applicable to more then just the pointer, so having a non-generic name name

Re: [PATCH libinput 1/3] Add a timer subsystem

2014-06-04 Thread Jonas Ådahl
On Wed, Jun 04, 2014 at 05:26:34PM +0200, Hans de Goede wrote: Currently we are using DIY timers in the touchpad softbutton and tap handling code, and at least the softbutton code gets its wrong. It uses one timer-fd per touchpad to set a timeout per touch, which means that if a timeout is set

Re: [PATCH] s/libinput_pointer_button_state/libinput_button_state/

2014-06-04 Thread Jonas Ådahl
On Thu, Jun 05, 2014 at 07:45:00AM +1000, Peter Hutterer wrote: On Wed, Jun 04, 2014 at 10:40:10PM +0200, Jonas Ådahl wrote: On Wed, Jun 04, 2014 at 12:54:58PM +1000, Peter Hutterer wrote: On Tue, Jun 03, 2014 at 08:08:02PM -0400, Stephen Chandler Paul wrote: Button states are applicable

Re: [PATCH] s/libinput_pointer_button_state/libinput_button_state/

2014-06-04 Thread Peter Hutterer
On Thu, Jun 05, 2014 at 12:21:52AM +0200, Jonas Ådahl wrote: On Thu, Jun 05, 2014 at 07:45:00AM +1000, Peter Hutterer wrote: On Wed, Jun 04, 2014 at 10:40:10PM +0200, Jonas Ådahl wrote: On Wed, Jun 04, 2014 at 12:54:58PM +1000, Peter Hutterer wrote: On Tue, Jun 03, 2014 at 08:08:02PM

Re: [PATCH libinput 03/10] touchpad: hook up to the tapping configuration

2014-06-04 Thread Peter Hutterer
On Wed, Jun 04, 2014 at 10:57:36PM +0200, Jonas Ådahl wrote: On Wed, Jun 04, 2014 at 11:10:35AM +0200, Hans de Goede wrote: On 06/03/2014 07:34 AM, Peter Hutterer wrote: [...] @@ -583,9 +580,56 @@ tp_tap_handle_timeout(struct tp_dispatch *tp, uint64_t time) return tp-tap.timeout;

Re: [PATCH libinput 1/3] Add a timer subsystem

2014-06-04 Thread Peter Hutterer
On Wed, Jun 04, 2014 at 05:26:34PM +0200, Hans de Goede wrote: Currently we are using DIY timers in the touchpad softbutton and tap handling code, and at least the softbutton code gets its wrong. It uses one timer-fd per touchpad to set a timeout per touch, which means that if a timeout is set