Re: [PATCH libinput 1/9] path: keep the udev context around

2014-11-24 Thread Hans de Goede
Hi, On 11/24/2014 01:46 AM, Peter Hutterer wrote: We need it for each device anyway, keep the ref around. Makes error handling a bit easier, we don't need to handle failing udev_new() and reduce the danger of mis-refcounting it. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks

Re: [PATCH libinput 2/9] path: split out creating a device into a helper function

2014-11-24 Thread Hans de Goede
Hi, On 11/24/2014 01:46 AM, Peter Hutterer wrote: No functional changes Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/path.c | 57 - 1

Re: [PATCH libinput 3/9] path: store the udev device instead of just the devnode

2014-11-24 Thread Hans de Goede
Hi, On 11/24/2014 01:46 AM, Peter Hutterer wrote: Long-term plan to use more of udev_device here is to better protect us against re-opening a different device that happens to have the same devnode. This now also prints an error message for invalid devices, the log tests are adjusted.

Re: [PATCH libinput 4/9] evdev: use a udev_device instead of separate sysname/syspath/devnode

2014-11-24 Thread Hans de Goede
Hi, On 11/24/2014 01:46 AM, Peter Hutterer wrote: Using a udev_device instead of the various bits separately safes us re-initializing udev contexts whenever we need to compare the device. And having the actual udev device makes it a bit easier to ensure that we're not re-initializing a

Re: [PATCH libinput 5/9] evdev: remove a race condition opening the wrong device

2014-11-24 Thread Hans de Goede
Hi, On 11/24/2014 01:46 AM, Peter Hutterer wrote: Potential race condition: - udev notifies us that a udev_device became available - we go for a coffee and chat to the neighbours on the way - the device is unplugged - a new device is plugged in, gets the same devnode - we finish our coffee and

Re: [PATCH libinput 6/9] udev: optionally pass the seat name into device_added()

2014-11-24 Thread Hans de Goede
Hi, On 11/24/2014 01:46 AM, Peter Hutterer wrote: Prep work for changing seat names on devices. No functional changes. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/udev-seat.c | 13 -

Re: [PATCH libinput 7/9] path: optionally pass the seat name into path_device_enable()

2014-11-24 Thread Hans de Goede
Hi, On 11/24/2014 01:46 AM, Peter Hutterer wrote: Prep work for changing seat names on devices. No functional changes. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- src/path.c | 30

Re: [PATCH libinput 8/9] Add libinput_device_set_seat_logical_name() to change seats at runtime

2014-11-24 Thread Hans de Goede
Hi, On 11/24/2014 01:46 AM, Peter Hutterer wrote: The seat of a device is currently immutable, but a device may (in a multi-pointer case) move between different logical seats. Moving it between seats is akin to removing it and re-plugging it, so let's do exactly that. The physical seat name

Re: [PATCH libinput 9/9] test: add seat changing tests

2014-11-24 Thread Hans de Goede
Hi, On 11/24/2014 01:46 AM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- test/path.c | 71 ++- test/udev.c | 78

Re: [PATCH v1 weston 05/11] tests: Allow tests to use customized command line parameters

2014-11-24 Thread Pekka Paalanen
On Fri, 21 Nov 2014 12:38:35 -0800 Bryce Harrington br...@osg.samsung.com wrote: On Fri, Nov 21, 2014 at 04:56:03PM +0200, Pekka Paalanen wrote: On Wed, 19 Nov 2014 15:06:20 -0800 Bryce Harrington br...@osg.samsung.com wrote: From: Derek Foreman der...@osg.samsung.com Tests will

Re: [PATCH 2/2] touchpad: Add edge-scrolling support

2014-11-24 Thread Hans de Goede
Hi, On 11/20/2014 07:19 AM, Peter Hutterer wrote: On Wed, Nov 19, 2014 at 11:50:13AM +0100, Hans de Goede wrote: [...] + + switch (tp-model) { + case MODEL_SYNAPTICS: + edge_width = width * .07; + edge_height = height * .07; + break; +

Re: [PATCH v1 weston 06/11] tests: Add screenshot recording to weston-test

2014-11-24 Thread Pekka Paalanen
On Wed, 19 Nov 2014 15:06:21 -0800 Bryce Harrington br...@osg.samsung.com wrote: From: Derek Foreman der...@osg.samsung.com Adds wl_test_record_screenshot() to weston test. This commit also adds a dependency on cairo to weston-test to use it for writing PNG files. Fixes:

[PATCH libinput v3 1/3] touchpad: Move 2 finger scrolling functions to above tp_process_state()

2014-11-24 Thread Hans de Goede
This is purely a code move, this is a preparation patch for adding edge scrolling support. Signed-off-by: Hans de Goede hdego...@redhat.com --- src/evdev-mt-touchpad.c | 118 1 file changed, 59 insertions(+), 59 deletions(-) diff --git

[PATCH libinput v3 2/3] touchpad: Add code to get the touchpad model / manufacturer

2014-11-24 Thread Hans de Goede
This is useful to know in some cases, it is e.g. necessary to figure out which percentage of a touchpads range to use as edge for edge-scrolling. Note this is a slightly cleaned up copy of the same code in xf86-input-synaptics. Signed-off-by: Hans de Goede hdego...@redhat.com ---

Re: [PATCH libinput v2 3/3] touchpad: Add edge-scrolling support

2014-11-24 Thread Hans de Goede
Hi, On 11/21/2014 01:29 AM, Peter Hutterer wrote: On Thu, Nov 20, 2014 at 10:34:51AM +0100, Hans de Goede wrote: [...] +int +tp_edge_scroll_init(struct tp_dispatch *tp, struct evdev_device *device) +{ + struct tp_touch *t; + int width, height; + int edge_width, edge_height; +

Re: [PATCH v1 weston 07/11] tests: Add a fadein test

2014-11-24 Thread Pekka Paalanen
On Wed, 19 Nov 2014 15:06:22 -0800 Bryce Harrington br...@osg.samsung.com wrote: This also serves as a proof of concept of the screen capture functionality and as a demo for snapshot-based rendering verification. Signed-off-by: Bryce Harrington br...@osg.samsung.com --- Makefile.am

Re: [PATCH v1 weston 09/11] tests: Add support for comparing output against reference images

2014-11-24 Thread Pekka Paalanen
On Wed, 19 Nov 2014 15:06:24 -0800 Bryce Harrington br...@osg.samsung.com wrote: Steal Cairo's files_equal() routine to do byte comparison of the rendered files. Note that since the clock time will change run to run we can only compare against the first frame (which will be black). Not even

Re: [PATCH v1 weston 11/11] tests: Construct the filename external to wl_test_record_screenshot

2014-11-24 Thread Pekka Paalanen
On Wed, 19 Nov 2014 15:06:26 -0800 Bryce Harrington br...@osg.samsung.com wrote: We need to use the output filename when we do a comparison with the appropriate reference image, so move the filename construction to the caller of record_screenshot() instead. Doing this also requires

Re: [PATCH v1 weston 00/11] Headless rendering testing

2014-11-24 Thread Pekka Paalanen
On Wed, 19 Nov 2014 15:06:15 -0800 Bryce Harrington br...@osg.samsung.com wrote: This set of patches by Derek and I implement functionality to do screenshot-based testing of wayland. The idea is to allow tests to render the desktop to memory using Pixman, apply an optional clipping mask via

Re: [PATCH weston] input: don't run the key bindings on focus in

2014-11-24 Thread Pekka Paalanen
On Fri, 21 Nov 2014 13:45:04 + Daniel Stone dan...@fooishbar.org wrote: Yep, this is correct. (I'll get back to the other thread shortly.) -d On Thursday, November 20, 2014, Giulio Camuffo giuliocamu...@gmail.com wrote: When getting the focus we get the list of pressed keys,

Re: [PATCH weston] desktop-shell: don't crash input-panel if no kbd focus

2014-11-24 Thread Pekka Paalanen
On Thu, 20 Nov 2014 10:25:17 +0200 Pekka Paalanen ppaala...@gmail.com wrote: From: Pekka Paalanen pekka.paala...@collabora.co.uk If a keyboard exists but it has no current focus, yet something asks the input-panel to come up, we would crash here. Check that there is a focus before

Re: [PATCH weston 4/6] xdg-shell: Send an error when the client uses the not-topmost popup

2014-11-24 Thread Pekka Paalanen
On Sat, 22 Nov 2014 12:28:28 -0800 Jasper St. Pierre jstpie...@mecheye.net wrote: Either in destroy or get_xdg_popup. --- desktop-shell/shell.c | 21 - protocol/xdg-shell.xml | 7 +++ 2 files changed, 27 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v1] Added string conversion utility functions

2014-11-24 Thread Imran Zaman
Thanks Bill for your comments. Please see my comments inline. On Fri, Nov 21, 2014 at 9:31 PM, Bill Spitzak spit...@gmail.com wrote: There is no need to pass endptr, because your functions will always fail if it is not set to point to the terminating null. [IZ] endptr is passed other than

Re: [PATCH weston 5/6] xdg-shell: Rewrite documentation

2014-11-24 Thread Pekka Paalanen
On Sat, 22 Nov 2014 12:28:29 -0800 Jasper St. Pierre jstpie...@mecheye.net wrote: This rewrites basically all of the text inside xdg-shell to be up to date, clearer, and rid of wl_shell and X11 terminology. --- protocol/xdg-shell.xml | 256 ++---

Re: Wayland and Weston in Patchwork

2014-11-24 Thread Imran Zaman
Hi Somehow I dont see the patch below in patch work: http://lists.freedesktop.org/archives/wayland-devel/2014-November/018410.html Any idea what is wrong with it or there is some sort of filtering or ? BR imran On Thu, Nov 20, 2014 at 12:47 AM, Bill Spitzak spit...@gmail.com wrote: On

Re: [PATCH weston 0/6] Fixups and rewrites for xdg-shell

2014-11-24 Thread Pekka Paalanen
On Sat, 22 Nov 2014 12:28:24 -0800 Jasper St. Pierre jstpie...@mecheye.net wrote: This is the last round of fixups I'm going to to the existing xdg-shell interface. We'll be adding on other APIs before it goes fully stable, but before that, let's focus on making sure what we already have is

Re: Wayland and Weston in Patchwork

2014-11-24 Thread Pekka Paalanen
On Mon, 24 Nov 2014 15:33:51 +0200 Imran Zaman imran.za...@gmail.com wrote: Hi Somehow I dont see the patch below in patch work: http://lists.freedesktop.org/archives/wayland-devel/2014-November/018410.html Any idea what is wrong with it or there is some sort of filtering or ? Hi, yeah,

Re: [PATCH wayland] increase server listen queue to 8

2014-11-24 Thread Imran Zaman
Actually we were connecting multiple simultaneous child/session westons to system weston and sometime it didn't succeed. Nevertheless we are not sure that this can be one of the reasons and we couldnt spot the problem precisely (we were testing it in Tizen with kernel version: 3.14.19-10.4) We

Re: Wayland and Weston in Patchwork

2014-11-24 Thread Imran Zaman
Exactly git send-email did ask for utf-8 and i guess i entered y.. shall I not? and no idea why git is making it multipart.. Shall i try to resend the patch with utf-8 question as 'no'? BR imran On Mon, Nov 24, 2014 at 3:50 PM, Pekka Paalanen ppaala...@gmail.com wrote: On Mon, 24 Nov 2014

Re: [PATCH weston] input: don't send to clients key events eaten by bindings

2014-11-24 Thread Pekka Paalanen
On Fri, 21 Nov 2014 18:34:32 + Daniel Stone dan...@fooishbar.org wrote: Hi, On 21 November 2014 08:57, Pekka Paalanen ppaala...@gmail.com wrote: I agree 100%. Again, think of nesting compositors: why should our compositor behave completely different if it's nested? The more

[PATCH v2] Increase listen queue to 128

2014-11-24 Thread Imran Zaman
This will allow more than 1 simultaneous client connections to the server without the possibility of connection refused error. Signed-off-by: Imran Zaman imran.za...@gmail.com --- src/wayland-server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wayland-server.c

Re: [PATCH v1] Added string conversion utility functions

2014-11-24 Thread Bill Spitzak
On 11/24/2014 05:08 AM, Imran Zaman wrote: Thanks Bill for your comments. Please see my comments inline. On Fri, Nov 21, 2014 at 9:31 PM, Bill Spitzak spit...@gmail.com wrote: There is no need to pass endptr, because your functions will always fail if it is not set to point to the

Re: [PATCH weston 5/6] xdg-shell: Rewrite documentation

2014-11-24 Thread Bill Spitzak
On 11/22/2014 12:28 PM, Jasper St. Pierre wrote: interface name=xdg_shell version=1 + xdg_shell allows clients to turn a wl_surface into a real window + which can be dragged, resized, stacked, and moved around by the + user. Everything about this interface is suited

Re: FreeBSD libinput

2014-11-24 Thread Ales Katona
Hey, as far as I know epoll is only available on freeBSD via the linux compatibility kernel + libraries layer, which is not installed by default. There is kqueue which is an arguably better event handling mechanism. There's an existing patch for such a rewrite here:

[PATCH libinput 2/2] test: Add test for mouse dpi tag parser

2014-11-24 Thread Derek Foreman
Signed-off-by: Derek Foreman der...@osg.samsung.com --- test/Makefile.am| 7 - test/mouse_dpi_parser.c | 69 + 2 files changed, 75 insertions(+), 1 deletion(-) create mode 100644 test/mouse_dpi_parser.c diff --git a/test/Makefile.am

Re: [PATCH v1 weston 06/11] tests: Add screenshot recording to weston-test

2014-11-24 Thread Derek Foreman
On 24/11/14 05:01 AM, Pekka Paalanen wrote: On Wed, 19 Nov 2014 15:06:21 -0800 Bryce Harrington br...@osg.samsung.com wrote: From: Derek Foreman der...@osg.samsung.com Adds wl_test_record_screenshot() to weston test. This commit also adds a dependency on cairo to weston-test to use it for

Re: [PATCH v1 weston 06/11] tests: Add screenshot recording to weston-test

2014-11-24 Thread Bryce Harrington
On Mon, Nov 24, 2014 at 04:31:01PM -0600, Derek Foreman wrote: On 24/11/14 05:01 AM, Pekka Paalanen wrote: On Wed, 19 Nov 2014 15:06:21 -0800 Bryce Harrington br...@osg.samsung.com wrote: From: Derek Foreman der...@osg.samsung.com Adds wl_test_record_screenshot() to weston test.

[PATCH] Ignore devices that have joystick buttons

2014-11-24 Thread Krzysztof A. Sobiecki
This patch allows libinput to ignore devices that have joystick buttons. Signed-off-by: Krzysztof Sobiecki sob...@gmail.com --- src/evdev.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/evdev.c b/src/evdev.c index 36c6859..5f6cc32 100644 --- a/src/evdev.c +++ b/src/evdev.c @@

Re: vc_dispmanx_set_wl_buffer_in_use not found

2014-11-24 Thread Jeff Chua
On Tue, Nov 18, 2014 at 3:45 PM, Pekka Paalanen pekka.paala...@collabora.co.uk wrote: well, with so little information, all I can ask is: are you sure you had Wayland-enabled version of a player, and the player is using GLESv2 instead of anything else like desktop OpenGL? # ldd mplayer

Re: [PATCH wayland 2/2] support specifying custom directories for the client and server

2014-11-24 Thread Jussi Laako
On 19.11.2014 12:56, Pekka Paalanen wrote: I have very hard time deciding if we should allow the environment to overwrite the server and client assumptions on where the socket is. It would be easier for me to accept new API functions that operate with absolute paths or existing fds explicitly,

Re: [PATCH v1] Added string conversion utility functions

2014-11-24 Thread Imran Zaman
On Tue, Nov 25, 2014 at 1:15 AM, Bill Spitzak spit...@gmail.com wrote: On 11/24/2014 11:32 AM, Imran Zaman wrote: [IZ2] This is the case where endptr is used in patch. I can remove endptr but it seems its used so i have to keep the existing functionality in place. + if (!weston_strtoi(pid,

Re: [PATCH libinput v3 2/3] touchpad: Add code to get the touchpad model / manufacturer

2014-11-24 Thread Peter Hutterer
On Mon, Nov 24, 2014 at 12:16:05PM +0100, Hans de Goede wrote: This is useful to know in some cases, it is e.g. necessary to figure out which percentage of a touchpads range to use as edge for edge-scrolling. Note this is a slightly cleaned up copy of the same code in xf86-input-synaptics.

Re: [PATCH 2/2] Support for adjusting socket access rights to allow group of users to connect to the socket.

2014-11-24 Thread Jussi Laako
On 19.11.2014 16:22, Pekka Paalanen wrote: When a session compositor is started, you can already use WAYLAND_SOCKET environment variable to pass an opened connection to it. If your system compositor forks session compositors, no problem. If something else starts your session compositors, you

Re: [PATCH libinput 1/2] evdev: Query mouse DPI from udev

2014-11-24 Thread Peter Hutterer
On Mon, Nov 24, 2014 at 03:53:36PM -0600, Derek Foreman wrote: Instead of using a hard coded mouse DPI value, we query it from udev. If it's not present or the property is obviously broken we fall back to default. for the archives: the thing we're struggling with on high-DPI mice is that our

Re: [PATCH libinput 2/2] test: Add test for mouse dpi tag parser

2014-11-24 Thread Peter Hutterer
On Mon, Nov 24, 2014 at 03:53:37PM -0600, Derek Foreman wrote: Signed-off-by: Derek Foreman der...@osg.samsung.com --- test/Makefile.am| 7 - test/mouse_dpi_parser.c | 69 + 2 files changed, 75 insertions(+), 1 deletion(-)

[PATCH weston] simple-shm: explain two initial roundtrips

2014-11-24 Thread Pekka Paalanen
From: Pekka Paalanen pekka.paala...@collabora.co.uk Explain carefully why we need two roundtrips, not just one, not just dispatch and roundtrip, but two roundtrips after creating the wl_registry object. Signed-off-by: Pekka Paalanen pekka.paala...@collabora.co.uk --- clients/simple-shm.c | 30