Re: [PATCH 2/2] releasing: Add example commands to release directions

2015-01-09 Thread Bryce Harrington
On Wed, Jan 07, 2015 at 10:11:29AM +1000, Peter Hutterer wrote: On Tue, Jan 06, 2015 at 02:08:39PM -0800, Bryce Harrington wrote: also, the xorg release script was modified a while ago to support wayland/weston. as much as a step-by-step instruction is useful, having everyone run the same

[PATCH weston v2 2/2] releasing: Add example commands to release directions

2015-01-09 Thread Bryce Harrington
Note that for weston, configure.ac needs version numbers updated in several places. `make distcheck` for weston no longer triggers the test suite to run, so update the directions to run a `make check` pre-release. Switch to using the X.org release.sh script in place of some of the manual steps.

[PATCH weston v2 1/2] releasing: Typo

2015-01-09 Thread Bryce Harrington
Signed-off-by: Bryce Harrington br...@osg.samsung.com --- releasing.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/releasing.txt b/releasing.txt index 2db84d5..2debcd0 100644 --- a/releasing.txt +++ b/releasing.txt @@ -26,7 +26,7 @@ To make a release follow these steps.

[PATCH wayland v2 3/3] tests: Fix FAIL in sanity-test (*timeout*) when Yama LSM enabled

2015-01-09 Thread Bryce Harrington
This fixes a regression in the testsuite since c3653f7f, where four of the timeout tests fail with Timeouts suppressed messages. The timeouts are being suppressed because the testsuite is erroneously detecting that a debugger is attached. This detection mechanism (adopted from libinput) uses

[PATCH wayland v2 1/3] tests: Fix typo evnironment

2015-01-09 Thread Bryce Harrington
Signed-off-by: Bryce Harrington br...@osg.samsung.com Reviewed-by: Marek Chalupa mchqwe...@gmail.com --- tests/test-runner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test-runner.c b/tests/test-runner.c index 753617f..9abf22f 100644 --- a/tests/test-runner.c +++

Re: [PATCH wayland 1/2] tests: Typo

2015-01-09 Thread Marek Chalupa
Reviewed-by: Marek Chalupa mchqwe...@gmail.com On 7 January 2015 at 02:11, Bryce Harrington br...@osg.samsung.com wrote: Signed-off-by: Bryce Harrington br...@osg.samsung.com --- tests/test-runner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test-runner.c

Re: Where should project Weston go?

2015-01-09 Thread Marek Chalupa
On 5 January 2015 at 16:37, Eoff, Ullysses A ullysses.a.e...@intel.com wrote: -Original Message- From: wayland-devel [mailto:wayland-devel-boun...@lists.freedesktop.org] On Behalf Of Pekka Paalanen Sent: Wednesday, December 10, 2014 8:32 AM To: wayland-devel@lists.freedesktop.org

[PATCH libinput] build-pedantic: use main(void)

2015-01-09 Thread Marek Chalupa
Main has unused parameters argc and argv. Since they are unused and C 99 allows to prototype main as 'int main(void)', remove them and replace by void. It fixes build when unused parameters are treated as errors. Signed-off-by: Marek Chalupa mchqwe...@gmail.com --- test/build-pedantic.c | 2 +-

[PATCH weston 3/6] zoom: Rename zoom_area_center_from_pointer to zoom_area_center_from_point

2015-01-09 Thread Derek Foreman
It doesn't do anything with a pointer, and zoom can be initiated by the keyboard, so the name was a little confusing. Signed-off-by: Derek Foreman der...@osg.samsung.com --- src/zoom.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/zoom.c b/src/zoom.c index

[PATCH weston 1/6] zoom: Change zoom-active to a bool

2015-01-09 Thread Derek Foreman
Signed-off-by: Derek Foreman der...@osg.samsung.com --- src/compositor.h | 2 +- src/zoom.c | 7 --- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/compositor.h b/src/compositor.h index 3f7ed4a..311bea0 100644 --- a/src/compositor.h +++ b/src/compositor.h @@ -152,7

[PATCH weston 2/6] zoom: Call weston_output_activate_zoom() appropriately

2015-01-09 Thread Derek Foreman
No longer call weston_output_update_zoom() when trying to zoom out on an unzoomed output. Add an assert() to make sure update_zoom is never called without an active zoom. Signed-off-by: Derek Foreman der...@osg.samsung.com --- desktop-shell/shell.c | 5 - src/zoom.c| 2 ++ 2

[PATCH weston 5/6] zoom: Only use a motion listener if a pointer is available

2015-01-09 Thread Derek Foreman
If no pointer is available for a seat, we no longer try to install a motion listener. Also, we now add a motion listener when a pointer device is plugged in. Note that a seat may have a pointer when the device to move it has been removed - in this case we still add the listener and it will work

[PATCH weston 4/6] zoom: Store the seat that initiated a zoom

2015-01-09 Thread Derek Foreman
Track the seat that initiated a seat instead of picking the first one. Signed-off-by: Derek Foreman der...@osg.samsung.com --- desktop-shell/shell.c | 2 +- src/compositor.h | 4 +++- src/zoom.c| 20 +++- 3 files changed, 11 insertions(+), 15 deletions(-) diff

[PATCH weston 6/6] zoom: Change how we select a zoom location

2015-01-09 Thread Derek Foreman
Any time the zoom is updated the best zoom target will be calculated with the following priority: 1) The current pointer location. 2) The last known location of the pointer that initiated the zoom. 3) The center of the current keyboard focus. If the focus is split across heads, multiple heads

[PATCH weston 0/6] Better multi-seat zoom handling

2015-01-09 Thread Derek Foreman
This started out as a small patch to stop weston from crashing when attempting to zoom with the key bind on a pointerless seat... Zoom shouldn't crash when no pointer is present, and multiple seats shouldn't interfere with eachother's zoom anymore. The new target picking semantics hopefully

[PATCH weston 1/2] shell: fix positioning of maximized surfaces with a custom geometry

2015-01-09 Thread Giulio Camuffo
--- desktop-shell/shell.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index a7514f7..f6d9c79 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shell.c @@ -5374,8 +5374,13 @@ set_maximized_position(struct

[PATCH weston v2 2/2] xwm: support maximizing xwayland windows

2015-01-09 Thread Giulio Camuffo
This patch adds the maximize button to the window frame for the windows which set the MWM_DECOR_MAXIMIZE hint, and it wires it with the shell via a new method in weston_shell_interface. Additionally, it also listens for the wm hints coming from the client, but it doesn't support maximizing a

Re: [PATCH weston v2 08/20] compositor: add weston_matrix_transform_rect() and use it where appropriate

2015-01-09 Thread Giulio Camuffo
Just a nitpick below: 2014-10-16 18:55 GMT+03:00 Derek Foreman der...@osg.samsung.com: New function that transforms a pixman_box32_t rectangle by a matrix. Since pixman rectangles are represented by 2 corners, non-90 degree rotations can't be properly represented. This function gives the

Re: [PATCH weston v2 01/20] weston_surface: Add surface-to-buffer and buffer-to-surface matrices

2015-01-09 Thread Derek Foreman
On 09/01/15 02:52 PM, Giulio Camuffo wrote: I have a comment below, the rest looks good to me. 2014-10-16 18:55 GMT+03:00 Derek Foreman der...@osg.samsung.com: From: Jason Ekstrand ja...@jlekstrand.net --- src/compositor.c | 84

Re: [PATCH weston v2 01/20] weston_surface: Add surface-to-buffer and buffer-to-surface matrices

2015-01-09 Thread Giulio Camuffo
I have a comment below, the rest looks good to me. 2014-10-16 18:55 GMT+03:00 Derek Foreman der...@osg.samsung.com: From: Jason Ekstrand ja...@jlekstrand.net --- src/compositor.c | 84 src/compositor.h | 6 2 files changed,

Re: [PATCH weston v2 05/20] pixman-renderer: Add a weston_matrix_to_pixman_transform function and simplify the buffer-to-output matrix computation

2015-01-09 Thread Giulio Camuffo
One comment below, otherwise looks fine 2014-10-16 18:55 GMT+03:00 Derek Foreman der...@osg.samsung.com: From: Jason Ekstrand ja...@jlekstrand.net Now that we have a buffer-to-surface matrix and the global-to-output matrix is in pixels, we can remove a large chunk of confusing code from the

Re: [PATCH weston v2 05/20] pixman-renderer: Add a weston_matrix_to_pixman_transform function and simplify the buffer-to-output matrix computation

2015-01-09 Thread Derek Foreman
Thanks for looking at this! On 09/01/15 03:15 PM, Giulio Camuffo wrote: One comment below, otherwise looks fine 2014-10-16 18:55 GMT+03:00 Derek Foreman der...@osg.samsung.com: From: Jason Ekstrand ja...@jlekstrand.net Now that we have a buffer-to-surface matrix and the global-to-output

Re: [PATCH v2 libinput] Change axis events to carry all directions

2015-01-09 Thread Hans de Goede
Hi, On 07-01-15 02:33, Peter Hutterer wrote: Sending separate axis events instead of one unified events is limiting, especially when simultaneously scrolling in both directions and the caller tries to implement kinetic scrolling. Take a page from the tablet-support branch and instead implement

Re: [PATCH v2 libinput 3/6] touchpad: add a TOUCH_HOVERING state

2015-01-09 Thread Hans de Goede
Hi Peter, On 07-01-15 01:14, Peter Hutterer wrote: Some touchpads provide touch information while the finger hovers over the touchpad, i.e. before BTN_TOUCH. Add a touch state for those touchpads so we can ignore the touches until they actually start. The approach is now: instead of BEGIN we

Re: [PATCH libinput] test: add another hover test

2015-01-09 Thread Hans de Goede
Hi, On 07-01-15 01:18, Peter Hutterer wrote: Release one touch point at the same time as a fake touch. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- I'll squash it in with the other tests before merging but for easier review it's separate here. This tests for the scenario Hans