Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-27 Thread Hans de Goede
Hi, On 23-01-15 14:57, Hans de Goede wrote: Hi, On 23-01-15 14:53, Jonas Ådahl wrote: On Fri, Jan 23, 2015 at 12:18:01PM +0100, Hans de Goede wrote: Hi, On 23-01-15 05:21, Peter Hutterer wrote: +double +libinput_event_gesture_get_absolute_x(struct libinput_event_gesture *event); this

Re: [PATCH weston 2/2] libinput: Ignore non seat wide keyboard key events

2015-01-27 Thread Peter Hutterer
On Wed, Jan 28, 2015 at 12:18:01PM +0800, Jonas Ådahl wrote: > Keyboard key events will be received from a device where a key has > been pressed, even though an equivalent key has been pressed (same > key code) on a device connected to the same seat. notify_key() > expects to only be called as if t

[PATCH weston 2/2] libinput: Ignore non seat wide keyboard key events

2015-01-27 Thread Jonas Ådahl
Keyboard key events will be received from a device where a key has been pressed, even though an equivalent key has been pressed (same key code) on a device connected to the same seat. notify_key() expects to only be called as if there was only one keyboard device associated with the given seat, so

[PATCH weston 1/2] libinput: Ignore non seat wide pointer button events

2015-01-27 Thread Jonas Ådahl
Pointer button events will be received from a device where a button has been pressed, even though an equivalent button has been pressed (same button code) on a device connected to the same seat. notify_button() expects to only be called as if there was only one pointer device associated with the gi

Re: [PATCH weston] xwm: fix use after free

2015-01-27 Thread Bryce Harrington
On Fri, Dec 26, 2014 at 06:10:35PM +0200, Giulio Camuffo wrote: > Calling wl_event_source_remove() will free the event source later, so > reset the pointer to avoid calling it two times on the same pointer. > Fix a compositor crash when copying some text from weston terminal, > pasting it in the sa

Re: [PATCH wayland] event-loop: Process idle callbacks after the epoll fds

2015-01-27 Thread Bill Spitzak
This does not look right to me: it means that the idle function will not get called until some message comes in from a client. On 01/27/2015 02:21 PM, Derek Foreman wrote: To fix a shutdown crash in weston's x11 compositor I want to move the weston X window close to an idle handler. Since idle

Re: [PATCH weston 2/3] clients: Require EGL_MIN_SWAP_INTERVAL to be 0 for subsurfaces

2015-01-27 Thread Jonas Ådahl
On Tue, Jan 27, 2015 at 09:29:52AM -0600, Derek Foreman wrote: > On 26/01/15 08:24 PM, Jonas Ådahl wrote: > > On Mon, Jan 26, 2015 at 02:27:51PM -0600, Derek Foreman wrote: > >> On 26/01/15 04:19 AM, Jonas Ådahl wrote: > >>> Warn and fail when trying to create sub surfaces when swap interval 0 is >

Re: [PATCH weston v4] xwm: tell the shell the pid of the X clients

2015-01-27 Thread Bill Spitzak
On 01/27/2015 12:00 PM, Daniel Stone wrote: If the hostname's been truncated, then it's not useful for our purposes. I would think the truncated hostname would provide more information such as in an error message. But anyway this could be done this way: name[sizeof(name)-1] = 0;

[PATCH wayland v2] doc: Fill in high level description for Surfaces

2015-01-27 Thread Bryce Harrington
Signed-off-by: Bryce Harrington --- doc/publican/sources/Protocol.xml | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/doc/publican/sources/Protocol.xml b/doc/publican/sources/Protocol.xml index b79b6be..d2d7a7e 100644 --- a/doc/publican/sources/Protocol.xml +++

Re: [PATCH v2 libinput 3/3] Deprecate libinput_device_has_capability

2015-01-27 Thread Jonas Ådahl
On Wed, Jan 28, 2015 at 09:47:28AM +1000, Peter Hutterer wrote: > With the introduction of capability events, this is theoretically racy. > > In the current implementation that's fine as we add the capabilities before we > return the device, but in the future a capability event may be in the event

Re: [PATCH v2 libinput] Restore capability events

2015-01-27 Thread Jonas Ådahl
On Wed, Jan 28, 2015 at 09:45:31AM +1000, Peter Hutterer wrote: > This reverts commit ab9260c5c70b95779f39069b31646ff5cf8970ad, with a bunch of > changes on top. > > First change is different naming, the events are now DEVICE_CAPABILITY_ADDED > and DEVICE_CAPABILITY_REMOVED for consistency with th

[PATCH v2 libinput 3/3] Deprecate libinput_device_has_capability

2015-01-27 Thread Peter Hutterer
With the introduction of capability events, this is theoretically racy. In the current implementation that's fine as we add the capabilities before we return the device, but in the future a capability event may be in the event queue to add/remove a capability, so this call is unreliable. Signed-o

[PATCH v2 libinput] Restore capability events

2015-01-27 Thread Peter Hutterer
This reverts commit ab9260c5c70b95779f39069b31646ff5cf8970ad, with a bunch of changes on top. First change is different naming, the events are now DEVICE_CAPABILITY_ADDED and DEVICE_CAPABILITY_REMOVED for consistency with the device events. The behaviour of capability events is as previously, the

Re: [PATCH weston v3] xwm: support maximizing xwayland windows

2015-01-27 Thread Bryce Harrington
On Tue, Jan 27, 2015 at 03:24:54PM -0800, Bryce Harrington wrote: > On Tue, Jan 27, 2015 at 07:40:46PM +0200, Giulio Camuffo wrote: > > This patch adds the maximize button to the window frame for the windows > > which set the MWM_DECOR_MAXIMIZE hint, and it wires it with the shell > > via a new met

Re: [PATCH weston v3] xwm: support maximizing xwayland windows

2015-01-27 Thread Bryce Harrington
On Tue, Jan 27, 2015 at 07:40:46PM +0200, Giulio Camuffo wrote: > This patch adds the maximize button to the window frame for the windows > which set the MWM_DECOR_MAXIMIZE hint, and it wires it with the shell > via a new method in weston_shell_interface. > Additionally, it also listens for the wm

Re: Is the RDP backend suppose to work?

2015-01-27 Thread Hardening
Le 24/01/2015 20:00, John Obaterspok a écrit : > Hello, > > I've tried for quite some time to get the RDP backend going. Perhaps > it's just me that's not setting things up correctly. I'm trying this on > a updated 64-bit Fedora 21 box that has Wayland 1.6 and > freerdp-1.2.0-0.2.beta.1.fc21.x86_6

Re: [PATCH weston 7/7] text: Fix text-input for multi-seat

2015-01-27 Thread Bryce Harrington
On Fri, Dec 05, 2014 at 03:38:41PM -0600, Derek Foreman wrote: > Multi-seat configurations currently break the text-backend, crashing > weston. This is an attempt to clean up any crashes and have somewhat > sensible input panel behavior with multi-seat. > > Signed-off-by: Derek Foreman Offhand

Re: [PATCH v2 weston] editor: Make editor multi-seat aware

2015-01-27 Thread Bryce Harrington
On Thu, Dec 18, 2014 at 08:13:24PM +, Jan Arne Petersen wrote: > Hey, > > On Wed Dec 17 2014 at 4:53:24 PM Derek Foreman > wrote: > > > With multi-seat, multiple entries can occur on the text inputs in the > > editor. Also, the panel shouldn't be hidden by the editor if either > > text entr

Re: [PATCH weston 0/6] Better multi-seat zoom handling

2015-01-27 Thread Bryce Harrington
Giulio or Jonas, would one of you mind doing a design review of this patchset? Thanks, Bryce On Fri, Jan 09, 2015 at 12:45:13PM -0600, Derek Foreman wrote: > This started out as a small patch to stop weston from crashing when > attempting to zoom with the key bind on a pointerless seat... > > Zo

[PATCH weston] compositor-x11: Move the x11 window close to an idle handler

2015-01-27 Thread Derek Foreman
The input loop is actually dispatched in the middle of the frame repaint. When the X11 event results in closing the compositor, this can cause the current output to be destroyed just prior to trying to process animations on it. We fix this by handling the window close event in an idle callback. N

[PATCH wayland] event-loop: Process idle callbacks after the epoll fds

2015-01-27 Thread Derek Foreman
To fix a shutdown crash in weston's x11 compositor I want to move the weston X window close to an idle handler. Since idle handlers are processed at the start of an event loop, the handler that deals with window close will run at the start of the next input_loop dispatch, after which the dispatche

Re: [PATCH weston] xwm: set the _NET_WM_DESKTOP property of the windows

2015-01-27 Thread Bryce Harrington
On Tue, Jan 27, 2015 at 11:13:36AM +, Daniel Stone wrote: > Hi, > > On 13 December 2014 at 16:06, Giulio Camuffo wrote: > > Some X clients use the _NET_WM_DESKTOP property to tell if the window > > is mapped or not. If set, it should say the virtual desktop the window > > is currently in, if

Re: [weston,v1,17/17] tests: add interactive tests

2015-01-27 Thread Bryce Harrington
On Fri, Dec 05, 2014 at 02:36:50PM +0100, Marek Chalupa wrote: > These tests are using pointer and keyboard simulated events > to interact with client. > > Signed-off-by: Marek Chalupa Hi Marek, This patch series has a number of different improvements for tests, and looks like a good candidate

Re: [weston, v2, 17/17] configure: add an option to allow building only the libraries

2015-01-27 Thread Bryce Harrington
On Thu, Dec 04, 2014 at 11:01:23PM +0200, Giulio Camuffo wrote: > the --enable/disable-weston-binaries emable or disable the creation > of the 'weston', 'weston-launch' and all the binaries that are > installed in $prefix/lib/libexec. This allows, together with > --enable-clients, to only build the

Re: [6/6] image demo client: Add support for color management

2015-01-27 Thread Bryce Harrington
On Mon, Oct 13, 2014 at 07:40:51PM +0200, Niels Ole Salscheider wrote: > You can now use "C" to switch between the following modes: > - Assume sRGB input color space > - Assume that the input color space is the blending color space > - Attach a false-color ICC profile to the surface > > Signed-off

Re: [PATCH weston v5] xwm: tell the shell the pid of the X clients

2015-01-27 Thread Giulio Camuffo
2015-01-27 22:00 GMT+02:00 Jasper St. Pierre : > The only existing use I see for the PID is for killing the client. There is already a mechanism for that anyway, so nothing needs to be added. > > I'd also argue that using the PID for application tracking is bound to go > awry for a variety of rea

Re: [PATCH weston v5] xwm: tell the shell the pid of the X clients

2015-01-27 Thread Jasper St. Pierre
The only existing use I see for the PID is for killing the client. I'd also argue that using the PID for application tracking is bound to go awry for a variety of reasons, and you should use WM_CLASS or _GTK_APPLICATION_ID for more complete tracking. On Tue, Jan 27, 2015 at 12:29 PM, Giulio Camuf

Re: [PATCH weston v4] xwm: tell the shell the pid of the X clients

2015-01-27 Thread Daniel Stone
Hi, On 27 January 2015 at 19:56, Bill Spitzak wrote: > On 01/27/2015 06:52 AM, Daniel Stone wrote: >> POSIX.1-2001 says that if such >> truncation occurs, then it is unspecified whether the returned >> buffer includes a terminating >> null byte. >> >> I think the best thing to do

Re: [PATCH weston v4] xwm: tell the shell the pid of the X clients

2015-01-27 Thread Bill Spitzak
On 01/27/2015 06:52 AM, Daniel Stone wrote: POSIX.1-2001 says that if such truncation occurs, then it is unspecified whether the returned buffer includes a terminating null byte. I think the best thing to do here would be: for (i = 0; i < sizeof(name); i++) { if (name[

Re: [PATCH wayland 2/8] test-compositor: extend leak checks into clients

2015-01-27 Thread Bill Spitzak
On 01/27/2015 04:24 AM, Daniel Stone wrote: I like the second patch (the one that tests if WAYLAND_SOCKET was cleared) better but this: + if (!getenv("WAYLAND_SOCKET")) + consumed_inherited_fd = 1; + + check_leaks(cur_alloc, cur_fds - consumed_inherited_fd); could in

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-27 Thread Bill Spitzak
On 01/26/2015 09:49 PM, Jonas Ådahl wrote: I'd say either this (2fg swipe doesn't exist), or generate both scroll events and 2fg swipe gesture events for 2fg swiping movements. Either the 2fg scroll feature "eats" its corresponding swipe gesture feaure and we ignore its existance, or we emit mul

Re: Change screens color temperature

2015-01-27 Thread Giulio Camuffo
2015-01-27 19:47 GMT+02:00 Matthias Treydte : > >> installed "Redshift", a tool to change the color temperature of your >> screen according to the time of day: > > >> Sadly it's only implemented for Xorg, so I can't "make an app" that uses >> redshift on Jolla. > > > Redshift already has a "drm" mo

Re: Change screens color temperature

2015-01-27 Thread Matthias Treydte
installed "Redshift", a tool to change the color temperature of your screen according to the time of day: Sadly it's only implemented for Xorg, so I can't "make an app" that uses redshift on Jolla. Redshift already has a "drm" module, which might be compatible with weston. I just tried it

[PATCH weston v3] xwm: support maximizing xwayland windows

2015-01-27 Thread Giulio Camuffo
This patch adds the maximize button to the window frame for the windows which set the MWM_DECOR_MAXIMIZE hint, and it wires it with the shell via a new method in weston_shell_interface. Additionally, it also listens for the wm hints coming from the client, but it doesn't support maximizing a window

Re: [PATCH weston v2 2/2] xwm: support maximizing xwayland windows

2015-01-27 Thread Giulio Camuffo
2015-01-27 17:28 GMT+02:00 Daniel Stone : > Hi, > > On 9 January 2015 at 18:10, Giulio Camuffo wrote: >> + if (maximized != window->maximized_vert && >> window->maximized_horz) { > > Surely this needs to be: > if (maximized != (window->maximized_vert && window->maximized_horz))? Oo

Re: [PATCH weston v5] xwm: tell the shell the pid of the X clients

2015-01-27 Thread Giulio Camuffo
2015-01-27 19:23 GMT+02:00 Jasper St. Pierre : > Are you still not using XKillClient for some reason? This patch is not about killing X clients, it's about passing the pid to the shell, so not sure what relevance it has. > > On Tue, Jan 27, 2015 at 12:10 PM, Giulio Camuffo > wrote: >> >> All the

Re: [PATCH weston v5] xwm: tell the shell the pid of the X clients

2015-01-27 Thread Jasper St. Pierre
Are you still not using XKillClient for some reason? On Tue, Jan 27, 2015 at 12:10 PM, Giulio Camuffo wrote: > All the surfaces from all the X clients share the same wl_client so > wl_client_get_credentials can't be used to get the pid of the X > clients. > The shell may need to know the pid to

[PATCH v2 1/1] configure.ac: use pkg-config to find expat

2015-01-27 Thread Andrew Oakley
This is now done in the same way as the libffi dependency and still allows the library to be installed in a non-standard location (with PKG_CONFIG_PATH). --- Makefile.am | 1 + configure.ac | 11 +-- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/Makefile.am b/Makefile.a

Re: [PATCH 1/1] configure.ac: use pkg-config to find expat

2015-01-27 Thread Andrew Oakley
On 27/01/15 16:32, sardemff7+wayl...@sardemff7.net wrote: > Once the two things below are fixed: > > Reviewed-by: Quentin Glidic Thanks for the review, didn't know about the AM_CFLAGS thing! ___ wayland-devel mailing list wayland-devel@lists.freedeskto

[PATCH weston v5] xwm: tell the shell the pid of the X clients

2015-01-27 Thread Giulio Camuffo
All the surfaces from all the X clients share the same wl_client so wl_client_get_credentials can't be used to get the pid of the X clients. The shell may need to know the pid to be able to associate a surface with e.g. a DBus service. --- v5: added the check on the hostname desktop-shell/shell.

Re: [PATCH 1/1] configure.ac: use pkg-config to find expat

2015-01-27 Thread sardemff7+wayland
Once the two things below are fixed: Reviewed-by: Quentin Glidic On 2015-01-26 15:32, Andrew Oakley wrote: This is now done in the same way as the libffi dependency and still allows the library to be installed in a non-standard location (with PKG_CONFIG_PATH). We also now enable the normal G

Re: Is the RDP backend suppose to work?

2015-01-27 Thread Manuel Bachmann
Hi John, >From my experience, a certificate is necessary. I see that you are generating the certificate manually ; please try to use the steps described in the following tutorial : https://wiki.tizen.org/wiki/Weston_RDP_access (the "winpr-makecert" tool should be build in one the "winpr" subdire

Re: Change screens color temperature

2015-01-27 Thread Daniel Stone
Hi, On 23 December 2014 at 11:42, Ruben De Smet wrote: > I'm a proud Jolla owner and therefore a daily Wayland user. I just > installed "Redshift", a tool to change the color temperature of your > screen according to the time of day: > http://jonls.dk/redshift/ > > Sadly it's only implemented for

Re: [PATCH weston 2/3] clients: Require EGL_MIN_SWAP_INTERVAL to be 0 for subsurfaces

2015-01-27 Thread Derek Foreman
On 26/01/15 08:24 PM, Jonas Ådahl wrote: > On Mon, Jan 26, 2015 at 02:27:51PM -0600, Derek Foreman wrote: >> On 26/01/15 04:19 AM, Jonas Ådahl wrote: >>> Warn and fail when trying to create sub surfaces when swap interval 0 is >>> not supported by the EGL platform. >>> >>> Signed-off-by: Jonas Ådah

Re: [PATCH weston v2 2/2] xwm: support maximizing xwayland windows

2015-01-27 Thread Daniel Stone
Hi, On 9 January 2015 at 18:10, Giulio Camuffo wrote: > + if (maximized != window->maximized_vert && > window->maximized_horz) { Surely this needs to be: if (maximized != (window->maximized_vert && window->maximized_horz))? You could break this out into a separate local variable

Change screens color temperature

2015-01-27 Thread Ruben De Smet
Hello I'm a proud Jolla owner and therefore a daily Wayland user. I just installed "Redshift", a tool to change the color temperature of your screen according to the time of day: http://jonls.dk/redshift/ Sadly it's only implemented for Xorg, so I can't "make an app" that uses redshift on Jolla.

[PATCH 1/1] configure.ac: use pkg-config to find expat

2015-01-27 Thread Andrew Oakley
This is now done in the same way as the libffi dependency and still allows the library to be installed in a non-standard location (with PKG_CONFIG_PATH). We also now enable the normal GCC options when building the scanner. --- Makefile.am | 1 + configure.ac | 11 +-- 2 files changed, 2

Is the RDP backend suppose to work?

2015-01-27 Thread John Obaterspok
Hello, I've tried for quite some time to get the RDP backend going. Perhaps it's just me that's not setting things up correctly. I'm trying this on a updated 64-bit Fedora 21 box that has Wayland 1.6 and freerdp-1.2.0-0.2.beta.1.fc21.x86_64. [john@testbox ~]$ weston --backend=rdp-backend.so Date:

Re: [PATCH weston v4] xwm: tell the shell the pid of the X clients

2015-01-27 Thread Daniel Stone
Hi, On 12 January 2015 at 17:04, Giulio Camuffo wrote: > diff --git a/xwayland/window-manager.c b/xwayland/window-manager.c > index f362eac..748c896 100644 > --- a/xwayland/window-manager.c > +++ b/xwayland/window-manager.c > @@ -401,6 +401,7 @@ weston_wm_window_read_properties(struct weston_wm_w

Re: [PATCH weston] ivi-shell-transition: check create_layout_transition() return value.

2015-01-27 Thread Daniel Stone
Tanibata-san, On 19 January 2015 at 02:04, Tanibata, Nobuhiko (ADITJ/SWG) wrote: > I basically agree this solution. > When I observe other code in Weston. There are two patterns when error > happens in Weston. > - just output error by Weston_log. And then return from the method. > - use wl_resou

Re: [PATCH weston 6/6] compositor-headless: Add test mode

2015-01-27 Thread Daniel Stone
Hi, On 19 December 2014 at 18:45, Derek Foreman wrote: > static int > headless_output_repaint(struct weston_output *output_base, >pixman_region32_t *damage) > { > struct headless_output *output = (struct headless_output *) > output_base; > struct weston

Re: [PATCH weston v2 1/6] test: Add a compositor test-mode

2015-01-27 Thread Daniel Stone
Hi, On 22 December 2014 at 22:08, Derek Foreman wrote: > diff --git a/protocol/wayland-test.xml b/protocol/wayland-test.xml > index 18b6625..292abe9 100644 > --- a/protocol/wayland-test.xml > +++ b/protocol/wayland-test.xml > @@ -26,7 +26,7 @@ > THIS SOFTWARE. > > > - > + > >

Re: [PATCH wayland 2/8] test-compositor: extend leak checks into clients

2015-01-27 Thread Daniel Stone
Hi, On 19 December 2014 at 13:53, Marek Chalupa wrote: > diff --git a/tests/test-compositor.h b/tests/test-compositor.h > index c41b17b..f77a5db 100644 > --- a/tests/test-compositor.h > +++ b/tests/test-compositor.h > @@ -95,3 +95,9 @@ struct client_info *client_create_with_name(struct display >

Re: [RFC wayland] cpp-test: check for C++ compiler

2015-01-27 Thread Daniel Stone
Hi, On 19 December 2014 at 19:20, Mariusz Ceier wrote: > This won't work when there's C++ compiler but no 'which', but I think that's > ok, since it only affects 1 test. > > Reviewed-by: Mariusz Ceier > > On 19 December 2014 at 17:40, Marek Chalupa wrote: >> >> Do not try to build it if no C++

Re: [PATCH weston] xwm: set the _NET_WM_DESKTOP property of the windows

2015-01-27 Thread Daniel Stone
Hi, On 13 December 2014 at 16:06, Giulio Camuffo wrote: > Some X clients use the _NET_WM_DESKTOP property to tell if the window > is mapped or not. If set, it should say the virtual desktop the window > is currently in, if unset it means the window is unmapped. > The xwm currently has no way to k

Re: [PATCH weston] compositor-x11: Move the x11 event handler to the display loop

2015-01-27 Thread Daniel Stone
Hi, On 19 December 2014 at 15:02, Pekka Paalanen wrote: > On Fri, 19 Dec 2014 08:08:33 -0600 > Derek Foreman wrote: >> On 19/12/14 06:40 AM, Pekka Paalanen wrote: >> > There is some fancy input scheduling going on with the repaint loop, so >> > that input events would be sent as a burst to the c

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-27 Thread Jonas Ådahl
On Tue, Jan 27, 2015 at 10:12:20AM +0100, Hans de Goede wrote: > Hi, > > On 27-01-15 05:22, Peter Hutterer wrote: > > > > >or, even easier: 2fg swipe doesn't exist, use scrolling instead. > > Right, that is what I'm going for, big +1 AFAIK other OS don't > even have 2fg swipe, why would we in

Re: [RFC libinput] Add an API for touchpad gesture events

2015-01-27 Thread Hans de Goede
Hi, On 27-01-15 05:22, Peter Hutterer wrote: or, even easier: 2fg swipe doesn't exist, use scrolling instead. Right, that is what I'm going for, big +1 AFAIK other OS don't even have 2fg swipe, why would we invent something new here, and getting ourselves in a place of hurt while doing so.