On 22/07/15 02:25 AM, Marek Chalupa wrote:
Thanks for review,
On 07/17/2015 11:02 PM, Derek Foreman wrote:
On 16/07/15 06:59 AM, Marek Chalupa wrote:
Create functions for structures allocation (instead of inlining it into
the code) and free the objects after we don't use them anymore.
Thanks for review,
On 07/17/2015 11:02 PM, Derek Foreman wrote:
On 16/07/15 06:59 AM, Marek Chalupa wrote:
Create functions for structures allocation (instead of inlining it into
the code) and free the objects after we don't use them anymore.
Signed-off-by: Marek Chalupa mchqwe...@gmail.com
On Tue, Jul 21, 2015 at 10:15:24PM +0200, Hans de Goede wrote:
Hi,
On 07/16/2015 01:55 AM, Peter Hutterer wrote:
On Wed, Jul 15, 2015 at 11:44:47AM -0400, Benjamin Tissoires wrote:
On Mon, Jul 13, 2015 at 11:39 PM, Peter Hutterer
peter.hutte...@who-t.net wrote:
These touchpads have a
Dominic Jänichen d.newsgroups@... writes:
Hello Peter,
did you think about Thinkpads? For me, having physical buttons above
the touchpad is the reason to have the thumb on it... That is, while using
the trackpoint.
(This particular touchpad also is a clickpad, but there is (older) models
Peter Hutterer peter.hutterer@... writes:
The use-case we have thumb detection for is to let a user rest a
thumb on the touchpad before clicking. On a touchpad with physical
buttons, the thumb won't be resting on the touchpad.
Hello Peter,
did you think about Thinkpads? For me, having
Hi,
On 22-07-15 07:09, Peter Hutterer wrote:
On touchpads with a higher resolution we also see higher pressure values.
Scale accordingly, but use the T440s as reference and don't go below that
device's threshold. A false positive is worse than a false negative when it
comes to thumb detection.
Hi,
On 22-07-15 07:09, Peter Hutterer wrote:
That's the most likely area it will be resting in, if it's sitting anywhere
above that it's likely part of an interaction.
A thumb in the lowest 15mm needs to trigger the pressure threshold before it's
labelled a thumb. A thumb in the lowest 8mm is
Hi,
On 14-07-15 05:41, Peter Hutterer wrote:
Rather than magic percentages of the touchpad axis ranges, make it a fixed
size of 7mm. Except on synaptics touchpads, because they won't give us the
actual axis range but rather the typical bezel limits.
Signed-off-by: Peter Hutterer
Hi,
On 15-07-15 04:32, Peter Hutterer wrote:
Thumb detection interfered with gestures a fair bit but it shouldn't. A pinch
gesture with a thumb is a fairly natural move so we shouldn't cancel that.
A swipe gesture with a thumb on the touchpad - well, don't do that. No need
for code here.
Hi,
On 21-07-15 07:51, Peter Hutterer wrote:
Synaptics touchpads internally detect 5 touches but we use the serial
protocol in the kernel. That only allows for 2 slots so we get odd cursor
jumps whenever a third finger is put on the touchpad. Those come in two
varieties:
1) one slot ends when
Hi,
On 21-07-15 09:20, Peter Hutterer wrote:
3mm is too large, especially on fine-grained scroll motions. Since we
already use the hysteresis to defuzz the current touchpad point, having a
slower threshold here should not cause any adverse motions.
This affects the pinch gestures too and needs
Hi,
On 22-07-15 07:09, Peter Hutterer wrote:
The average human hand has four fingers but only one thumb, i.e. the chance of
a fake finger being close to the top-most touch is higher than to whatever the
first touch was (which may be a thumb at the bottom of the touchpad).
So search for the
Hi,
On 22-07-15 07:09, Peter Hutterer wrote:
A thumb may not move, but may change pressure so we need to process
accordingly.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Patches 8 - 10 LGTM:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
Hi,
On 22-07-15 07:09, Peter Hutterer wrote:
If a thumb moves around, it's not resting and we should consider it a normal
touch.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
src/evdev-mt-touchpad.c | 16
src/evdev-mt-touchpad.h | 1 +
test/touchpad.c
Hi,
On 13-07-15 04:46, Peter Hutterer wrote:
DWT can interfere with some applications where keyboard and touchpad use at
the same time is common, e.g. games but also anything that requires a
combination of frequent pointer motion and use of keyboard shortcuts.
Expose a toggle to disable DWT
On Wed, Jul 22, 2015 at 03:54:02PM +0200, Hans de Goede wrote:
Hi,
On 22-07-15 07:09, Peter Hutterer wrote:
If a thumb moves around, it's not resting and we should consider it a normal
touch.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
src/evdev-mt-touchpad.c | 16
On Wed, Jul 22, 2015 at 03:51:09PM +0200, Hans de Goede wrote:
Hi,
On 22-07-15 07:09, Peter Hutterer wrote:
That's the most likely area it will be resting in, if it's sitting anywhere
above that it's likely part of an interaction.
A thumb in the lowest 15mm needs to trigger the pressure
On 07/22/2015 07:43 PM, Derek Foreman wrote:
On 22/07/15 02:25 AM, Marek Chalupa wrote:
Thanks for review,
On 07/17/2015 11:02 PM, Derek Foreman wrote:
On 16/07/15 06:59 AM, Marek Chalupa wrote:
Create functions for structures allocation (instead of inlining it into
the code) and free the
This was a stopgap measure to support the Lenovo Carbon X1 3rd and the Lenovo
*50 series. These devices have the trackpoint buttons wired to the touchpad
and thus trackpoint events came from the touchpad device.
This was fixed in the kernel commit cdd9dc195916ef5644cfac079094c3c1d1616e4c,
the
We're again hitting the fork ulimits again (see also 9c2afae14) causing test
case failures in the valgrind run of the touchpad test.
Split out the touchpad button tests so we don't require special ulimits on
test boxes.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
FWIW, the fork
Installing the udev rules and reloading udevadm takes around 150ms each
time. For test-pointer alone (currently 336 tests) this adds almost a
minute to the runtime.
The model quirks and libinput udev rules don't change, so installing them once
at the start of the test run is sufficient.
Free all the memory we have allocated during running.
v2.: split creating objects and getting rid of leaks
into two patches
move check for NULL description into free_description
Signed-off-by: Marek Chalupa mchqwe...@gmail.com
---
src/scanner.c | 110
wrap creating and initializing objects (structures)
into functions and use them in the code.
Signed-off-by: Marek Chalupa mchqwe...@gmail.com
---
src/scanner.c | 158 ++
1 file changed, 105 insertions(+), 53 deletions(-)
diff --git
Hi folks,
It's been some time since I started developing a tool called wldbg in my
free time. I'm using it while debugging applications based on wayland
and I think it is in enough good shape to bring it out (although there
is still a lot of missing features I'd like to add/fix)
It can work
24 matches
Mail list logo
