Re: [PATCH wayland-protocols v2 2/2] Introduce pointer locking and confinement protocol

2016-01-18 Thread Bill Spitzak
On Fri, Jan 15, 2016 at 8:08 AM, Daniel Stone wrote: > Hi, > > On 12 January 2016 at 22:28, Bill Spitzak wrote: > > There should *only* be "one shot" requests, which are very quickly > accepted > > or denied by the compositor. The client creates it in

Re: [PATCH wayland v10 2/2] protocol: Add DnD actions

2016-01-18 Thread Bill Spitzak
> + While managing an "ask" action, the destination drag-and-drop > client > + may perform further wl_data_offer.receive requests, and is expected > + to perform one last wl_data_offer.set_actions request with a > preferred > + action other than "ask" (and optionally

Re: [PATCH libinput 5/7] tablet: add support for relative x/y motion deltas

2016-01-18 Thread Bill Spitzak
Isn't dx_unaccelerated exactly equal to the differences between x values? If not then I suspect the only difference is a linear scaling (ie between tablet-width/height or mm or whatever the xy are using and the pointer-like coordinates the dx are using). I think it would be less confusing if

[PATCH wayland] protocol: Add note about per version requirements to wl_data_device_manager

2016-01-18 Thread Jonas Ådahl
Add a note to the wl_data_device_manager global interface about the different requirements for operating the objects created from the bound global. Signed-off-by: Jonas Ådahl --- Pekka suggested we should add a note about the per version requirements

[PATCH wayland v4] tests: Test proxy versions

2016-01-18 Thread Derek Foreman
Add a test that confirms that proxy versions are always 0 for display and correct otherwise. Signed-off-by: Derek Foreman --- Patch broke when Jonas added user data to client_create, so I took the hint and re-implemented using user data instead of a global variable.

Re: [PATCH libinput 5/7] tablet: add support for relative x/y motion deltas

2016-01-18 Thread Bill Spitzak
On 01/17/2016 02:26 PM, Peter Hutterer wrote: On Fri, Jan 15, 2016 at 12:06:27PM -0800, Bill Spitzak wrote: Isn't dx_unaccelerated exactly equal to the differences between x values? hah, yes. indeed. that actually means we can drop it from the API since a client can use the mm value instead,

Re: [PATCH wayland-protocols v2 2/2] Introduce pointer locking and confinement protocol

2016-01-18 Thread Daniel Stone
Hi, On 15 January 2016 at 19:30, Bill Spitzak wrote: > On Fri, Jan 15, 2016 at 8:08 AM, Daniel Stone wrote: >> The proposed one-shot-but-delayed request to me felt like a really >> awkward compromise between the two, and not really one backed up by a >>

Re: [PATCH wayland] protocol: Add note about per version requirements to wl_data_device_manager

2016-01-18 Thread Carlos Garnacho
Hey Jonas, On Mon, Jan 18, 2016 at 11:18 AM, Jonas Ådahl wrote: > Add a note to the wl_data_device_manager global interface about the > different requirements for operating the objects created from the bound > global. > > Signed-off-by: Jonas Ådahl > --- > >

Re: [PATCH weston v4 07/20] libinput: Expose unaccelerated motion deltas in motion event struct

2016-01-18 Thread Daniel Stone
Hi, On 17 November 2015 at 10:10, Jonas Ådahl wrote: > Signed-off-by: Jonas Ådahl Apparently I just noted this locally, rather than on the list, but: Reviewed-by: Daniel Stone Cheers, Daniel

Re: [PATCH wayland-protocols 3/3] xdg-shell: Introduce xdg_tooltip

2016-01-18 Thread Mike Blumenkrantz
On Sun, 17 Jan 2016 10:37:09 +0800 Jonas Ådahl wrote: > On Sat, Jan 16, 2016 at 03:07:00PM -0500, Mike Blumenkrantz wrote: > > On Sat, 16 Jan 2016 10:28:20 +0800 > > Jonas Ådahl wrote: > > > > > On Fri, Jan 15, 2016 at 09:19:34PM -0500, Mike Blumenkrantz

[PATCH v2 libinput 6/7] tablet: hook up relative motion events

2016-01-18 Thread Peter Hutterer
Signed-off-by: Peter Hutterer Acked-by: Jason Gerecke --- Changes to v1: - updated for removal of the dx/dy unaccel coordinates doc/pointer-acceleration.dox | 6 ++ src/evdev-tablet.c | 116 +--- src/evdev.c

[PATCH libinput] touchpad: disable MT for all semi-mt devices

2016-01-18 Thread Peter Hutterer
Synaptics, Elantech and Alps semi-mt devices all have issues with reporting correct MT data, even the bounding box which semi-mt devices are supposed to report is wrong. Synaptics devices have massive jumps with two fingers down. Elantech devices may open slots without coordinate data. Alps

[PATCH v2 libinput 5/7] tablet: add support for relative x/y motion deltas

2016-01-18 Thread Peter Hutterer
Instead of an explicit tablet mode that device must be changed into, let the caller decide which coordinates are preferred. The tablet mode may be application-specific and usually depends on the tool as well. This patch adds an interface to get a motion delta for the x/y axes in pixel-like

Re: [PATCH wayland-protocols v2 2/2] Introduce pointer locking and confinement protocol

2016-01-18 Thread Jonas Ådahl
On Mon, Jan 18, 2016 at 06:28:29PM +, Daniel Stone wrote: > Hi, > > On 15 January 2016 at 19:30, Bill Spitzak wrote: > > On Fri, Jan 15, 2016 at 8:08 AM, Daniel Stone wrote: > >> The proposed one-shot-but-delayed request to me felt like a really > >>

Re: [PATCH wayland-protocols v2 2/2] Introduce pointer locking and confinement protocol

2016-01-18 Thread Peter Hutterer
On Fri, Jan 15, 2016 at 04:08:57PM +, Daniel Stone wrote: > Hi, > > On 12 January 2016 at 22:28, Bill Spitzak wrote: > > There should *only* be "one shot" requests, which are very quickly accepted > > or denied by the compositor. The client creates it in response to an

[RFC v3 libinput 2/2] buttonset: implement buttonset handling for Wacom tablet pads

2016-01-18 Thread Peter Hutterer
Same approach as evdev-tablet (started as copy/paste), with axis and buttons adjusted. Wacom's handling of pad devices requires a lot of non-obvious handling, e.g. ABS_THROTTLE is the second ring, ABS_RX is the strip, etc. This is not generic buttonset code, if we start supporting other devices

[RFC v3 libinput 1/2] buttonset: Add a "buttonset" interface for button-only devices

2016-01-18 Thread Peter Hutterer
A generic interface for devices that provide buttons and axes, but don't control the pointer. This caters for the Pad part of Wacom graphics tablets but could eventually also deal with remote controls, 3D mice and other devices. This patch adds a new interface "buttonset" with a new capability

Re: [PATCH weston] compositor-rdp: update link to wheel delta explanation

2016-01-18 Thread Jonas Ådahl
Reviewed (well checked the link) and push this one. Jonas On Mon, Jan 18, 2016 at 01:54:19PM +1000, Peter Hutterer wrote: > The previous one is a 404 now. > --- > src/compositor-rdp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/compositor-rdp.c

Re: [PATCH weston v9] data-device: Implement DnD actions

2016-01-18 Thread Jonas Ådahl
Have tested this with both old wl_data_device_manager users and new wl_data_device_manager users and it seems to work. So this, and the rest of the most recent version of the series it was part of is now pushed. Jonas On Mon, Jan 18, 2016 at 11:52:12PM +0100, Carlos Garnacho wrote: > The policy

Re: [PATCH v5 weston 2/2] Support axis source, axis discrete, frame and axis stop events

2016-01-18 Thread Jonas Ådahl
This one is now also pushed, with a couple of fixes (resource version checks before sending wl_pointer.frame when changing pointer focus). Jonas On Mon, Jan 18, 2016 at 04:38:22PM +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > Changes to v2: > -

Re: [PATCH libinput 5/7] tablet: add support for relative x/y motion deltas

2016-01-18 Thread Peter Hutterer
On Mon, Jan 18, 2016 at 09:54:09AM -0800, Bill Spitzak wrote: > On 01/17/2016 02:26 PM, Peter Hutterer wrote: > >On Fri, Jan 15, 2016 at 12:06:27PM -0800, Bill Spitzak wrote: > >>Isn't dx_unaccelerated exactly equal to the differences between x values? > > > >hah, yes. indeed. that actually means

[PATCH weston v9] data-device: Implement DnD actions

2016-01-18 Thread Carlos Garnacho
The policy in weston in order to determine the chosen DnD action is deliberately simple, and is probably the minimals that any compositor should be doing here. Besides honoring the set_actions requests on both wl_data_source and wl_data_offer, weston now will emit the newly added "action" events