[PATCH libinput] test: set the umask before msktemp to silence coverity

Signed-off-by: Peter Hutterer --- test/path.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/path.c b/test/path.c index 7d7c445..729ad86 100644 --- a/test/path.c +++ b/test/path.c @@ -28,6 +28,7 @@ #include #include #include +#include #include

Re: [PATCH libinput] tablet: add a fuzz-filter to avoid spamming callers with subpixel updates

On Mon, Apr 11, 2016 at 06:43:15PM -0700, Jason Gerecke wrote: > On Mon, Apr 11, 2016 at 5:17 PM, Peter Hutterer > wrote: > > This is especially a problem for the cursor tool which can be legitimately > > left on the tablet. It wobbles by a couple of device units,

Re: [PATCH libinput] tablet: add a fuzz-filter to avoid spamming callers with subpixel updates

On Mon, Apr 11, 2016 at 5:17 PM, Peter Hutterer wrote: > This is especially a problem for the cursor tool which can be legitimately > left on the tablet. It wobbles by a couple of device units, resulting in > continuous axis updates to the caller. Pre-filter any of these

[PATCH libinput] tablet: add a fuzz-filter to avoid spamming callers with subpixel updates

This is especially a problem for the cursor tool which can be legitimately left on the tablet. It wobbles by a couple of device units, resulting in continuous axis updates to the caller. Pre-filter any of these events by the axis' fuzz value so we don't even process them. For ABS_DISTANCE which

[PATCH wayland-protocols 01/19] readme: Correct spelling and grammar

From: Yong Bakos Signed-off-by: Yong Bakos --- README | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/README b/README index 324f873..da1f1d5 100644 --- a/README +++ b/README @@ -1,9 +1,9 @@ Wayland

[PATCH wayland-protocols 13/19] pointer-constraints: Correct spelling, grammar and consistency

From: Yong Bakos Downcase the protocol summary description to match other protocols. Replace 'surface-relative' with 'surface local' for consistency and clarity. Signed-off-by: Yong Bakos --- .../pointer-constraints-unstable-v1.xml

[PATCH wayland-protocols 02/19] presentation-time: Correct minor grammar errors

From: Yong Bakos Signed-off-by: Yong Bakos --- stable/presentation-time/presentation-time.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/stable/presentation-time/presentation-time.xml

[PATCH wayland-protocols 11/19] relative-pointer: Correct spelling error, one capitalization, and minor space

From: Yong Bakos Downcase the protocol description summary. Adjust two double-spaces to one, like the rest of the content. Signed-off-by: Yong Bakos --- unstable/relative-pointer/relative-pointer-unstable-v1.xml | 8 1 file changed,

[PATCH wayland-protocols 12/19] pointer-gestures: Correct pluralization, one space, minor vertical whitespace

From: Yong Bakos Adjust double-space after period to be consistent with all content. Adjust vertical whitespace surrounding first and last protocol tag to match conventions in this, and other, protocol xml docs. Signed-off-by: Yong Bakos ---

[PATCH wayland-protocols 04/19] xdg-shell: Remove inconsistent spacing

From: Yong Bakos Convert two two-space periods to one, consistent with the rest of the content. Adjusst vertical whitespace of final closing interface tag to match conventions set forth in this, and other, protocol docs. Signed-off-by: Yong Bakos

[PATCH wayland-protocols 15/19] input-method: Correct grammar, add missing line break

From: Yong Bakos Adds one line between two sequential request elements, to match conventions within this, and other, protocol xml docs. Signed-off-by: Yong Bakos --- unstable/input-method/input-method-unstable-v1.xml | 40

[PATCH wayland-protocols 03/19] xdg-shell: Downcase summary values consistently

From: Yong Bakos Signed-off-by: Yong Bakos --- unstable/xdg-shell/xdg-shell-unstable-v5.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/unstable/xdg-shell/xdg-shell-unstable-v5.xml

[PATCH wayland-protocols 19/19] fullscreen-shell: Add missing xml declaration

From: Yong Bakos Signed-off-by: Yong Bakos --- unstable/fullscreen-shell/fullscreen-shell-unstable-v1.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/unstable/fullscreen-shell/fullscreen-shell-unstable-v1.xml

Re: [PATCH wayland-protocols 16/19] fullscreen-shell: Correct spelling of parameter name

Jason, See below, this one patch affects the argument name of the zwp_fullscreen_shell_v1#capability event param name. yong > On Apr 11, 2016, at 5:23 PM, Yong Bakos wrote: > > From: Yong Bakos > > Signed-off-by: Yong Bakos

[PATCH wayland-protocols 08/19] text-input: Correct grammar

From: Yong Bakos Signed-off-by: Yong Bakos --- unstable/text-input/text-input-unstable-v1.xml | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/unstable/text-input/text-input-unstable-v1.xml

[PATCH wayland-protocols 06/19] text-input: Fix indentation and paragraph whitespace

From: Yong Bakos Replace the tab indentation of the MIT license with appropriate spaces. Add one missing line break between two description paragraphs. Adjust two line breaks to keep descriptions under 80 chars / line. Signed-off-by: Yong Bakos

[PATCH wayland-protocols 00/19] Correct writing errors

From: Yong Bakos This v1 patchset consists of spelling, grammar and minor formatting changes to all protocol xml files. The approach here is to be minimally invasive and to not impart stylistic changes; only corrections and consistency changes have been made, with the

[PATCH wayland-protocols 16/19] fullscreen-shell: Correct spelling of parameter name

From: Yong Bakos Signed-off-by: Yong Bakos --- unstable/fullscreen-shell/fullscreen-shell-unstable-v1.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/unstable/fullscreen-shell/fullscreen-shell-unstable-v1.xml

[PATCH wayland-protocols 09/19] tablet: Adjust vertical whitespace for consistency

From: Yong Bakos Add/remove vertial whitespace between xml elements according to conventions elsewhere within this, and other, protocol xml docs. Signed-off-by: Yong Bakos --- unstable/tablet/tablet-unstable-v1.xml | 4 1 file changed,

[PATCH wayland-protocols 10/19] tablet: Correct grammar and punctuation

From: Yong Bakos Correcting minor grammar and punctuation affords clarity. Standardize the use of 'surface local coordinates' in lieu of 'surface relative'. Capitalize Wayland where appropriate, similar to other occurences. Signed-off-by: Yong Bakos

[PATCH wayland-protocols 07/19] text-input: Rename text-input to text_input

From: Yong Bakos Interface names are lower_snake_case, and corresponding descriptions should match, for accuracy and clarity. This renaming only affects description text, to follow the convention that exists elswhere in this protocol document and in other protocol docs,

[PATCH wayland-protocols 14/19] linux-dmabuf: Add missing articles and punctuation, adjust minor whitespace

From: Yong Bakos Remove line breaks preceding closing interface tags, to match conventions in this, and other, protocol xml docs. Signed-off-by: Yong Bakos --- unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml | 18 -- 1

[PATCH wayland-protocols 05/19] xdg-shell: Adjust articles and correct grammar

From: Yong Bakos Signed-off-by: Yong Bakos --- unstable/xdg-shell/xdg-shell-unstable-v5.xml | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/unstable/xdg-shell/xdg-shell-unstable-v5.xml

[PATCH wayland-protocols 18/19] pointer-gestures: Add missing xml declaration

From: Yong Bakos Signed-off-by: Yong Bakos --- unstable/pointer-gestures/pointer-gestures-unstable-v1.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/unstable/pointer-gestures/pointer-gestures-unstable-v1.xml

[PATCH wayland-protocols 17/19] fullscreen-shell: Correct grammar, punctuation, minor naming and space

From: Yong Bakos Add missing periods that terminate sentences. Correct ARBITRARY_MODE to match the actual enum value name. Adjust one post-period space to match the rest of the content. Downcase summary description to match the rest of the document. Add line breaks

[ANNOUNCE] libinput 1.2.3

libinput 1.2.3 is now available and it provides a couple of bugfixes. The handling of the T450 jerky cursor motion had a bug, causing libinput to complain about invalid states (#94601). This is fixed now. The top software buttons on the T440 generation touchpads had their left-handed button

Re: [PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

I think this should probably use uint instead of int for params since zero is the "unset" number. Otherwise you have to write something about negative sizes. On Mon, Apr 11, 2016 at 3:11 PM Jasper St. Pierre wrote: > On Mon, Apr 11, 2016 at 12:59 AM, Olivier Fourdan

Re: [PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

On Mon, Apr 11, 2016 at 12:59 AM, Olivier Fourdan wrote: > Some application may wish to restrict their window in size, but > xdg-shell has no mechanism for the client to specify a maximum or > minimum size. > > As a result, the compositor may try to maximize or fullscreen a

Re: [PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

I figured min/max would be double-buffered state and require a commit to take affect. In fact, anything else means that we can't extend with additional size constraints in the future, since they couldn't be applied atomically. On Mon, Apr 11, 2016 at 12:02 PM, Bill Spitzak

[PATCH] ivi-layout : clear on_layer when layer_destroy

On_layer of ivi_layout_surface should be NULL in the layer_destroy. Previous code might access to removed ivilayer and cause SEGV. Signed-off-by: Wataru Natsume --- ivi-shell/ivi-layout.c |1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

On Apr 11, 2016, at 2:59 AM, Olivier Fourdan wrote: > > Some application may wish to restrict their window in size, but > xdg-shell has no mechanism for the client to specify a maximum or > minimum size. > > As a result, the compositor may try to maximize or fullscreen a

Re: [PATCH libinput] tablet: fix the airbrush slider range

Hey!, On Mon, Apr 11, 2016 at 1:32 AM, Peter Hutterer wrote: > Supposed to be [-1, 1] but we only generated [0, 1] > > Reported-by: Carlos Garnacho > Signed-off-by: Peter Hutterer Also: Tested-by: Carlos Garnacho

Re: Meaning of is_controlled argument of workspace_end_control event

On Mon, 11 Apr 2016 07:05:17 + "Potrola, MateuszX" wrote: > Hi all, > > > I have a question about one of events from ivi-hmi-controller.xml - > workspace_end_control. > > What is the meaning of its argument - "is_controlled" ? > It's not documented anywhere and

[PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

Some application may wish to restrict their window in size, but xdg-shell has no mechanism for the client to specify a maximum or minimum size. As a result, the compositor may try to maximize or fullscreen a window while the client would not allow for the requested size. Add new requests

Re: [PATCH libinput 4/4] test: add test to ensure MB emulation doesn't start while the MB is down

Hi, On 11-04-16 05:54, Peter Hutterer wrote: We already handle the case where we have MB emulation active and a middle button is pressed because we often don't know if we have a middle button on the device. But the other way round makes little sense, when a physical middle button is down

Re: [PATCH libinput 3/4] evdev: enable middle-button scrolling on middle-button emulation

Hi, On 11-04-16 05:54, Peter Hutterer wrote: https://bugs.freedesktop.org/show_bug.cgi?id=94856 Signed-off-by: Peter Hutterer Patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans --- src/evdev.c| 107

Re: [PATCH libinput 2/4] evdev: check the button scrolling state instead of the hw button state

Hi, On 11-04-16 05:54, Peter Hutterer wrote: The state of button scrolling should determine whether we filter the event, not the hardware button state. Signed-off-by: Peter Hutterer --- src/evdev.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-)

Re: [PATCH libinput 1/4] evdev: if we have a quick scroll button release, skip middle button emulation

Hi, On 11-04-16 05:54, Peter Hutterer wrote: The only difference between evdev_pointer_notify_physical_button() and evdev_pointer_notify_button() is that the former filters out middle button emulations where applicable. Doing so effectively disables using a button for scrolling that is also

Re: [PATCH libinput] tablet: fix the airbrush slider range

Hi, On 11-04-16 01:32, Peter Hutterer wrote: Supposed to be [-1, 1] but we only generated [0, 1] Reported-by: Carlos Garnacho Signed-off-by: Peter Hutterer Patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans

Meaning of is_controlled argument of workspace_end_control event

Hi all, I have a question about one of events from ivi-hmi-controller.xml - workspace_end_control. What is the meaning of its argument - "is_controlled" ? It's not documented anywhere and looking at implementation in hmi-controller.c, it seems that this is set according to move of layer