[PATCH libinput] udev: update the hwdb matches to avoid use of ( and )

2016-04-12 Thread Peter Hutterer
libudev's util_replace_chars() replaces the () with underscores so that match would work too but let's use ? instead to make it look like a regex. This now activates the rules for all cyapa touchpads, before they wouldn't have applied to any device.

Re: [PATCH 4/5] compositor: Version the backend configuration structures

2016-04-12 Thread Bryce Harrington
On Tue, Apr 12, 2016 at 09:44:10PM -0700, Bryce Harrington wrote: > On Wed, Apr 06, 2016 at 11:43:54AM +0300, Pekka Paalanen wrote: > > On Mon, 21 Mar 2016 23:11:29 +0100 > > Benoit Gschwind wrote: > > > > > Hello, > > > > > > I think that struct_version and struct_size

Re: [PATCH 5/5] compositor: Document refs for alternatives/assumptions for backend configs

2016-04-12 Thread Bryce Harrington
On Wed, Apr 06, 2016 at 11:46:28AM +0300, Pekka Paalanen wrote: > On Wed, 9 Mar 2016 16:49:32 -0800 > Bryce Harrington wrote: > > > Signed-off-by: Bryce Harrington > > --- > > src/main.c | 13 + > > 1 file changed, 13 insertions(+) > >

Re: [PATCH 4/5] compositor: Version the backend configuration structures

2016-04-12 Thread Bryce Harrington
On Wed, Apr 06, 2016 at 11:43:54AM +0300, Pekka Paalanen wrote: > On Mon, 21 Mar 2016 23:11:29 +0100 > Benoit Gschwind wrote: > > > Hello, > > > > I think that struct_version and struct_size should not be belong > > compositor.h. I think those versioning should be back-end

Re: [PATCH 2/5] drm: port the drm backend to the new init api

2016-04-12 Thread Bryce Harrington
On Wed, Apr 06, 2016 at 11:37:57AM +0300, Pekka Paalanen wrote: > On Wed, 9 Mar 2016 16:49:29 -0800 > Bryce Harrington wrote: > > > From: Giulio Camuffo > > > > Signed-off-by: Bryce Harrington > > Reviewed-by: Quentin

Re: [PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

2016-04-12 Thread The Rasterman
On Tue, 12 Apr 2016 15:25:36 + Mike Blumenkrantz said: > Sure, that sounds good to me! i like the idea of keeping < 0 invalid for now... it leaves wiggle room in future to maybe make it valid and have special meaning but for now is invalid thus can be assumed

[PATCH libinput] test: add test for no scroll events before the scroll button timeout

2016-04-12 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/evdev.c| 2 ++ test/pointer.c | 31 +++ 2 files changed, 33 insertions(+) diff --git a/src/evdev.c b/src/evdev.c index f0311c6..a237ce6 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -280,6 +280,8 @@

Re: [PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

2016-04-12 Thread Olivier Fourdan
> On 04/12/2016 08:17 AM, Olivier Fourdan wrote: > [...] > > > > But that raise another point, what if the client itself specifies a > > geometry (using set_window_geometry) outside of the min/max? > > > > I reckon that would be a protocol error as well. if so, I guess it means I > > have to

Re: [PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

2016-04-12 Thread Mike Blumenkrantz
Sure, that sounds good to me! On Tue, Apr 12, 2016 at 11:24 AM Olivier Fourdan wrote: > Hi Mike. > > > Okay, if we're not going with uints then at the least can the "use 0 to > > unset min/max" be changed to "use <= 0 to unset min/max" to explicitly > > cover that case? > >

Re: [PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

2016-04-12 Thread Olivier Fourdan
Hi Mike. > Okay, if we're not going with uints then at the least can the "use 0 to > unset min/max" be changed to "use <= 0 to unset min/max" to explicitly > cover that case? I think we should simply indicate that the width and height must be greater than or equal to zero, so we remain

Re: [PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

2016-04-12 Thread Olivier Fourdan
> > > Good point. Setting an invalid state should probably result in a > > > protocol error. > > > > No this cannot be a protocol error because that makes it difficult to > > change the size range to a new one that does not intersect the old one. > > > > Perhaps having the commit of an invalid

Re: [PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

2016-04-12 Thread Mike Blumenkrantz
Okay, if we're not going with uints then at the least can the "use 0 to unset min/max" be changed to "use <= 0 to unset min/max" to explicitly cover that case? On Tue, Apr 12, 2016 at 10:40 AM Olivier Fourdan wrote: > Hi, > > > > > Good point. Setting an invalid state

Re: [PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

2016-04-12 Thread Olivier Fourdan
Hi, > > Good point. Setting an invalid state should probably result in a > > protocol error. > > No this cannot be a protocol error because that makes it difficult to > change the size range to a new one that does not intersect the old one. > > Perhaps having the commit of an invalid state be

[PATCH v6 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

2016-04-12 Thread Olivier Fourdan
Some application may wish to restrict their window in size, but xdg-shell has no mechanism for the client to specify a maximum or minimum size. As a result, the compositor may try to maximize or fullscreen a window while the client would not allow for the requested size. Add new requests

Re: [PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

2016-04-12 Thread Yong Bakos
On Apr 12, 2016, at 2:22 AM, Jonas Ådahl wrote: > > On Tue, Apr 12, 2016 at 03:20:27AM -0400, Olivier Fourdan wrote: >> Hi Mike, >> >> - Original Message - >>> I think this should probably use uint instead of int for params since zero >>> is the "unset" number.

Re: [PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

2016-04-12 Thread Jonas Ådahl
On Tue, Apr 12, 2016 at 08:05:03AM -0500, Yong Bakos wrote: > On Apr 12, 2016, at 2:22 AM, Jonas Ådahl wrote: > > > > On Tue, Apr 12, 2016 at 03:20:27AM -0400, Olivier Fourdan wrote: > >> Hi Mike, > >> > >> - Original Message - > >>> I think this should probably use

Re: [PATCH] ivi-layout : clear on_layer when layer_destroy

2016-04-12 Thread Pekka Paalanen
On Mon, 11 Apr 2016 21:34:52 +0900 Wataru Natsume wrote: > On_layer of ivi_layout_surface should be NULL in the layer_destroy. > Previous code might access to removed ivilayer and cause SEGV. > > Signed-off-by: Wataru Natsume >

Re: [PATCH] client: use the thread reader_count to fix deadlock.

2016-04-12 Thread Daniel Stone
Hi Boram, On 8 April 2016 at 00:58, Boram Park wrote: > This patch solves the deadlock issue of the below scenario. > > 1. A thread polls several fds including the wayland's fd. > 2. This thread probably calls wl_display_prepare_read() before polling > fds. >

[PATCH] client: use the thread reader_count to fix deadlock.

2016-04-12 Thread Boram Park
This patch solves the deadlock issue of the below scenario. 1. A thread polls several fds including the wayland's fd. 2. This thread probably calls wl_display_prepare_read() before polling fds. 3. This thread could be awake by other event source which isn't related with wayland

Allow easy disabling of PRIMARY selection thru configuration?

2016-04-12 Thread Jeremy Morton
One of the long-term bugbears of users coming to Linux from just about any other GUI is the existence of two totally separate clipboards; the PRIMARY selection and the CLIPBOARD selection. I doubt I'm gonna get the default behaviour changed, even though I think this default is terribly

Re: [PATCH weston] weston-info: do not round refresh rates

2016-04-12 Thread Pekka Paalanen
On Tue, 12 Apr 2016 10:23:54 +0200 Quentin Glidic wrote: > On 12/04/2016 10:13, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > Weston-info was accidentally rounding refresh rates to integer Hz. > > > > Fix it to print 3

Re: [PATCH weston] weston-info: do not round refresh rates

2016-04-12 Thread Quentin Glidic
On 12/04/2016 10:13, Pekka Paalanen wrote: From: Pekka Paalanen Weston-info was accidentally rounding refresh rates to integer Hz. Fix it to print 3 decimals, as the protocol carries exactly that. Reported-by: Michel Dänzer Cc: John Galt

[PATCH weston] weston-info: do not round refresh rates

2016-04-12 Thread Pekka Paalanen
From: Pekka Paalanen Weston-info was accidentally rounding refresh rates to integer Hz. Fix it to print 3 decimals, as the protocol carries exactly that. Reported-by: Michel Dänzer Cc: John Galt Signed-off-by:

Re: [PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

2016-04-12 Thread Olivier Fourdan
Hi Jasper, - Original Message - > I figured min/max would be double-buffered state and require a commit > to take affect. In fact, anything else means that we can't extend with > additional size constraints in the future, since they couldn't be > applied atomically. Completely agree,

Re: [PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

2016-04-12 Thread Jonas Ådahl
On Tue, Apr 12, 2016 at 03:20:27AM -0400, Olivier Fourdan wrote: > Hi Mike, > > - Original Message - > > I think this should probably use uint instead of int for params since zero > > is the "unset" number. Otherwise you have to write something about negative > > sizes. > > Reason I used

Re: [PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests

2016-04-12 Thread Olivier Fourdan
Hi Mike, - Original Message - > I think this should probably use uint instead of int for params since zero > is the "unset" number. Otherwise you have to write something about negative > sizes. Reason I used "int" is because these are limits for size, which are expressed with int as

Re: [PATCH libinput] test: set the umask before msktemp to silence coverity

2016-04-12 Thread Hans de Goede
Hi, On 12-04-16 07:11, Peter Hutterer wrote: Signed-off-by: Peter Hutterer Reviewed-by: Hans de Goede Regards, Hans --- test/path.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/path.c b/test/path.c index 7d7c445..729ad86