Re: [PATCH libinput 1/2] test: create a lock file to avoid parallel udev reloads during device add

2016-07-04 Thread Jonas Ådahl
On Tue, Jul 05, 2016 at 12:43:43PM +1000, Peter Hutterer wrote: > litest_add_device and litest_delete_device trigger a udev rule reload. This > messes with some test devices and when we run multiple tests in parallel we > get weird errors like "keyboard $BLAH failed the touchpad sanity test". > >

[PATCH libinput 2/2] test: up the timeout to 30s

2016-07-04 Thread Peter Hutterer
10s is not enough when running the test suite in parallel as any test may have to wait longer than that to get access to the udev lock. Especially for tests with multiple timeouts it was too easy to trigger timeouts. Up the timeout to 30s, this seems reliable enough now. Signed-off-by: Peter

[PATCH libinput 1/2] test: create a lock file to avoid parallel udev reloads during device add

2016-07-04 Thread Peter Hutterer
litest_add_device and litest_delete_device trigger a udev rule reload. This messes with some test devices and when we run multiple tests in parallel we get weird errors like "keyboard $BLAH failed the touchpad sanity test". Still not 100% reliable to run tests in parallel, but it's vastly

Re: [PATCH weston 3/9] gl-renderer: move check_extension() to shared/

2016-07-04 Thread Emil Velikov
On 4 July 2016 at 15:34, Emil Velikov wrote: > diff --git a/shared/config-parser.c b/shared/config-parser.c > index 2256469..d316958 100644 > --- a/shared/config-parser.c > +++ b/shared/config-parser.c > @@ -39,6 +39,7 @@ > > #include > #include "config-parser.h" >

Re: [PATCH weston 4/6] libweston: use new versioning scheme

2016-07-04 Thread Emil Velikov
On 4 July 2016 at 15:45, Quentin Glidic wrote: > On 04/07/2016 16:23, Emil Velikov wrote: >> >> Use the documented libweston-$major.so.0.$minor.$patch scheme. >> >> An (almost) identical one is used by GLIB, GTK{2,3}, QT5, json-glib and >> others. >> >> v2: >> -

Re: [PATCH weston 6/6] libweston: do not use weston version in libweston.pc

2016-07-04 Thread Emil Velikov
On 4 July 2016 at 15:35, Quentin Glidic wrote: > On 04/07/2016 16:23, Emil Velikov wrote: >> >> From: Emil Velikov >> >> Signed-off-by: Emil Velikov >> --- >> configure.ac | 1 + >>

Re: [PATCH weston 0/6] Rework libweston versioning, take 2(?)

2016-07-04 Thread Emil Velikov
On 4 July 2016 at 15:55, Pekka Paalanen wrote: > On Mon, 4 Jul 2016 15:23:48 +0100 > Emil Velikov wrote: > >> Hi all, >> >> Here is a respin of the earlier series which changes how libweston is >> named, and thus shipped. I believe all the

Re: [PATCH weston 5/6] libweston: do not add libweston-$version to the Cflags

2016-07-04 Thread Emil Velikov
On 4 July 2016 at 15:32, Quentin Glidic wrote: > On 04/07/2016 16:23, Emil Velikov wrote: >> >> From: Emil Velikov >> >> When managing headers there's normally two ways to handle them >> - with or without the subfolder. >> >> Opting

[PATCH weston 0/9] Finalise EGL/GL define(s) rework

2016-07-04 Thread Emil Velikov
Hi all, This series depends on "EGL/GL definitions cleanup" and does a couple of things: - makes sure that we consistently use check_extension over strstr for extension checking, as the latter might trigger false positives. - The remainder of the fall-back definitions has been moved to

[PATCH weston 2/9] libweston: don't install shared/platform.h

2016-07-04 Thread Emil Velikov
From: Emil Velikov The header contains a set of extension check (helpers), which do not provide any compositor related functionality and are not required for using libweston. Signed-off-by: Emil Velikov --- Feel free to disagree, but imho

[PATCH weston 7/9] weston-egl-ext.h: add EGL platform definitions

2016-07-04 Thread Emil Velikov
From: Emil Velikov Will allow us to consolidate the multiple definitions through the tree. Signed-off-by: Emil Velikov --- libweston/weston-egl-ext.h | 19 +++ 1 file changed, 19 insertions(+) diff --git

[PATCH weston 4/9] shared/platform.h: use weston_check_extension over strstr

2016-07-04 Thread Emil Velikov
From: Emil Velikov The later can give false positives. Signed-off-by: Emil Velikov --- shared/platform.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/shared/platform.h b/shared/platform.h index

Re: [PATCH weston 5/6] libweston: do not add libweston-$version to the Cflags

2016-07-04 Thread Quentin Glidic
On 04/07/2016 16:23, Emil Velikov wrote: From: Emil Velikov When managing headers there's normally two ways to handle them - with or without the subfolder. Opting for the latter case here, since it will provide direct feedback, whether one is using libweston-0 or

[PATCH weston 6/9] clients/simple-egl: use weston_check_extension over strstr

2016-07-04 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- clients/simple-egl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clients/simple-egl.c b/clients/simple-egl.c index d5a2660..0214b2d 100644 ---

[PATCH weston 1/9] shared/platform.h: add missing stdbool.h include

2016-07-04 Thread Emil Velikov
From: Emil Velikov Required by the bool type, used through the header. Signed-off-by: Emil Velikov --- shared/platform.h | 1 + 1 file changed, 1 insertion(+) diff --git a/shared/platform.h b/shared/platform.h index dd55008..b1b9128

[PATCH weston 8/9] gl-renderer: remove local EGL platform (re)definitions

2016-07-04 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- libweston/gl-renderer.h | 17 - 1 file changed, 17 deletions(-) diff --git a/libweston/gl-renderer.h b/libweston/gl-renderer.h index 71f6b46..ad81a64 100644 ---

[PATCH weston 5/9] clients/nested: use weston_check_extension over strstr

2016-07-04 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- clients/nested.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clients/nested.c b/clients/nested.c index 6c21aa4..9f74326 100644 --- a/clients/nested.c +++

[PATCH weston 3/9] gl-renderer: move check_extension() to shared/

2016-07-04 Thread Emil Velikov
From: Emil Velikov ... prefixing it with a "weston_". This way we can reuse it across the board, instead of the current strstr. The latter of which can give us false positives, thus it will be resolved with next commit(s). Signed-off-by: Emil Velikov

[PATCH weston 2/7] weston-egl-ext.h: remove EGL_EGLEXT_PROTOTYPES sections

2016-07-04 Thread Emil Velikov
From: Emil Velikov Those the function declarations alongside the EGL_EGLEXT_PROTOTYPES guards. Although those are copy/paste sections from the header(s), having and/or using them is a bad idea, as per the EGL spec. Signed-off-by: Emil Velikov

[PATCH weston 0/7] EGL/GL definitions cleanup

2016-07-04 Thread Emil Velikov
It seems that a handful of extensions were missing fallback definitions and/or were handled sub optimally. So this series folds most (the remainder coming in another series) of the typedef/defines in weston-egl-ext.h and cleanups all the ifdef spaghetti through the codebase. -Emil

[PATCH weston 7/7] simple-egl: remove incomplete EGL_EXT_buffer_age definition

2016-07-04 Thread Emil Velikov
From: Emil Velikov A more complete alternative is already provided by the weston-egl-ext.h header. The latter of which we already include. Signed-off-by: Emil Velikov --- clients/simple-egl.c | 5 - 1 file changed, 5 deletions(-)

[PATCH weston 1/7] client/nested: reuse weston-egl-ext.h declarations

2016-07-04 Thread Emil Velikov
From: Emil Velikov Rather than introducing a local copy of the EGL_WL_create_wayland_buffer_from_image (re)definition, just use the local header. This also gives us access to EGL_WL_bind_wayland_display which is also used in the client, yet the C file is missing a

[PATCH weston 6/7] gl-renderer: remove EGL_EXT_image_dma_buf_import guards

2016-07-04 Thread Emil Velikov
From: Emil Velikov We provide a (workaround) definition in weston-egl-ext.h, thus we don't need any guards. Signed-off-by: Emil Velikov --- libweston/gl-renderer.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH weston 3/7] weston-egl-ext.h: add EGL_EXT_swap_buffers_with_damage definitions

2016-07-04 Thread Emil Velikov
From: Emil Velikov ... and use it from simple-egl and gl-renderer. Signed-off-by: Emil Velikov --- clients/simple-egl.c | 6 +- libweston/gl-renderer.c| 12 libweston/weston-egl-ext.h | 5 + 3 files

[PATCH weston 4/7] weston-egl-ext.h: add EGL_MESA_configless_context definitions

2016-07-04 Thread Emil Velikov
From: Emil Velikov ... and use it in gl-renderer. Signed-off-by: Emil Velikov --- libweston/gl-renderer.c| 4 libweston/weston-egl-ext.h | 5 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git

[PATCH weston 5/7] weston-egl-ext.h: add GL_EXT_unpack_subimage definitions

2016-07-04 Thread Emil Velikov
From: Emil Velikov ... and use it in gl-renderer. Signed-off-by: Emil Velikov --- libweston/gl-renderer.c| 9 - libweston/weston-egl-ext.h | 7 +++ 2 files changed, 7 insertions(+), 9 deletions(-) diff --git

[PATCH weston 6/6] libweston: do not use weston version in libweston.pc

2016-07-04 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- configure.ac | 1 + libweston/libweston.pc.in | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index be40f10..46b61ae 100644

[PATCH weston 1/6] README: clarify libweston purpose/goals.

2016-07-04 Thread Emil Velikov
From: Emil Velikov v2: Rewrap, add a couple of missing words (Pekka). v3: Use alternative wording (Yong). Signed-off-by: Emil Velikov --- README | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git

[PATCH weston 4/6] libweston: use new versioning scheme

2016-07-04 Thread Emil Velikov
Use the documented libweston-$major.so.0.$minor.$patch scheme. An (almost) identical one is used by GLIB, GTK{2,3}, QT5, json-glib and others. v2: - Use shorter variable names LIBWESTON_{MAJOR,MINOR...} - Correctly use -version-info. - Drop unneeded @LIBWESTON_VERSION_MAJOR@ additions.

[PATCH weston 2/6] README: minor the libweston ABI/API documentation

2016-07-04 Thread Emil Velikov
From: Emil Velikov v2: Elaborate what is meant with "major ABI versions" (Pekka). Signed-off-by: Emil Velikov Reviewed-by: Pekka Paalanen (v1) --- README | 25 + 1 file changed, 13

[PATCH weston 5/6] libweston: do not add libweston-$version to the Cflags

2016-07-04 Thread Emil Velikov
From: Emil Velikov When managing headers there's normally two ways to handle them - with or without the subfolder. Opting for the latter case here, since it will provide direct feedback, whether one is using libweston-0 or any other version. Which in turn should

[PATCH weston 0/6] Rework libweston versioning, take 2(?)

2016-07-04 Thread Emil Velikov
Hi all, Here is a respin of the earlier series which changes how libweston is named, and thus shipped. I believe all the logic/reasoning is explicitly stated, although if something feels amiss, please let me know. NOTE: WARNING: The series exposes a fatal bug in weston thus the tests fail to

[PATCH weston 3/6] README: Document versioning scheme, forward compatibility

2016-07-04 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov --- Pekka, There's a couple of things to 'break' - forward and backward compatibility. Latter implies changing (removing) certain existing API, while the former is used in reference to

Re: [PATCH weston 1/3] weston: Add a specific option to load XWayland

2016-07-04 Thread Michael Schellenberger Costa
Hi Quentin, Am 04.07.2016 um 15:58 schrieb Quentin Glidic: > From: Quentin Glidic > > Signed-off-by: Quentin Glidic > --- > compositor/main.c | 25 +++-- > man/weston.ini.man | 7 +-- > man/weston.man

Re: [PATCH weston 1/3] weston: Add a specific option to load XWayland

2016-07-04 Thread Quentin Glidic
On 04/07/2016 16:02, Michael Schellenberger Costa wrote: Hi Quentin, Am 04.07.2016 um 15:58 schrieb Quentin Glidic: From: Quentin Glidic Signed-off-by: Quentin Glidic --- compositor/main.c | 25 +++--

[PATCH weston] gl-renderer: Silence silly warning

2016-07-04 Thread Quentin Glidic
From: Quentin Glidic Signed-off-by: Quentin Glidic --- libweston/gl-renderer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libweston/gl-renderer.c b/libweston/gl-renderer.c index 28c0b50..73b6ccc 100644 ---

[PATCH weston 0/3] libweston common modules

2016-07-04 Thread Quentin Glidic
From: Quentin Glidic A little series to allow compositors to share modules which only rely on libweston. Patch 1 is standalone, and it makes it more obvious that patch 3 is just copying a function around. Patch 2 is mostly renames. It looks big but it’s quite

[PATCH weston 2/3] modules: Drop module_init as a shared init function

2016-07-04 Thread Quentin Glidic
From: Quentin Glidic Use different functions so we cannot load a libweston module in weston or the other way around. Also properly namespace backend_init and use a different name for weston shells. Signed-off-by: Quentin Glidic ---

[PATCH weston 3/3] libweston: Add a generic weston_compositor_load_module

2016-07-04 Thread Quentin Glidic
From: Quentin Glidic This way, we can share modules between libweston-based compositors, but they can only be loaded explicitely by the compositor. Signed-off-by: Quentin Glidic --- Makefile.am| 3 ++- compositor/main.c

[PATCH weston 2/2] automake: add missing git-version.h dependency

2016-07-04 Thread Emil Velikov
From: Emil Velikov compositor/main.c depends on the header, while the dependency isn't specified. Thus depending on the order of how things are build we could get a build failure. Signed-off-by: Emil Velikov --- Strictly speaking one

[PATCH weston 1/2] automake: list the the builddir include before the srcdir

2016-07-04 Thread Emil Velikov
From: Emil Velikov Otherwise we'll pick up the stale (in-tree) generated source(s) over the fresh (out-of-tree) ones. Signed-off-by: Emil Velikov --- It's quite a corner case, although it could save you a lot of time debugging. ---

Re: [PATCH wayland 3/5] Add API to get the list of connected clients

2016-07-04 Thread Giulio Camuffo
2016-06-17 13:51 GMT+02:00 Pekka Paalanen : > On Mon, 7 Mar 2016 18:31:33 +0100 > Giulio Camuffo wrote: > >> --- >> src/wayland-server-core.h | 14 + >> src/wayland-server.c | 52 >> +++

Re: [PATCH weston 2/2] gl-renderer,simple-dmabuf-v4l: fix dmabuf y-invert

2016-07-04 Thread Pekka Paalanen
On Mon, 4 Jul 2016 16:25:16 +0300 Pekka Paalanen wrote: > From: Pekka Paalanen > > Invert the Y_INVERT flag for the EGL import fo dmabufs. This fixes > weston-simple-dmabuf-intel to show the same image on both GL-composited > and with

[PATCH weston 1/2] clients/dmabuf-v4l: explain vivid setup

2016-07-04 Thread Pekka Paalanen
From: Pekka Paalanen Add very short explanation on how to set up Vivid driver, when you don't have suitable V4L2 device to use. Using the XR24 (DRM_FORMAT_XRGB) format practically guarantees that you can test direct scanout on a hardware overlay, too. At

[PATCH weston 2/2] gl-renderer, simple-dmabuf-v4l: fix dmabuf y-invert

2016-07-04 Thread Pekka Paalanen
From: Pekka Paalanen Invert the Y_INVERT flag for the EGL import fo dmabufs. This fixes weston-simple-dmabuf-intel to show the same image on both GL-composited and with direct scanout on a hardware plane. Before, the image would y-flip when switching between these

Re: Override redirect windows with keyboard grabs on Xwayland

2016-07-04 Thread Olivier Fourdan
Hey Adam, > This feels a lot like any other "app wants attention" case where you > should just get a pulsing button or bouncing icon in the taskbar. The > o-r window might be mapped and focused from Xwayland's perspective but > there's nothing compelling wayland to actually show or focus it >