Re: [PATCH weston v4 1/3] compositor: If the output is inhibited, don't idle it off

On Tue, Aug 16, 2016 at 09:51:01AM -0500, Derek Foreman wrote: > On 15/08/16 09:33 PM, Bryce Harrington wrote: > > On Mon, Aug 15, 2016 at 06:57:52PM -0500, Derek Foreman wrote: > >> On 10/08/16 07:25 PM, Bryce Harrington wrote: > >>> Adds a helper routine weston_output_inhibited_outputs() which

Re: [PATCH weston v4 2/3] compositor: Implement idle inhibition

On Tue, Aug 16, 2016 at 09:57:31AM -0500, Derek Foreman wrote: > On 15/08/16 09:15 PM, Bryce Harrington wrote: > > On Mon, Aug 15, 2016 at 07:01:24PM -0500, Derek Foreman wrote: > >> On 10/08/16 07:25 PM, Bryce Harrington wrote: > >>> Signed-off-by: Bryce Harrington > >>>

Re: [PATCH 1/3 v4] wayland-server: Add API to control globals visibility

On Aug 16, 2016, at 1:05 AM, Olivier Fourdan wrote: > > Add a new API to let compositor decide whether or not a wl_global > should be advertised to the clients via wl_registry_bind() or > display_get_registry() > > By using its own filter, the compositor can decide which

Re: [PATCH 3/3 v6] tests: Add a test for global filter

On Aug 16, 2016, at 12:34 PM, Olivier Fourdan wrote: > > Test if the global filter is effectively filtering out the global when > the filter returns false. > > Signed-off-by: Olivier Fourdan Seems sufficient. Thanks Olivier! Reviewed-by: Yong Bakos

[ANNOUNCE] weston 1.11.91

Here's the alpha for the upcoming 1.12 release. Below are the full list of changes so far for this release. Changes: Armin Krezović (26): compositor-headless: Support starting with zero outputs desktop-shell: Return NULL when no outputs are present toytoolkit:

[ANNOUNCE] wayland 1.11.91

Here's the alpha for the upcoming 1.12 release. Below are the full list of changes so far for this release. Changes: Bryce Harrington (4): scanner: Fix reported executable name to 'wayland-scanner' tests: Require base 10 for the string specifying the number of open fd's

[PATCH 3/3 v6] tests: Add a test for global filter

Test if the global filter is effectively filtering out the global when the filter returns false. Signed-off-by: Olivier Fourdan --- v3: split out as its own commit v4: Follow up on Jonas' comments: assert(hi.has_data_offer == false) instead of assert(hi.has_data_offer

[PATCH 3/3 v5] tests: Add a test for global filter

Test if the global filter is effectively filtering out the global when the filter returns false. Signed-off-by: Olivier Fourdan --- v3: split out as its own commit v4: Follow up on Jonas' comments: assert(hi.has_data_offer == false) instead of assert(hi.has_data_offer

Re: [PATCH wayland] scanner: Correct doxygen group name for *_add_listener

On Aug 15, 2016, at 10:13 PM, Jonas Ådahl wrote: > > On Tue, Jul 26, 2016 at 04:09:48PM -0500, Yong Bakos wrote: >> From: Yong Bakos >> >> From: Bill Spitzak > > Should the patch author be Yong or Bill here? If a patch was

Re: [PATCH weston v4 2/3] compositor: Implement idle inhibition

On 15/08/16 09:15 PM, Bryce Harrington wrote: > On Mon, Aug 15, 2016 at 07:01:24PM -0500, Derek Foreman wrote: >> On 10/08/16 07:25 PM, Bryce Harrington wrote: >>> Signed-off-by: Bryce Harrington >>> --- >>> Makefile.am| 4 ++- >>> configure.ac | 2

Re: [PATCH weston v4 1/3] compositor: If the output is inhibited, don't idle it off

On 15/08/16 09:33 PM, Bryce Harrington wrote: > On Mon, Aug 15, 2016 at 06:57:52PM -0500, Derek Foreman wrote: >> On 10/08/16 07:25 PM, Bryce Harrington wrote: >>> Adds a helper routine weston_output_inhibited_outputs() which returns a >>> mask of outputs that should inhibit screen idling. >>> >>>

Re: [PATCH weston 06/12 v2] weston: Port headless backend to new output handling API

On Sun, 14 Aug 2016 17:28:15 +0200 Armin Krezović wrote: > This is a complete port of the headless backend that > uses recently added output handling API for output > configuration. > > - Output can be configured at runtime by passing the > necessary configuration

Re: [PATCH] gl-renderer: emit frame_signal after eglSwapBuffers

On 08/16/2016 10:18 AM, Pekka Paalanen wrote: > On Fri, 12 Aug 2016 14:11:40 +0200 > Fabien Dessenne wrote: > >> Emit frame_signal at the end of the GL renderer processing, so the >> frame_signal clients are informed after the buffer is actually updated. >> >>

Re: [PATCH weston 05/12] weston: Port fbdev backend to new output handling API

On Sun, 14 Aug 2016 17:28:14 +0200 Armin Krezović wrote: > This is a complete port of the fbdev backend that uses > recently added output handling API for output > configuration. > > It is required that the scale and transform values are > set using the previously

[PATCH weston 2/2] desktop-shell: Add back the saved position for fullscreen/maximized

From: Quentin Glidic Signed-off-by: Quentin Glidic --- desktop-shell/shell.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index cc091a9..7ea7aa2 100644 ---

[PATCH weston 1/2] desktop-shell: Unset fullscreen/maximized state on commit

From: Quentin Glidic Maybe libweston-desktop should prevent the committed callback to be called if no state changed. For now, keep the interesting state in shell_surface like they used to. This only stores the current state, as libweston-desktop is still in charge of

Re: [PATCH weston 04/12 v2] weston: Port DRM backend to new output handling API

On Sun, 14 Aug 2016 17:28:13 +0200 Armin Krezović wrote: > This is a complete port of the DRM backend that uses > recently added output handling API for output > configuration. > > Output can be configured at runtime by passing the > necessary configuration parameters,

Re: [PATCH weston 12/12] libweston: Remove weston_backend_output_config structure

On 14/08/2016 17:28, Armin Krezović wrote: Signed-off-by: Armin Krezović Trivial: Reviewed-by: Quentin Glidic Cheers, --- libweston/compositor.h | 14 -- 1 file changed, 14 deletions(-) diff --git

Re: [PATCH weston 11/12] weston: Rename weston_output_init_pending() to weston_output_init()

On 14/08/2016 17:28, Armin Krezović wrote: Signed-off-by: Armin Krezović Good: Reviewed-by: Quentin Glidic Cheers, --- libweston/compositor-drm.c | 2 +- libweston/compositor-fbdev.c| 2 +- libweston/compositor-headless.c |

Re: [PATCH weston 07/12 v2] Port RDP backend to new output handling API

On 14/08/2016 17:28, Armin Krezović wrote: This is a complete port of the RDP backend that uses recently added output handling API for output configuration. Output can be configured at runtime by passing the necessary configuration parameters, which can be filled in manually or obtained from

Re: [PATCH weston 05/12] weston: Port fbdev backend to new output handling API

On 14/08/2016 17:28, Armin Krezović wrote: This is a complete port of the fbdev backend that uses recently added output handling API for output configuration. It is required that the scale and transform values are set using the previously added functionality. After everything has been set,

Re: [PATCH weston 04/12 v2] weston: Port DRM backend to new output handling API

On 14/08/2016 17:28, Armin Krezović wrote: This is a complete port of the DRM backend that uses recently added output handling API for output configuration. Output can be configured at runtime by passing the necessary configuration parameters, which can be filled in manually or obtained from

Re: [PATCH weston 03/12 v2] compositor: Implement output configuration using windowed_output_api

On 14/08/2016 17:28, Armin Krezović wrote: This implements output configuration for outputs which use previously added weston_windowed_output_api. The function takes an output that's to be configured, default configuration that's to be set in case no configuration is specified in the config file

Re: [PATCH 03/10] compositor: Implement output configuration using windowed_output_api

On Fri, 12 Aug 2016 18:34:20 +0300 Pekka Paalanen wrote: > On Thu, 11 Aug 2016 17:33:58 +0200 > Armin Krezović wrote: > > > This implements output configuration for outputs which use > > previously added weston_windowed_output_api. The function >

Re: [PATCH weston 02/12 v2] libweston: Add initial output API for windowed outputs configuration

On 14/08/2016 17:28, Armin Krezović wrote: This adds new plugin-specific API for configuring outputs on "windowed" backends, such as X11, wayland/non-fullscreen and even headless (although, it doesn't have any windows, its configuration is very similar). It can be used from compositors to

Re: [PATCH weston] libweston-desktop/{wl_shell, xwayland}: Fix changing between toplevel states

On 16/08/2016 11:47, Emmanuel Gil Peyrot wrote: On Tue, Aug 16, 2016 at 11:42:47AM +0200, Quentin Glidic wrote: From: Quentin Glidic Tested-by: Emmanuel Gil Peyrot Thanks, pushed: f6636a8..6384edf master -> master Cheers,

Re: [PATCH weston] libweston-desktop/{wl_shell, xwayland}: Fix changing between toplevel states

On Tue, Aug 16, 2016 at 11:42:47AM +0200, Quentin Glidic wrote: > From: Quentin Glidic Tested-by: Emmanuel Gil Peyrot > > Signed-off-by: Quentin Glidic > --- > libweston-desktop/wl-shell.c | 4 +++- >

[PATCH weston] libweston-desktop/{wl_shell, xwayland}: Fix changing between toplevel states

From: Quentin Glidic Signed-off-by: Quentin Glidic --- libweston-desktop/wl-shell.c | 4 +++- libweston-desktop/xwayland.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/libweston-desktop/wl-shell.c

Re: [PATCH weston 2/2] libweston-desktop/xwayland: Actually destroy the view

On 16/08/2016 11:05, Jonas Ådahl wrote: On Tue, Aug 16, 2016 at 10:55:44AM +0200, Quentin Glidic wrote: From: Quentin Glidic Signed-off-by: Quentin Glidic 1-2 are also Rb me. All three pushed: 154c5d2..f6636a8 master -> master

Re: [PATCH weston 2/2] libweston-desktop/xwayland: Actually destroy the view

On Tue, Aug 16, 2016 at 10:55:44AM +0200, Quentin Glidic wrote: > From: Quentin Glidic > > Signed-off-by: Quentin Glidic 1-2 are also Rb me. Jonas > --- > libweston-desktop/xwayland.c | 7 +-- > 1 file changed, 5 insertions(+),

Re: [PATCH 02/10] libweston: Add initial output API for windowed outputs configuration

On Sun, 14 Aug 2016 17:45:04 +0200 Armin Krezović wrote: > On 12.08.2016 18:28, Pekka Paalanen wrote: > > On Thu, 11 Aug 2016 17:33:57 +0200 > > Armin Krezović wrote: > > > >> This adds new plugin-specific API for configuring outputs > >>

[PATCH weston 2/2] libweston-desktop/xwayland: Actually destroy the view

From: Quentin Glidic Signed-off-by: Quentin Glidic --- libweston-desktop/xwayland.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libweston-desktop/xwayland.c b/libweston-desktop/xwayland.c index

[PATCH weston 1/2] libweston-desktop: Rename _destroy_view to _unlink_view

From: Quentin Glidic It doesn't destroy the view per se (except for internal surfaces) and require the caller to also destroy the view itself at the appropriate time. Signed-off-by: Quentin Glidic --- desktop-shell/shell.c

Re: [PATCH weston] desktop-shell: Properly destroy the weston_desktop_view

On Tue, Aug 16, 2016 at 10:28:21AM +0200, Quentin Glidic wrote: > From: Quentin Glidic > > Signed-off-by: Quentin Glidic As discussed, API naming can be improved, but lets do that in the follow up. This is Reviewed-by: Jonas Ådahl

Re: [PATCH libinput] Read the horizontal wheel click angle property if available

Hi, On 16-08-16 07:18, Peter Hutterer wrote: The Logitech MX master has different click angles for the two wheels. https://github.com/systemd/systemd/issues/3947 Signed-off-by: Peter Hutterer Patch looks good to me: Reviewed-by: Hans de Goede

Re: [PATCH weston] Makefile.am: Fix libtool race

On 16/08/2016 10:26, Pekka Paalanen wrote: On Mon, 15 Aug 2016 16:51:32 +0100 Emil Velikov wrote: On 15 August 2016 at 16:29, Quentin Glidic wrote: From: Quentin Glidic Signed-off-by: Quentin Glidic

Re: [PATCH 1/3 v4] wayland-server: Add API to control globals visibility

On Tue, Aug 16, 2016 at 10:05:57AM +0200, Olivier Fourdan wrote: > Add a new API to let compositor decide whether or not a wl_global > should be advertised to the clients via wl_registry_bind() or > display_get_registry() > > By using its own filter, the compositor can decide which wl_global

Re: [PATCH 3/3 v4] tests: Add a test for global filter

Oops, before anyone waste dome time on this, the latest iteration of this patch is wrong, if the global is hidden it won;t be listed so the last test does nothing... I'll come up with something better shortly, hopefully... Sorry Olivier - Original Message - > Test if the global filter

[PATCH weston] desktop-shell: Properly destroy the weston_desktop_view

From: Quentin Glidic Signed-off-by: Quentin Glidic --- desktop-shell/shell.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index 786020b..8023b0d 100644 ---

Re: [PATCH weston] Makefile.am: Fix libtool race

On Mon, 15 Aug 2016 16:51:32 +0100 Emil Velikov wrote: > On 15 August 2016 at 16:29, Quentin Glidic > wrote: > > From: Quentin Glidic > > > > Signed-off-by: Quentin Glidic > >

Re: [PATCH] gl-renderer: emit frame_signal after eglSwapBuffers

On Fri, 12 Aug 2016 14:11:40 +0200 Fabien Dessenne wrote: > Emit frame_signal at the end of the GL renderer processing, so the > frame_signal clients are informed after the buffer is actually updated. > > Signed-off-by: Fabien Dessenne > --- >

Re: [PATCH wayland] shm: Make shm_pool_interface static const

On Fri, 12 Aug 2016 12:41:47 -0700 Bryce Harrington wrote: > On Fri, Aug 12, 2016 at 12:04:41PM -0700, Yong Bakos wrote: > > From: Yong Bakos > > > > Add static const modifiers to the shm_pool_interface definition, > > making it consistent with

[PATCH 1/3 v4] wayland-server: Add API to control globals visibility

Add a new API to let compositor decide whether or not a wl_global should be advertised to the clients via wl_registry_bind() or display_get_registry() By using its own filter, the compositor can decide which wl_global would be listed to clients. Compositors can use this mechanism to hide their

Re: [PATCH 1/3 v3] wayland-server: Add API to control globals visibility

Hi Yong > I thought you'd say that. :) > Ok, I get it - I did think of those things as well although coming to > a different conclusion. However, just consider this... > > > [...] > > I agree with your reasons above, but this is a setter associated with > a struct member, and the struct member