Re: Micro optimizations welcome?

2016-09-17 Thread Giulio Camuffo
2016-09-18 4:03 GMT+03:00 Yong Bakos : > On Sep 17, 2016, at 5:42 PM, Ursache Vladimir wrote: >> >> Hi, >> On amd64 struct wl_display from wayland-client.c can shrink in size >> from 320 bytes to 304 if two fields (last_error and id) are >> rearranged.

Re: Micro optimizations welcome?

2016-09-17 Thread Ursache Vladimir
I didn't try an ABI check (ever), I just spotted the padding while browsing the source code out of curiosity. As to struct protocol_error (from inside struct wl_display) I moved the "id" field to avoid compiler padding: from: uint32_t pointer uint32_t to: uint32_t uint32_t pointer On Sun,

Re: Micro optimizations welcome?

2016-09-17 Thread Yong Bakos
On Sep 17, 2016, at 5:42 PM, Ursache Vladimir wrote: > > Hi, > On amd64 struct wl_display from wayland-client.c can shrink in size > from 320 bytes to 304 if two fields (last_error and id) are > rearranged. Compiles fine. I believe you mean last_error and protocol_error.

Micro optimizations welcome?

2016-09-17 Thread Ursache Vladimir
Hi, On amd64 struct wl_display from wayland-client.c can shrink in size from 320 bytes to 304 if two fields (last_error and id) are rearranged. Compiles fine. End result looks like this: struct wl_display { struct wl_proxy proxy; struct wl_connection *connection; /* When display

[PATCH wayland] util: Document GCC attributes

2016-09-17 Thread Yong Bakos
From: Yong Bakos Add doxygen comment blocks so these annotations are documented in the html documentation. Signed-off-by: Yong Bakos --- src/wayland-util.h | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git

Re: [PATCH wayland-protocols] idle-inhibit: Lead with a verb in request description

2016-09-17 Thread Yong Bakos
On Sep 16, 2016, at 8:42 PM, Bryce Harrington wrote: > > Signed-off-by: Bryce Harrington Reviewed-by: Yong Bakos yong > --- > unstable/idle-inhibit/idle-inhibit-unstable-v1.xml | 4 ++-- > 1 file changed, 2

Re: [PATCH wayland-protocols] input-method: Cleanup some grammar

2016-09-17 Thread Yong Bakos
On Sep 16, 2016, at 9:37 PM, Bryce Harrington wrote: > > Fix which vs. that, and rephrase a few descriptions to be clearer. > > Signed-off-by: Bryce Harrington Reviewed-by: Yong Bakos yong > --- >

Re: [PATCH] clients/stacking: Silence a compiler warning

2016-09-17 Thread Armin Krezović
On 15.09.2016 13:14, Eric Engestrom wrote: > On Sat, Sep 10, 2016 at 10:55:21PM +0200, Armin Krezović wrote: >> clang doesn't support gnu_print attribute, so just >> leave it out when clang is used. >> >> Signed-off-by: Armin Krezović >> --- >> clients/stacking.c | 4

Re: [PATCH weston 07/14 v3] weston: Port RDP backend to new output handling API

2016-09-17 Thread Armin Krezović
On 16.09.2016 15:49, Pekka Paalanen wrote: > On Thu, 18 Aug 2016 18:42:35 +0200 > Armin Krezović wrote: > >> This is a complete port of the RDP backend that uses >> recently added output handling API for output >> configuration. >> >> Output can be configured at runtime

Re: [PATCH weston 04/14 v3] weston: Port DRM backend to new output handling API

2016-09-17 Thread Armin Krezović
On 15.09.2016 13:37, Pekka Paalanen wrote: > On Wed, 14 Sep 2016 11:50:34 +0200 > Armin Krezović wrote: > >> On 13.09.2016 12:49, Pekka Paalanen wrote: >>> On Thu, 18 Aug 2016 18:42:32 +0200 >>> Armin Krezović wrote: >>> This is a