Re: [PATCH weston] libweston-desktop/xdg-shell: Properly properly handle ack_configure

On 2017-07-26 03:32 PM, Quentin Glidic wrote: On 7/26/17 9:39 PM, Derek Foreman wrote: commit 749637a8a306588964885fe6b25fda6087a84ccd introduced this feature, but the break is outside of any conditional so only the first item in the list is ever tested. If a client skips a few configures and

RE: [RFC weston 0/9] weston-debug protocol, API, and tool

Hello Pekka, Please find my replies. > What do you think of the alias idea? This idea looks good to group the debug scopes. > I'm still not sure who or when would be able to push this work forward. > I am very happy to hear it is a workable idea for you too. We can complete the pending works

Re: [PATCH 4/5] build: set the scanner --object-type option

On Wed, 26 Jul 2017 14:56:20 +0100 Emil Velikov wrote: > From: Emil Velikov > > Unlike most other scanner users, the core wayland interfaces are > public ally available via the libwayland DSO. > > Signed-off-by: Emil Velikov

Re: [PATCH 5/5] wayland-scanner.mk: default --object-type to static

On Wed, 26 Jul 2017 14:56:21 +0100 Emil Velikov wrote: > From: Emil Velikov > > Unlike the core wayland library, it's recommended that one statically > embeds the protocol within their binary. > Hi, that is true, but I'd rather leave

Re: [PATCH 3/5] scanner: introduce --object-type option

On Wed, 26 Jul 2017 14:56:19 +0100 Emil Velikov wrote: > From: Emil Velikov > > The option is used to indicate how the code will be used - would it be a > part of shared or static one. > > In the former case one needs to export the

Re: [PATCH weston] libweston-desktop: fix the size of unmaximized xdg surfaces

On 7/27/17 3:01 PM, Giulio Camuffo wrote: When unmaximizing a surface the configure event should send 0,0 as the requested size, so that the client can use the size that it had before maximizing Hi, I disagree on this patch for a few reasons: - the size can be ignored in this case, so there

Re: [PATCH 2/5] scanner: use tabs for indentation.

On Wed, 26 Jul 2017 14:56:18 +0100 Emil Velikov wrote: > From: Emil Velikov > > File uses tabs, barring the few instances fixed with this patch. > > Signed-off-by: Emil Velikov > --- > src/scanner.c | 6 +++---

Re: [PATCH 1/5] scanner: remove unused scanner.mk

On Wed, 26 Jul 2017 14:56:17 +0100 Emil Velikov wrote: > From: Emil Velikov > > Nothing in the existing codebase references the file. > > Signed-off-by: Emil Velikov > --- > src/scanner.mk | 8 > 1

Re: [PATCH wayland 2/3] scanner: Allow adding a prefix to exported symbols

On Wed, 26 Jul 2017 16:09:32 +0100 Emil Velikov wrote: > On 25 July 2017 at 10:24, Pekka Paalanen wrote: > > On Tue, 25 Jul 2017 15:25:58 +0800 > > Jonas Ådahl wrote: > > > >> On Mon, Jul 24, 2017 at 02:16:04PM +0300, Pekka

[PATCH weston] libweston-desktop: fix the size of unmaximized xdg surfaces

When unmaximizing a surface the configure event should send 0,0 as the requested size, so that the client can use the size that it had before maximizing --- libweston-desktop/xdg-shell-v6.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git

Re: [PATCH wayland 1/3] Pass input/output files as arguments to wayland-scanner

On Wed, 26 Jul 2017 15:57:19 +0100 Emil Velikov wrote: > On 3 July 2017 at 10:16, Jonas Ådahl wrote: > > When input/output files are passed as arguments to wayland-scanner, > > instead of using stdin/stdout, warning and error messages will contain > >

Re: [RFC weston 0/9] weston-debug protocol, API, and tool

On Thu, 27 Jul 2017 11:55:25 + "Devadoss, Maniraj (RBEI/ECF3; ADITG/SWG)" wrote: > Hello Pekka, > > I integrated the patches and evaluated the protocol. Initially I faced > crashing with the following call stack. > > EXH

[PATCH wayland] Do not create man page links with doxygen

From: Armin Krezović There is a lot of files created with .so links to non-installed files, making most of installed pages useless. The files referenced in .so links are not suitable for installation nor do they contain any useful information for them to be worth

RE: [RFC weston 0/9] weston-debug protocol, API, and tool

Hello Pekka, I integrated the patches and evaluated the protocol. Initially I faced crashing with the following call stack. EXH /lib64/libc-2.24.so(strlen+0x10)[0xb6ddfcd0] EXH /lib64/libc-2.24.so(_IO_vfprintf+0x1938)[0xb6dad300] EXH /lib64/libc-2.24.so(_IO_fprintf+0x68)[0xb6db2e18]

Re: [PATCH] Switch graphviz files to use HTML-style labels

On Thu, 1 Jun 2017 22:48:29 -0400 otay...@redhat.com wrote: > From: "Owen W. Taylor" > > With recent versions of graphviz, generation of the diagrams in the > documentation > fails with: > > /usr/bin/dot -Tpng -oxml/x-architecture.png dot/x-architecture.gv > Warning:

Re: [PATCH weston] input: Stop leaking libinput event source on session deactivation

On Thu, 27 Jul 2017 06:34:02 +1000 Peter Hutterer wrote: > On Tue, Jul 25, 2017 at 04:49:52PM -0500, Derek Foreman wrote: > > On 2017-07-25 04:39 PM, Derek Foreman wrote: > > > This is easily noticed as a leaked fd on every VC switch. > > > > > > Signed-off-by: Derek

Re: [PATCH weston] compositor-drm: reset KMS state on VT-switch in

On Thu, 27 Jul 2017 14:07:31 +0300 Pekka Paalanen wrote: > On Thu, 27 Jul 2017 11:54:43 +0100 > Daniel Stone wrote: > > > Hi, > > > > On 27 July 2017 at 11:51, Pekka Paalanen wrote: > > > @@ -2810,6 +2820,7 @@

Re: [PATCH weston] compositor-drm: reset KMS state on VT-switch in

On Thu, 27 Jul 2017 11:54:43 +0100 Daniel Stone wrote: > Hi, > > On 27 July 2017 at 11:51, Pekka Paalanen wrote: > > @@ -2810,6 +2820,7 @@ create_output_for_connector(struct drm_backend *b, > > if (output == NULL) > > goto err;

Re: [PATCH weston] compositor-drm: reset KMS state on VT-switch in

Hi, On 27 July 2017 at 11:51, Pekka Paalanen wrote: > @@ -2810,6 +2820,7 @@ create_output_for_connector(struct drm_backend *b, > if (output == NULL) > goto err; > > + output->state_invalid = true; > output->connector = connector; >

[PATCH weston] compositor-drm: reset KMS state on VT-switch in

From: Pekka Paalanen Fix a regression with VT-switching away from Weston and then back causing drmModePageFlip() to fail with ENOSPC or EINVAL, leaving one or more outputs not updated. The regression appeared in 47224cc9312fef05c1a523ea0da0a1aae66f100d:

Re: [PATCH] extras: Update status for Kodi

On Sun, 11 Jun 2017 11:31:59 +0200 Philipp Kerling wrote: > Wayland integration in Kodi was accepted as Google Summer of Code > Project. It is already on-par with the prior implementation > feature-wise. > > Sorting is in reverse chronological order because usually people

Re: [PATCH weston] logind: actually close fd in launcher_logind_close

On Wed, 26 Jul 2017 18:04:19 +0300 Pekka Paalanen wrote: > On Tue, 25 Jul 2017 16:17:36 -0500 > Derek Foreman wrote: > > > We still need to close fds passed to us - or we leak quite a few fds > > on VC switch. > > > > Regression, originally fixed

Re: Re Weston with fbdev-backend shows blank screen on display

On Wed, 26 Jul 2017 20:16:42 +0530 saikishore wrote: > Date: Wed, 26 Jul 2017 16:38:53 +0300 > From: Pekka Paalanen > To: saikishore > Cc: wayland-devel@lists.freedesktop.org > Subject: Re: Weston with fbdev-backend shows blank screen