Re: [PATCH wayland-protocols 2/3] tests: Add compile tests

Hi, Meant 'patch' rather than 'series' when offering my R-b to the other patch. Oops. On 11 October 2017 at 10:00, Jonas Ådahl wrote: > + # Check that header can be included by a pedantic C99 compiler > + test_name = 'test-build-pedantic-@0@'.format(protocol.underscorify()) >

Re: [PATCH wayland-protocols 1/3] Add meson build system support

Hi Jonas, On 11 October 2017 at 10:00, Jonas Ådahl wrote: > +wayland_scanner = find_program('wayland-scanner') It would be good to have this follow Quentin's suggestion for how to find wayland-scanner generally. Apart from that, series is: Reviewed-by: Daniel Stone

Re: [PATCH v2 wayland 00/11] Stop leaking file descriptors

Hi Derek, On 13 April 2017 at 17:51, Derek Foreman wrote: > Moved the test cases to the end so they're not introduced in a failed > state. > > Reworked the removal of the global zombie singleton patch - we now > create a wl_zombie at proxy creation time and store the

Re: [PATCH v2 wayland 04/11] connection: Make wl_closure_destroy() close fds of undispatched closures

Hi Derek, On 13 April 2017 at 17:51, Derek Foreman wrote: > void > -wl_closure_destroy(struct wl_closure *closure) > +wl_closure_destroy(struct wl_closure *closure, bool dispatched) > { > + /* wl_closure_destroy has free() semantics */ > + if (!closure) > +

Re: [PATCH wayland] scanner: Add autoconf macro to check for the proper scanner

Jussi, Tomek, Emil, On 18 August 2017 at 10:36, Quentin Glidic wrote: > On 8/18/17 11:30 AM, Quentin Glidic wrote: >> Projects have been using various ways to check for the wayland-scanner, >> mostly based on their developper own use case, and often not allowing

Re: [RFC weston] libweston: Do not include subsurfaces with NULL buffer in bounding box

Hi Philipp, On 28 July 2017 at 15:41, Philipp Kerling wrote: > I was pondering how to remove the window decorations of my application > (which live in subsurfaces) when going full screen without flickering. > > At first I just destroyed the surfaces, but that lead to flicker

Re: [PATCH 2/2] server: add log message when client connection is destroyed due to an error

Hi Mathias, Thanks for your patch! The idea seems fine, but I have a few comments. On 8 June 2017 at 08:39, wrote: > @@ -313,16 +326,30 @@ wl_client_connection_data(int fd, uint32_t mask, void > *data) > uint32_t resource_flags; > int opcode, size,

Re: [PATCH weston] editor: unify key handling

Hi Weng, Thanks for the patch, and sorry for the horrendous delay in giving you feedback. In general, your patch looks very good and makes a lot of sense. However: On 1 February 2017 at 03:22, Weng Xuetian wrote: > @@ -395,81 +402,8 @@ text_input_keysym(void *data, >

Re: [weston v2] linux-dmabuf: align DMABUF exposed formats with EGL supported formats

Hi Vincent, On 20 March 2017 at 09:50, Vincent ABRIOU wrote: > Any feedback on this patch? Sorry for not replying sooner. With the modifiers code having landed, this would need some rework to fit there. When the modifiers query is available, we'd need to drop the RGB

Re: [PATCH weston 2/2] weston: add --device option for DRM-backend

Hi Pekka, On 28 March 2017 at 16:26, Pekka Paalanen wrote: > Developers with testing rigs having multiple graphics cards plugged in > often want to test things on a specific card. We have ways to choose a > card through seat assignments, but configuring that run by run is >

Re: [PATCH weston 3/5] gl-renderer: always enable unpack subimage and RG textures in ES3 contexts

On Mon, Dec 4, 2017 at 5:57 PM, Emil Velikov wrote: > On 29 November 2017 at 14:25, Arnaud Vrac wrote: >> From: Arnaud Vrac >> >> The GL_EXT_unpack_subimage and GL_EXT_texture_rg are part of the core ES >> 3.0 specification, so also

Re: [PATCH weston 5/5] gl-renderer: use correct pixel shader for NV12 format uploaded to RG texture

On Mon, Dec 4, 2017 at 6:08 PM, Emil Velikov wrote: > On 29 November 2017 at 14:25, Arnaud Vrac wrote: >> Signed-off-by: Arnaud Vrac > > Please mention how you've spotted and/or verified this. > > I'm ~90% this is correct, although I

Re: [PATCH weston 5/5] gl-renderer: use correct pixel shader for NV12 format uploaded to RG texture

On 29 November 2017 at 14:25, Arnaud Vrac wrote: > Signed-off-by: Arnaud Vrac Please mention how you've spotted and/or verified this. I'm ~90% this is correct, although I would check with the author. Vincent, can you double check the patch/series [1]?

Re: [PATCH weston 3/5] gl-renderer: always enable unpack subimage and RG textures in ES3 contexts

On 29 November 2017 at 14:25, Arnaud Vrac wrote: > From: Arnaud Vrac > > The GL_EXT_unpack_subimage and GL_EXT_texture_rg are part of the core ES > 3.0 specification, so also check the GL driver version in addition to > the extension string to determine if

Re: [PATCH weston 4/5] gl-renderer: fix pixel format used in texture uploads when using R/RG textures

On 29 November 2017 at 14:25, Arnaud Vrac wrote: > From: Arnaud Vrac > > In glTexImage2D / glTexSubImage2D calls, the only pixel formats allowed > for the GL_R8 and GL_RG internal formats are respectively GL_RED and s/GL_RG/GL_RG8/ ^^ > GL_RG [1]. > > Make

Re: [PATCH weston 1/5] gl-renderer: save OpenGL version in renderer context

On Mon, Dec 4, 2017 at 5:31 PM, Emil Velikov wrote: > Hi Arnaud, > > On 29 November 2017 at 14:25, Arnaud Vrac wrote: >> From: Arnaud Vrac >> > Here I'd mention why we care about the version. Esp. since the helper > itself looks

Re: [systemd-devel] [PATCH weston] doc/systemd: system service example

On Fri, 1 Dec 2017 18:25:35 +0100 Lennart Poettering wrote: > On Fr, 01.12.17 13:42, Pekka Paalanen (ppaala...@gmail.com) wrote: > > > > > > This is racy, as the session ID is not really reliably predictable, > > > > > and is synthesized in different contexts in

Re: Scanner with --no-documentation option (source-code included)

Hi Felipe, On 2 December 2017 at 20:17, ferreiradaselva wrote: > I don't know how useful this feature would be for others (it would be for > me), but I made the wayland-scanner to take a no-documentation option. It > omits the documentation comments (but still

[PATCH weston 8/8] tests: Add test for touch event timestamps

Add test to verify that the server correctly sets the timestamps of touch events. This requires updating the weston-test protocol with a new request for touch events. Signed-off-by: Alexandros Frantzis --- Makefile.am | 7 +++-

[PATCH weston 7/8] tests: Add test for keyboard key event timestamps

Add test to verify that the server correctly sets the timestamps of keyboard key events. This requires updating the weston-test protocol to support passing key event timestamps. Signed-off-by: Alexandros Frantzis --- protocol/weston-test.xml | 3 ++

[PATCH weston 6/8] tests: Add test for pointer axis events

Add test to verify the server correctly emits pointer axis events. This requires updating the weston-test protocol with a new request for pointer axis events. Signed-off-by: Alexandros Frantzis --- protocol/weston-test.xml | 7 +++

[PATCH weston 3/8] tests: Move wl_pointer tests to their own file

Move wl_pointer tests from event-test.c to their own pointer-test.c file. This move makes the test organization clearer and more consistent, and will make addition of further pointer tests easier. Signed-off-by: Alexandros Frantzis --- Makefile.am |

[PATCH weston 2/8] shared: Add helpers to convert between protocol data and timespec

Add helpers to safely convert between struct timespec values and tv_sec_hi, tv_sec_lo, tv_nsec triplets used for sending high-resolution timestamp data over the wayland protocol. Replace existing conversion code with the helper functions. Signed-off-by: Alexandros Frantzis

[PATCH weston 5/8] tests: Add checks for pointer motion and button event timestamps

Enhance the existing pointer motion and button event tests to additionally verify the event timestamps. This requires updating the weston-test protocol to support passing motion and button event timestamps. Signed-off-by: Alexandros Frantzis ---

[PATCH weston 4/8] tests: Use separate test cases for pointer motion and button tests

Split pointer motion and pointer button tests so that each test case is more focused and self-contained. Signed-off-by: Alexandros Frantzis --- tests/pointer-test.c | 36 +--- 1 file changed, 25 insertions(+), 11 deletions(-)

[PATCH weston 1/8] shared: Add timespec_normalize helper

Add a helper function to normalize struct timespec values so that the nanoseconds part is less than 1 second and has the same sign as the seconds part (if the seconds part is not 0). Normalization is required to ensure we can safely convert timespec values to wayland protocol data, i.e, to

[PATCH weston 0/8] tests: Add input event timestamp tests

This patchset enhances the test suite with test cases that verify that the server correctly sets input event timestamps. In the process the input tests have been reorganized and cleaned up to make it easier to support the new test cases. A secondary goal of this patchset is to prepare the test

Re: Can I copy-paste Wayland generated header in my own library header?

On Mon, 04 Dec 2017 05:59:02 -0500 ferreiradaselva wrote: > >From: ppaala...@gmail.com > >To: ferreiradaselva > > > > Hi, > > > > first, IANAL, of course. > > I don't know ZLIB license, or why you picked that instead of MIT, for >

Re: Can I copy-paste Wayland generated header in my own library header?

Hi, > Original Message >From: ppaala...@gmail.com >To: ferreiradaselva > > Hi, > > first, IANAL, of course. > > The copyrights header you get in the generated headers and code comes > from the XML files. It is the license of the XML protocol >

Re: [PATCH wayland] protocol: Add deprecation note about wl_shell

Hi! On 4 December 2017 at 09:16, Pekka Paalanen wrote: > On Sat, 2 Dec 2017 10:57:45 +0800 > Jonas Ådahl wrote: > >> Now that xdg_shell is stable and much better defined than wl_shell we >> can finally deprecate wl_shell and guide users towards xdg_shell

Re: Can I copy-paste Wayland generated header in my own library header?

On Sat, 02 Dec 2017 09:39:33 -0500 ferreiradaselva wrote: > Good morning. > > I'm writing a cross-platform window framework, like GLFW, but > containing only two files (a source and a header). > > I would like to copy and paste the content of the xdg-shell.h >

Re: [PATCH wayland] protocol: Add deprecation note about wl_shell

On Sat, 2 Dec 2017 10:57:45 +0800 Jonas Ådahl wrote: > Now that xdg_shell is stable and much better defined than wl_shell we > can finally deprecate wl_shell and guide users towards xdg_shell > instead. > > Signed-off-by: Jonas Ådahl > --- Hi, Acked-by:

Re: [PATCH wayland] connection: Print the content of arrays in closures

On Fri, 1 Dec 2017 17:08:15 + Daniel Stone wrote: > Hi, > > On 10 July 2017 at 19:28, Emmanuel Gil Peyrot > wrote: > > The current behaviour when WAYLAND_DEBUG is set is to print “array”, > > which is quite unhelpful. > > > > This patch