Re: [PATCH wayland] connection: Fix broken log message when demarshalling short closure

2018-02-14 Thread Pekka Paalanen
On Wed, 14 Feb 2018 12:15:11 -0600 Derek Foreman wrote: > Like the similar wl_log() message further into this function that was > fixed in commit 2fc248dc2c877d02694db40aad52180d71373d5a this should > be printing the sender_id saved earlier instead of *p. > > Since p is

[PATCH wayland] connection: Fix broken log message when demarshalling short closure

2018-02-14 Thread Derek Foreman
Like the similar wl_log() message further into this function that was fixed in commit 2fc248dc2c877d02694db40aad52180d71373d5a this should be printing the sender_id saved earlier instead of *p. Since p is incremented during the loop it would not only print an incorrect object id, it could read

[PATCH] core: implement a safe wl_signal_emit

2018-02-14 Thread Simon Ser
The previous implementation tried to be safe but wasn't: a listener couldn't remove the next one. This removes the need for wl_priv_signal. newsignal-test is now merged into signal-test. --- This is followup of "RFC: server: implement wl_priv_signal_emit without emit_list" [1] which removes

Re: [PATCH] RFC: server: implement wl_priv_signal_emit without emit_list

2018-02-14 Thread Pekka Paalanen
On Sun, 28 Jan 2018 12:37:36 -0500 Simon Ser wrote: > This is a RFC to be able to run tests and check that this approach > is working. The end goal is to remove wl_priv_signal completely and > implement a safe wl_signal_emit. > --- > What do you think of this approach? It

[PATCH weston v3 3/7] libweston: Make weston_seat release safe

2018-02-14 Thread Alexandros Frantzis
Ensure the server can safely handle client requests for wl_seat resource that have become inert due to weston_seat object release and subsequent destruction. The clean-up involves, among other things, unsetting the destroyed weston_seat object from the user data of wl_seat resources, and handling

[ANNOUNCE] wayland-protocols 1.13

2018-02-14 Thread Jonas Ådahl
wayland-protocols 1.13 is now available. This version includes a new unstable protocol: Input timestamps, a protocol for providing high resolution timestamps to input events. See the corresponding commit and protocol XML file for details. Here is the shortlog: Alexandros Frantzis (1):

[PATCH wayland] tests: disable coredumps on sanity-test

2018-02-14 Thread Pekka Paalanen
From: Pekka Paalanen SEGV and ABRT by default cause a core dump, which may create a file, launch crash handlers, and so on. sanity-test has 21 processes that are expected to crash like this. Disable core dumps on them all. I counted 21 entries in coredumpctl

RE: [PATCH weston] tests: fix a race condition in ivi-shell tests

2018-02-14 Thread Ucan, Emre (ADITG/ESB)
Hi Pekka, > -Original Message- > From: wayland-devel [mailto:wayland-devel- > boun...@lists.freedesktop.org] On Behalf Of Pekka Paalanen > Sent: Mittwoch, 14. Februar 2018 12:22 > To: Ucan, Emre (ADITG/ESB) > Cc: wayland-devel@lists.freedesktop.org > Subject: Re: [PATCH weston] tests:

Re: [PATCH weston] tests: fix a race condition in ivi-shell tests

2018-02-14 Thread Pekka Paalanen
On Wed, 14 Feb 2018 11:06:54 +0100 Emre Ucan wrote: > ivi-shell tests load their own controller plugin > for testing purposes. Tests also uses the generated > weston-ivi.in config file, which causes weston to > load hmi-controller and its helper client. > Existence of

[PATCH weston] tests: fix a race condition in ivi-shell tests

2018-02-14 Thread Emre Ucan
ivi-shell tests load their own controller plugin for testing purposes. Tests also uses the generated weston-ivi.in config file, which causes weston to load hmi-controller and its helper client. Existence of hmi-controller and its helper client confuses test plugins. Because they are creating

Re: [PATCH weston] libweston-desktop/xdg-shell-v5: Drop xdg-shell v5 support

2018-02-14 Thread Pekka Paalanen
On Wed, 14 Feb 2018 10:06:27 +0200 Pekka Paalanen wrote: > On Tue, 13 Feb 2018 09:49:53 -0600 > Derek Foreman wrote: > > > On 2018-02-13 08:20 AM, Alexandros Frantzis wrote: > > > Drop support for the obsolete xdg-shell v5 protocol. This clears

Re: [PATCH weston] desktop-shell: fix shell_output_destroy_move_layer unused variable

2018-02-14 Thread Pekka Paalanen
On Tue, 13 Feb 2018 15:57:33 + Daniel Stone wrote: > Hi Pekka, > > On 13 February 2018 at 14:21, Pekka Paalanen wrote: > > /home/pq/git/weston/desktop-shell/shell.c: In function > > ‘shell_output_destroy_move_layer’: > >

Re: [PATCH weston] libweston-desktop/xdg-shell-v5: Drop xdg-shell v5 support

2018-02-14 Thread Pekka Paalanen
On Tue, 13 Feb 2018 09:49:53 -0600 Derek Foreman wrote: > On 2018-02-13 08:20 AM, Alexandros Frantzis wrote: > > Drop support for the obsolete xdg-shell v5 protocol. This clears the > > path to properly support xdg-shell stable, since xdg-shell stable and > > xdg-shell v5