Re: [PATCH weston] Revert "config-parser: Catch negative numbers assigned to unsigned config values"

On Wed, Jul 13, 2016 at 02:27:17PM -0700, Yong Bakos wrote: > On Jul 13, 2016, at 2:10 PM, Bryce Harrington <br...@osg.samsung.com> wrote: > > > > On Wed, Jul 13, 2016 at 01:27:29PM -0700, Bryce Harrington wrote: > >> The reduction in range limits does have an effec

[PATCH weston 2/2] Re-apply "config-parser: Catch negative numbers assigned to unsigned config values"

the change is believed to have no impact in practice. Also add a test case for negative numbers that catches this error condition. Signed-off-by: Bryce Harrington <br...@osg.samsung.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> --- shared/config-parser.c | 12

[PATCH weston 1/2] config-parser: Add weston_config_section_get_color

tively, resulting in colors 0x01234567, 0x00053977, and 0x0012d687 being displayed. This new routine forces hexadecimal to be used in all cases when parsing color values, so "0x01234567", "01234567", and "1234567" all result in the same color value, ""

Re: [PATCH wayland-protocols v5 3/4] tablet: restrict the cursor surface to one per tool

utterer <peter.hutte...@who-t.net> > Reviewed-by: Jason Gerecke <jason.gere...@wacom.com> > Reviewed-by: Carlos Garnacho <carl...@gnome.org> Makes sense; overloading behaviors and trying to do too many things at once often leads to oddball corner cases. Reviewed-by: Bryce

Re: [PATCH wayland-protocols v5 2/4] tablet: change all degree values from int to wl_fixed

cho <carl...@gnome.org> Reviewed-by: Bryce Harrington <br...@osg.samsung.com> > --- > unstable/tablet/tablet-unstable-v2.xml | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/unstable/tablet/tablet-unstable-v2.xml > b/unstabl

Re: [PATCH wayland-protocols v5 1/4] tablet: add v2 of the tablet protocol

hutte...@who-t.net> > Reviewed-by: Jason Gerecke <jason.gere...@wacom.com> > Reviewed-by: Carlos Garnacho <carl...@gnome.org> Reviewed-by: Bryce Harrington <br...@osg.samsung.com> > --- > Makefile.am| 1 + > unstable/tablet/tablet-uns

Re: [PATCH weston] Revert "config-parser: Catch negative numbers assigned to unsigned config values"

On Wed, Jul 13, 2016 at 02:12:43PM -0700, Yong Bakos wrote: > On Jul 13, 2016, at 1:27 PM, Bryce Harrington <br...@osg.samsung.com> wrote: > > > > The reduction in range limits does have an effect for color values, > > which are expressed as hexadecimal values from 0

Re: [PATCH weston] Revert "config-parser: Catch negative numbers assigned to unsigned config values"

On Wed, Jul 13, 2016 at 01:27:29PM -0700, Bryce Harrington wrote: > The reduction in range limits does have an effect for color values, > which are expressed as hexadecimal values from 0x to > 0x. By limiting the range to INT_MAX, color values of > 0x8000 and up

[PATCH weston] Revert "config-parser: Catch negative numbers assigned to unsigned config values"

-off-by: Bryce Harrington <br...@osg.samsung.com> --- shared/config-parser.c | 12 +--- tests/config-parser-test.c | 31 --- 2 files changed, 1 insertion(+), 42 deletions(-) diff --git a/shared/config-parser.c b/shared/config-parser.c index 4c67220..1

[PATCH weston 0/3] Standardize error checking for strtol calls

. Bryce Harrington (3): Standardize error checking for strtol calls xwayland: Improve error checking for strtol call option-parser: Improve error checking for strtol call compositor/main.c | 3 ++- compositor/systemd-notify.c | 2 +- libweston/compositor.c | 3 ++- libweston

[PATCH weston 3/3] option-parser: Improve error checking for strtol call

Make the error checking consistent with other strtol() calls. Note that since strtol(nptr, ) sets endptr == nptr if there were no digits, this catches the case where the string was blank, so there's no need to test *value != '\0'. Signed-off-by: Bryce Harrington <br...@osg.samsung.

[PATCH weston 2/3] xwayland: Improve error checking for strtol call

, and the resulting number must be within the accepted range. Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- xwayland/launcher.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xwayland/launcher.c b/xwayland/launcher.c index b7aee3b..5b81fef 100644 --- a/xwayland/laun

[PATCH weston 1/3] Standardize error checking for strtol calls

the error checking can all be tightened up and made consistent with other strtol() calls. This follows the error checking style used in Wayland (c.f. wayland-client.c and scanner.c) and c.f. commit cbc05378. Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- compositor/

Re: [PATCH weston] Require base-10 for strtol() calls

On Tue, Jul 12, 2016 at 06:49:06PM -0700, Yong Bakos wrote: > On Jul 12, 2016, at 4:51 PM, Bryce Harrington <br...@osg.samsung.com> wrote: > > > > The third arg to strtol() specifies the base to assume for the number. > > When 0 is passed, as is currently done in o

Re: [PATCH weston] Include space in 'if ('

On Wed, Jul 13, 2016 at 10:23:42AM +1000, Peter Hutterer wrote: > On Tue, Jul 12, 2016 at 04:59:05PM -0700, Bryce Harrington wrote: > > Signed-off-by: Bryce Harrington <br...@osg.samsung.com> > > --- > > Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> >

[PATCH weston] Include space in 'if ('

Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- compositor/main.c | 2 +- ivi-shell/ivi-layout-transition.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/compositor/main.c b/compositor/main.c index 8400d70..1f75ae0 100644 --- a/comp

[PATCH weston] Require base-10 for strtol() calls

-off-by: Bryce Harrington <br...@osg.samsung.com> --- compositor/main.c | 2 +- libweston/compositor.c | 2 +- shared/config-parser.c | 2 +- xwayland/launcher.c| 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/compositor/main.c b/compositor/main.c index 6cf9194..8

Re: [PATCH weston] config-parser: Catch negative numbers assigned to unsigned config values

On Tue, Jul 12, 2016 at 01:17:20PM +0100, Eric Engestrom wrote: > On Mon, Jul 11, 2016 at 05:55:15PM -0700, Bryce Harrington wrote: > > strtoul() has a side effect that when given a string representing a > > negative number, it returns a negated version as the value, and does not &g

Re: [PATCH weston] config-parser: Catch negative numbers assigned to unsigned config values

..@imgtec.com> > wrote: > > > On Mon, Jul 11, 2016 at 05:55:15PM -0700, Bryce Harrington wrote: > > > strtoul() has a side effect that when given a string representing a > > > negative number, it returns a negated version as the value, and does not &

Re: [PATCH weston] rdp: Check for non-digits and errno in strtol call

On Tue, Jul 12, 2016 at 08:12:37AM -0700, Yong Bakos wrote: > On Jul 11, 2016, at 5:02 PM, Bryce Harrington <br...@osg.samsung.com> wrote: > > > > Improve error checking for situations like RDP_FD=42foo, or where the > > provided number is out of range. > &

[PATCH weston] config-parser: Catch negative numbers assigned to unsigned config values

this error condition. Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- shared/config-parser.c | 12 +++- tests/config-parser-test.c | 31 +++ 2 files changed, 42 insertions(+), 1 deletion(-) diff --git a/shared/config-parser.c b/shared/confi

[PATCH weston] rdp: Check for non-digits and errno in strtol call

Improve error checking for situations like RDP_FD=42foo, or where the provided number is out of range. Suggestion by Yong Bakos. Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- libweston/compositor-rdp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib

Re: [PATCH] scanner: Improve documentation for strtouint()

On Fri, Jul 08, 2016 at 07:38:13PM -0700, Yong Bakos wrote: > On Jul 8, 2016, at 4:51 PM, Bryce Harrington <br...@osg.samsung.com> wrote: > > > > From: Bryce Harrington <br...@bryceharrington.org> > > > > Signed-off-by: Bryce Harrington <br...@osg.samsun

Re: [PATCH] tests: Require base 10 for the string specifying the number of open fd's

On Fri, Jul 08, 2016 at 07:39:33PM -0700, Yong Bakos wrote: > On Jul 8, 2016, at 7:00 PM, Bryce Harrington <br...@osg.samsung.com> wrote: > > > > The third arg to strtol() specifies the base to assume for the number. > > When 0 is passed, as is currently done in wa

Re: [PATCH weston] rdp: Check for non-numeric value in RDP_FD env var

On Fri, Jul 08, 2016 at 08:11:26PM -0700, Yong Bakos wrote: > On Jul 8, 2016, at 6:54 PM, Bryce Harrington <br...@osg.samsung.com> wrote: > > > > strtoul(nptr, endptr, ...) will set *endptr to nptr in the case of where > > no digits were read from the str

Re: [PATCH weston] config-parser: Improve error checks for strtol/strtoul calls

On Mon, Jul 11, 2016 at 09:28:16AM +1000, Peter Hutterer wrote: > On Thu, Jul 07, 2016 at 02:24:39PM -0700, Bryce Harrington wrote: > > On Thu, Jul 07, 2016 at 02:08:28PM -0700, Bryce Harrington wrote: > > > Check errno, which is set of over/underflow, out of range, etc.

Re: [PATCH weston] Remove a wrong closing “extern "C"” in shared/xalloc.c

On Mon, Jul 11, 2016 at 05:31:59PM +0100, Emmanuel Gil Peyrot wrote: > Signed-off-by: Emmanuel Gil Peyrot Thanks, pushed: cbc0537..7fc000c master -> master > --- > shared/xalloc.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/shared/xalloc.c

Re: [PATCH weston] Remove a wrong closing “extern "C"” in shared/xalloc.c

On Mon, Jul 11, 2016 at 05:31:59PM +0100, Emmanuel Gil Peyrot wrote: > Signed-off-by: Emmanuel Gil Peyrot <emmanuel.pey...@collabora.com> Reviewed-by: Bryce Harrington <br...@osg.samsung.com> > --- > shared/xalloc.c | 5 - > 1 file changed, 5 deletions(-) > >

Re: [PATCH weston] config-parser: Improve error checks for strtol/strtoul calls

On Mon, Jul 11, 2016 at 09:39:00AM -0700, Bill Spitzak wrote: > On Sun, Jul 10, 2016 at 4:28 PM, Peter Hutterer <peter.hutte...@who-t.net> > wrote: > > > On Thu, Jul 07, 2016 at 02:24:39PM -0700, Bryce Harrington wrote: > > > On Thu, Jul 07, 2016 at 02:08:28PM

Re: [PATCH weston] option-parser: Require integer option string values to be base-10

On Fri, Jul 08, 2016 at 06:47:19PM -0700, Yong Bakos wrote: > On Jul 8, 2016, at 5:52 PM, Bryce Harrington <br...@osg.samsung.com> wrote: > > > > The third arg to strtol() specifies the base to assume for the number. > > When 0 is passed, as is currently done in o

[PATCH] tests: Require base 10 for the string specifying the number of open fd's

it should expect to be open. We should expect this to be specified only as a decimal number, there's no reason why one would want to use octal or hexadecimal for that. Suggested by Yong Bakos. Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- tests/exec-fd-leak-checker.c | 2 +- 1 file c

[PATCH weston] rdp: Check for non-numeric value in RDP_FD env var

strtoul(nptr, endptr, ...) will set *endptr to nptr in the case of where no digits were read from the string, and return 0. Running with RDP_FD=foo would thus result in fd=0 being specified to freerdp_peer_new(), which is unlikely to be the user's intent. Signed-off-by: Bryce Harrington <

[PATCH weston] multi-resource: Check for no digits in time description

strtoul(nptr, endptr, ...) will set *endptr to nptr in the case of where no digits were read from the string. E.g. "foo:bar" should trigger an error, instead of being read as "0:0" and allowed through. Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- cl

[PATCH weston] option-parser: Require integer option string values to be base-10

code in the future. Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- shared/option-parser.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/shared/option-parser.c b/shared/option-parser.c index d5fee8e..33355b8 100644 --- a/shared/option-parser.c +++ b/

[PATCH] scanner: Improve documentation for strtouint()

From: Bryce Harrington <br...@bryceharrington.org> Signed-off-by: Bryce Harrington <br...@osg.samsung.com> Signed-off-by: Bryce Harrington <br...@bryceharrington.org> --- src/scanner.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/s

[PATCH] wayland-client: Require base 10 for WAYLAND_SOCKET, explicitly

for socket fd's. So be explicit about what base we're assuming here and avoid any potential surprises. Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- src/wayland-client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wayland-client.c b/src/wayland-cl

Re: [PATCH weston] config-parser: Improve error checks for strtol/strtoul calls

On Fri, Jul 08, 2016 at 11:33:56AM +0100, Eric Engestrom wrote: > On Fri, Jul 08, 2016 at 10:26:43AM +0100, Eric Engestrom wrote: > > On Thu, Jul 07, 2016 at 02:08:28PM -0700, Bryce Harrington wrote: > > > + errno = 0; > > > *value = strtol(entry->value,

Re: [PATCH wayland-protocols] Fix grammar for 'an X*'

On Fri, Jul 08, 2016 at 10:20:22AM +0100, Eric Engestrom wrote: > On Thu, Jul 07, 2016 at 10:56:12AM -0700, Bryce Harrington wrote: > > Signed-off-by: Bryce Harrington <br...@osg.samsung.com> > > This is the last of it, right? ^^ > Reviewed-by: Eric Engestrom <eric.en

Re: [PATCH weston] config-parser: Improve error checks for strtol/strtoul calls

On Thu, Jul 07, 2016 at 02:08:28PM -0700, Bryce Harrington wrote: > Check errno, which is set of over/underflow, out of range, etc. Also > check for empty strings (the usages covered in this patch already also > cover the case where there are non-digits present). Set errno to 0 > b

[PATCH weston] config-parser: Improve error checks for strtol/strtoul calls

under the testsuite). This follows the error checking style used in Wayland (c.f. wayland-client.c and scanner.c). In tests, also check errno, and add testcases for parsing '0'. Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- shared/config-parser.c | 6 -- tests/config-

[PATCH wayland-protocols] Fix grammar for 'an X*'

Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- unstable/input-method/input-method-unstable-v1.xml | 2 +- unstable/text-input/text-input-unstable-v1.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/unstable/input-method/input-method-unstable-v1.

Re: [PATCH weston] xwayland: Grammar fixes

On Thu, Jul 07, 2016 at 01:16:38PM +0100, Eric Engestrom wrote: > On Wed, Jul 06, 2016 at 03:25:19PM -0700, Bryce Harrington wrote: > > Signed-off-by: Bryce Harrington <br...@osg.samsung.com> > > --- > > xwayland/xwayland-api.h | 16 > > 1

[PATCH weston] dmabuf: Fix grammar in a comment

Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- libweston/linux-dmabuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libweston/linux-dmabuf.c b/libweston/linux-dmabuf.c index 78e77a2..a91ae85 100644 --- a/libweston/linux-dmabuf.c +++ b/libweston/linux-dm

[PATCH weston] xwayland: Grammar fixes

Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- xwayland/xwayland-api.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/xwayland/xwayland-api.h b/xwayland/xwayland-api.h index 4be87e5..9a16147 100644 --- a/xwayland/xwayland-api.h +++ b/xw

[PATCH weston] xwayland: Cleanup error message on spawn failure Signed-off-by: Bryce Harrington <br...@osg.samsung.com>

Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- compositor/xwayland.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compositor/xwayland.c b/compositor/xwayland.c index 9fa7600..9881cd9 100644 --- a/compositor/xwayland.c +++ b/compositor/xwayland.c @@

[PATCH weston] xwayland: Include missing config.h

Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- compositor/xwayland.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/compositor/xwayland.c b/compositor/xwayland.c index 26eda20..9fa7600 100644 --- a/compositor/xwayland.c +++ b/compositor/xwayland.c @@ -24,6

Re: [PATCH weston] terminal: Fix segmentation fault when processing DCH ANSI escape code

On Sat, Jul 02, 2016 at 12:35:21AM +, aa...@correspondwith.me wrote: > Fix a segfault where terminal parses a DCH escape code and the cursor is at > the end of the line, causing terminal_shift_line to memmove memory it doesn't > own. > --- > clients/terminal.c | 17 ++--- > 1

Re: Free software license of weston1.9

On Thu, Jun 30, 2016 at 11:59:58AM +0800, Jonas Ådahl wrote: > On Thu, Jun 30, 2016 at 04:43:29AM +0200, Armin Krezović wrote: > > On 30.06.2016 04:19, 袁嘉伟 wrote: > > > Hi, All: > > > > > > > > > Who does know that the free software license of weston 1.9 is GPL or > > > LGPL? > > >

Re: [PATCH wayland-web 1/1] html: Remove trailing whitespace

ering the diff beyond the intent of the author. > > Remove trailing whitespace from all html files, so the annoyance described > above no longer occurs. > > Signed-off-by: Yong Bakos <yba...@humanoriented.com> Reviewed-by: Bryce Harrington <br...@osg.sam

[PATCH weston 1/2] input: Rename weston_surface_activate to weston_seat_set_keyboard_focus

all callers as appropriate. Change was asked for by pq, May 26, 2016: "This should be called weston_seat_set_keyboard_focus(seat, surface). Keyboard focus is a property of the seat." Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- desktop-shell/shell.c

[PATCH weston 2/2] input: Move weston_seat_set_keyboard_focus and document

Place it with the other weston_seat functions. Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- libweston/compositor.h | 7 --- libweston/input.c | 34 +++--- 2 files changed, 23 insertions(+), 18 deletions(-) diff --git a/libweston/compos

Re: [PATCH weston v3 2/8] compositor: Track inhibition state in weston_surface

On Tue, Jun 28, 2016 at 12:15:49PM +0300, Pekka Paalanen wrote: > On Thu, 23 Jun 2016 17:32:50 -0700 > Bryce Harrington <br...@osg.samsung.com> wrote: > > > On Thu, May 26, 2016 at 06:01:27PM +0300, Pekka Paalanen wrote: > > > On Thu, 7 Apr 2016 16:44:17 -0

Re: [PATCH weston v3 2/8] compositor: Track inhibition state in weston_surface

On Thu, May 26, 2016 at 06:01:27PM +0300, Pekka Paalanen wrote: > On Thu, 7 Apr 2016 16:44:17 -0700 > Bryce Harrington <br...@osg.samsung.com> wrote: > > > Signed-off-by: Bryce Harrington <br...@osg.samsung.com> > > Hi, > > the commit message could use

Re: [PATCH weston v2 0/2] Separate Weston from libweston

On Wed, Jun 22, 2016 at 02:44:23PM +0300, Pekka Paalanen wrote: > On Thu, 9 Jun 2016 15:20:35 +0300 > Pekka Paalanen wrote: > > > From: Pekka Paalanen > > > > After these two patches, we have weston-the-compositor sources in > >

Re: [PATCH wayland-web] FAQ: Modernise FAQ and inject some optimism

ything that helps get the website better up to date. Details can always be fixed up more later. Acked-by: Bryce Harrington <br...@osg.samsung.com> > --- > faq.html | 115 > --- > 1 file changed, 43 insertions(+), 72

Re: [PATCH wayland-web] Build instructions for Ubuntu 16.04

t; +git clone git://anongit.freedesktop.org/xorg/xserver > +cd xserver > +./autogen.sh --prefix=$WLD --disable-docs --disable-devel-docs \ > + --enable-xwayland --disable-xorg --disable-xvfb --disable-xnest \ > + --disable-xquartz --disable-xwin > +make make install > +cd .. > + > +# Links needed so XWayland works: > +mkdir -p $WLD/share/X11/xkb/rules > +ln -s /usr/share/X11/xkb/rules/evdev $WLD/share/X11/xkb/rules/ > +ln -s /usr/bin/xkbcomp $WLD/bin/ > + > +# Weston configuration: > +mkdir -p ~/.config > +cp weston/weston.ini ~/.config > +nano ~/.config/weston.ini # edit to set background and > turn on xwayland.so module > + > +# Run it in an X11 window: > +weston > + > + > + > + > + > -- > 2.7.4 Acked-by: Bryce Harrington <br...@osg.samsung.com> ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH weston] weston-simple-im: Make capitalization consistent in error messages

On Thu, Jun 16, 2016 at 09:24:56PM -0600, Yong Bakos wrote: > > > On Jun 16, 2016, at 12:11 PM, Bryce Harrington <br...@osg.samsung.com> > > wrote: > > > > On Thu, Jun 16, 2016 at 11:14:01AM -0500, Derek Foreman wrote: > >> On 15/06/16 07:59 PM

[PATCH weston] terminal: Document console codes less cryptically

C.f. http://man7.org/linux/man-pages/man4/console_codes.4.html Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- clients/terminal.c | 72 +++--- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/clients/terminal.c b/c

[PATCH weston] Make config.h inclusion consistent

Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- clients/multi-resource.c | 2 +- clients/presentation-shm.c| 2 +- clients/simple-damage.c | 2 +- clients/simple-dmabuf-intel.c | 2 +- clients/simple-dmabuf-v4l.c | 2 +- clients/simple-shm.c | 2 +- c

[PATCH weston] weston-simple-im: Make capitalization consistent in error messages

Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- clients/weston-simple-im.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/clients/weston-simple-im.c b/clients/weston-simple-im.c index 4c1d7cf..0ee505a 100644 --- a/clients/weston-simple-im.c +++ b/c

[PATCH libxkbcommon 3/3] doc: Also mention the wayland test client in the quick guide

Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- doc/quick-guide.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/quick-guide.md b/doc/quick-guide.md index 6e04ba5..9d66475 100644 --- a/doc/quick-guide.md +++ b/doc/quick-guide.md @@ -20,6 +20,8 @@ can find complete an

[PATCH libxkbcommon 2/3] doc: Declare keymap for wayland example

keymap was defined in the X11 example, but also define it in the wayland example just to make it a bit more standalone Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- doc/quick-guide.md | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/quick-guide.md b/doc/quick-guide.md

[PATCH libxkbcommon 1/3] doc: Fix ctx type in example

xkb_context_new() returns a xkb_context pointer, so change the variable definition to be consistent. Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- doc/quick-guide.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/quick-guide.md b/doc/quick-guide.md

Re: [PATCH weston v2 0/2] Separate Weston from libweston

On Thu, Jun 09, 2016 at 03:20:35PM +0300, Pekka Paalanen wrote: > From: Pekka Paalanen > > After these two patches, we have weston-the-compositor sources in compositor/, > and libweston sources in libweston/. > > Since these patches have been generated with git

Re: [PATCH weston v3 7/8] Define the screensaver inhibitor client interface

On Thu, May 26, 2016 at 06:02:09PM +0300, Pekka Paalanen wrote: > On Thu, 7 Apr 2016 16:44:22 -0700 > Bryce Harrington <br...@osg.samsung.com> wrote: > > > Hook up the API defined in wayland-protocols to allow client screensaver > > inhibition requests. > > &g

Re: [PATCH wayland-protocols v3] Add screensaver idle inhibitor protocol

On Wed, Jun 08, 2016 at 12:02:14PM +0300, Pekka Paalanen wrote: > On Wed, 8 Jun 2016 10:51:30 +0800 > Jonas Ådahl <jad...@gmail.com> wrote: > > > On Tue, Jun 07, 2016 at 07:10:25PM -0700, Bryce Harrington wrote: > > > On Fri, Jun 03, 2016 at 09:26:24AM +0800, Jonas

Re: [PATCH wayland-protocols v3] Add screensaver idle inhibitor protocol

On Fri, Jun 03, 2016 at 09:26:24AM +0800, Jonas Ådahl wrote: > On Thu, Jun 02, 2016 at 02:24:20PM -0700, Bryce Harrington wrote: > > This interface allows disabling of screensaver/screenblanking on a > > per-surface basis. As long as the surface remains visible and > > n

Re: [PATCH wayland-protocols v3] Add screensaver idle inhibitor protocol

On Fri, Jun 03, 2016 at 11:41:12AM +0300, Pekka Paalanen wrote: > On Thu, 2 Jun 2016 14:33:42 -0700 > Bryce Harrington <br...@osg.samsung.com> wrote: > > > On Wed, May 18, 2016 at 04:11:39PM +0300, Pekka Paalanen wrote: > > > On Thu, 24 Mar 2016 11:14:33 -0

Re: [PATCH wayland-protocols v3] Add screensaver idle inhibitor protocol

On Mon, Jun 06, 2016 at 10:08:00AM -0500, Yong Bakos wrote: > On Jun 6, 2016, at 7:18 AM, Pekka Paalanen wrote: > >> I don't believe this is a good choice. Imagine the case of a surface-less > >> 'inhibitor daemon.' > > > > An ordinary client must not be able to do that. > >

[PATCH v2] scanner: Fix reported executable name to 'wayland-scanner'

'wayland-scanner -v' (correctly) reports the program as named "wayland-scanner", but 'wayland-scanner -h' was inconsistent, referring to it as './scanner'. Also refactor this and other references to the program name to use a common #define, PROGRAM_NAME. Signed-off-by: Bryce Harr

Re: [PATCH] scanner: Fix reported executable name to 'wayland-scanner'

On Fri, Jun 03, 2016 at 07:33:09PM +1000, Peter Hutterer wrote: > On Fri, Jun 03, 2016 at 09:16:43AM +0800, Jonas Ådahl wrote: > > On Thu, Jun 02, 2016 at 02:42:44PM -0700, Bryce Harrington wrote: > > > 'wayland-scanner -v' (correctly) reports the program as named >

Re: [PATCH v3] compositor-x11: fix title overflow in x11_backend_create_output

> failure. > > Signed-of-by: Benoit Gschwind<gschw...@gnu-log.net> Yeah I had noticed this myself earlier and wondered if it should be dynamically allocated. This looks like it would be a possible candidate for the stable branch if we do a .1. Reviewed-by: Bryce Harrington <br...@o

Re: [PATCH weston] compositor-wayland: Correct output base make name

Yong Bakos <yba...@humanoriented.com> Reviewed-by: Bryce Harrington <br...@osg.samsung.com> > --- > src/compositor-wayland.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c > index fe

Re: [PATCH wayland-protocols v3] Add screensaver idle inhibitor protocol

On Fri, Jun 03, 2016 at 10:39:24AM -0500, Yong Bakos wrote: > >>> + This destroys the inhibit manager. > > > > Good addition. Should probably say how destroying the manager affects > > the inhibitors created from it (no effect at all)? > > Agreed w/ pq. But, is the inhibit manager a /singleton/

Re: [PATCH] scanner: Fix reported executable name to 'wayland-scanner'

On Fri, Jun 03, 2016 at 06:34:38PM -0500, Yong Bakos wrote: > Hi, > > On Jun 2, 2016, at 8:16 PM, Jonas Ådahl <jad...@gmail.com> wrote: > > > > On Thu, Jun 02, 2016 at 02:42:44PM -0700, Bryce Harrington wrote: > >> 'wayland-scanner -v' (correctly) report

Re: [PATCH weston v3 6/8] ivi-shell: Support tracking active surfaces

On Thu, May 26, 2016 at 06:02:00PM +0300, Pekka Paalanen wrote: > On Thu, 7 Apr 2016 16:44:21 -0700 > Bryce Harrington <br...@osg.samsung.com> wrote: > > > Activity for ivi-shell follows either click or touch. Only a single > > surface can be active in the shell at

Re: [PATCH weston v3 5/8] fullscreen-shell: Support tracking active surfaces

On Thu, May 26, 2016 at 06:01:52PM +0300, Pekka Paalanen wrote: > On Thu, 7 Apr 2016 16:44:20 -0700 > Bryce Harrington <br...@osg.samsung.com> wrote: > > > Surface activity is determined by what surface is being displayed > > fullscreen. Only a single surface can be a

Re: [PATCH v2c] weston: catch missing commandline values

On Thu, May 12, 2016 at 08:12:09PM -0700, Florian Hänel wrote: > Sorry for the spam, last version for today. > Does not make sense to fprintf a value that causes ENOMEM. > Fixed some more whitespace. > > Florian > >From 4c390be81da27e7b2331c3e71b848e03173b4632 Mon Sep 17 00:00:00 2001 > From:

[PATCH] scanner: Fix reported executable name to 'wayland-scanner'

'wayland-scanner -v' (correctly) reports the program as named "wayland-scanner", but 'wayland-scanner -h' was inconsistent, referring to it as './scanner'. Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- src/scanner.c | 4 ++-- 1 file changed, 2 insertions(+), 2 de

Re: [PATCH wayland-protocols v3] Add screensaver idle inhibitor protocol

On Mon, Mar 28, 2016 at 11:10:22AM +0300, Giulio Camuffo wrote: > 2016-03-24 20:14 GMT+02:00 Bryce Harrington <br...@osg.samsung.com>: > > This interface allows disabling of screensaver/screenblanking on a > > per-surface basis. As long as the surface remains visible

Re: [PATCH wayland-protocols v3] Add screensaver idle inhibitor protocol

On Wed, May 18, 2016 at 04:11:39PM +0300, Pekka Paalanen wrote: > On Thu, 24 Mar 2016 11:14:33 -0700 > Bryce Harrington <br...@osg.samsung.com> wrote: > > > This interface allows disabling of screensaver/screenblanking on a > > per-surface basis. As long as

[PATCH wayland-protocols v3] Add screensaver idle inhibitor protocol

. Signed-off-by: Bryce Harrington <br...@bryceharrington.org> --- v2: + Rename protocol to idle-inhibit v3: + Added a destructor for the idle manager + Changed sub-surface behavior to inherit idle from parent surface + Various wording changes suggested by pq Makef

Re: [PATCH wayland] wayland-server: Clarify included header dependencies

, making this dependency clear. > Remove the redundant inclusion of wayland-server-protocol.h. > > Signed-off-by: Yong Bakos <yba...@humanoriented.com> Reviewed-by: Bryce Harrington <br...@osg.samsung.com> Pushed: To ssh://git.freedesktop.org/git/wayland/wayland 972f1a2..d58

Re: [PATCH wayland] event-loop: Make transitive include explicit

gt; > is wayland-server-core.h. > > > > Signed-off-by: Yong Bakos <yba...@humanoriented.com> > > Reviewed-by: Jonas Ådahl <jad...@gmail.com> Reviewed-by: Bryce Harrington <br...@osg.samsung.com> Pushed: To ssh://git.freedesktop.org/git/wayland/wayland a1bce0e.

Re: [PATCH] weston-launch: Handle invalid command line options

ptions or to quit in the > event of their presence. I'm not experienced enough to judge, so others > will have to chime in. So fwiw, > > Reviewed-by: Yong Bakos <yba...@humanoriented.com> > Tested-by: Yong Bakos <yba...@humanoriented.com> Thanks, pushed: Reviewed-by: Bryc

Re: [PATCH wayland 0/3] doc: Unpublish private objects and functions

++- > 3 files changed, 20 insertions(+), 18 deletions(-) In checking the doxygen documentation, these changes all look good, and near as I can tell the routines in question are in fact private, so for all three patches: Reviewed-by: Bryce Harrington <br...@osg.samsun

Re: [PATCH weston] Remove Raspberry Pi backend and renderer

Given there's an all-FOSS alternative coming down the pike, I see little reason to hold on to the proprietary-driver dependent backend. Acked-by: Bryce Harrington <br...@osg.samsung.com> On Wed, Jun 01, 2016 at 01:11:15PM +0300, Pekka Paalanen wrote: > From: Pekka Paalanen <

[ANNOUNCE] wayland 1.11.0

1.12-alpha in mid-August - 1.12-beta in early September - 1.12-rc1 in mid-September, with rc2 only if necessary - 1.12.0 by the end of September Changes since RC: - Bryce Harrington (1): configure.ac: bump to version 1.11.0 for the official release Full list of cha

Re: [PATCH wayland-protocols v3] Add screensaver idle inhibitor protocol

On Wed, May 18, 2016 at 04:11:39PM +0300, Pekka Paalanen wrote: > On Thu, 24 Mar 2016 11:14:33 -0700 > > Should I go through the v3 Weston patches too, or do you want to revise > them according to protocol changes first? Yes, the weston patches are the main thing that haven't gotten reviewed so

[ANNOUNCE] weston 1.10.93

for possible inclusion in the release, but no other major changes are anticipated between now and the release. See the alpha and beta release announcements for previous changes. Changes since beta: --- Bryce Harrington (4): ivi: Fix spellings in comments build: Define

[ANNOUNCE] wayland 1.10.93

the month. There are no release blocking bugs for Wayland, so I do not anticipate any deviation from the schedule. See the alpha and beta release announcements for previous changes. Changes since previous Beta: Bryce Harrington (1): configure.ac: bump to versi

Re: [ANNOUNCE] wayland 1.10.91

On Tue, May 24, 2016 at 09:49:20AM +0800, Jonas Ådahl wrote: > On Mon, May 23, 2016 at 02:22:45PM -0700, Bryce Harrington wrote: > > On Fri, May 20, 2016 at 03:35:15PM -0700, Bryce Harrington wrote: > > > On Wed, May 11, 2016 at 12:11:50PM -0700, Bryce Harrington wrote: >

Re: writing Was: [PATCH weston 1/5] gl-renderer: Rename gl_renderer_create to gl_renderer_display_create

On Wed, May 18, 2016 at 06:33:15PM -0400, Yong Bakos wrote: > Hi, > I'm partly to blame for the bikeshedding on writing, yet believe me, > I'm always asking "is this worth it?", prioritizing corrections/clarity > over mere style judgements, and am definitely sensitive to > everyone's cognitive

Re: [ANNOUNCE] wayland 1.10.91

On Fri, May 20, 2016 at 03:35:15PM -0700, Bryce Harrington wrote: > On Wed, May 11, 2016 at 12:11:50PM -0700, Bryce Harrington wrote: > > On Fri, May 06, 2016 at 02:17:23PM +0300, Pekka Paalanen wrote: > > > On Wed, 4 May 2016 11:46:23 -0700 > > > Bryce Harrington &l

Re: [PATCH weston v3] configure: unify wayland-client and wayland-server requirements

at of Mesa. > > This patch is based on the similar patch by Bryce Harrington that used > m4_define instead of a variable. Since that's such a minor change, I'll just squash this to mine. Bryce > Cc: Bryce Harrington <br...@osg.samsung.com> > Cc: Quentin Glidic

[PATCH weston v3] build: Define wayland prereq version

-by: Bryce Harrington <br...@osg.samsung.com> --- configure.ac | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index e1300b4..d034907 100644 --- a/configure.ac +++ b/configure.ac @@ -11,6 +11,8 @@ AC_INIT([weston], [

Re: [ANNOUNCE] wayland 1.10.91

On Wed, May 11, 2016 at 12:11:50PM -0700, Bryce Harrington wrote: > On Fri, May 06, 2016 at 02:17:23PM +0300, Pekka Paalanen wrote: > > On Wed, 4 May 2016 11:46:23 -0700 > > Bryce Harrington <br...@osg.samsung.com> wrote: > > > > > On Wed, May 04, 2016 at 12:5

[PATCH weston v2] build: Define wayland prereq version

Establishes a single variable for defining the libwayland version requirements. Enforces the same version dependency between libwayland-client and libwayland-server, as recommended by pq in the 1.11 release discussions. Signed-off-by: Bryce Harrington <br...@osg.samsung.com> --- config

Re: [PATCH weston] build: Define wayland prereq version

On Thu, May 12, 2016 at 09:48:17AM +0100, Emil Velikov wrote: > On 12 May 2016 at 09:13, Pekka Paalanen <ppaala...@gmail.com> wrote: > > On Thu, 12 May 2016 11:12:28 +1000 > > Peter Hutterer <peter.hutte...@who-t.net> wrote: > > > >> On Wed, May 11, 2016 a

Re: [PATCH wayland 3/5] server: don't proceed in posting no-memory error on client destruction

On Mon, May 16, 2016 at 12:22:02PM +0300, Pekka Paalanen wrote: > On Fri, 13 May 2016 15:01:20 +0200 > Marek Chalupa wrote: Hi Marek, Thanks for providing the test cases to go along with this, much appreciated. The first patch in this set looked fine to me, and with pq's

<    1   2   3   4   5   6   7   8   9   10   >